mirror of
https://gitee.com/milvus-io/milvus.git
synced 2025-12-28 22:45:26 +08:00
0425336635
Related to #46453 The test was flaky because Submit() returns a Future and executes asynchronously. The test was setting sig=true immediately after Submit() returned, but the task's Run() might not have completed yet, causing mock expectation failures. Fix by calling future.Await() to wait for task execution to complete before signaling. Also remove dead commented code. Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
80 lines
1.5 KiB
Go
80 lines
1.5 KiB
Go
package syncmgr
|
|
|
|
import (
|
|
"context"
|
|
"testing"
|
|
"time"
|
|
|
|
"github.com/stretchr/testify/suite"
|
|
"go.uber.org/atomic"
|
|
)
|
|
|
|
type KeyLockDispatcherSuite struct {
|
|
suite.Suite
|
|
}
|
|
|
|
func (s *KeyLockDispatcherSuite) TestKeyLock() {
|
|
ctx, cancel := context.WithCancel(context.Background())
|
|
defer cancel()
|
|
d := newKeyLockDispatcher[int64](2)
|
|
|
|
done := make(chan struct{})
|
|
t1 := NewMockTask(s.T())
|
|
t1.EXPECT().Run(ctx).Run(func(_ context.Context) {
|
|
<-done
|
|
}).Return(nil)
|
|
t2 := NewMockTask(s.T())
|
|
t2.EXPECT().Run(ctx).Return(nil)
|
|
|
|
sig := atomic.NewBool(false)
|
|
|
|
d.Submit(ctx, 1, t1)
|
|
|
|
go func() {
|
|
future := d.Submit(ctx, 1, t2)
|
|
future.Await()
|
|
sig.Store(true)
|
|
}()
|
|
|
|
s.False(sig.Load(), "task 2 will never be submit before task 1 done")
|
|
|
|
close(done)
|
|
|
|
s.Eventually(sig.Load, time.Second, time.Millisecond*100)
|
|
}
|
|
|
|
func (s *KeyLockDispatcherSuite) TestCap() {
|
|
ctx, cancel := context.WithCancel(context.Background())
|
|
defer cancel()
|
|
d := newKeyLockDispatcher[int64](1)
|
|
|
|
t1 := NewMockTask(s.T())
|
|
t2 := NewMockTask(s.T())
|
|
|
|
done := make(chan struct{})
|
|
t1.EXPECT().Run(ctx).Run(func(_ context.Context) {
|
|
<-done
|
|
}).Return(nil)
|
|
t2.EXPECT().Run(ctx).Return(nil)
|
|
sig := atomic.NewBool(false)
|
|
|
|
d.Submit(ctx, 1, t1)
|
|
|
|
go func() {
|
|
future := d.Submit(ctx, 2, t2)
|
|
future.Await()
|
|
|
|
sig.Store(true)
|
|
}()
|
|
|
|
s.False(sig.Load(), "task 2 will never be submit before task 1 done")
|
|
|
|
close(done)
|
|
|
|
s.Eventually(sig.Load, time.Second, time.Millisecond*100)
|
|
}
|
|
|
|
func TestKeyLockDispatcher(t *testing.T) {
|
|
suite.Run(t, new(KeyLockDispatcherSuite))
|
|
}
|