admin/milvus
1
0
Fork 0
mirror of https://gitee.com/milvus-io/milvus.git synced 2025-12-28 14:35:27 +08:00
Code Issues Packages Projects Releases Wiki Activity

fix: [skip e2e] resolve flaky TestKeyLockDispatcher unit test (#46454)

Browse Source 
Related to #46453

The test was flaky because Submit() returns a Future and executes
asynchronously. The test was setting sig=true immediately after Submit()
returned, but the task's Run() might not have completed yet, causing
mock expectation failures.

Fix by calling future.Await() to wait for task execution to complete
before signaling. Also remove dead commented code.

Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
This commit is contained in:
congqixia 2025-12-19 14:07:19 +08:00 committed by GitHub
parent 617a77b0bd
commit 0425336635
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 4 additions and 32 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

36
internal/flushcommon/syncmgr/key_lock_dispatcher_test.go
View File

@ -9,34 +9,6 @@ import (
"go.uber.org/atomic"
)
/*
type mockTask struct {
targetID int64
ch chan struct{}
err error
}
func (t *mockTask) done() {
close(t.ch)
}
func (t *mockTask) SegmentID() int64 { panic("no implementation") }
func (t *mockTask) Checkpoint() *msgpb.MsgPosition { panic("no implementation") }
func (t *mockTask) StartPosition() *msgpb.MsgPosition { panic("no implementation") }
func (t *mockTask) ChannelName() string { panic("no implementation") }
func (t *mockTask) Run() error {
<-t.ch
return t.err
}
func newMockTask(err error) *mockTask {
return &mockTask{
err: err,
ch: make(chan struct{}),
}
}*/
type KeyLockDispatcherSuite struct {
suite.Suite
}
@ -59,8 +31,8 @@ func (s *KeyLockDispatcherSuite) TestKeyLock() {
d.Submit(ctx, 1, t1)
go func() {
d.Submit(ctx, 1, t2)
future := d.Submit(ctx, 1, t2)
future.Await()
sig.Store(true)
}()
@ -89,8 +61,8 @@ func (s *KeyLockDispatcherSuite) TestCap() {
d.Submit(ctx, 1, t1)
go func() {
// defer t2.done()
d.Submit(ctx, 2, t2)
future := d.Submit(ctx, 2, t2)
future.Await()
sig.Store(true)
}()