mirror of
https://gitee.com/milvus-io/milvus.git
synced 2025-12-28 14:35:27 +08:00
### **User description** issue: #46097 - the flush rate is modified into 4qps, so the testcase is fail. ___ ### **PR Type** Tests, Bug fix ___ ### **Description** - Replace sequential flush calls with concurrent requests to trigger rate limiting - Add sync.WaitGroup for concurrent goroutine execution - Check for rate limit errors across multiple concurrent flush operations - Remove hardcoded error message expectation for flexibility ___ ### Diagram Walkthrough ```mermaid flowchart LR A["Sequential Flush Calls"] -->|Replace with| B["Concurrent Flush Requests"] B -->|Use| C["sync.WaitGroup"] C -->|Validate| D["Rate Limit Errors"] ``` <details><summary><h3>File Walkthrough</h3></summary> <table><thead><tr><th></th><th align="left">Relevant files</th></tr></thead><tbody><tr><td><strong>Tests</strong></td><td><table> <tr> <td> <details> <summary><strong>insert_test.go</strong><dd><code>Refactor flush rate test to use concurrent requests</code> </dd></summary> <hr> tests/go_client/testcases/insert_test.go <ul><li>Added <code>sync</code> package import for concurrent goroutine synchronization<br> <li> Replaced sequential flush calls with 10 concurrent flush operations <br>using goroutines<br> <li> Implemented WaitGroup to synchronize all concurrent flush requests<br> <li> Modified error validation to check for rate limit errors across all <br>concurrent attempts instead of expecting specific sequential behavior<br> <li> Relaxed error message matching to only check for "rate limit exceeded" <br>substring</ul> </details> </td> <td><a href="https://github.com/milvus-io/milvus/pull/46497/files#diff-89a4ddfa15d096e6a5f647da0e461715e5a692b375b04a3d01939f419b00f529">+19/-4</a> </td> </tr> </table></td></tr></tbody></table> </details> ___ <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit ## Release Notes * **Tests** * Enhanced testing of concurrent flush operations to improve validation of system reliability under concurrent load scenarios. --- **Note:** This release contains internal testing improvements with no direct user-facing feature changes. <sub>✏️ Tip: You can customize this high-level summary in your review settings.</sub> <!-- end of auto-generated comment: release notes by coderabbit.ai --> Signed-off-by: chyezh <chyezh@outlook.com>
Tests
E2E Test
Configuration Requirements
Operating System
| Operating System | Version |
|---|---|
| Amazon Linux | 2023 or above |
| Ubuntu | 20.04 or above |
| Mac | 10.14 or above |
Hardware
| Hardware Type | Recommended Configuration |
|---|---|
| CPU | x86_64 architecture Intel CPU Sandy Bridge or above CPU Instruction Set - SSE4_2 - AVX - AVX2 - AVX512 or arm64 Linux/MacOS |
| Memory | 16 GB or more |
Software
| Software Name | Version |
|---|---|
| Docker | 19.05 or above |
| Docker Compose | 1.25.5 or above |
| jq | 1.3 or above |
| kubectl | 1.14 or above |
| helm | 3.0 or above |
| kind | 0.10.0 or above |
Installing Dependencies
Troubleshooting Docker and Docker Compose
- Confirm that Docker Daemon is running:
$ docker info
-
Ensure that Docker is installed. Refer to the official installation instructions for Docker CE/EE.
-
Start the Docker Daemon if it is not already started.
-
To run Docker without
rootprivileges, create a user group labeleddocker, then add a user to the group withsudo usermod -aG docker $USER. Log out and log back into the terminal for the changes to take effect. For more information, see the official Docker documentation for Managing Docker as a Non-Root User.
- Check the version of Docker-Compose
$ docker compose version
docker compose version 1.25.5, build 8a1c60f6
docker-py version: 4.1.0
CPython version: 3.7.5
OpenSSL version: OpenSSL 1.1.1f 31 Mar 2020
- To install Docker-Compose, see Install Docker Compose
Install jq
Install kubectl
Install helm
- Refer to https://helm.sh/docs/intro/install/
Install kind
Run E2E Tests
$ cd tests/scripts
$ ./e2e-k8s.sh
Getting help
You can get help with the following command:
$ ./e2e-k8s.sh --help