mirror of
https://gitee.com/milvus-io/milvus.git
synced 2026-01-07 19:31:51 +08:00
53a300db83
issue: #42937 <!-- This is an auto-generated comment: release notes by coderabbit.ai --> - Core invariant: callers must explicitly close output streams (call Close()) instead of relying on RemoteOutputStream's destructor to perform closure. - Logic removed/simplified: RemoteOutputStream's destructor no longer closes or asserts on the underlying arrow::io::OutputStream; an explicit public Close() method was added and closure responsibility moved to that code path. - Why this is safe (no data loss/regression): callers now invoke Close() before reading or destroying streams (e.g., DiskFileManagerTest::ReadAndWriteWithStream calls os->Close() before opening the input stream). Write paths remain unchanged (RemoteOutputStream::Write -> output_stream_->Write), and Close invokes output_stream_->Close() with status assertion, ensuring flush/confirmation via the same API and preserving data integrity; removing destructor-side asserts prevents unexpected failures during object destruction without changing write/close semantics. - Chore: updated third-party pins — internal/core/thirdparty/knowhere CMakeLists.txt: KNOWHERE_VERSION -> a59816e; internal/core/thirdparty/milvus-common CMakeLists.txt: MILVUS-COMMON-VERSION -> b6629f7. <!-- end of auto-generated comment: release notes by coderabbit.ai --> Signed-off-by: xianliang.li <xianliang.li@zilliz.com>