18397 Commits

Author SHA1 Message Date
yah01
ce8219f1a3
fix: bypass growing index if no index meta (#28791) (#28859)
we shouldn't panic if no index meta, just skip building it
fix #28022
pr: #28791

---------

Signed-off-by: yah01 <yang.cen@zilliz.com>
2023-11-30 21:10:32 +08:00
aoiasd
880189e598
enhance: Delete by complex expression use partitionKey optimization (#27952) (#28128)
relate: https://github.com/milvus-io/milvus/issues/27948
pr: https://github.com/milvus-io/milvus/pull/27952

Signed-off-by: aoiasd <zhicheng.yue@zilliz.com>
2023-11-30 17:56:31 +08:00
yihao.dai
d0a56ecca5
fix: Fix minio latency monitoring for get operation (#28510) (#28643)
see also: https://github.com/milvus-io/milvus/issues/28509

pr: https://github.com/milvus-io/milvus/pull/28510

Currently Minio latency monitoring for get operation only collects the
duration of getting object (which just returns an io.Reader and does not
really read from minio), this pr will correct this behavior.

Signed-off-by: bigsheeper <yihao.dai@zilliz.com>
2023-11-30 10:44:28 +08:00
cai.zhang
00461145b3
enhance: [Pick]Support importing data with parquet file (#28820)
issue: https://github.com/milvus-io/milvus/issues/28272
master pr: #28608 

Numpy does not support array type import.
Array type data is imported through parquet.

Signed-off-by: Cai Zhang <cai.zhang@zilliz.com>
2023-11-29 22:16:29 +08:00
cai.zhang
2062e5b368
enhance: [Pick]Update arrow version to v12 (#28425) (#28828)
master pr: #28425 
issue: https://github.com/milvus-io/milvus/issues/28423

Signed-off-by: Cai Zhang <cai.zhang@zilliz.com>
2023-11-29 20:04:28 +08:00
congqixia
e3653af9c9
fix: data race on rootcoord.proxyClientManager.proxyClient (#28787) (#28798)
Cherry-pick from master
pr: #28787
Fix #28786

Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
2023-11-29 18:00:27 +08:00
yihao.dai
a78ea4fea0
fix: Check ErrSegmentNotFound in delete node (#28371) (#28638)
We have been check ErrSegmentNotFound in insert_buffer_node in datanode,
we should also check it in delete_node.

issue: https://github.com/milvus-io/milvus/issues/27145

pr: https://github.com/milvus-io/milvus/pull/28371

Signed-off-by: bigsheeper <yihao.dai@zilliz.com>
2023-11-29 17:50:27 +08:00
nico
a3aceb97a4
test: update test cases and pymilvus version (#28746)
pr: #28706

Signed-off-by: nico <cheng.yuan@zilliz.com>
2023-11-29 10:28:29 +08:00
congqixia
0688ec4d83
enhance: [cherry-pick] Add channel checkpoint ts lag metric (#28767) (#28776)
Cherry-pick from master
pr: #28767
See also #28765

---------

Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
2023-11-28 19:28:28 +08:00
Gao
ccca932cc6
fix: [2.3] correct autoindex segment num (#28429)
issue: #28386 
pr: #28387

Signed-off-by: chasingegg <chao.gao@zilliz.com>
2023-11-28 19:24:26 +08:00
cai.zhang
fda452ea4d
enhance: [Pick] Revert import support csv format (#28766)
issue: #28778 
master pr: #28760

Signed-off-by: Cai Zhang <cai.zhang@zilliz.com>
2023-11-28 18:26:28 +08:00
aoiasd
cbb05a2d52
fix: [Cherry-pick] log can not reduce level (#28770)
relate: https://github.com/milvus-io/milvus/issues/28749
pr: https://github.com/milvus-io/milvus/pull/28750

Signed-off-by: aoiasd <zhicheng.yue@zilliz.com>
2023-11-28 16:26:33 +08:00
aoiasd
224f2755c5
enhance: [Cherry-pick]Refine accesslog to support format by yaml and support more metric (#28740)
relate: https://github.com/milvus-io/milvus/issues/28086
pr: https://github.com/milvus-io/milvus/issues/28086

---------

Signed-off-by: aoiasd <zhicheng.yue@zilliz.com>
2023-11-28 15:34:28 +08:00
yah01
8ea1ef03ad
enhance: store system fields in segcore (#28524) (#28727)
we need the system fields info for some usacase
fix: #28523

pr: #28524

---------

Signed-off-by: yah01 <yah2er0ne@outlook.com>
2023-11-28 15:32:31 +08:00
groot
ecfa0a9b10
test: Unskip a bulkinsert test case (#28780)
Unskip a bulkinsert test case which is skipped by #28209

pr: https://github.com/milvus-io/milvus/pull/28679

Signed-off-by: yhmo <yihua.mo@zilliz.com>
2023-11-28 13:00:27 +08:00
groot
d20328bc05
test: Avoid unstable case of bulkinsert (#28757)
test: There are too many test cases for bulkinsert+partition_key. Each
case creates 10 bulkinsert tasks to import a file with 100~200 rows. The
default num_partitions is 64 for partition_key. So, each task will
generate 64 tiny segments. There are 10 cases, each case 10 tasks, each
task 64 tiny segment, totally there are 6400 tiny segments generated.
And all these segment row count is less than 1024, no need to build
index, and take part in compaction. There will be lots of compaction
tasks generated. It costs too much time to process these compaction
tasks. Eventually, some cases are timeout after waiting 5 minutes for
their segments to be ready and cases fail.

Specifying the num_partitions to a small value can avoid this problem.

pr: https://github.com/milvus-io/milvus/pull/28679

```
[2023-11-21T03:41:16.187Z] testcases/test_bulk_insert.py::TestBulkInsert::test_partition_key_on_json_file[int_scalar-True-True] PASSED [ 54%]
[2023-11-21T03:41:42.796Z] testcases/test_bulk_insert.py::TestBulkInsert::test_partition_key_on_json_file[int_scalar-False-True] PASSED [ 57%]
[2023-11-21T03:42:04.694Z] testcases/test_bulk_insert.py::TestBulkInsert::test_partition_key_on_json_file[string_scalar-True-True] PASSED [ 60%]
[2023-11-21T03:42:31.205Z] testcases/test_bulk_insert.py::TestBulkInsert::test_partition_key_on_json_file[string_scalar-False-True] PASSED [ 63%]
[2023-11-21T03:43:38.876Z] testcases/test_bulk_insert.py::TestBulkInsert::test_partition_key_on_multi_numpy_files[10-150-13-True] XPASS [ 66%]
[2023-11-21T03:49:00.357Z] testcases/test_bulk_insert.py::TestBulkInsert::test_partition_key_on_multi_numpy_files[10-150-13-False] XFAIL [ 69%]
[2023-11-21T03:53:51.811Z] testcases/test_bulk_insert.py::TestBulkInsert::test_partition_key_on_csv_file[int_scalar-True] FAILED [ 72%]
[2023-11-21T03:58:58.283Z] testcases/test_bulk_insert.py::TestBulkInsert::test_partition_key_on_csv_file[int_scalar-False] FAILED [ 75%]
[2023-11-21T04:02:04.696Z] testcases/test_bulk_insert.py::TestBulkInsert::test_partition_key_on_csv_file[string_scalar-True] PASSED [ 78%]
[2023-11-21T04:02:26.608Z] testcases/test_bulk_insert.py::TestBulkInsert::test_partition_key_on_csv_file[string_scalar-False] PASSED [ 81%]
```

Signed-off-by: yhmo <yihua.mo@zilliz.com>
2023-11-28 10:34:31 +08:00
Enwei Jiao
7afd7553ed
feat: trigger compaction to handle index version (#28442) (#28754)
issue: https://github.com/milvus-io/milvus/issues/28441
pr: https://github.com/milvus-io/milvus/pull/28442

---------

Signed-off-by: Enwei Jiao <enwei.jiao@zilliz.com>
2023-11-28 10:24:26 +08:00
wayblink
1ed92da414
enhance:[cherry-pick] Merge flowgraph goroutines into 1 (#28728)
see also: #28654 #28233

Signed-off-by: wayblink <anyang.wang@zilliz.com>
2023-11-27 21:04:27 +08:00
congqixia
5a962a631a
fix: [cherry-pick] Change schema to atomic.Pointer to avoid data race (#28739) (#28759)
Cherry-pick from master
pr: #28739
See also #28738

Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
2023-11-27 19:50:27 +08:00
jaime
9378f78218
enhance: Add logs for each step during service initialization (#28687)
/kind improvement
pr: #28624

Signed-off-by: jaime <yun.zhang@zilliz.com>
2023-11-27 17:54:26 +08:00
cai.zhang
ef115dd7df
enhance: Support Array DataType for bulk_insert (#28578)
issue: https://github.com/milvus-io/milvus/issues/28272
master pr: #28341 
Support array DataType for bulk_insert with json, binlog files.

Signed-off-by: Cai Zhang <cai.zhang@zilliz.com>
2023-11-27 16:56:27 +08:00
jaime
2e78b4de96
fix: cmux graceful shutdown on proxy service #28383 (#28680)
issue: https://github.com/milvus-io/milvus/issues/28305
pr: #28383

Signed-off-by: jaime <yun.zhang@zilliz.com>
2023-11-27 16:28:34 +08:00
yah01
55fda49104
enhance: validate JSON data while inserting (#28602) (#28725)
some SDKs doesn't check the JSON data validation,
add this in server.

pr: #28602

Signed-off-by: yah01 <yah2er0ne@outlook.com>
2023-11-27 16:16:26 +08:00
yah01
c4be1ddf44
enhance: improve the error messages and logs (#28684) (#28726)
- better name for log fields
- make the error and log consistent

pr: #28684

Signed-off-by: yah01 <yah2er0ne@outlook.com>
2023-11-27 15:40:26 +08:00
wei liu
9e82a75c22
enhance: Increase heartbeat timeout (#28648) (#28721)
pr: #28648
it's easy to trigger heartbeat timeout after 100ms when standalone cpu
usage reach 100%.
This PR increase the heartbeat timeout param to 2000ms

Signed-off-by: Wei Liu <wei.liu@zilliz.com>
2023-11-27 10:40:26 +08:00
yihao.dai
8520ee7552
enhance: Print nq (#28507) (#28639)
Log nq in search path.

pr: https://github.com/milvus-io/milvus/pull/28507

---------

Signed-off-by: bigsheeper <yihao.dai@zilliz.com>
2023-11-27 10:18:26 +08:00
yah01
a1b861ed7a
enhance: improve load speed (#28518) (#28719)
This check rejects load request if running out the pool workers, but
small segment would be loaded soon, another segments would been loading
again after a check interval, which leads to slow loading for collection

Block the request by go pool

pr: #28518

Signed-off-by: yah01 <yah2er0ne@outlook.com>
2023-11-26 22:10:26 +08:00
cai.zhang
3b06db1d04
enhance: [Pick] Handle knowhere error for creare diskann index (#28691)
master pr: #28690

Signed-off-by: Cai Zhang <cai.zhang@zilliz.com>
2023-11-26 18:58:25 +08:00
congqixia
6512b12fba
enhance: [cherry-pick] Make etcd kv request timeout configurable (#28661) (#28701)
Cherry-pick from master
pr: #28661
See also #28660
This pr add request timeout config item for etcd kv request timeout
 Sync the default timeout value to same value for etcdKV & tikv config

Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
2023-11-24 21:16:26 +08:00
congqixia
e4ea148c0f
fix: [cherry-pick] Add IndexList check for load segment request (#28601) (#28700)
Cherry-pick from master
pr: #28601
See also #28022 #28034
The load segment may reaches before watch dml channel, so the index meta
may be empty as well

Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
2023-11-24 15:02:39 +08:00
smellthemoon
288844e3cf
enhance: Reduce the goroutine in flowgraph to 2 (#28233) (#28545)
each node in flow graph alloc a goroutine, but it is actually executed
sequentially and can be placed in one goroutine. InputNode will consume
msg form msgstream, alloc one goroutine.
issue: #24826 
pr: #28233

Signed-off-by: lixinguo <xinguo.li@zilliz.com>
Co-authored-by: lixinguo <xinguo.li@zilliz.com>
2023-11-24 15:00:26 +08:00
chyezh
1b86efbafb
fix: [cherry-pick] error root path for catalog when using tikv (#28463)
Related Issue: #28162 
Related pr: #28163

Signed-off-by: chyezh <ye.zhen@zilliz.com>
2023-11-24 14:28:24 +08:00
yah01
c6ba4fa102
enhance: enhance the accuracy of memory usage (#28554) (#28559)
before this, Milvus use container/system's memory info to get the memory
usage, which could be inaccurate.

we allocates the memory by private anon mmap,
then rss - shared would be the accurate memory usage

resolve https://github.com/milvus-io/milvus/issues/28553
pr: #28554

---------

Signed-off-by: yah01 <yah2er0ne@outlook.com>
2023-11-24 14:12:25 +08:00
cai.zhang
968d6fdcde
fix: Fix bug for parse expression that include quotes (#28418)
master pr: #28416 
issue: #28365
Fix bug for parsing error when a string enclosed in single quotes in an
expression contains multiple double quotes.
such as:
```
expr = "tag == '\"blue\"'"
```

Signed-off-by: Cai Zhang <cai.zhang@zilliz.com>
2023-11-24 11:02:24 +08:00
yah01
5ca7851f4a
enhance: refine error messages (#28424) (#28614)
- Split the simple reason and full detail
- Refine existing error messages related: #28422
related: https://github.com/milvus-io/milvus/issues/28422
pr: #28424

---------

Signed-off-by: yah01 <yah2er0ne@outlook.com>
2023-11-24 10:04:24 +08:00
zhagnlu
0bda17e97b
enhance: Add precheck when chunk manager init (#28593)
#28329 
pr: https://github.com/milvus-io/milvus/pull/28330

Signed-off-by: luzhang <luzhang@zilliz.com>
Co-authored-by: luzhang <luzhang@zilliz.com>
2023-11-23 20:34:25 +08:00
zhagnlu
41667f3227
enhance: Disable stdout buffer (#28597)
#28390 
pr: https://github.com/milvus-io/milvus/pull/28391

Signed-off-by: luzhang <luzhang@zilliz.com>
Co-authored-by: luzhang <luzhang@zilliz.com>
2023-11-23 20:20:24 +08:00
zhagnlu
e13b3aa9b1
fix: panic if minio port is empty (#28595)
#28460 
pr: https://github.com/milvus-io/milvus/pull/28461

Signed-off-by: luzhang <luzhang@zilliz.com>
Co-authored-by: luzhang <luzhang@zilliz.com>
2023-11-23 20:18:33 +08:00
Enwei Jiao
c73bb26782
fix: disable reset kafka connection timeout (#28681)
pr: https://github.com/milvus-io/milvus/pull/28642
issue https://github.com/milvus-io/milvus/issues/28588

Signed-off-by: Enwei Jiao <enwei.jiao@zilliz.com>
2023-11-23 19:42:30 +08:00
wei liu
33bbdf6c88
fix: Fix channel manager bg checker exit when disable auto balance (#28459) (#28606)
issue: #28454
pr: #28459

Signed-off-by: Wei Liu <wei.liu@zilliz.com>
2023-11-23 19:18:29 +08:00
wayblink
a04b528ce7
fix: [cherry-pick] failed to release collection with more than 128 partitions (#28567)
issue: #28343
pr: #28446

Signed-off-by: wayblink <anyang.wang@zilliz.com>
2023-11-22 14:00:23 +08:00
smellthemoon
d2ebbe2317
enhance: create goroutine only once(#28594) (#28609)
create goroutine only once when getOrCreateMergedTimeTickerSender
pr: #28594

Signed-off-by: lixinguo <xinguo.li@zilliz.com>
Co-authored-by: lixinguo <xinguo.li@zilliz.com>
2023-11-22 10:26:28 +08:00
congqixia
0fbd610e89
fix: [cherry-pick] querynodev2 local worker failed to maintain collection ref (#28631)
Cherry-pick from master
pr: #28590 #28598
See also #28589 #28596 
Increase ref for collection during load and unref after load completed.
Use the same logic protection from services.go `LoadSegments`
Perform `Unref` after release sealed segments

---------

Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
2023-11-22 10:04:23 +08:00
zhuwenxing
558e301236
test:skip a bulk insert testcase temporarily (#28621)
skip a bulk insert test case temporarily.
It is a known issue but needs more time to solve. skip the test case is
for not blocking other PR

Signed-off-by: zhuwenxing <wenxing.zhu@zilliz.com>
2023-11-21 19:12:22 +08:00
wei liu
c7ec882033
enhance: Remove rpc during querycoord start (#28396) (#28604)
issue: #28332
pr: #28396

during querycoord's recover, it try to call `DescribeCollection` and
`ShowPartitions` to root coord, to checker whether collection or
partition has been released in rootcoord. but if rootcoord isn't not
ready yet, the rpc will fail, the querycoord panic.

to fix this, we remove rpc call during querycoord's start

Signed-off-by: Wei Liu <wei.liu@zilliz.com>
2023-11-21 18:08:29 +08:00
smellthemoon
d724b07037
enhance: Use single instance for mergedTimeTickerSender (#27730) (#28546)
use single instance for mergedTimeTickerSender
issue: https://github.com/milvus-io/milvus/issues/24826
pr: https://github.com/milvus-io/milvus/pull/27730

Signed-off-by: lixinguo <xinguo.li@zilliz.com>
Co-authored-by: lixinguo <xinguo.li@zilliz.com>
2023-11-21 16:04:23 +08:00
PowderLi
92e5f96064
fix: symbol 'GetStorageMetrics' and 'enableDynamicField' (#28581)
issue: #28579 #28504
pr: #28580

1. replace enableDynamic with enableDynamicField
2. cgo directly link to milvus_storage

Signed-off-by: PowderLi <min.li@zilliz.com>
2023-11-21 15:30:23 +08:00
PowderLi
1383680b3a
add internal storage metrics (#28279)
/kind improvement
issue: #28277

pr: #28278

Signed-off-by: PowderLi <min.li@zilliz.com>
2023-11-19 17:22:25 +08:00
PowderLi
4a46ae7a8a
Improve HTTP server include metrics and RESTful API (#28210)
/kind improvement
issue: #27653

pr: #28045

Signed-off-by: PowderLi <min.li@zilliz.com>
2023-11-19 17:16:21 +08:00
congqixia
484131a550
fix: [cherry-pick] protect EventDispatcher map with mutex (#28540) (#28555)
Add mutex protection for `EventDispatcher.registry` map 
Fix #28538
pr: #28540 #28552
Also add unit test case for all methods for EventDispatcher

---------

Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
2023-11-19 12:56:20 +08:00