18537 Commits

Author SHA1 Message Date
SimFG
a2365e4b2a
enhance: [2.3] Add concurrency for datacoord segment GC (#29557)
issue: #29553
pr: https://github.com/milvus-io/milvus/pull/29561
/kind improvement

Signed-off-by: SimFG <bang.fu@zilliz.com>
2024-01-03 13:16:57 +08:00
foxspy
66c84655d8
fix: [Cherry-pick] throw exception when upload file failed for DiskIndex (#29628)
Cherry pick from master
pr: #29627 
related to: #29417

Signed-off-by: xianliang <xianliang.li@zilliz.com>
2024-01-03 11:10:47 +08:00
MrPresent-Han
757834602a
enhance: add param for bloomfilter(#29388) (#29614)
related: https://github.com/milvus-io/milvus/issues/29388
pr: https://github.com/milvus-io/milvus/pull/29490

Signed-off-by: MrPresent-Han <chun.han@zilliz.com>
2024-01-02 18:58:47 +08:00
Jiquan Long
7a373bec46
enhance: print total memory when milvus starts (#29351) (#29352)
issue: #29349 
pr: #29351

---------

Signed-off-by: longjiquan <jiquan.long@zilliz.com>
2023-12-31 17:42:47 +08:00
cai.zhang
0902e5aada
enhance: [Pick]Support azurite docker for develope env (#29140)
master pr: #29021

Signed-off-by: Cai Zhang <cai.zhang@zilliz.com>
2023-12-31 17:18:37 +08:00
sammy.huang
ac1b1b01d1
enhance: [skip e2e][automated] Bump milvus version to v2.3.4 (#29605)
Signed-off-by: Sammy Huang <sammy.huang@zilliz.com>
2023-12-30 07:38:45 +08:00
congqixia
7a192da870
enhance: Bump version 2.3.4 & milvus-proto (#29598)
Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
v2.3.4
2023-12-29 18:32:45 +08:00
cai.zhang
ba1d0556ba
fix: Import data from parquet file in streaming way (#29528)
issue:  #29292 
master pr: #29514

Signed-off-by: Cai Zhang <cai.zhang@zilliz.com>
2023-12-29 11:56:45 +08:00
congqixia
5ec79ab6f6
fix: [Cherry-pick] Add atomic method to get collection target (#29580)
Cherry pick from master
pr: #29577
Related to #29575

Add `getCollectionTarget` method which is atomic when scope is
`CurrentTargetFirst` or `NextTargetFirst`
Also return error when executor finds no channel in target manager

---------

Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
2023-12-29 10:30:46 +08:00
congqixia
67313ccc86
fix: [cherry-pick] exclude insertData before growing checkpoint (#29559)
Cherry-pick from master
pr: #29558
See also: #29556
Refine exclude segment function signature
Add exclude growing before checkpoint logic

Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
2023-12-28 18:18:54 +08:00
wei liu
a13fc4d346
enhance: Remove useless log in collection observer (#29555)
pr: #29554
This PR removed useless log in collection observer

Signed-off-by: Wei Liu <wei.liu@zilliz.com>
2023-12-28 17:14:45 +08:00
wei liu
07ef52e845
fix: Choose wrong shard leader during balance channel(#29525) (#29532)
issue: #29523
pr: #29525

readable shard leader should still be the old one during channel
balance, if the new shard leader is not ready.
This PR fixed that query coord choose wrong shard leader during balance
channel

Signed-off-by: Wei Liu <wei.liu@zilliz.com>
2023-12-28 15:22:51 +08:00
congqixia
687eb3955e
enhance: [Cherry-pick] Refine C.NewSegment response and handle exception (#28952) (#29550)
Cherry-pick from master
pr: #28952
See also #28795

Orignal `C.NewSegment` may panic if some condition is not met, this pr
changes response struct to `CNewSegmentResult`, which contains
`C.CStatus` and may return catched exception

---------

---------

Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
2023-12-28 14:48:47 +08:00
congqixia
852547b1c5
fix: [cherry-pick] compose exclude info from flushed segment id (#29549)
Cherry-pick from master
pr: #29548
See also #29526

Previous PR removed flushed segment info from request, which causes
pipeline failing to exclude flushed segment info

Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
2023-12-28 14:02:54 +08:00
congqixia
dd52a674aa
enhance: [cherry-pick] add ctx for HandleCStatus and callers (#29517) (#29546)
Cherry-pick from master
pr: #29517 
See also #29516

Make `HandleCStatus` print trace id for better logging

Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
2023-12-28 10:20:47 +08:00
congqixia
eb11b1a56e
enhance: [Cherry-pick] remove flushed segmentInfo in WatchChannelRequest (#29527)
Cherry-pick from master
pr: #29526
`WatchDmChannel` only need growing segment info, this PR removes fetch
segmentInfos when fill watch dml channel request.

---------

Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
2023-12-27 23:46:46 +08:00
yah01
4c0ca83928
enhance: speed up loading with many deletions (#29455) (#29520)
the executor always fetches the latest segment info, so we could consume
from the latest checkpoint, which could save much time while deleted
many entities

pr: #29455

Signed-off-by: yah01 <yang.cen@zilliz.com>
Signed-off-by: yah01 <yah2er0ne@outlook.com>
2023-12-27 23:24:46 +08:00
MrPresent-Han
151a5c3ca8
fix: iterator lose data for duplicted result(#29406) (#29446)
related: #29406
pr: #29451

Signed-off-by: MrPresent-Han <chun.han@zilliz.com>
2023-12-27 23:22:46 +08:00
congqixia
fc5dd524c5
enhance: [Cherry-pick] add log when release segment created for load failure (#29464) (#29500)
Cherry-pick from master
pr: #29464 
Add log for releasing segment created during load process when load
error happens

Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
2023-12-27 20:00:48 +08:00
yah01
e422a62a80
enhance: improve the handling for segcore error (#29471) (#29521)
- fix lost exception details in segcore
- improve the logs of handling errors from segcore

pr: #29471

Signed-off-by: yah01 <yang.cen@zilliz.com>
2023-12-27 19:06:46 +08:00
wei liu
ad37b98cda
enhance: Rewrite gen stopping segment plan based on assign segment (29473) (#29480)
pr: #29473

`AssignSegment` method defines how to assign segment to nodes, but
score_based_balance implement another assign logic in
`genStoppingSegmentPlan`
This PR rewrite gen stopping segment plan based on assign segment.

Signed-off-by: Wei Liu <wei.liu@zilliz.com>
2023-12-27 15:50:47 +08:00
wei liu
d0bcbf3953
fix: Upgrade from 2.2 should update CollectionLoadInfo (#29443) (#29479)
pr: #29443
milvus branch 2.3 add `loadType` in CollectionLoadInfo, so for
collection meta upgrade from 2.2, we should add `loadType` to
CollectionLoadInfo. This PR update CollectionLoadInfo with `loadType`
when meet a old version CollectionLoadInfo

Signed-off-by: Wei Liu <wei.liu@zilliz.com>
2023-12-27 15:48:58 +08:00
Jiquan Long
82fb37e332
fix: panic in concurrent insert/query scenario (#29408) (#29488)
issue: https://github.com/milvus-io/milvus/issues/29405
pr: #29408 

---------

Signed-off-by: longjiquan <jiquan.long@zilliz.com>
2023-12-27 15:08:45 +08:00
congqixia
5ba0f476d5
fix: [2.3]parse logID from logPath if copyDeltalog find logID not provided (#29276)
Cherry-pick from master
pr: #29273
See also: #29272

This PR add `getDeltaLogID` to safely return logID when Binlog struct
has zero value logID. It parses logID from logPath if the format is
valid. Otherwise, this function shall return error.

---------

Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
2023-12-27 14:42:46 +08:00
wei liu
26b1853c54
fix: Auto balance param can't be updated by dynamic(#29501) (#29502)
pr: #29501
This PR fixed that auto balance param can't be updated by dynamic

Signed-off-by: Wei Liu <wei.liu@zilliz.com>
2023-12-27 14:30:53 +08:00
aoiasd
1311911a26
enhance: [Cherry-Pick] make sure stream closed (#29457)
relate: https://github.com/milvus-io/milvus/issues/28367
pr: https://github.com/milvus-io/milvus/pull/29456

---------

Signed-off-by: aoiasd <zhicheng.yue@zilliz.com>
2023-12-27 10:02:46 +08:00
yah01
51cab791cf
fix: missing to support compact for Array type (#29505) (#29504)
the array type can't be compacted, the system could continue with the
inserted segments, but these segments can be never compacted

fix #29503
pr: #29505

---------

Signed-off-by: yah01 <yah2er0ne@outlook.com>
2023-12-27 08:15:51 +08:00
aoiasd
f5bba79963
enhance: [Cherry-Pick] add default local path for access log (#29461)
relate: https://github.com/milvus-io/milvus/issues/29459
pr: https://github.com/milvus-io/milvus/pull/29460

Signed-off-by: aoiasd <zhicheng.yue@zilliz.com>
2023-12-26 17:52:47 +08:00
aoiasd
6eeb4b7f9a
enhance: [Cherry-Pick] Refine delete by expression for forbid proxy dml task scheduler hang (#29359)
relate: https://github.com/milvus-io/milvus/issues/29146
pr: https://github.com/milvus-io/milvus/pull/29340

---------

Signed-off-by: aoiasd <zhicheng.yue@zilliz.com>
2023-12-26 17:50:48 +08:00
congqixia
14d8b1fe85
fix: [Cherry-pick] Add scope limit for querynode DeleteRequest (#29476)
Cherry-pick from master
pr: #29474 
See also #27515

When Delegator processes delete data, it forwards delete data with only
segment id specified. When two segments has same segment id but one is
growing and the other is sealed, the delete will be applied to both
segments which causes delete data out of order when concurrent load
segment occurs.

Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
2023-12-26 16:40:50 +08:00
MrPresent-Han
95d1056e32
refine the range of chunk size config value(#29388) (#29472)
related: #https://github.com/milvus-io/milvus/issues/29388
pr: https://github.com/milvus-io/milvus/pull/29389

Signed-off-by: MrPresent-Han <chun.han@zilliz.com>
2023-12-26 14:34:46 +08:00
wei liu
514da535e5
enhance: add metrics for stopping querynode balance progress (#29201) (#29390)
pr: #29201
This PR add three metrics to track the stopping balance progress.

Signed-off-by: Wei Liu <wei.liu@zilliz.com>
2023-12-26 10:02:46 +08:00
aoiasd
477def9368
fix: [Cherry-Pick]Use uber atomic instead sync/atomic which only supported after go v1.20 (#29379)
relate: https://github.com/milvus-io/milvus/issues/29376
pr: https://github.com/milvus-io/milvus/pull/29377

Signed-off-by: aoiasd <zhicheng.yue@zilliz.com>
2023-12-26 10:00:47 +08:00
congqixia
f25d1f9b2c
enhance: [cherry-pick] change protection to RLock for loadStreamDelete (#29452)
Cherry-pick from master
pr: #29450 
See also #29332

Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
2023-12-25 23:27:01 +08:00
aoiasd
908e075fdb
enhance: [Cherry-pick] pack datacoord Cluster and SessionManager with interface and mock them (#29171)
relate: https://github.com/milvus-io/milvus/issues/28861
https://github.com/milvus-io/milvus/issues/28854
pr: https://github.com/milvus-io/milvus/pull/28869

---------

Signed-off-by: aoiasd <zhicheng.yue@zilliz.com>
2023-12-25 14:42:44 +08:00
PowderLi
0c3de8d886
fix: Partition related privileges should belong to Collection (#29429)
issue: #29427
master pr: #29428

it will try to find privilege_name from the object_type, while grant a
privilege to a role

Signed-off-by: PowderLi <min.li@zilliz.com>
2023-12-25 14:18:43 +08:00
aoiasd
2256b53e03
fix: [Cherry-pick]Remove SetFinalizer which cause proxy msgstream memory leak (#29404)
relate: https://github.com/milvus-io/milvus/issues/28367
pr: https://github.com/milvus-io/milvus/pull/29403

Signed-off-by: aoiasd <zhicheng.yue@zilliz.com>
2023-12-25 10:16:53 +08:00
nico
60a90463d0
test: update test cases (#29416)
issue: #27518 #29274
pr: #29383

Signed-off-by: nico <cheng.yuan@zilliz.com>
2023-12-23 15:46:42 +08:00
yah01
0ec8c6c748
enhance: reduce the memory usage of variable length data (#29387) (#29402)
add all loading data into a buffer and then copy them into the a
fit-in-size memory
pr: https://github.com/milvus-io/milvus/pull/29387

---------

Signed-off-by: yah01 <yah2er0ne@outlook.com>
2023-12-22 16:56:42 +08:00
SimFG
b69543c7dc
fix: [2.3] Clean the compaction plan info to avoid the object leak (#29368)
issue: https://github.com/milvus-io/milvus/issues/29296
pr: #29365

Signed-off-by: SimFG <bang.fu@zilliz.com>
2023-12-22 12:02:44 +08:00
wei liu
5fa63da4e3
fix: Rename invalid parameterutil package path (#29334) (#29391)
pr: #29334
This PR renames the invalid parameterutil package path

Signed-off-by: Wei Liu <wei.liu@zilliz.com>
2023-12-22 10:06:41 +08:00
SimFG
74e72ce27e
enhance: [2.3] Support to get the param value in the runtime (#29298)
pr: #29297
/kind improvement

Signed-off-by: SimFG <bang.fu@zilliz.com>
2023-12-21 20:36:43 +08:00
yihao.dai
d8800f5ca5
fix: Return time tick delay error and refine quota error messages (#29289) (#29363)
This pr:
Handles the time tick delay error when converting old error codes to
milvus errors.
Enhances quota error messages by eliminating "force deny" and
substituting it with "quota exceeded."

pr: https://github.com/milvus-io/milvus/pull/29289
issue: https://github.com/milvus-io/milvus/issues/29288

Signed-off-by: bigsheeper <yihao.dai@zilliz.com>
2023-12-21 14:58:49 +08:00
chyezh
ace81b8306
fix: fixup data race at generate binlog index (#29371)
issue: #29339
pr: #29370

Signed-off-by: chyezh <ye.zhen@zilliz.com>
2023-12-21 14:56:40 +08:00
congqixia
15bad6485f
enhance: [cherry-pick] refine proxy meta cache partition logic (#29315) (#29378)
Cherry-pick from master
pr: #29315
See also #29113

- Unify partition info refresh logic
- Prevent parse partition names for each partition key search request

---------

Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
2023-12-21 14:16:42 +08:00
yah01
babfb7d671
enhance: remove all unnecessary string formatting (#29323) (#29361)
done by two regex expressions:

- `PanicInfo\((.+),[. \n]+fmt::format\(([.\s\S]+?)\)\)`
- `AssertInfo\((.+),[. \n]+fmt::format\(([.\s\S]+?)\)\)`

related: #28811
pr: #29323

Signed-off-by: yah01 <yang.cen@zilliz.com>
2023-12-21 10:14:52 +08:00
congqixia
85f17ada74
fix: [cherry-pick] grpc client check session skipped due to role not match (#29358)
Cherry pick from master
pr: #29356
Related to #28815

---------

Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
2023-12-21 10:12:51 +08:00
congqixia
9050b236e4
fix: [cherry-pick] delegator may mark segment offline by mistake (#29344)
cherry-pick from master
pr: #29343
See also #29332

The segment may be released before or during the request when delegator
tries to forward delete request to yet. Currently, these two situation
returns different error code.

In this particular case, ErrSegmentNotLoaded and ErrSegmentNotFound
shall both be ignored preventing return search service unavailable by
mistake.

---------

Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
2023-12-20 21:16:41 +08:00
sre-ci-robot
2227cad047
[automated] Update Pytest image changes (#29333)
Update Pytest image changes
See changes:
f1ed04bee7
Signed-off-by: sre-ci-robot sre-ci-robot@users.noreply.github.com

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
2023-12-20 19:52:42 +08:00
zhuwenxing
40ad5d714a
test: [skip e2e] [cherry-pick]fix getting hotfix image tag (#29350)
By adding conjunctions, you can obtain more accurate results.

pr: https://github.com/milvus-io/milvus/pull/29347

Signed-off-by: zhuwenxing <wenxing.zhu@zilliz.com>
2023-12-20 17:12:41 +08:00