20761 Commits

Author SHA1 Message Date
congqixia
5d919b077b
enhance: [2.4] Bump golang/x/net to v0.33 fixing security alarm (#39209)
Cherry pick from master
pr: #38850 

Related to https://github.com/milvus-io/milvus/security/dependabot/106

Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
2025-01-13 19:35:00 +08:00
sthuang
e56399720d
fix: [2.4] rbac custom group privilege level check (#39194)
cherry-pick from master: https://github.com/milvus-io/milvus/pull/39164
related: related: https://github.com/milvus-io/milvus/issues/39086

---------

Signed-off-by: shaoting-huang <shaoting.huang@zilliz.com>
2025-01-13 13:58:58 +08:00
sthuang
af2264446f
fix: [2.4] restore rbac with empty meta panic (#39142)
cp from master
pr: #39141
related: https://github.com/milvus-io/milvus/issues/38985

Signed-off-by: shaoting-huang <shaoting.huang@zilliz.com>
2025-01-13 10:24:59 +08:00
congqixia
29a0e31c2f
fix: [2.4] Return io error other than NotExist refreshing config (#38924) (#39073)
Cherry-pick from master
pr: #38924 
Related to #38923

This PR:

- Check whether `os.Stat` config file error is io.ErrNotExist
- Panic when get config return error during Milvus initialization

---------

---------

Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
2025-01-10 14:09:04 +08:00
Zhen Ye
782cd749bb
enhance: make new go package to manage proto (#39129)
issue: #39095
pr: #39114

---------

Signed-off-by: chyezh <chyezh@outlook.com>
2025-01-10 10:13:01 +08:00
SimFG
feb885a204
enhance: [2.4] update the expr static web page (#39089)
issue: #39083
pr: #39082
/kind improvement
Three new functions of the static web page:
1. The input box can be expanded and scrolled if it exceeds the maximum
size
2. Input history
3. It will simply check whether the quotation marks and brackets appear
in pairs

Signed-off-by: SimFG <bang.fu@zilliz.com>
2025-01-09 10:03:02 +08:00
cai.zhang
3b99485615
enhance: clean compaction task in compactionHandler (#38170) (#38848)
issue: #35711, #38811 

master pr: #38170
master pr:  #38925

---------

Signed-off-by: wayblink <anyang.wang@zilliz.com>
Signed-off-by: Cai Zhang <cai.zhang@zilliz.com>
Co-authored-by: wayblink <anyang.wang@zilliz.com>
2025-01-08 15:58:57 +08:00
congqixia
d8bc793be3
enhance: [2.4] Use bitset or instead of bitwise set (#39037) (#39042)
Cherry pick from master
pr: #39037
Related to #39003

Copying bitset value bit by bit is slow and CPU heavy, this PR utilizes
bitset operator "|=" to accelerate this procedure

Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
2025-01-08 15:40:56 +08:00
congqixia
9e22106370
enhance: [2.4] Fix go mod conflict (#39021)
Previous PR #38892

Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
2025-01-06 19:22:56 +08:00
aoiasd
b3410f52d9
enhance:[Cherry-pick] report restful and grpc auth info to hook (#38892)
pr: https://github.com/milvus-io/milvus/pull/38112
https://github.com/milvus-io/milvus/pull/38943

---------

Signed-off-by: aoiasd <zhicheng.yue@zilliz.com>
2025-01-06 15:10:57 +08:00
cai.zhang
b4c773de69
enhance: [2.4]Return collection not loaded rather than not found on querynode (#38593) (#38920)
issue: https://github.com/milvus-io/milvus/issues/38586

master pr: https://github.com/milvus-io/milvus/pull/38593

Signed-off-by: Cai Zhang <cai.zhang@zilliz.com>
2025-01-05 18:56:55 +08:00
cai.zhang
52a135cf78
fix: [2.4] expression with capital AND and OR are not recognized (#38929)
fix https://github.com/milvus-io/milvus/issues/38864
AND, OR and NOT is not recognized in milvus parser

master pr: #38927

Signed-off-by: Cai Zhang <cai.zhang@zilliz.com>
2025-01-05 18:53:01 +08:00
zhikunyao
a300074692
enhance: update opensource etcd version (#38973)
Signed-off-by: Zhikun Yao <zhikun.yao@zilliz.com>
2025-01-03 12:54:55 +08:00
Xiaofan
a3ea66f621
fix: drop partition can not be successful if load failed[2.4] (#38871)
related to https://github.com/milvus-io/milvus/issues/38649
pr: #38793
when partition load failed, the partition drop will also fail due to the
wrong error message

Signed-off-by: xiaofanluan <xiaofan.luan@zilliz.com>
2025-01-02 09:54:54 +08:00
sre-ci-robot
ef1b722570
[automated] Bump milvus version to v2.4.20 (#38901)
Bump milvus version to v2.4.20
Signed-off-by: sre-ci-robot sre-ci-robot@users.noreply.github.com

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
2025-01-02 09:28:53 +08:00
Patrick Weizhi Xu
ccbe6fc646
enhance: [2.4] add param for tuning max VARCHAR length (#38890)
issue: #38882
pr: https://github.com/milvus-io/milvus/pull/38884

Signed-off-by: Patrick Weizhi Xu <weizhi.xu@zilliz.com>
(cherry picked from commit 72fecd4f34637a78c1cbc789ee3d97797b458fc0)
v2.4.20
2024-12-31 18:19:19 +08:00
yihao.dai
163b258a68
enhance: Bump milvus version to v2.4.20 (#38889)
Signed-off-by: bigsheeper <yihao.dai@zilliz.com>
2024-12-31 16:33:56 +08:00
foxspy
c0e781072e
fix: [2.4] enable mmap for sparse index (#38849)
issue: #29419
/kind branch-feature

Signed-off-by: xianliang.li <xianliang.li@zilliz.com>
2024-12-31 16:28:53 +08:00
zhuwenxing
fb8b880212
test: [skip e2e][cherry-pick]fix pytest_addoption type (#38861)
pr: https://github.com/milvus-io/milvus/pull/38860
/kind improvement

Signed-off-by: zhuwenxing <wenxing.zhu@zilliz.com>
2024-12-31 14:12:58 +08:00
Xianhui Lin
4813fc08e2
fix: [2.4]fix altercollectionfield interceptor dbname (#38664)
fix altercollectionfield interceptor dbname
issue: 
master pr: https://github.com/milvus-io/milvus/pull/38662

Signed-off-by: Xianhui.Lin <xianhui.lin@zilliz.com>
2024-12-31 10:29:24 +08:00
cai.zhang
c3e26a35f5
fix: [2.4] Release compaction task lock when return function (#38857)
issue: #38851 

master pr: #38856

Signed-off-by: Cai Zhang <cai.zhang@zilliz.com>
2024-12-31 10:28:53 +08:00
Zhen Ye
253860b862
fix: the retrieve plan on heap is used after free when reduce (#38842)
issue: #38731
pr: #38840

Signed-off-by: chyezh <chyezh@outlook.com>
2024-12-30 16:02:54 +08:00
SimFG
bd67acc68a
enhance: [2.4] update expr version to support method parameter type conversion (#38781)
/kind improvement
issue: #38780

Signed-off-by: SimFG <bang.fu@zilliz.com>
2024-12-30 15:59:06 +08:00
sre-ci-robot
2f208ebc6f
[automated] Bump milvus version to v2.4.19 (#38800)
Bump milvus version to v2.4.19
Signed-off-by: sre-ci-robot sre-ci-robot@users.noreply.github.com

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
2024-12-27 09:12:51 +08:00
congqixia
fec92e9fa6
enhance: Bump milvus & proto version to v2.4.19 (#38773)
Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
v2.4.19
2024-12-26 16:34:50 +08:00
sthuang
92c7f6a72e
fix: [2.4] expand privilege group when list policy in rootcoord (#38759)
cherry-pick from: https://github.com/milvus-io/milvus/pull/38758
related: https://github.com/milvus-io/milvus/issues/38757

Signed-off-by: shaoting-huang <shaoting.huang@zilliz.com>
2024-12-26 14:42:50 +08:00
jaime
b496fa1914
fix: Revert Expose metrics of stanby coordinators (#27698) (#38742)
issue: #38608
pr: #38620

Signed-off-by: jaime <yun.zhang@zilliz.com>
2024-12-26 10:16:51 +08:00
cai.zhang
e8eea587d5
enhance: [2.4] Revert clean compaction task in compactionHandler (#38753)
Reverts milvus-io/milvus#38584

issue: https://github.com/milvus-io/milvus/issues/35711

master pr: https://github.com/milvus-io/milvus/pull/38170

Signed-off-by: Cai Zhang <cai.zhang@zilliz.com>
2024-12-25 21:44:50 +08:00
XuanYang-cn
7f1116566e
enhance: [24]Add missing delete metrics (#38634) (#38746)
Add 2 counter metrics:
- Total delete entries from deltalog:
milvus_datanode_compaction_delete_count
- Total missing deletes: milvus_datanode_compaction_missing_delete_count

See also: #34665
pr: #38634

Signed-off-by: yangxuan <xuan.yang@zilliz.com>

---------

Signed-off-by: yangxuan <xuan.yang@zilliz.com>
2024-12-25 19:44:52 +08:00
aoiasd
b9eb396a5f
fix: [Cherry-pick] access log retention new log not the old and skip rotate empty log (#38661)
pr: https://github.com/milvus-io/milvus/pull/38309
relate: https://github.com/milvus-io/milvus/issues/38293

Signed-off-by: aoiasd <zhicheng.yue@zilliz.com>
2024-12-25 19:08:52 +08:00
ThreadDao
604fb754a2
test: add cases for async milvus client (#38691)
issue: #38697
pr: #38699

Signed-off-by: ThreadDao <yufen.zong@zilliz.com>
2024-12-25 17:08:49 +08:00
wei liu
9e43e550e6
fix: [2.4] Prevent balancer from overloading the same QueryNode (#38720)
issue: #38718
pr: #38719
The balancer calculates the workload of executing tasks as an ongoing
score for target nodes. However, a logic issue arises when
GetSegmentTaskDelta or GetChannelTaskDelta is called with
collectionID=-1, which incorrectly returns zero.

Due to the incorrect global score, the executing task's workload is not
properly reflected for each collection. Consequently, each collection
submits its own balance task, leading to the balancer assigning
excessive tasks to the same QueryNode.

---------

Signed-off-by: Wei Liu <wei.liu@zilliz.com>
2024-12-25 15:14:51 +08:00
sthuang
ef6aae86cf
fix: [2.4] fix privilege group list and list collections (#38698)
cherry-pick from: https://github.com/milvus-io/milvus/pull/38684
related: https://github.com/milvus-io/milvus/issues/37031

Signed-off-by: shaoting-huang <shaoting.huang@zilliz.com>
2024-12-25 14:32:51 +08:00
wei liu
d975139c01
fix: Fix update loading collection's load config doesn't work (#38596)
issue: #38594
pr: #38595

---------

Signed-off-by: Wei Liu <wei.liu@zilliz.com>
2024-12-25 11:30:51 +08:00
Zhen Ye
5d2f454ce4
enhance: add multiply factor when loading index (#38721)
issue: #38715
pr: #38716

Signed-off-by: chyezh <chyezh@outlook.com>
2024-12-25 10:50:58 +08:00
wei liu
8fe883f7c1
fix: [2.4] Querycoord will trigger unexpected balance task after restart (#38714)
issue: #38606 
pr: #38630

---------

Signed-off-by: Wei Liu <wei.liu@zilliz.com>
2024-12-25 10:46:50 +08:00
yihao.dai
648078e83b
fix: [2.4] Fix 0 read count during import (#38696)
issue: https://github.com/milvus-io/milvus/issues/38693

pr: https://github.com/milvus-io/milvus/pull/38694

Signed-off-by: bigsheeper <yihao.dai@zilliz.com>
2024-12-24 20:58:50 +08:00
congqixia
5fd69a07ff
fix: [2.4] Remove sync task after finished (#38681) (#38686)
Cherry-pick from master
pr: #38681
Related to #38680

Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
2024-12-24 19:00:52 +08:00
cai.zhang
afaabc2a38
enhance: [2.4] clean compaction task in compactionHandler (#38170) (#38584)
issue: #35711

master pr: #38170

Signed-off-by: wayblink <anyang.wang@zilliz.com>
Signed-off-by: Cai Zhang <cai.zhang@zilliz.com>
Co-authored-by: wayblink <anyang.wang@zilliz.com>
2024-12-24 15:34:50 +08:00
cai.zhang
7363a1c0cb
fix: [2.4] Support hybrid search with expression template (#38624)
issue: #38616 

master pr: #38623

Signed-off-by: Cai Zhang <cai.zhang@zilliz.com>
2024-12-23 14:34:50 +08:00
cai.zhang
ad68bc6204
fix: [2.4] Decode unicode for json key in expression (#38652)
issue: #38626

master pr: #38651

Signed-off-by: Cai Zhang <cai.zhang@zilliz.com>
2024-12-23 13:54:51 +08:00
XuanYang-cn
21d76ad1ce
enhance: Use partitionID when delete by partitionKey (#38232)
When delete by partition_key, Milvus will generates L0 segments
globally. During L0 Compaction, those L0 segments will touch all
partitions collection wise. Due to the false-positive rate of segment
bloomfilters, L0 compactions will append false deltalogs to completed
irrelevant partitions, which causes *partition deletion amplification.

This PR uses partition_key to set targeted partitionID when producing
deleteMsgs into MsgStreams. This'll narrow down L0 segments scope to
partition level, and remove the false-positive influence
collection-wise.

However, due to DeleteMsg structure, we can only label one partition to
one deleteMsg, so this enhancement fails if user wants to delete over 2
partition_keys in one deletion.

pr: #38231 
See also: #34665

Signed-off-by: yangxuan <xuan.yang@zilliz.com>
2024-12-23 13:52:51 +08:00
sre-ci-robot
592f34c2d7
[automated] Bump milvus version to v2.4.18 (#38605)
Bump milvus version to v2.4.18
Signed-off-by: sre-ci-robot sre-ci-robot@users.noreply.github.com

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
2024-12-21 07:24:48 +08:00
XuanYang-cn
e82af48706
fix: State trans error in concurrent Release and Watching (#38591)
See also: #38589
pr: #38590

Signed-off-by: yangxuan <xuan.yang@zilliz.com>
v2.4.18
2024-12-19 21:46:47 +08:00
congqixia
451deb3298
enhance: Bump milvus & proto version to v2.4.18 (#38552)
mockery update related to #31779

Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
2024-12-19 10:32:47 +08:00
yanliang567
dc78b67f73
test: Add alter index, alter collection, alter database tests (#38561)
related issue: #38471

---------

Signed-off-by: yanliang567 <yanliang.qiao@zilliz.com>
2024-12-19 10:30:47 +08:00
smellthemoon
98052cfcc3
fix: need pass parameter to listPrivilegeGroups(#38562) (#38564)
pr: #38562 
issue: #38563

Signed-off-by: lixinguo <xinguo.li@zilliz.com>
Co-authored-by: lixinguo <xinguo.li@zilliz.com>
2024-12-18 20:28:51 +08:00
sthuang
d84e4f6ed2
fix: [2.4] rbac revoke check if there is same privilege in other privilege groups granted (#38559)
cherry-pick from master: https://github.com/milvus-io/milvus/pull/38558
related: https://github.com/milvus-io/milvus/issues/38557

Signed-off-by: shaoting-huang <shaoting.huang@zilliz.com>
2024-12-18 19:30:47 +08:00
Chun Han
306f200af0
fix: growing-groupby-crush(#38533) (#38553)
related: #38533
pr: https://github.com/milvus-io/milvus/pull/38538

Signed-off-by: MrPresent-Han <chun.han@gmail.com>
Co-authored-by: MrPresent-Han <chun.han@gmail.com>
2024-12-18 17:12:47 +08:00
Bingyi Sun
b469999f65
enhance: allow hyphen in partition name (#38474)
Signed-off-by: sunby <sunbingyi1992@gmail.com>
2024-12-18 13:54:47 +08:00