admin/milvus
1
0
Fork 0
mirror of https://gitee.com/milvus-io/milvus.git synced 2026-01-07 19:31:51 +08:00
Code Issues Packages Projects Releases Wiki Activity

enhance: Support collection name for ProxyDeleteVectors as well (#38247)

Browse Source 
issue: https://github.com/milvus-io/milvus/issues/38242

Signed-off-by: Reid Chan <reidchan@apache.org>
This commit is contained in:
Reid Chan 2024-12-06 15:00:40 +08:00 committed by GitHub
parent edabfa8fa6
commit e1aebe8fce
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
2 changed files with 6 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
internal/proxy/task_delete.go
View File

@ -188,7 +188,11 @@ func (dt *deleteTask) Execute(ctx context.Context) (err error) {
}
func (dt *deleteTask) PostExecute(ctx context.Context) error {
metrics.ProxyDeleteVectors.WithLabelValues(paramtable.GetStringNodeID(), dt.req.GetDbName()).Add(float64(dt.count))
metrics.ProxyDeleteVectors.WithLabelValues(
paramtable.GetStringNodeID(),
dt.req.GetDbName(),
dt.req.GetCollectionName(),
).Add(float64(dt.count))
return nil
}

2
pkg/metrics/proxy_metrics.go
View File

@ -66,7 +66,7 @@ var (
Subsystem: typeutil.ProxyRole,
Name: "delete_vectors_count",
Help: "counter of vectors successfully deleted",
}, []string{nodeIDLabelName, databaseLabelName})
}, []string{nodeIDLabelName, databaseLabelName, collectionName})
// ProxySQLatency record the latency of search successfully.
ProxySQLatency = prometheus.NewHistogramVec(