From e1aebe8fcef960b346c62a6cdfddbf1f6068a55e Mon Sep 17 00:00:00 2001 From: Reid Chan Date: Fri, 6 Dec 2024 15:00:40 +0800 Subject: [PATCH] enhance: Support collection name for ProxyDeleteVectors as well (#38247) issue: https://github.com/milvus-io/milvus/issues/38242 Signed-off-by: Reid Chan --- internal/proxy/task_delete.go | 6 +++++- pkg/metrics/proxy_metrics.go | 2 +- 2 files changed, 6 insertions(+), 2 deletions(-) diff --git a/internal/proxy/task_delete.go b/internal/proxy/task_delete.go index 8ffdf84860..e4addae3fc 100644 --- a/internal/proxy/task_delete.go +++ b/internal/proxy/task_delete.go @@ -188,7 +188,11 @@ func (dt *deleteTask) Execute(ctx context.Context) (err error) { } func (dt *deleteTask) PostExecute(ctx context.Context) error { - metrics.ProxyDeleteVectors.WithLabelValues(paramtable.GetStringNodeID(), dt.req.GetDbName()).Add(float64(dt.count)) + metrics.ProxyDeleteVectors.WithLabelValues( + paramtable.GetStringNodeID(), + dt.req.GetDbName(), + dt.req.GetCollectionName(), + ).Add(float64(dt.count)) return nil } diff --git a/pkg/metrics/proxy_metrics.go b/pkg/metrics/proxy_metrics.go index 40a6cc01d1..45a8a1ec2e 100644 --- a/pkg/metrics/proxy_metrics.go +++ b/pkg/metrics/proxy_metrics.go @@ -66,7 +66,7 @@ var ( Subsystem: typeutil.ProxyRole, Name: "delete_vectors_count", Help: "counter of vectors successfully deleted", - }, []string{nodeIDLabelName, databaseLabelName}) + }, []string{nodeIDLabelName, databaseLabelName, collectionName}) // ProxySQLatency record the latency of search successfully. ProxySQLatency = prometheus.NewHistogramVec(