admin/milvus
1
0
Fork 0
mirror of https://gitee.com/milvus-io/milvus.git synced 2026-01-07 19:31:51 +08:00
Code Issues Packages Projects Releases Wiki Activity

Fix RHNSWPQ pqm divide by zero (#18700)

Browse Source 
See also: #18671

Signed-off-by: yangxuan <xuan.yang@zilliz.com>

Signed-off-by: yangxuan <xuan.yang@zilliz.com>
This commit is contained in:
XuanYang-cn 2022-08-18 19:24:51 +08:00 committed by GitHub
parent cf1c5902e5
commit a782ded0bd
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 5 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
internal/util/indexparamcheck/conf_adapter.go
View File

@ -419,7 +419,7 @@ func (adapter *RHNSWPQConfAdapter) CheckTrain(params map[string]string) bool {
return false
}
pqm, err := strconv.Atoi(pqmStr)
if err != nil {
if err != nil || pqm == 0 {
return false
}

4
internal/util/indexparamcheck/conf_adapter_test.go
View File

@ -461,6 +461,9 @@ func TestRHNSWPQConfAdapter_CheckTrain(t *testing.T) {
invalidParamsPQM := copyParams(validParams)
invalidParamsPQM[PQM] = "NAN"
invalidParamsPQMZero := copyParams(validParams)
invalidParamsPQMZero[PQM] = "0"
cases := []struct {
params map[string]string
want bool
@ -473,6 +476,7 @@ func TestRHNSWPQConfAdapter_CheckTrain(t *testing.T) {
{invalidMParamsMax, false},
{invalidParamsWithoutPQM, false},
{invalidParamsPQM, false},
{invalidParamsPQMZero, false},
}
adapter := newRHNSWPQConfAdapter()