diff --git a/internal/util/indexparamcheck/conf_adapter.go b/internal/util/indexparamcheck/conf_adapter.go index 9f1fd55787..2d1f60954b 100644 --- a/internal/util/indexparamcheck/conf_adapter.go +++ b/internal/util/indexparamcheck/conf_adapter.go @@ -419,7 +419,7 @@ func (adapter *RHNSWPQConfAdapter) CheckTrain(params map[string]string) bool { return false } pqm, err := strconv.Atoi(pqmStr) - if err != nil { + if err != nil || pqm == 0 { return false } diff --git a/internal/util/indexparamcheck/conf_adapter_test.go b/internal/util/indexparamcheck/conf_adapter_test.go index 9063151be4..d5649af576 100644 --- a/internal/util/indexparamcheck/conf_adapter_test.go +++ b/internal/util/indexparamcheck/conf_adapter_test.go @@ -461,6 +461,9 @@ func TestRHNSWPQConfAdapter_CheckTrain(t *testing.T) { invalidParamsPQM := copyParams(validParams) invalidParamsPQM[PQM] = "NAN" + invalidParamsPQMZero := copyParams(validParams) + invalidParamsPQMZero[PQM] = "0" + cases := []struct { params map[string]string want bool @@ -473,6 +476,7 @@ func TestRHNSWPQConfAdapter_CheckTrain(t *testing.T) { {invalidMParamsMax, false}, {invalidParamsWithoutPQM, false}, {invalidParamsPQM, false}, + {invalidParamsPQMZero, false}, } adapter := newRHNSWPQConfAdapter()