admin/milvus
1
0
Fork 0
mirror of https://gitee.com/milvus-io/milvus.git synced 2025-12-08 01:58:34 +08:00
Code Issues Packages Projects Releases Wiki Activity

Refine indexcoord logs (#18589)

Browse Source 
Signed-off-by: yun.zhang <yun.zhang@zilliz.com>

Signed-off-by: yun.zhang <yun.zhang@zilliz.com>
This commit is contained in:
jaime 2022-08-11 10:00:38 +08:00 committed by GitHub
parent cd04258122
commit 0e95f8a690
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
3 changed files with 5 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
internal/datacoord/services.go
View File

@ -651,7 +651,7 @@ func (s *Server) GetRecoveryInfo(ctx context.Context, req *datapb.GetRecoveryInf
CollectionID: collectionID, CollectionID: collectionID,
}) })
if err = VerifyResponse(dresp, err); err != nil { if err = VerifyResponse(dresp, err); err != nil {
log.Error("get collection info from master failed", log.Error("get collection info from rootcoord failed",
zap.Int64("collectionID", collectionID), zap.Int64("collectionID", collectionID),
zap.Error(err)) zap.Error(err))

2
internal/indexcoord/index_builder.go
View File

@ -166,7 +166,7 @@ func (ib *indexBuilder) process(buildID UniqueID) {
// if all IndexNodes are executing task, wait for one of them to finish the task. // if all IndexNodes are executing task, wait for one of them to finish the task.
nodeID, client := ib.ic.nodeManager.PeekClient(meta) nodeID, client := ib.ic.nodeManager.PeekClient(meta)
if client == nil { if client == nil {
log.Error("index builder peek client error, there is no available") log.RatedDebug(30, "index builder peek client error, there is no available")
return return
} }
// update version and set nodeID // update version and set nodeID

7
internal/indexcoord/meta_table.go
View File

@ -272,17 +272,17 @@ func (mt *metaTable) GetMeta(buildID UniqueID) (*Meta, bool) {
func (mt *metaTable) canIndex(buildID int64) bool { func (mt *metaTable) canIndex(buildID int64) bool {
meta := mt.indexBuildID2Meta[buildID] meta := mt.indexBuildID2Meta[buildID]
if meta.indexMeta.MarkDeleted { if meta.indexMeta.MarkDeleted {
log.Warn("Index has been deleted", zap.Int64("buildID", buildID)) log.Debug("Index has been deleted", zap.Int64("buildID", buildID))
return false return false
} }
if meta.indexMeta.NodeID != 0 { if meta.indexMeta.NodeID != 0 {
log.Error("IndexCoord metaTable BuildIndex, but indexMeta's NodeID is not zero", log.Debug("IndexCoord metaTable BuildIndex, but indexMeta's NodeID is not zero",
zap.Int64("buildID", buildID), zap.Int64("nodeID", meta.indexMeta.NodeID)) zap.Int64("buildID", buildID), zap.Int64("nodeID", meta.indexMeta.NodeID))
return false return false
} }
if meta.indexMeta.State != commonpb.IndexState_Unissued { if meta.indexMeta.State != commonpb.IndexState_Unissued {
log.Error("IndexCoord metaTable BuildIndex, but indexMeta's state is not unissued", log.Debug("IndexCoord metaTable BuildIndex, but indexMeta's state is not unissued",
zap.Int64("buildID", buildID), zap.String("state", meta.indexMeta.State.String())) zap.Int64("buildID", buildID), zap.String("state", meta.indexMeta.State.String()))
return false return false
} }
@ -303,7 +303,6 @@ func (mt *metaTable) UpdateVersion(indexBuildID UniqueID, nodeID UniqueID) error
return mt.saveIndexMeta(m) return mt.saveIndexMeta(m)
} }
if err := mt.updateMeta(indexBuildID, updateFunc); err != nil { if err := mt.updateMeta(indexBuildID, updateFunc); err != nil {
log.Error("IndexCoord metaTable UpdateVersion fail", zap.Int64("buildID", indexBuildID), zap.Error(err))
return err return err
} }
log.Info("IndexCoord metaTable UpdateVersion success", zap.Int64("IndexBuildId", indexBuildID), log.Info("IndexCoord metaTable UpdateVersion success", zap.Int64("IndexBuildId", indexBuildID),