From 0e95f8a690c3e6a1036bb8963b587b56106f4ddd Mon Sep 17 00:00:00 2001 From: jaime Date: Thu, 11 Aug 2022 10:00:38 +0800 Subject: [PATCH] Refine indexcoord logs (#18589) Signed-off-by: yun.zhang Signed-off-by: yun.zhang --- internal/datacoord/services.go | 2 +- internal/indexcoord/index_builder.go | 2 +- internal/indexcoord/meta_table.go | 7 +++---- 3 files changed, 5 insertions(+), 6 deletions(-) diff --git a/internal/datacoord/services.go b/internal/datacoord/services.go index 8d45b13c44..7f4d20a7d9 100644 --- a/internal/datacoord/services.go +++ b/internal/datacoord/services.go @@ -651,7 +651,7 @@ func (s *Server) GetRecoveryInfo(ctx context.Context, req *datapb.GetRecoveryInf CollectionID: collectionID, }) if err = VerifyResponse(dresp, err); err != nil { - log.Error("get collection info from master failed", + log.Error("get collection info from rootcoord failed", zap.Int64("collectionID", collectionID), zap.Error(err)) diff --git a/internal/indexcoord/index_builder.go b/internal/indexcoord/index_builder.go index 6293b6a19c..705b759c0d 100644 --- a/internal/indexcoord/index_builder.go +++ b/internal/indexcoord/index_builder.go @@ -166,7 +166,7 @@ func (ib *indexBuilder) process(buildID UniqueID) { // if all IndexNodes are executing task, wait for one of them to finish the task. nodeID, client := ib.ic.nodeManager.PeekClient(meta) if client == nil { - log.Error("index builder peek client error, there is no available") + log.RatedDebug(30, "index builder peek client error, there is no available") return } // update version and set nodeID diff --git a/internal/indexcoord/meta_table.go b/internal/indexcoord/meta_table.go index ada1b5f698..0a01e97bee 100644 --- a/internal/indexcoord/meta_table.go +++ b/internal/indexcoord/meta_table.go @@ -272,17 +272,17 @@ func (mt *metaTable) GetMeta(buildID UniqueID) (*Meta, bool) { func (mt *metaTable) canIndex(buildID int64) bool { meta := mt.indexBuildID2Meta[buildID] if meta.indexMeta.MarkDeleted { - log.Warn("Index has been deleted", zap.Int64("buildID", buildID)) + log.Debug("Index has been deleted", zap.Int64("buildID", buildID)) return false } if meta.indexMeta.NodeID != 0 { - log.Error("IndexCoord metaTable BuildIndex, but indexMeta's NodeID is not zero", + log.Debug("IndexCoord metaTable BuildIndex, but indexMeta's NodeID is not zero", zap.Int64("buildID", buildID), zap.Int64("nodeID", meta.indexMeta.NodeID)) return false } if meta.indexMeta.State != commonpb.IndexState_Unissued { - log.Error("IndexCoord metaTable BuildIndex, but indexMeta's state is not unissued", + log.Debug("IndexCoord metaTable BuildIndex, but indexMeta's state is not unissued", zap.Int64("buildID", buildID), zap.String("state", meta.indexMeta.State.String())) return false } @@ -303,7 +303,6 @@ func (mt *metaTable) UpdateVersion(indexBuildID UniqueID, nodeID UniqueID) error return mt.saveIndexMeta(m) } if err := mt.updateMeta(indexBuildID, updateFunc); err != nil { - log.Error("IndexCoord metaTable UpdateVersion fail", zap.Int64("buildID", indexBuildID), zap.Error(err)) return err } log.Info("IndexCoord metaTable UpdateVersion success", zap.Int64("IndexBuildId", indexBuildID),