Zhen Ye 7c575a18b0
enhance: support AckSyncUp for broadcaster, and enable it in truncate api (#46313)
issue: #43897
also for issue: #46166

add ack_sync_up flag into broadcast message header, which indicates that
whether the broadcast operation is need to be synced up between the
streaming node and the coordinator.
If the ack_sync_up is false, the broadcast operation will be acked once
the recovery storage see the message at current vchannel, the fast ack
operation can be applied to speed up the broadcast operation.
If the ack_sync_up is true, the broadcast operation will be acked after
the checkpoint of current vchannel reach current message.
The fast ack operation can not be applied to speed up the broadcast
operation, because the ack operation need to be synced up with streaming
node.
e.g. if truncate collection operation want to call ack once callback
after the all segment are flushed at current vchannel, it should set the
ack_sync_up to be true.

TODO: current implementation doesn't promise the ack sync up semantic,
it only promise FastAck operation will not be applied, wait for 3.0 to
implement the ack sync up semantic. only for truncate api now.

---------

Signed-off-by: chyezh <chyezh@outlook.com>
2025-12-17 16:55:17 +08:00

82 lines
2.3 KiB
Go

package message
import (
"google.golang.org/protobuf/proto"
"github.com/milvus-io/milvus/pkg/v2/proto/messagespb"
"github.com/milvus-io/milvus/pkg/v2/util/funcutil"
"github.com/milvus-io/milvus/pkg/v2/util/typeutil"
)
// newBroadcastHeaderFromProto creates a BroadcastHeader from proto.
func newBroadcastHeaderFromProto(proto *messagespb.BroadcastHeader) *BroadcastHeader {
rks := make(typeutil.Set[ResourceKey], len(proto.GetResourceKeys()))
for _, key := range proto.GetResourceKeys() {
rks.Insert(NewResourceKeyFromProto(key))
}
return &BroadcastHeader{
BroadcastID: proto.GetBroadcastId(),
VChannels: proto.GetVchannels(),
ResourceKeys: rks,
AckSyncUp: proto.GetAckSyncUp(),
}
}
type BroadcastHeader struct {
BroadcastID uint64
VChannels []string
ResourceKeys typeutil.Set[ResourceKey]
AckSyncUp bool
}
// BroadcastResult is the result of broadcast operation.
type BroadcastResult[H proto.Message, B proto.Message] struct {
Message SpecializedBroadcastMessage[H, B]
Results map[string]*AppendResult
}
// AckResult is the result of ack operation.
type AckResult[H proto.Message, B proto.Message] struct {
Message SpecializedImmutableMessage[H, B]
}
// GetMaxTimeTick returns the max time tick of the broadcast result.
func (br *BroadcastResult[H, B]) GetMaxTimeTick() uint64 {
maxTimeTick := uint64(0)
for _, result := range br.Results {
if result.TimeTick > maxTimeTick {
maxTimeTick = result.TimeTick
}
}
return maxTimeTick
}
// GetControlChannelResult returns the append result of the control channel.
// Return nil if the control channel is not found.
func (br *BroadcastResult[H, B]) GetControlChannelResult() *AppendResult {
for vchannel, result := range br.Results {
if funcutil.IsControlChannel(vchannel) {
return result
}
}
return nil
}
// GetVChannelsWithoutControlChannel returns the vchannels without control channel.
func (br *BroadcastResult[H, B]) GetVChannelsWithoutControlChannel() []string {
vchannels := make([]string, 0, len(br.Results))
for vchannel := range br.Results {
if !funcutil.IsControlChannel(vchannel) {
vchannels = append(vchannels, vchannel)
}
}
return vchannels
}
// AppendResult is the result of append operation.
type AppendResult struct {
MessageID MessageID
LastConfirmedMessageID MessageID
TimeTick uint64
}