mirror of
https://gitee.com/milvus-io/milvus.git
synced 2026-01-07 19:31:51 +08:00
issue: #44358 Implement complete snapshot management system including creation, deletion, listing, description, and restoration capabilities across all system components. Key features: - Create snapshots for entire collections - Drop snapshots by name with proper cleanup - List snapshots with collection filtering - Describe snapshot details and metadata Components added/modified: - Client SDK with full snapshot API support and options - DataCoord snapshot service with metadata management - Proxy layer with task-based snapshot operations - Protocol buffer definitions for snapshot RPCs - Comprehensive unit tests with mockey framework - Integration tests for end-to-end validation Technical implementation: - Snapshot metadata storage in etcd with proper indexing - File-based snapshot data persistence in object storage - Garbage collection integration for snapshot cleanup - Error handling and validation across all operations - Thread-safe operations with proper locking mechanisms <!-- This is an auto-generated comment: release notes by coderabbit.ai --> - Core invariant/assumption: snapshots are immutable point‑in‑time captures identified by (collection, snapshot name/ID); etcd snapshot metadata is authoritative for lifecycle (PENDING → COMMITTED → DELETING) and per‑segment manifests live in object storage (Avro / StorageV2). GC and restore logic must see snapshotRefIndex loaded (snapshotMeta.IsRefIndexLoaded) before reclaiming or relying on segment/index files. - New capability added: full end‑to‑end snapshot subsystem — client SDK APIs (Create/Drop/List/Describe/Restore + restore job queries), DataCoord SnapshotWriter/Reader (Avro + StorageV2 manifests), snapshotMeta in meta, SnapshotManager orchestration (create/drop/describe/list/restore), copy‑segment restore tasks/inspector/checker, proxy & RPC surface, GC integration, and docs/tests — enabling point‑in‑time collection snapshots persisted to object storage and restorations orchestrated across components. - Logic removed/simplified and why: duplicated recursive compaction/delta‑log traversal and ad‑hoc lookup code were consolidated behind two focused APIs/owners (Handler.GetDeltaLogFromCompactTo for delta traversal and SnapshotManager/SnapshotReader for snapshot I/O). MixCoord/coordinator broker paths were converted to thin RPC proxies. This eliminates multiple implementations of the same traversal/lookup, reducing divergence and simplifying responsibility boundaries. - Why this does NOT introduce data loss or regressions: snapshot create/drop use explicit two‑phase semantics (PENDING → COMMIT/DELETING) with SnapshotWriter writing manifests and metadata before commit; GC uses snapshotRefIndex guards and IsRefIndexLoaded/GetSnapshotBySegment/GetSnapshotByIndex checks to avoid removing referenced files; restore flow pre‑allocates job IDs, validates resources (partitions/indexes), performs rollback on failure (rollbackRestoreSnapshot), and converts/updates segment/index metadata only after successful copy tasks. Extensive unit and integration tests exercise pending/deleting/GC/restore/error paths to ensure idempotence and protection against premature deletion. <!-- end of auto-generated comment: release notes by coderabbit.ai --> --------- Signed-off-by: Wei Liu <wei.liu@zilliz.com>
737 lines
20 KiB
Go
737 lines
20 KiB
Go
// Licensed to the LF AI & Data foundation under one
|
|
// or more contributor license agreements. See the NOTICE file
|
|
// distributed with this work for additional information
|
|
// regarding copyright ownership. The ASF licenses this file
|
|
// to you under the Apache License, Version 2.0 (the
|
|
// "License"); you may not use this file except in compliance
|
|
// with the License. You may obtain a copy of the License at
|
|
//
|
|
// http://www.apache.org/licenses/LICENSE-2.0
|
|
//
|
|
// Unless required by applicable law or agreed to in writing, software
|
|
// distributed under the License is distributed on an "AS IS" BASIS,
|
|
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
// See the License for the specific language governing permissions and
|
|
// limitations under the License.
|
|
|
|
package proxy
|
|
|
|
import (
|
|
"context"
|
|
"time"
|
|
|
|
"go.uber.org/zap"
|
|
|
|
"github.com/milvus-io/milvus-proto/go-api/v2/commonpb"
|
|
"github.com/milvus-io/milvus-proto/go-api/v2/milvuspb"
|
|
"github.com/milvus-io/milvus/internal/types"
|
|
"github.com/milvus-io/milvus/pkg/v2/log"
|
|
"github.com/milvus-io/milvus/pkg/v2/proto/datapb"
|
|
"github.com/milvus-io/milvus/pkg/v2/util/commonpbutil"
|
|
"github.com/milvus-io/milvus/pkg/v2/util/merr"
|
|
"github.com/milvus-io/milvus/pkg/v2/util/paramtable"
|
|
)
|
|
|
|
const (
|
|
CreateSnapshotTaskName = "CreateSnapshotTask"
|
|
DropSnapshotTaskName = "DropSnapshotTask"
|
|
DescribeSnapshotTaskName = "DescribeSnapshotTask"
|
|
ListSnapshotsTaskName = "ListSnapshotsTask"
|
|
RestoreSnapshotTaskName = "RestoreSnapshotTask"
|
|
GetRestoreSnapshotStateTaskName = "GetRestoreSnapshotStateTask"
|
|
ListRestoreSnapshotJobsTaskName = "ListRestoreSnapshotJobsTask"
|
|
)
|
|
|
|
type createSnapshotTask struct {
|
|
baseTask
|
|
Condition
|
|
req *milvuspb.CreateSnapshotRequest
|
|
ctx context.Context
|
|
mixCoord types.MixCoordClient
|
|
result *commonpb.Status
|
|
|
|
collectionID UniqueID
|
|
}
|
|
|
|
func (cst *createSnapshotTask) TraceCtx() context.Context {
|
|
return cst.ctx
|
|
}
|
|
|
|
func (cst *createSnapshotTask) ID() UniqueID {
|
|
return cst.req.GetBase().GetMsgID()
|
|
}
|
|
|
|
func (cst *createSnapshotTask) SetID(uid UniqueID) {
|
|
cst.req.GetBase().MsgID = uid
|
|
}
|
|
|
|
func (cst *createSnapshotTask) Name() string {
|
|
return CreateSnapshotTaskName
|
|
}
|
|
|
|
func (cst *createSnapshotTask) Type() commonpb.MsgType {
|
|
return cst.req.GetBase().GetMsgType()
|
|
}
|
|
|
|
func (cst *createSnapshotTask) BeginTs() Timestamp {
|
|
return cst.req.GetBase().GetTimestamp()
|
|
}
|
|
|
|
func (cst *createSnapshotTask) EndTs() Timestamp {
|
|
return cst.req.GetBase().GetTimestamp()
|
|
}
|
|
|
|
func (cst *createSnapshotTask) SetTs(ts Timestamp) {
|
|
cst.req.Base.Timestamp = ts
|
|
}
|
|
|
|
func (cst *createSnapshotTask) OnEnqueue() error {
|
|
if cst.req.Base == nil {
|
|
cst.req.Base = commonpbutil.NewMsgBase()
|
|
}
|
|
cst.req.Base.MsgType = commonpb.MsgType_CreateSnapshot
|
|
cst.req.Base.SourceID = paramtable.GetNodeID()
|
|
return nil
|
|
}
|
|
|
|
func (cst *createSnapshotTask) PreExecute(ctx context.Context) error {
|
|
collectionID, err := globalMetaCache.GetCollectionID(ctx, cst.req.GetDbName(), cst.req.GetCollectionName())
|
|
if err != nil {
|
|
return err
|
|
}
|
|
cst.collectionID = collectionID
|
|
|
|
return nil
|
|
}
|
|
|
|
func (cst *createSnapshotTask) Execute(ctx context.Context) error {
|
|
log.Ctx(ctx).Info("proxy create snapshot",
|
|
zap.String("snapshotName", cst.req.GetName()),
|
|
zap.String("collectionName", cst.req.GetCollectionName()),
|
|
zap.Int64("collectionID", cst.collectionID),
|
|
)
|
|
|
|
var err error
|
|
cst.result, err = cst.mixCoord.CreateSnapshot(ctx, &datapb.CreateSnapshotRequest{
|
|
Base: commonpbutil.NewMsgBase(
|
|
commonpbutil.WithMsgType(commonpb.MsgType_CreateSnapshot),
|
|
),
|
|
Name: cst.req.GetName(),
|
|
Description: cst.req.GetDescription(),
|
|
CollectionId: cst.collectionID,
|
|
})
|
|
if err = merr.CheckRPCCall(cst.result, err); err != nil {
|
|
return err
|
|
}
|
|
return nil
|
|
}
|
|
|
|
func (cst *createSnapshotTask) PostExecute(ctx context.Context) error {
|
|
return nil
|
|
}
|
|
|
|
type dropSnapshotTask struct {
|
|
baseTask
|
|
Condition
|
|
req *milvuspb.DropSnapshotRequest
|
|
ctx context.Context
|
|
mixCoord types.MixCoordClient
|
|
result *commonpb.Status
|
|
}
|
|
|
|
func (dst *dropSnapshotTask) TraceCtx() context.Context {
|
|
return dst.ctx
|
|
}
|
|
|
|
func (dst *dropSnapshotTask) ID() UniqueID {
|
|
return dst.req.GetBase().GetMsgID()
|
|
}
|
|
|
|
func (dst *dropSnapshotTask) SetID(uid UniqueID) {
|
|
dst.req.GetBase().MsgID = uid
|
|
}
|
|
|
|
func (dst *dropSnapshotTask) Name() string {
|
|
return DropSnapshotTaskName
|
|
}
|
|
|
|
func (dst *dropSnapshotTask) Type() commonpb.MsgType {
|
|
return dst.req.GetBase().GetMsgType()
|
|
}
|
|
|
|
func (dst *dropSnapshotTask) BeginTs() Timestamp {
|
|
return dst.req.GetBase().GetTimestamp()
|
|
}
|
|
|
|
func (dst *dropSnapshotTask) EndTs() Timestamp {
|
|
return dst.req.GetBase().GetTimestamp()
|
|
}
|
|
|
|
func (dst *dropSnapshotTask) SetTs(ts Timestamp) {
|
|
dst.req.Base.Timestamp = ts
|
|
}
|
|
|
|
func (dst *dropSnapshotTask) OnEnqueue() error {
|
|
if dst.req.Base == nil {
|
|
dst.req.Base = commonpbutil.NewMsgBase()
|
|
}
|
|
dst.req.Base.MsgType = commonpb.MsgType_DropSnapshot
|
|
dst.req.Base.SourceID = paramtable.GetNodeID()
|
|
return nil
|
|
}
|
|
|
|
func (dst *dropSnapshotTask) PreExecute(ctx context.Context) error {
|
|
// No additional validation needed for drop snapshot
|
|
return nil
|
|
}
|
|
|
|
func (dst *dropSnapshotTask) Execute(ctx context.Context) error {
|
|
log.Ctx(ctx).Info("proxy drop snapshot",
|
|
zap.String("snapshotName", dst.req.GetName()),
|
|
)
|
|
|
|
var err error
|
|
dst.result, err = dst.mixCoord.DropSnapshot(ctx, &datapb.DropSnapshotRequest{
|
|
Base: commonpbutil.NewMsgBase(
|
|
commonpbutil.WithMsgType(commonpb.MsgType_DropSnapshot),
|
|
),
|
|
Name: dst.req.GetName(),
|
|
})
|
|
if err = merr.CheckRPCCall(dst.result, err); err != nil {
|
|
return err
|
|
}
|
|
return nil
|
|
}
|
|
|
|
func (dst *dropSnapshotTask) PostExecute(ctx context.Context) error {
|
|
return nil
|
|
}
|
|
|
|
type describeSnapshotTask struct {
|
|
baseTask
|
|
Condition
|
|
req *milvuspb.DescribeSnapshotRequest
|
|
ctx context.Context
|
|
mixCoord types.MixCoordClient
|
|
result *milvuspb.DescribeSnapshotResponse
|
|
}
|
|
|
|
func (dst *describeSnapshotTask) TraceCtx() context.Context {
|
|
return dst.ctx
|
|
}
|
|
|
|
func (dst *describeSnapshotTask) ID() UniqueID {
|
|
return dst.req.GetBase().GetMsgID()
|
|
}
|
|
|
|
func (dst *describeSnapshotTask) SetID(uid UniqueID) {
|
|
dst.req.GetBase().MsgID = uid
|
|
}
|
|
|
|
func (dst *describeSnapshotTask) Name() string {
|
|
return DescribeSnapshotTaskName
|
|
}
|
|
|
|
func (dst *describeSnapshotTask) Type() commonpb.MsgType {
|
|
return dst.req.GetBase().GetMsgType()
|
|
}
|
|
|
|
func (dst *describeSnapshotTask) BeginTs() Timestamp {
|
|
return dst.req.GetBase().GetTimestamp()
|
|
}
|
|
|
|
func (dst *describeSnapshotTask) EndTs() Timestamp {
|
|
return dst.req.GetBase().GetTimestamp()
|
|
}
|
|
|
|
func (dst *describeSnapshotTask) SetTs(ts Timestamp) {
|
|
dst.req.Base.Timestamp = ts
|
|
}
|
|
|
|
func (dst *describeSnapshotTask) OnEnqueue() error {
|
|
if dst.req.Base == nil {
|
|
dst.req.Base = commonpbutil.NewMsgBase()
|
|
}
|
|
dst.req.Base.MsgType = commonpb.MsgType_DescribeSnapshot
|
|
dst.req.Base.SourceID = paramtable.GetNodeID()
|
|
return nil
|
|
}
|
|
|
|
func (dst *describeSnapshotTask) PreExecute(ctx context.Context) error {
|
|
// No additional validation needed for describe snapshot
|
|
return nil
|
|
}
|
|
|
|
func (dst *describeSnapshotTask) Execute(ctx context.Context) error {
|
|
log.Ctx(ctx).Info("proxy describe snapshot",
|
|
zap.String("snapshotName", dst.req.GetName()),
|
|
)
|
|
|
|
result, err := dst.mixCoord.DescribeSnapshot(ctx, &datapb.DescribeSnapshotRequest{
|
|
Base: commonpbutil.NewMsgBase(
|
|
commonpbutil.WithMsgType(commonpb.MsgType_DescribeSnapshot),
|
|
),
|
|
Name: dst.req.GetName(),
|
|
IncludeCollectionInfo: false,
|
|
})
|
|
if err = merr.CheckRPCCall(result, err); err != nil {
|
|
dst.result = &milvuspb.DescribeSnapshotResponse{
|
|
Status: merr.Status(err),
|
|
}
|
|
return err
|
|
}
|
|
|
|
snapshotInfo := result.GetSnapshotInfo()
|
|
|
|
collectionName, err := globalMetaCache.GetCollectionName(ctx, "", snapshotInfo.GetCollectionId())
|
|
if err != nil {
|
|
log.Ctx(ctx).Warn("DescribeSnapshot fail to get collection name",
|
|
zap.Error(err))
|
|
return err
|
|
}
|
|
var partitionNames []string
|
|
for _, partitionID := range snapshotInfo.GetPartitionIds() {
|
|
partitionName, err := globalMetaCache.GetPartitionName(ctx, "", collectionName, partitionID)
|
|
if err != nil {
|
|
log.Ctx(ctx).Warn("DescribeSnapshot fail to get partition name",
|
|
zap.Error(err))
|
|
}
|
|
partitionNames = append(partitionNames, partitionName)
|
|
}
|
|
|
|
dst.result = &milvuspb.DescribeSnapshotResponse{
|
|
Status: result.GetStatus(),
|
|
Name: snapshotInfo.GetName(),
|
|
Description: snapshotInfo.GetDescription(),
|
|
CreateTs: snapshotInfo.GetCreateTs(),
|
|
CollectionName: collectionName,
|
|
PartitionNames: partitionNames,
|
|
S3Location: snapshotInfo.GetS3Location(),
|
|
}
|
|
|
|
return nil
|
|
}
|
|
|
|
func (dst *describeSnapshotTask) PostExecute(ctx context.Context) error {
|
|
return nil
|
|
}
|
|
|
|
type listSnapshotsTask struct {
|
|
baseTask
|
|
Condition
|
|
req *milvuspb.ListSnapshotsRequest
|
|
ctx context.Context
|
|
mixCoord types.MixCoordClient
|
|
result *milvuspb.ListSnapshotsResponse
|
|
|
|
collectionID UniqueID
|
|
}
|
|
|
|
func (lst *listSnapshotsTask) TraceCtx() context.Context {
|
|
return lst.ctx
|
|
}
|
|
|
|
func (lst *listSnapshotsTask) ID() UniqueID {
|
|
return lst.req.GetBase().GetMsgID()
|
|
}
|
|
|
|
func (lst *listSnapshotsTask) SetID(uid UniqueID) {
|
|
lst.req.GetBase().MsgID = uid
|
|
}
|
|
|
|
func (lst *listSnapshotsTask) Name() string {
|
|
return ListSnapshotsTaskName
|
|
}
|
|
|
|
func (lst *listSnapshotsTask) Type() commonpb.MsgType {
|
|
return lst.req.GetBase().GetMsgType()
|
|
}
|
|
|
|
func (lst *listSnapshotsTask) BeginTs() Timestamp {
|
|
return lst.req.GetBase().GetTimestamp()
|
|
}
|
|
|
|
func (lst *listSnapshotsTask) EndTs() Timestamp {
|
|
return lst.req.GetBase().GetTimestamp()
|
|
}
|
|
|
|
func (lst *listSnapshotsTask) SetTs(ts Timestamp) {
|
|
lst.req.Base.Timestamp = ts
|
|
}
|
|
|
|
func (lst *listSnapshotsTask) OnEnqueue() error {
|
|
if lst.req.Base == nil {
|
|
lst.req.Base = commonpbutil.NewMsgBase()
|
|
}
|
|
lst.req.Base.MsgType = commonpb.MsgType_ListSnapshots
|
|
lst.req.Base.SourceID = paramtable.GetNodeID()
|
|
return nil
|
|
}
|
|
|
|
func (lst *listSnapshotsTask) PreExecute(ctx context.Context) error {
|
|
collectionID, err := globalMetaCache.GetCollectionID(ctx, lst.req.GetDbName(), lst.req.GetCollectionName())
|
|
if err != nil {
|
|
return err
|
|
}
|
|
lst.collectionID = collectionID
|
|
|
|
return nil
|
|
}
|
|
|
|
func (lst *listSnapshotsTask) Execute(ctx context.Context) error {
|
|
log.Ctx(ctx).Info("proxy list snapshots",
|
|
zap.String("collectionName", lst.req.GetCollectionName()),
|
|
zap.Int64("collectionID", lst.collectionID),
|
|
)
|
|
|
|
result, err := lst.mixCoord.ListSnapshots(ctx, &datapb.ListSnapshotsRequest{
|
|
Base: commonpbutil.NewMsgBase(
|
|
commonpbutil.WithMsgType(commonpb.MsgType_ListSnapshots),
|
|
),
|
|
CollectionId: lst.collectionID,
|
|
})
|
|
if err = merr.CheckRPCCall(result, err); err != nil {
|
|
lst.result = &milvuspb.ListSnapshotsResponse{
|
|
Status: merr.Status(err),
|
|
}
|
|
return err
|
|
}
|
|
|
|
lst.result = &milvuspb.ListSnapshotsResponse{
|
|
Status: result.GetStatus(),
|
|
Snapshots: result.GetSnapshots(),
|
|
}
|
|
|
|
return nil
|
|
}
|
|
|
|
func (lst *listSnapshotsTask) PostExecute(ctx context.Context) error {
|
|
return nil
|
|
}
|
|
|
|
type restoreSnapshotTask struct {
|
|
baseTask
|
|
Condition
|
|
req *milvuspb.RestoreSnapshotRequest
|
|
ctx context.Context
|
|
mixCoord types.MixCoordClient
|
|
result *milvuspb.RestoreSnapshotResponse
|
|
}
|
|
|
|
func (rst *restoreSnapshotTask) TraceCtx() context.Context {
|
|
return rst.ctx
|
|
}
|
|
|
|
func (rst *restoreSnapshotTask) ID() UniqueID {
|
|
return rst.req.GetBase().GetMsgID()
|
|
}
|
|
|
|
func (rst *restoreSnapshotTask) SetID(uid UniqueID) {
|
|
rst.req.GetBase().MsgID = uid
|
|
}
|
|
|
|
func (rst *restoreSnapshotTask) Name() string {
|
|
return RestoreSnapshotTaskName
|
|
}
|
|
|
|
func (rst *restoreSnapshotTask) Type() commonpb.MsgType {
|
|
return rst.req.GetBase().GetMsgType()
|
|
}
|
|
|
|
func (rst *restoreSnapshotTask) BeginTs() Timestamp {
|
|
return rst.req.GetBase().GetTimestamp()
|
|
}
|
|
|
|
func (rst *restoreSnapshotTask) EndTs() Timestamp {
|
|
return rst.req.GetBase().GetTimestamp()
|
|
}
|
|
|
|
func (rst *restoreSnapshotTask) SetTs(ts Timestamp) {
|
|
rst.req.Base.Timestamp = ts
|
|
}
|
|
|
|
func (rst *restoreSnapshotTask) OnEnqueue() error {
|
|
if rst.req.Base == nil {
|
|
rst.req.Base = commonpbutil.NewMsgBase()
|
|
}
|
|
rst.req.Base.MsgType = commonpb.MsgType_RestoreSnapshot
|
|
rst.req.Base.SourceID = paramtable.GetNodeID()
|
|
return nil
|
|
}
|
|
|
|
func (rst *restoreSnapshotTask) PreExecute(ctx context.Context) error {
|
|
// No additional validation needed for restore snapshot pre-execute
|
|
return nil
|
|
}
|
|
|
|
func (rst *restoreSnapshotTask) Execute(ctx context.Context) error {
|
|
log.Ctx(ctx).Info("proxy restore snapshot",
|
|
zap.String("snapshotName", rst.req.GetName()),
|
|
zap.String("collectionName", rst.req.GetCollectionName()),
|
|
zap.String("dbName", rst.req.GetDbName()),
|
|
)
|
|
|
|
// Delegate directly to DataCoord which handles the entire restore process
|
|
resp, err := rst.mixCoord.RestoreSnapshot(ctx, &datapb.RestoreSnapshotRequest{
|
|
Base: commonpbutil.NewMsgBase(
|
|
commonpbutil.WithMsgType(commonpb.MsgType_RestoreSnapshot),
|
|
),
|
|
Name: rst.req.GetName(),
|
|
DbName: rst.req.GetDbName(),
|
|
CollectionName: rst.req.GetCollectionName(),
|
|
})
|
|
if err != nil {
|
|
log.Ctx(ctx).Warn("RestoreSnapshot failed",
|
|
zap.Error(err))
|
|
rst.result = &milvuspb.RestoreSnapshotResponse{Status: merr.Status(err)}
|
|
return err
|
|
}
|
|
if err := merr.CheckRPCCall(resp, err); err != nil {
|
|
rst.result = &milvuspb.RestoreSnapshotResponse{Status: resp.GetStatus()}
|
|
return err
|
|
}
|
|
rst.result = &milvuspb.RestoreSnapshotResponse{
|
|
Status: merr.Success(),
|
|
JobId: resp.GetJobId(),
|
|
}
|
|
return nil
|
|
}
|
|
|
|
func (rst *restoreSnapshotTask) PostExecute(ctx context.Context) error {
|
|
return nil
|
|
}
|
|
|
|
type getRestoreSnapshotStateTask struct {
|
|
baseTask
|
|
Condition
|
|
req *milvuspb.GetRestoreSnapshotStateRequest
|
|
ctx context.Context
|
|
mixCoord types.MixCoordClient
|
|
result *milvuspb.GetRestoreSnapshotStateResponse
|
|
}
|
|
|
|
func (grst *getRestoreSnapshotStateTask) TraceCtx() context.Context {
|
|
return grst.ctx
|
|
}
|
|
|
|
func (grst *getRestoreSnapshotStateTask) ID() UniqueID {
|
|
return grst.req.GetBase().GetMsgID()
|
|
}
|
|
|
|
func (grst *getRestoreSnapshotStateTask) SetID(uid UniqueID) {
|
|
grst.req.GetBase().MsgID = uid
|
|
}
|
|
|
|
func (grst *getRestoreSnapshotStateTask) Name() string {
|
|
return GetRestoreSnapshotStateTaskName
|
|
}
|
|
|
|
func (grst *getRestoreSnapshotStateTask) Type() commonpb.MsgType {
|
|
return grst.req.GetBase().GetMsgType()
|
|
}
|
|
|
|
func (grst *getRestoreSnapshotStateTask) BeginTs() Timestamp {
|
|
return grst.req.GetBase().GetTimestamp()
|
|
}
|
|
|
|
func (grst *getRestoreSnapshotStateTask) EndTs() Timestamp {
|
|
return grst.req.GetBase().GetTimestamp()
|
|
}
|
|
|
|
func (grst *getRestoreSnapshotStateTask) SetTs(ts Timestamp) {
|
|
grst.req.Base.Timestamp = ts
|
|
}
|
|
|
|
func (grst *getRestoreSnapshotStateTask) OnEnqueue() error {
|
|
if grst.req.Base == nil {
|
|
grst.req.Base = commonpbutil.NewMsgBase()
|
|
}
|
|
grst.req.Base.MsgType = commonpb.MsgType_GetRestoreSnapshotState
|
|
grst.req.Base.SourceID = paramtable.GetNodeID()
|
|
return nil
|
|
}
|
|
|
|
func (grst *getRestoreSnapshotStateTask) PreExecute(ctx context.Context) error {
|
|
// No additional validation needed for get restore snapshot state
|
|
return nil
|
|
}
|
|
|
|
func (grst *getRestoreSnapshotStateTask) Execute(ctx context.Context) error {
|
|
log.Ctx(ctx).Info("proxy get restore snapshot state",
|
|
zap.Int64("jobID", grst.req.GetJobId()),
|
|
)
|
|
|
|
result, err := grst.mixCoord.GetRestoreSnapshotState(ctx, &datapb.GetRestoreSnapshotStateRequest{
|
|
Base: commonpbutil.NewMsgBase(
|
|
commonpbutil.WithMsgType(commonpb.MsgType_Undefined),
|
|
),
|
|
JobId: grst.req.GetJobId(),
|
|
})
|
|
if err = merr.CheckRPCCall(result, err); err != nil {
|
|
grst.result = &milvuspb.GetRestoreSnapshotStateResponse{
|
|
Status: merr.Status(err),
|
|
}
|
|
return err
|
|
}
|
|
|
|
// Convert datapb.RestoreSnapshotInfo to milvuspb.RestoreSnapshotInfo
|
|
info := result.GetInfo()
|
|
var milvusInfo *milvuspb.RestoreSnapshotInfo
|
|
if info != nil {
|
|
collectionName := ""
|
|
dbName := ""
|
|
if info.GetCollectionId() != 0 {
|
|
var err error
|
|
collectionName, err = globalMetaCache.GetCollectionName(ctx, "", info.GetCollectionId())
|
|
if err != nil {
|
|
log.Ctx(ctx).Warn("GetRestoreSnapshotState fail to get collection name",
|
|
zap.Error(err))
|
|
}
|
|
}
|
|
|
|
milvusInfo = &milvuspb.RestoreSnapshotInfo{
|
|
JobId: info.GetJobId(),
|
|
SnapshotName: info.GetSnapshotName(),
|
|
DbName: dbName,
|
|
CollectionName: collectionName,
|
|
State: milvuspb.RestoreSnapshotState(info.GetState()),
|
|
Progress: info.GetProgress(),
|
|
Reason: info.GetReason(),
|
|
StartTime: 0, // datapb doesn't have start_time
|
|
TimeCost: info.GetTimeCost(),
|
|
}
|
|
}
|
|
|
|
grst.result = &milvuspb.GetRestoreSnapshotStateResponse{
|
|
Status: result.GetStatus(),
|
|
Info: milvusInfo,
|
|
}
|
|
|
|
return nil
|
|
}
|
|
|
|
func (grst *getRestoreSnapshotStateTask) PostExecute(ctx context.Context) error {
|
|
return nil
|
|
}
|
|
|
|
type listRestoreSnapshotJobsTask struct {
|
|
baseTask
|
|
Condition
|
|
req *milvuspb.ListRestoreSnapshotJobsRequest
|
|
ctx context.Context
|
|
mixCoord types.MixCoordClient
|
|
result *milvuspb.ListRestoreSnapshotJobsResponse
|
|
|
|
collectionID UniqueID
|
|
}
|
|
|
|
func (lrst *listRestoreSnapshotJobsTask) TraceCtx() context.Context {
|
|
return lrst.ctx
|
|
}
|
|
|
|
func (lrst *listRestoreSnapshotJobsTask) ID() UniqueID {
|
|
return lrst.req.GetBase().GetMsgID()
|
|
}
|
|
|
|
func (lrst *listRestoreSnapshotJobsTask) SetID(uid UniqueID) {
|
|
lrst.req.GetBase().MsgID = uid
|
|
}
|
|
|
|
func (lrst *listRestoreSnapshotJobsTask) Name() string {
|
|
return ListRestoreSnapshotJobsTaskName
|
|
}
|
|
|
|
func (lrst *listRestoreSnapshotJobsTask) Type() commonpb.MsgType {
|
|
return lrst.req.GetBase().GetMsgType()
|
|
}
|
|
|
|
func (lrst *listRestoreSnapshotJobsTask) BeginTs() Timestamp {
|
|
return lrst.req.GetBase().GetTimestamp()
|
|
}
|
|
|
|
func (lrst *listRestoreSnapshotJobsTask) EndTs() Timestamp {
|
|
return lrst.req.GetBase().GetTimestamp()
|
|
}
|
|
|
|
func (lrst *listRestoreSnapshotJobsTask) SetTs(ts Timestamp) {
|
|
lrst.req.Base.Timestamp = ts
|
|
}
|
|
|
|
func (lrst *listRestoreSnapshotJobsTask) OnEnqueue() error {
|
|
if lrst.req.Base == nil {
|
|
lrst.req.Base = commonpbutil.NewMsgBase()
|
|
}
|
|
lrst.req.Base.MsgType = commonpb.MsgType_ListRestoreSnapshotJobs
|
|
lrst.req.Base.SourceID = paramtable.GetNodeID()
|
|
return nil
|
|
}
|
|
|
|
func (lrst *listRestoreSnapshotJobsTask) PreExecute(ctx context.Context) error {
|
|
if lrst.req.GetCollectionName() != "" {
|
|
collectionID, err := globalMetaCache.GetCollectionID(ctx, lrst.req.GetDbName(), lrst.req.GetCollectionName())
|
|
if err != nil {
|
|
return err
|
|
}
|
|
lrst.collectionID = collectionID
|
|
}
|
|
return nil
|
|
}
|
|
|
|
func (lrst *listRestoreSnapshotJobsTask) Execute(ctx context.Context) error {
|
|
log.Ctx(ctx).Info("proxy list restore snapshot jobs",
|
|
zap.String("collectionName", lrst.req.GetCollectionName()),
|
|
zap.Int64("collectionID", lrst.collectionID),
|
|
)
|
|
|
|
result, err := lrst.mixCoord.ListRestoreSnapshotJobs(ctx, &datapb.ListRestoreSnapshotJobsRequest{
|
|
Base: commonpbutil.NewMsgBase(
|
|
commonpbutil.WithMsgType(commonpb.MsgType_Undefined),
|
|
),
|
|
CollectionId: lrst.collectionID,
|
|
})
|
|
if err = merr.CheckRPCCall(result, err); err != nil {
|
|
lrst.result = &milvuspb.ListRestoreSnapshotJobsResponse{
|
|
Status: merr.Status(err),
|
|
}
|
|
return err
|
|
}
|
|
|
|
// Convert datapb.RestoreSnapshotInfo to milvuspb.RestoreSnapshotInfo
|
|
jobs := result.GetJobs()
|
|
milvusJobs := make([]*milvuspb.RestoreSnapshotInfo, 0, len(jobs))
|
|
for _, job := range jobs {
|
|
collectionName := ""
|
|
if job.GetCollectionId() != 0 {
|
|
var err error
|
|
collectionName, err = globalMetaCache.GetCollectionName(ctx, "", job.GetCollectionId())
|
|
if err != nil {
|
|
log.Ctx(ctx).Warn("ListRestoreSnapshotJobs fail to get collection name",
|
|
zap.Error(err))
|
|
}
|
|
}
|
|
|
|
milvusJobs = append(milvusJobs, &milvuspb.RestoreSnapshotInfo{
|
|
JobId: job.GetJobId(),
|
|
SnapshotName: job.GetSnapshotName(),
|
|
DbName: lrst.req.GetDbName(),
|
|
CollectionName: collectionName,
|
|
State: milvuspb.RestoreSnapshotState(job.GetState()),
|
|
Progress: job.GetProgress(),
|
|
Reason: job.GetReason(),
|
|
StartTime: uint64(time.Now().UnixNano() - int64(job.GetTimeCost())),
|
|
TimeCost: job.GetTimeCost(),
|
|
})
|
|
}
|
|
|
|
lrst.result = &milvuspb.ListRestoreSnapshotJobsResponse{
|
|
Status: result.GetStatus(),
|
|
Jobs: milvusJobs,
|
|
}
|
|
|
|
return nil
|
|
}
|
|
|
|
func (lrst *listRestoreSnapshotJobsTask) PostExecute(ctx context.Context) error {
|
|
return nil
|
|
}
|