mirror of
https://gitee.com/milvus-io/milvus.git
synced 2026-01-07 19:31:51 +08:00
issue: https://github.com/milvus-io/milvus/issues/44123 <!-- This is an auto-generated comment: release notes by coderabbit.ai --> - Core invariant: legacy in-cluster CDC/replication plumbing (ReplicateMsg types, ReplicateID-based guards and flags) is obsolete — the system relies on standard msgstream positions, subPos/end-ts semantics and timetick ordering as the single source of truth for message ordering and skipping, so replication-specific channels/types/guards can be removed safely. - Removed/simplified logic (what and why): removed replication feature flags and params (ReplicateMsgChannel, TTMsgEnabled, CollectionReplicateEnable), ReplicateMsg type and its tests, ReplicateID constants/helpers and MergeProperties hooks, ReplicateConfig and its propagation (streamPipeline, StreamConfig, dispatcher, target), replicate-aware dispatcher/pipeline branches, and replicate-mode pre-checks/timestamp-allocation in proxy tasks — these implemented a redundant alternate “replicate-mode” pathway that duplicated position/end-ts and timetick logic. - Why this does NOT cause data loss or regression (concrete code paths): no persistence or core write paths were removed — proxy PreExecute flows (internal/proxy/task_*.go) still perform the same schema/ID/size validations and then follow the normal non-replicate execution path; dispatcher and pipeline continue to use position/subPos and pullback/end-ts in Seek/grouping (pkg/mq/msgdispatcher/dispatcher.go, internal/util/pipeline/stream_pipeline.go), so skipping and ordering behavior remains unchanged; timetick emission in rootcoord (sendMinDdlTsAsTt) is now ungated (no silent suppression), preserving or increasing timetick delivery rather than removing it. - PR type and net effect: Enhancement/Refactor — removes deprecated replication API surface (types, helpers, config, tests) and replication branches, simplifies public APIs and constructor signatures, and reduces surface area for future maintenance while keeping DML/DDL persistence, ordering, and seek semantics intact. <!-- end of auto-generated comment: release notes by coderabbit.ai --> --------- Signed-off-by: bigsheeper <yihao.dai@zilliz.com>
222 lines
5.7 KiB
Go
222 lines
5.7 KiB
Go
package proxy
|
|
|
|
import (
|
|
"context"
|
|
"strings"
|
|
"testing"
|
|
|
|
"github.com/stretchr/testify/assert"
|
|
"github.com/stretchr/testify/mock"
|
|
"google.golang.org/grpc/metadata"
|
|
|
|
"github.com/milvus-io/milvus-proto/go-api/v2/commonpb"
|
|
"github.com/milvus-io/milvus-proto/go-api/v2/milvuspb"
|
|
"github.com/milvus-io/milvus/internal/mocks"
|
|
"github.com/milvus-io/milvus/pkg/v2/common"
|
|
"github.com/milvus-io/milvus/pkg/v2/proto/rootcoordpb"
|
|
"github.com/milvus-io/milvus/pkg/v2/util"
|
|
"github.com/milvus-io/milvus/pkg/v2/util/crypto"
|
|
"github.com/milvus-io/milvus/pkg/v2/util/merr"
|
|
"github.com/milvus-io/milvus/pkg/v2/util/paramtable"
|
|
)
|
|
|
|
func TestCreateDatabaseTask(t *testing.T) {
|
|
paramtable.Init()
|
|
rc := NewMixCoordMock()
|
|
defer rc.Close()
|
|
|
|
ctx := context.Background()
|
|
task := &createDatabaseTask{
|
|
Condition: NewTaskCondition(ctx),
|
|
CreateDatabaseRequest: &milvuspb.CreateDatabaseRequest{
|
|
Base: &commonpb.MsgBase{
|
|
MsgType: commonpb.MsgType_CreateDatabase,
|
|
MsgID: 100,
|
|
Timestamp: 100,
|
|
},
|
|
DbName: "db",
|
|
},
|
|
ctx: ctx,
|
|
mixCoord: rc,
|
|
result: nil,
|
|
}
|
|
|
|
t.Run("ok", func(t *testing.T) {
|
|
err := task.PreExecute(ctx)
|
|
assert.NoError(t, err)
|
|
|
|
assert.Equal(t, commonpb.MsgType_CreateDatabase, task.Type())
|
|
assert.Equal(t, UniqueID(100), task.ID())
|
|
assert.Equal(t, Timestamp(100), task.BeginTs())
|
|
assert.Equal(t, Timestamp(100), task.EndTs())
|
|
assert.Equal(t, "db", task.GetDbName())
|
|
err = task.Execute(ctx)
|
|
assert.NoError(t, err)
|
|
|
|
task.Base = nil
|
|
err = task.OnEnqueue()
|
|
assert.NoError(t, err)
|
|
assert.Equal(t, paramtable.GetNodeID(), task.GetBase().GetSourceID())
|
|
assert.Equal(t, UniqueID(0), task.ID())
|
|
})
|
|
|
|
t.Run("pre execute fail", func(t *testing.T) {
|
|
task.DbName = "#0xc0de"
|
|
err := task.PreExecute(ctx)
|
|
assert.Error(t, err)
|
|
})
|
|
}
|
|
|
|
func TestDropDatabaseTask(t *testing.T) {
|
|
paramtable.Init()
|
|
rc := NewMixCoordMock()
|
|
defer rc.Close()
|
|
|
|
ctx := context.Background()
|
|
task := &dropDatabaseTask{
|
|
Condition: NewTaskCondition(ctx),
|
|
DropDatabaseRequest: &milvuspb.DropDatabaseRequest{
|
|
Base: &commonpb.MsgBase{
|
|
MsgType: commonpb.MsgType_DropDatabase,
|
|
MsgID: 100,
|
|
Timestamp: 100,
|
|
},
|
|
DbName: "db",
|
|
},
|
|
ctx: ctx,
|
|
mixCoord: rc,
|
|
result: nil,
|
|
}
|
|
|
|
cache := NewMockCache(t)
|
|
cache.On("RemoveDatabase",
|
|
mock.Anything, // context.Context
|
|
mock.AnythingOfType("string"),
|
|
).Maybe()
|
|
globalMetaCache = cache
|
|
|
|
t.Run("ok", func(t *testing.T) {
|
|
err := task.PreExecute(ctx)
|
|
assert.NoError(t, err)
|
|
|
|
assert.Equal(t, commonpb.MsgType_DropDatabase, task.Type())
|
|
assert.Equal(t, UniqueID(100), task.ID())
|
|
assert.Equal(t, Timestamp(100), task.BeginTs())
|
|
assert.Equal(t, Timestamp(100), task.EndTs())
|
|
assert.Equal(t, "db", task.GetDbName())
|
|
err = task.Execute(ctx)
|
|
assert.NoError(t, err)
|
|
|
|
task.Base = nil
|
|
err = task.OnEnqueue()
|
|
assert.NoError(t, err)
|
|
assert.Equal(t, paramtable.GetNodeID(), task.GetBase().GetSourceID())
|
|
assert.Equal(t, UniqueID(0), task.ID())
|
|
})
|
|
|
|
t.Run("pre execute fail", func(t *testing.T) {
|
|
task.DbName = "#0xc0de"
|
|
err := task.PreExecute(ctx)
|
|
assert.Error(t, err)
|
|
})
|
|
}
|
|
|
|
func TestListDatabaseTask(t *testing.T) {
|
|
paramtable.Init()
|
|
rc := NewMixCoordMock()
|
|
defer rc.Close()
|
|
|
|
ctx := GetContext(context.Background(), "root:123456")
|
|
task := &listDatabaseTask{
|
|
Condition: NewTaskCondition(ctx),
|
|
ListDatabasesRequest: &milvuspb.ListDatabasesRequest{
|
|
Base: &commonpb.MsgBase{
|
|
MsgType: commonpb.MsgType_ListDatabases,
|
|
MsgID: 100,
|
|
Timestamp: 100,
|
|
},
|
|
},
|
|
ctx: ctx,
|
|
mixCoord: rc,
|
|
result: nil,
|
|
}
|
|
|
|
t.Run("ok", func(t *testing.T) {
|
|
err := task.PreExecute(ctx)
|
|
assert.NoError(t, err)
|
|
|
|
assert.Equal(t, commonpb.MsgType_ListDatabases, task.Type())
|
|
assert.Equal(t, UniqueID(100), task.ID())
|
|
assert.Equal(t, Timestamp(100), task.BeginTs())
|
|
assert.Equal(t, Timestamp(100), task.EndTs())
|
|
err = task.Execute(ctx)
|
|
assert.NoError(t, err)
|
|
assert.NotNil(t, task.result)
|
|
|
|
err = task.OnEnqueue()
|
|
assert.NoError(t, err)
|
|
assert.Equal(t, paramtable.GetNodeID(), task.GetBase().GetSourceID())
|
|
assert.Equal(t, UniqueID(0), task.ID())
|
|
|
|
taskCtx := AppendUserInfoForRPC(ctx)
|
|
md, ok := metadata.FromOutgoingContext(taskCtx)
|
|
assert.True(t, ok)
|
|
authorization, ok := md[strings.ToLower(util.HeaderAuthorize)]
|
|
assert.True(t, ok)
|
|
expectAuth := crypto.Base64Encode("root:root")
|
|
assert.Equal(t, expectAuth, authorization[0])
|
|
})
|
|
}
|
|
|
|
func TestAlterDatabase(t *testing.T) {
|
|
rc := mocks.NewMockMixCoordClient(t)
|
|
|
|
rc.EXPECT().AlterDatabase(mock.Anything, mock.Anything).Return(merr.Success(), nil)
|
|
task := &alterDatabaseTask{
|
|
AlterDatabaseRequest: &milvuspb.AlterDatabaseRequest{
|
|
Base: &commonpb.MsgBase{},
|
|
DbName: "test_alter_database",
|
|
Properties: []*commonpb.KeyValuePair{{Key: common.MmapEnabledKey, Value: "true"}},
|
|
},
|
|
mixCoord: rc,
|
|
}
|
|
err := task.PreExecute(context.Background())
|
|
assert.Nil(t, err)
|
|
|
|
err = task.Execute(context.Background())
|
|
assert.Nil(t, err)
|
|
|
|
task1 := &alterDatabaseTask{
|
|
AlterDatabaseRequest: &milvuspb.AlterDatabaseRequest{
|
|
Base: &commonpb.MsgBase{},
|
|
DbName: "test_alter_database",
|
|
DeleteKeys: []string{common.MmapEnabledKey},
|
|
},
|
|
mixCoord: rc,
|
|
}
|
|
err1 := task1.PreExecute(context.Background())
|
|
assert.Nil(t, err1)
|
|
|
|
err1 = task1.Execute(context.Background())
|
|
assert.Nil(t, err1)
|
|
}
|
|
|
|
func TestDescribeDatabaseTask(t *testing.T) {
|
|
rc := mocks.NewMockMixCoordClient(t)
|
|
|
|
rc.EXPECT().DescribeDatabase(mock.Anything, mock.Anything).Return(&rootcoordpb.DescribeDatabaseResponse{}, nil)
|
|
task := &describeDatabaseTask{
|
|
DescribeDatabaseRequest: &milvuspb.DescribeDatabaseRequest{
|
|
Base: &commonpb.MsgBase{},
|
|
DbName: "test_describe_database",
|
|
},
|
|
mixCoord: rc,
|
|
}
|
|
|
|
err := task.PreExecute(context.Background())
|
|
assert.Nil(t, err)
|
|
|
|
err = task.Execute(context.Background())
|
|
assert.Nil(t, err)
|
|
}
|