mirror of
https://gitee.com/milvus-io/milvus.git
synced 2026-01-07 19:31:51 +08:00
issue: #46635 ## Summary - Fix spelling error in constant name: `CredentialSeperator` -> `CredentialSeparator` - Updated all usages across the codebase to use the correct spelling ## Changes - `pkg/util/constant.go`: Renamed the constant - `pkg/util/contextutil/context_util.go`: Updated usage - `pkg/util/contextutil/context_util_test.go`: Updated usage - `internal/proxy/authentication_interceptor.go`: Updated usage - `internal/proxy/util.go`: Updated usage - `internal/proxy/util_test.go`: Updated usage - `internal/proxy/trace_log_interceptor_test.go`: Updated usage - `internal/proxy/accesslog/info/util.go`: Updated usage - `internal/distributed/proxy/service.go`: Updated usage - `internal/distributed/proxy/httpserver/utils.go`: Updated usage ## Test Plan - [x] All references updated consistently - [x] No functional changes - only constant name spelling correction <!-- This is an auto-generated comment: release notes by coderabbit.ai --> - Core invariant: the separator character for credentials remains ":" everywhere — only the exported identifier was renamed from CredentialSeperator → CredentialSeparator; the constant value and split/join semantics are unchanged. - Change (bug fix): corrected the misspelled exported constant in pkg/util/constant.go and updated all references across the codebase (parsing, token construction, header handling and tests) to use the new identifier; this is an identifier rename that removes an inconsistent symbol and prevents compile-time/reference errors. - Logic simplified/redundant work removed: no runtime logic was removed; the simplification is purely maintenance-focused — eliminating a misspelled exported name that could cause developers to introduce duplicate or incorrect constants. - No data loss or behavior regression: runtime code paths are unchanged — e.g., GetAuthInfoFromContext, ParseUsernamePassword, AuthenticationInterceptor, proxy service token construction and access-log extraction still use ":" to split/join credentials; updated and added unit tests (parsing and metadata extraction) exercise these paths and validate identical semantics. <!-- end of auto-generated comment: release notes by coderabbit.ai --> --------- Signed-off-by: majiayu000 <1835304752@qq.com> Signed-off-by: lif <1835304752@qq.com> Co-authored-by: Claude Opus 4.5 <noreply@anthropic.com>
210 lines
5.5 KiB
Go
210 lines
5.5 KiB
Go
// Licensed to the LF AI & Data foundation under one
|
|
// or more contributor license agreements. See the NOTICE file
|
|
// distributed with this work for additional information
|
|
// regarding copyright ownership. The ASF licenses this file
|
|
// to you under the Apache License, Version 2.0 (the
|
|
// "License"); you may not use this file except in compliance
|
|
// with the License. You may obtain a copy of the License at
|
|
//
|
|
// http://www.apache.org/licenses/LICENSE-2.0
|
|
//
|
|
// Unless required by applicable law or agreed to in writing, software
|
|
// distributed under the License is distributed on an "AS IS" BASIS,
|
|
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
// See the License for the specific language governing permissions and
|
|
// limitations under the License.
|
|
|
|
package info
|
|
|
|
import (
|
|
"context"
|
|
"strings"
|
|
"testing"
|
|
|
|
"github.com/stretchr/testify/assert"
|
|
"google.golang.org/grpc/metadata"
|
|
|
|
"github.com/milvus-io/milvus-proto/go-api/v2/schemapb"
|
|
"github.com/milvus-io/milvus/pkg/v2/util"
|
|
"github.com/milvus-io/milvus/pkg/v2/util/crypto"
|
|
)
|
|
|
|
func TestGetSdkTypeByUserAgent(t *testing.T) {
|
|
_, ok := getSdkTypeByUserAgent([]string{})
|
|
assert.False(t, ok)
|
|
|
|
sdk, ok := getSdkTypeByUserAgent([]string{"grpc-node-js.test"})
|
|
assert.True(t, ok)
|
|
assert.Equal(t, "nodejs", sdk)
|
|
|
|
sdk, ok = getSdkTypeByUserAgent([]string{"grpc-python.test"})
|
|
assert.True(t, ok)
|
|
assert.Equal(t, "Python", sdk)
|
|
|
|
sdk, ok = getSdkTypeByUserAgent([]string{"grpc-go.test"})
|
|
assert.True(t, ok)
|
|
assert.Equal(t, "Golang", sdk)
|
|
|
|
sdk, ok = getSdkTypeByUserAgent([]string{"grpc-java.test"})
|
|
assert.True(t, ok)
|
|
assert.Equal(t, "Java", sdk)
|
|
|
|
_, ok = getSdkTypeByUserAgent([]string{"invalid_type"})
|
|
assert.False(t, ok)
|
|
}
|
|
|
|
func TestGetLengthFromTemplateValue(t *testing.T) {
|
|
t.Run("bool_array", func(t *testing.T) {
|
|
tv := &schemapb.TemplateValue{
|
|
Val: &schemapb.TemplateValue_ArrayVal{
|
|
ArrayVal: &schemapb.TemplateArrayValue{
|
|
Data: &schemapb.TemplateArrayValue_BoolData{
|
|
BoolData: &schemapb.BoolArray{
|
|
Data: []bool{true, false},
|
|
},
|
|
},
|
|
},
|
|
},
|
|
}
|
|
|
|
assert.Equal(t, 2, getLengthFromTemplateValue(tv))
|
|
})
|
|
|
|
t.Run("string_array", func(t *testing.T) {
|
|
tv := &schemapb.TemplateValue{
|
|
Val: &schemapb.TemplateValue_ArrayVal{
|
|
ArrayVal: &schemapb.TemplateArrayValue{
|
|
Data: &schemapb.TemplateArrayValue_StringData{
|
|
StringData: &schemapb.StringArray{
|
|
Data: []string{"foo", "bar"},
|
|
},
|
|
},
|
|
},
|
|
},
|
|
}
|
|
|
|
assert.Equal(t, 2, getLengthFromTemplateValue(tv))
|
|
})
|
|
|
|
t.Run("long_array", func(t *testing.T) {
|
|
tv := &schemapb.TemplateValue{
|
|
Val: &schemapb.TemplateValue_ArrayVal{
|
|
ArrayVal: &schemapb.TemplateArrayValue{
|
|
Data: &schemapb.TemplateArrayValue_LongData{
|
|
LongData: &schemapb.LongArray{
|
|
Data: []int64{0, 1},
|
|
},
|
|
},
|
|
},
|
|
},
|
|
}
|
|
|
|
assert.Equal(t, 2, getLengthFromTemplateValue(tv))
|
|
})
|
|
|
|
t.Run("double_array", func(t *testing.T) {
|
|
tv := &schemapb.TemplateValue{
|
|
Val: &schemapb.TemplateValue_ArrayVal{
|
|
ArrayVal: &schemapb.TemplateArrayValue{
|
|
Data: &schemapb.TemplateArrayValue_DoubleData{
|
|
DoubleData: &schemapb.DoubleArray{
|
|
Data: []float64{0, 1},
|
|
},
|
|
},
|
|
},
|
|
},
|
|
}
|
|
|
|
assert.Equal(t, 2, getLengthFromTemplateValue(tv))
|
|
})
|
|
|
|
t.Run("json_array", func(t *testing.T) {
|
|
tv := &schemapb.TemplateValue{
|
|
Val: &schemapb.TemplateValue_ArrayVal{
|
|
ArrayVal: &schemapb.TemplateArrayValue{
|
|
Data: &schemapb.TemplateArrayValue_JsonData{
|
|
JsonData: &schemapb.JSONArray{
|
|
Data: [][]byte{[]byte("{}"), []byte("{}")},
|
|
},
|
|
},
|
|
},
|
|
},
|
|
}
|
|
|
|
assert.Equal(t, 2, getLengthFromTemplateValue(tv))
|
|
})
|
|
|
|
t.Run("nil", func(t *testing.T) {
|
|
tv := &schemapb.TemplateValue{
|
|
Val: &schemapb.TemplateValue_ArrayVal{
|
|
ArrayVal: &schemapb.TemplateArrayValue{},
|
|
},
|
|
}
|
|
|
|
assert.Equal(t, -1, getLengthFromTemplateValue(tv))
|
|
})
|
|
|
|
t.Run("primitive", func(t *testing.T) {
|
|
tv := &schemapb.TemplateValue{
|
|
Val: &schemapb.TemplateValue_StringVal{
|
|
StringVal: "foo",
|
|
},
|
|
}
|
|
|
|
assert.Equal(t, 1, getLengthFromTemplateValue(tv))
|
|
})
|
|
}
|
|
|
|
func TestGetCurUserFromContext(t *testing.T) {
|
|
t.Run("valid context with user info", func(t *testing.T) {
|
|
ctx := context.Background()
|
|
token := crypto.Base64Encode("testuser:testpassword")
|
|
md := metadata.New(map[string]string{
|
|
strings.ToLower(util.HeaderAuthorize): token,
|
|
})
|
|
ctx = metadata.NewIncomingContext(ctx, md)
|
|
|
|
username, err := getCurUserFromContext(ctx)
|
|
assert.NoError(t, err)
|
|
assert.Equal(t, "testuser", username)
|
|
})
|
|
|
|
t.Run("no metadata in context", func(t *testing.T) {
|
|
ctx := context.Background()
|
|
_, err := getCurUserFromContext(ctx)
|
|
assert.Error(t, err)
|
|
})
|
|
|
|
t.Run("no authorization in metadata", func(t *testing.T) {
|
|
ctx := context.Background()
|
|
md := metadata.New(map[string]string{})
|
|
ctx = metadata.NewIncomingContext(ctx, md)
|
|
|
|
_, err := getCurUserFromContext(ctx)
|
|
assert.Error(t, err)
|
|
})
|
|
|
|
t.Run("invalid token format", func(t *testing.T) {
|
|
ctx := context.Background()
|
|
md := metadata.New(map[string]string{
|
|
strings.ToLower(util.HeaderAuthorize): "invalid_base64!@#",
|
|
})
|
|
ctx = metadata.NewIncomingContext(ctx, md)
|
|
|
|
_, err := getCurUserFromContext(ctx)
|
|
assert.Error(t, err)
|
|
})
|
|
|
|
t.Run("token without separator", func(t *testing.T) {
|
|
ctx := context.Background()
|
|
token := crypto.Base64Encode("tokenwithoutseparator")
|
|
md := metadata.New(map[string]string{
|
|
strings.ToLower(util.HeaderAuthorize): token,
|
|
})
|
|
ctx = metadata.NewIncomingContext(ctx, md)
|
|
|
|
_, err := getCurUserFromContext(ctx)
|
|
assert.Error(t, err)
|
|
})
|
|
}
|