mirror of
https://gitee.com/milvus-io/milvus.git
synced 2025-12-28 14:35:27 +08:00
7d6d279e9c
### **User description** issue: #46507 we use the assign/unassign api to manage the consumer manually, the commit operation will generate a new consumer group which is not what we want. so we disable the auto commit to avoid it, also see: https://github.com/confluentinc/confluent-kafka-python/issues/250#issuecomment-331377925 ___ ### **PR Type** Bug fix ___ ### **Description** - Disable auto-commit in Kafka consumer configuration - Prevents unwanted consumer group creation from manual offset management - Clarifies offset reset behavior with explanatory comments ___ ### Diagram Walkthrough ```mermaid flowchart LR A["Kafka Consumer Config"] --> B["Set enable.auto.commit to false"] B --> C["Prevent auto consumer group creation"] A --> D["Set auto.offset.reset to earliest"] D --> E["Handle deleted offsets gracefully"] ``` <details><summary><h3>File Walkthrough</h3></summary> <table><thead><tr><th></th><th align="left">Relevant files</th></tr></thead><tbody><tr><td><strong>Bug fix</strong></td><td><table> <tr> <td> <details> <summary><strong>builder.go</strong><dd><code>Disable auto-commit and add configuration comments</code> </dd></summary> <hr> pkg/streaming/walimpls/impls/kafka/builder.go <ul><li>Added <code>enable.auto.commit</code> configuration set to <code>false</code> to prevent <br>automatic consumer group creation<br> <li> Added explanatory comments for both <code>auto.offset.reset</code> and <br><code>enable.auto.commit</code> settings<br> <li> Clarifies that manual assign/unassign API is used for consumer <br>management</ul> </details> </td> <td><a href="https://github.com/milvus-io/milvus/pull/46508/files#diff-4b5635821fdc8b585d16c02d8a3b59079d8e667b2be43a073265112d72701add">+7/-0</a> </td> </tr> </table></td></tr></tbody></table> </details> ___ <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit ## Bug Fixes * Kafka consumer now reads from the earliest available messages and auto-commit has been disabled to support manual offset management. <sub>✏️ Tip: You can customize this high-level summary in your review settings.</sub> <!-- end of auto-generated comment: release notes by coderabbit.ai --> Signed-off-by: chyezh <chyezh@outlook.com>