milvus/pkg/util/vralloc/alloc_test.go
aoiasd 26c86ec221
enhance: fix unstable unit test (#46626)
<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
- Core invariant: TestWait must deterministically verify that
FixedSizeAllocator.Wait() is notified when virtual resources are
released, so an allocation blocked due to exhausted virtual capacity
eventually succeeds after explicit deallocations.
- Removed/simplified logic: replaced the previous flaky pattern that
spawned 100 concurrent goroutines performing Reallocate with an explicit
channel-synchronized release goroutine that performs 100 sequential
negative Reallocate calls only after the test blocks on allocation. This
eliminates timing-dependent concurrency and the nondeterministic i-based
assertion.
- Why no data loss or behavior regression: only the test changed —
allocator implementation (Allocate/Reallocate/Release/Wait/notify) and
public APIs are unchanged. The test now exercises the same code paths
(Allocate fails, Wait blocks on cond, Reallocate/Release call notify),
but in a deterministic order, so the allocator semantics and resource
accounting (used, allocs map) remain unaffected.
- Change type and intent: Enhancement/refactor of unit test stability —
it tightens test synchronization to remove race-dependent assertions and
ensure the Wait/notify mechanism is reliably exercised without modifying
allocator logic.
<!-- end of auto-generated comment: release notes by coderabbit.ai -->

Signed-off-by: aoiasd <zhicheng.yue@zilliz.com>
2025-12-30 17:05:21 +08:00

141 lines
4.3 KiB
Go

// Licensed to the LF AI & Data foundation under one
// or more contributor license agreements. See the NOTICE file
// distributed with this work for additional information
// regarding copyright ownership. The ASF licenses this file
// to you under the Apache License, Version 2.0 (the
// "License"); you may not use this file except in compliance
// with the License. You may obtain a copy of the License at
//
// http://www.apache.org/licenses/LICENSE-2.0
//
// Unless required by applicable law or agreed to in writing, software
// distributed under the License is distributed on an "AS IS" BASIS,
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
// See the License for the specific language governing permissions and
// limitations under the License.
package vralloc
import (
"fmt"
"sync"
"testing"
"github.com/stretchr/testify/assert"
"go.uber.org/zap"
"github.com/milvus-io/milvus/pkg/v2/log"
"github.com/milvus-io/milvus/pkg/v2/util/hardware"
)
func inspect[T comparable](a Allocator[T]) {
m := a.Inspect()
log.Info("Allocation", zap.Any("allocations", m), zap.Any("used", a.Used()))
}
func TestFixedSizeAllocator(t *testing.T) {
a := NewFixedSizeAllocator[string](&Resource{100, 100, 100})
// Allocate
allocated, _ := a.Allocate("a1", &Resource{10, 10, 10})
assert.Equal(t, true, allocated)
allocated, _ = a.Allocate("a2", &Resource{90, 90, 90})
assert.Equal(t, true, allocated)
allocated, short := a.Allocate("a3", &Resource{10, 0, 0})
assert.Equal(t, false, allocated)
assert.Equal(t, &Resource{10, 0, 0}, short)
allocated, _ = a.Allocate("a0", &Resource{-10, 0, 0})
assert.Equal(t, false, allocated)
inspect[string](a)
// Release
a.Release("a2")
allocated, _ = a.Allocate("a3", &Resource{10, 0, 0})
assert.Equal(t, true, allocated)
// Inspect
m := a.Inspect()
assert.Equal(t, 2, len(m))
// Allocate on identical id is not allowed
allocated, _ = a.Allocate("a1", &Resource{10, 0, 0})
assert.Equal(t, false, allocated)
// Reallocate
allocated, _ = a.Reallocate("a1", &Resource{10, 0, 0})
assert.Equal(t, true, allocated)
allocated, _ = a.Reallocate("a1", &Resource{-10, 0, 0})
assert.Equal(t, true, allocated)
allocated, _ = a.Reallocate("a1", &Resource{-20, 0, 0})
assert.Equal(t, false, allocated)
allocated, _ = a.Reallocate("a1", &Resource{80, 0, 0})
assert.Equal(t, true, allocated)
allocated, _ = a.Reallocate("a1", &Resource{10, 0, 0})
assert.Equal(t, false, allocated)
allocated, _ = a.Reallocate("a4", &Resource{0, 10, 0})
assert.Equal(t, true, allocated)
}
func TestFixedSizeAllocatorRace(t *testing.T) {
a := NewFixedSizeAllocator[string](&Resource{100, 100, 100})
wg := new(sync.WaitGroup)
for i := 0; i < 100; i++ {
wg.Add(1)
go func(index int) {
defer wg.Done()
allocated, _ := a.Allocate(fmt.Sprintf("a%d", index), &Resource{1, 1, 1})
assert.Equal(t, true, allocated)
}(i)
}
wg.Wait()
m := a.Inspect()
assert.Equal(t, 100, len(m))
}
func TestWait(t *testing.T) {
a := NewFixedSizeAllocator[string](&Resource{100, 100, 100})
allocated, _ := a.Allocate("a1", &Resource{100, 100, 100})
assert.True(t, allocated)
waitCh := make(chan struct{})
release := func() {
<-waitCh
for i := 0; i < 100; i++ {
allocated, _ := a.Reallocate("a1", &Resource{-1, -1, -1})
assert.Equal(t, true, allocated)
}
}
go release()
allocated, _ = a.Allocate("a2", &Resource{100, 100, 100})
assert.False(t, allocated)
close(waitCh) // start release a1
for !allocated {
a.Wait() // alloc after wait
allocated, _ = a.Allocate("a2", &Resource{100, 100, 100})
}
assert.True(t, allocated)
}
func TestPhysicalAwareFixedSizeAllocator(t *testing.T) {
hwMemoryLimit := int64(float32(hardware.GetMemoryCount()) * 0.9)
hwDiskLimit := int64(1<<63 - 1)
a := NewPhysicalAwareFixedSizeAllocator[string](&Resource{100, 100, 100}, hwMemoryLimit, hwDiskLimit, "/tmp")
allocated, _ := a.Allocate("a1", &Resource{10, 10, 10})
assert.Equal(t, true, allocated)
allocated, _ = a.Allocate("a2", &Resource{90, 90, 90})
assert.Equal(t, true, allocated)
allocated, short := a.Allocate("a3", &Resource{10, 0, 0})
assert.Equal(t, false, allocated)
assert.Equal(t, &Resource{10, 0, 0}, short)
// Reallocate
allocated, _ = a.Reallocate("a1", &Resource{0, -10, 0})
assert.True(t, allocated)
allocated, _ = a.Reallocate("a1", &Resource{10, 0, 0})
assert.False(t, allocated)
}