mirror of
https://gitee.com/milvus-io/milvus.git
synced 2025-12-28 14:35:27 +08:00
### **User description** issue: #46367 ___ ### **PR Type** Bug fix, Tests ___ ### **Description** - Fix unstable test case by adjusting float precision - Change listMix float value from 1.1 to 1.111 - Improves test stability for json_contains_any query ___ ### Diagram Walkthrough ```mermaid flowchart LR A["Test Data Generation"] -- "Adjust float precision" --> B["listMix field value"] B -- "1.1 to 1.111" --> C["Improved test stability"] ``` <details><summary><h3>File Walkthrough</h3></summary> <table><thead><tr><th></th><th align="left">Relevant files</th></tr></thead><tbody><tr><td><strong>Bug fix</strong></td><td><table> <tr> <td> <details> <summary><strong>test_milvus_client_query.py</strong><dd><code>Adjust float precision in test data</code> </dd></summary> <hr> tests/python_client/milvus_client/test_milvus_client_query.py <ul><li>Modified test data generation in <br><code>test_milvus_client_query_expr_all_datatype_json_contains_all</code> method<br> <li> Changed <code>listMix</code> field float value from <code>1.1</code> to <code>1.111</code> for improved <br>precision<br> <li> Addresses test instability issue by adjusting floating-point test data</ul> </details> </td> <td><a href="https://github.com/milvus-io/milvus/pull/46506/files#diff-d6fe357e4678415bc62596b802571043fa571c7d1b8e841aa43124437dd2f739">+1/-1</a> </td> </tr> </table></td></tr></tbody></table> </details> ___ <!-- This is an auto-generated comment: release notes by coderabbit.ai --> - Core invariant: the test assumes stable float equality/containment behavior for JSON-typed fields when generating test rows; small changes in stored float precision can make json_contains_any assertions flaky. - Exact fix for the bug (refs #46367): in tests/python_client/milvus_client/test_milvus_client_query.py, the test data value for the second element of the "listMix" JSON field was adjusted from i * 1.1 to i * 1.111 in test_milvus_client_query_expr_all_datatype_json_contains_all to increase numeric precision and remove instability in json_contains_any assertions. - Logic removed/simplified: no production logic was changed or removed — only a one-line test-data change. There is no control-flow or algorithmic simplification because the test’s intent and checks remain identical; the change removes the redundant dependence on a borderline float value that caused flakiness. - No data loss or behavior regression: this change only updates test-generated input (test_milvus_client_query_expr_all_datatype_json_contains_all) and does not touch any library or runtime code paths. Production code paths (query parsing/execution, JSON handling) are unchanged, so no persisted data, API behavior, or client logic is affected. <!-- end of auto-generated comment: release notes by coderabbit.ai --> Signed-off-by: nico <cheng.yuan@zilliz.com>
Tests
E2E Test
Configuration Requirements
Operating System
| Operating System | Version |
|---|---|
| Amazon Linux | 2023 or above |
| Ubuntu | 20.04 or above |
| Mac | 10.14 or above |
Hardware
| Hardware Type | Recommended Configuration |
|---|---|
| CPU | x86_64 architecture Intel CPU Sandy Bridge or above CPU Instruction Set - SSE4_2 - AVX - AVX2 - AVX512 or arm64 Linux/MacOS |
| Memory | 16 GB or more |
Software
| Software Name | Version |
|---|---|
| Docker | 19.05 or above |
| Docker Compose | 1.25.5 or above |
| jq | 1.3 or above |
| kubectl | 1.14 or above |
| helm | 3.0 or above |
| kind | 0.10.0 or above |
Installing Dependencies
Troubleshooting Docker and Docker Compose
- Confirm that Docker Daemon is running:
$ docker info
-
Ensure that Docker is installed. Refer to the official installation instructions for Docker CE/EE.
-
Start the Docker Daemon if it is not already started.
-
To run Docker without
rootprivileges, create a user group labeleddocker, then add a user to the group withsudo usermod -aG docker $USER. Log out and log back into the terminal for the changes to take effect. For more information, see the official Docker documentation for Managing Docker as a Non-Root User.
- Check the version of Docker-Compose
$ docker compose version
docker compose version 1.25.5, build 8a1c60f6
docker-py version: 4.1.0
CPython version: 3.7.5
OpenSSL version: OpenSSL 1.1.1f 31 Mar 2020
- To install Docker-Compose, see Install Docker Compose
Install jq
Install kubectl
Install helm
- Refer to https://helm.sh/docs/intro/install/
Install kind
Run E2E Tests
$ cd tests/scripts
$ ./e2e-k8s.sh
Getting help
You can get help with the following command:
$ ./e2e-k8s.sh --help