mirror of
https://gitee.com/milvus-io/milvus.git
synced 2025-12-06 17:18:35 +08:00
d8d1dcf076
1. Fix deregister dispatcher concurrency. (Keep sure the same logic as 2.5 branch) 2. Fix seek if includeCurrentMsg. (This is only needed by CDC, so there's no need to pick to 2.5 branch) issue: issue: https://github.com/milvus-io/milvus/issues/39862 pr: https://github.com/milvus-io/milvus/pull/39863 --------- Signed-off-by: bigsheeper <yihao.dai@zilliz.com>
340 lines
9.3 KiB
Go
340 lines
9.3 KiB
Go
// Licensed to the LF AI & Data foundation under one
|
|
// or more contributor license agreements. See the NOTICE file
|
|
// distributed with this work for additional information
|
|
// regarding copyright ownership. The ASF licenses this file
|
|
// to you under the Apache License, Version 2.0 (the
|
|
// "License"); you may not use this file except in compliance
|
|
// with the License. You may obtain a copy of the License at
|
|
//
|
|
// http://www.apache.org/licenses/LICENSE-2.0
|
|
//
|
|
// Unless required by applicable law or agreed to in writing, software
|
|
// distributed under the License is distributed on an "AS IS" BASIS,
|
|
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
// See the License for the specific language governing permissions and
|
|
// limitations under the License.
|
|
|
|
package msgdispatcher
|
|
|
|
import (
|
|
"sync"
|
|
"testing"
|
|
"time"
|
|
|
|
"github.com/cockroachdb/errors"
|
|
"github.com/stretchr/testify/assert"
|
|
"github.com/stretchr/testify/mock"
|
|
"golang.org/x/net/context"
|
|
|
|
"github.com/milvus-io/milvus-proto/go-api/v2/commonpb"
|
|
"github.com/milvus-io/milvus-proto/go-api/v2/msgpb"
|
|
"github.com/milvus-io/milvus/pkg/v2/mq/common"
|
|
"github.com/milvus-io/milvus/pkg/v2/mq/msgstream"
|
|
)
|
|
|
|
func TestDispatcher(t *testing.T) {
|
|
ctx := context.Background()
|
|
t.Run("test base", func(t *testing.T) {
|
|
d, err := NewDispatcher(ctx, newMockFactory(), time.Now().UnixNano(), "mock_pchannel_0",
|
|
nil, common.SubscriptionPositionEarliest, false, 0)
|
|
assert.NoError(t, err)
|
|
assert.NotPanics(t, func() {
|
|
d.Handle(start)
|
|
d.Handle(pause)
|
|
d.Handle(resume)
|
|
d.Handle(terminate)
|
|
})
|
|
|
|
pos := &msgstream.MsgPosition{
|
|
ChannelName: "mock_vchannel_0",
|
|
MsgGroup: "mock_msg_group",
|
|
Timestamp: 100,
|
|
}
|
|
d.curTs.Store(pos.GetTimestamp())
|
|
curTs := d.CurTs()
|
|
assert.Equal(t, pos.Timestamp, curTs)
|
|
})
|
|
|
|
t.Run("test AsConsumer fail", func(t *testing.T) {
|
|
ms := msgstream.NewMockMsgStream(t)
|
|
ms.EXPECT().AsConsumer(mock.Anything, mock.Anything, mock.Anything, mock.Anything).Return(errors.New("mock error"))
|
|
ms.EXPECT().Close().Return()
|
|
factory := &msgstream.MockMqFactory{
|
|
NewMsgStreamFunc: func(ctx context.Context) (msgstream.MsgStream, error) {
|
|
return ms, nil
|
|
},
|
|
}
|
|
d, err := NewDispatcher(ctx, factory, time.Now().UnixNano(), "mock_pchannel_0",
|
|
nil, common.SubscriptionPositionEarliest, false, 0)
|
|
|
|
assert.Error(t, err)
|
|
assert.Nil(t, d)
|
|
})
|
|
|
|
t.Run("test target", func(t *testing.T) {
|
|
d, err := NewDispatcher(ctx, newMockFactory(), time.Now().UnixNano(), "mock_pchannel_0",
|
|
nil, common.SubscriptionPositionEarliest, false, 0)
|
|
assert.NoError(t, err)
|
|
output := make(chan *msgstream.MsgPack, 1024)
|
|
|
|
getTarget := func(vchannel string, pos *Pos, ch chan *msgstream.MsgPack) *target {
|
|
target := newTarget(&StreamConfig{
|
|
VChannel: vchannel,
|
|
Pos: pos,
|
|
})
|
|
target.ch = ch
|
|
return target
|
|
}
|
|
|
|
d.AddTarget(getTarget("mock_vchannel_0", nil, output))
|
|
d.AddTarget(getTarget("mock_vchannel_1", nil, nil))
|
|
num := d.TargetNum()
|
|
assert.Equal(t, 2, num)
|
|
|
|
target, err := d.GetTarget("mock_vchannel_0")
|
|
assert.NoError(t, err)
|
|
assert.Equal(t, cap(output), cap(target.ch))
|
|
|
|
d.RemoveTarget("mock_vchannel_0")
|
|
|
|
num = d.TargetNum()
|
|
assert.Equal(t, 1, num)
|
|
})
|
|
|
|
t.Run("test concurrent send and close", func(t *testing.T) {
|
|
for i := 0; i < 100; i++ {
|
|
output := make(chan *msgstream.MsgPack, 1024)
|
|
target := newTarget(&StreamConfig{VChannel: "mock_vchannel_0"})
|
|
target.ch = output
|
|
assert.Equal(t, cap(output), cap(target.ch))
|
|
wg := &sync.WaitGroup{}
|
|
for j := 0; j < 100; j++ {
|
|
wg.Add(1)
|
|
go func() {
|
|
err := target.send(&MsgPack{})
|
|
assert.NoError(t, err)
|
|
wg.Done()
|
|
}()
|
|
wg.Add(1)
|
|
go func() {
|
|
target.close()
|
|
wg.Done()
|
|
}()
|
|
}
|
|
wg.Wait()
|
|
}
|
|
})
|
|
}
|
|
|
|
func BenchmarkDispatcher_handle(b *testing.B) {
|
|
d, err := NewDispatcher(context.Background(), newMockFactory(), time.Now().UnixNano(), "mock_pchannel_0",
|
|
nil, common.SubscriptionPositionEarliest, false, 0)
|
|
assert.NoError(b, err)
|
|
|
|
for i := 0; i < b.N; i++ {
|
|
d.Handle(start)
|
|
d.Handle(pause)
|
|
d.Handle(resume)
|
|
d.Handle(terminate)
|
|
}
|
|
// BenchmarkDispatcher_handle-12 9568 122123 ns/op
|
|
// PASS
|
|
}
|
|
|
|
func TestGroupMessage(t *testing.T) {
|
|
d, err := NewDispatcher(context.Background(), newMockFactory(), time.Now().UnixNano(), "mock_pchannel_0",
|
|
nil, common.SubscriptionPositionEarliest, false, 0)
|
|
assert.NoError(t, err)
|
|
d.AddTarget(newTarget(&StreamConfig{VChannel: "mock_pchannel_0_1v0"}))
|
|
d.AddTarget(newTarget(&StreamConfig{
|
|
VChannel: "mock_pchannel_0_2v0",
|
|
ReplicateConfig: msgstream.GetReplicateConfig("local-test", "foo", "coo"),
|
|
}))
|
|
{
|
|
// no replicate msg
|
|
packs := d.groupAndParseMsgs(msgstream.BuildConsumeMsgPack(&MsgPack{
|
|
BeginTs: 1,
|
|
EndTs: 10,
|
|
StartPositions: []*msgstream.MsgPosition{
|
|
{
|
|
ChannelName: "mock_pchannel_0",
|
|
MsgID: []byte("1"),
|
|
Timestamp: 1,
|
|
},
|
|
},
|
|
EndPositions: []*msgstream.MsgPosition{
|
|
{
|
|
ChannelName: "mock_pchannel_0",
|
|
MsgID: []byte("10"),
|
|
Timestamp: 10,
|
|
},
|
|
},
|
|
Msgs: []msgstream.TsMsg{
|
|
&msgstream.InsertMsg{
|
|
BaseMsg: msgstream.BaseMsg{
|
|
BeginTimestamp: 5,
|
|
EndTimestamp: 5,
|
|
},
|
|
InsertRequest: &msgpb.InsertRequest{
|
|
Base: &commonpb.MsgBase{
|
|
MsgType: commonpb.MsgType_Insert,
|
|
Timestamp: 5,
|
|
},
|
|
ShardName: "mock_pchannel_0_1v0",
|
|
},
|
|
},
|
|
},
|
|
}), nil)
|
|
assert.Len(t, packs, 1)
|
|
}
|
|
|
|
{
|
|
// equal to replicateID
|
|
packs := d.groupAndParseMsgs(msgstream.BuildConsumeMsgPack(&MsgPack{
|
|
BeginTs: 1,
|
|
EndTs: 10,
|
|
StartPositions: []*msgstream.MsgPosition{
|
|
{
|
|
ChannelName: "mock_pchannel_0",
|
|
MsgID: []byte("1"),
|
|
Timestamp: 1,
|
|
},
|
|
},
|
|
EndPositions: []*msgstream.MsgPosition{
|
|
{
|
|
ChannelName: "mock_pchannel_0",
|
|
MsgID: []byte("10"),
|
|
Timestamp: 10,
|
|
},
|
|
},
|
|
Msgs: []msgstream.TsMsg{
|
|
&msgstream.ReplicateMsg{
|
|
BaseMsg: msgstream.BaseMsg{
|
|
BeginTimestamp: 100,
|
|
EndTimestamp: 100,
|
|
},
|
|
ReplicateMsg: &msgpb.ReplicateMsg{
|
|
Base: &commonpb.MsgBase{
|
|
MsgType: commonpb.MsgType_Replicate,
|
|
Timestamp: 100,
|
|
ReplicateInfo: &commonpb.ReplicateInfo{
|
|
ReplicateID: "local-test",
|
|
},
|
|
},
|
|
},
|
|
},
|
|
},
|
|
}), nil)
|
|
assert.Len(t, packs, 2)
|
|
{
|
|
replicatePack := packs["mock_pchannel_0_2v0"]
|
|
assert.EqualValues(t, 100, replicatePack.BeginTs)
|
|
assert.EqualValues(t, 100, replicatePack.EndTs)
|
|
assert.EqualValues(t, 100, replicatePack.StartPositions[0].Timestamp)
|
|
assert.EqualValues(t, 100, replicatePack.EndPositions[0].Timestamp)
|
|
assert.Len(t, replicatePack.Msgs, 0)
|
|
}
|
|
{
|
|
replicatePack := packs["mock_pchannel_0_1v0"]
|
|
assert.EqualValues(t, 1, replicatePack.BeginTs)
|
|
assert.EqualValues(t, 10, replicatePack.EndTs)
|
|
assert.EqualValues(t, 1, replicatePack.StartPositions[0].Timestamp)
|
|
assert.EqualValues(t, 10, replicatePack.EndPositions[0].Timestamp)
|
|
assert.Len(t, replicatePack.Msgs, 0)
|
|
}
|
|
}
|
|
|
|
{
|
|
// not equal to replicateID
|
|
packs := d.groupAndParseMsgs(msgstream.BuildConsumeMsgPack(&MsgPack{
|
|
BeginTs: 1,
|
|
EndTs: 10,
|
|
StartPositions: []*msgstream.MsgPosition{
|
|
{
|
|
ChannelName: "mock_pchannel_0",
|
|
MsgID: []byte("1"),
|
|
Timestamp: 1,
|
|
},
|
|
},
|
|
EndPositions: []*msgstream.MsgPosition{
|
|
{
|
|
ChannelName: "mock_pchannel_0",
|
|
MsgID: []byte("10"),
|
|
Timestamp: 10,
|
|
},
|
|
},
|
|
Msgs: []msgstream.TsMsg{
|
|
&msgstream.ReplicateMsg{
|
|
BaseMsg: msgstream.BaseMsg{
|
|
BeginTimestamp: 100,
|
|
EndTimestamp: 100,
|
|
},
|
|
ReplicateMsg: &msgpb.ReplicateMsg{
|
|
Base: &commonpb.MsgBase{
|
|
MsgType: commonpb.MsgType_Replicate,
|
|
Timestamp: 100,
|
|
ReplicateInfo: &commonpb.ReplicateInfo{
|
|
ReplicateID: "local-test-1", // not equal to replicateID
|
|
},
|
|
},
|
|
},
|
|
},
|
|
},
|
|
}), nil)
|
|
assert.Len(t, packs, 1)
|
|
replicatePack := packs["mock_pchannel_0_2v0"]
|
|
assert.Nil(t, replicatePack)
|
|
}
|
|
|
|
{
|
|
// replicate end
|
|
replicateTarget, ok := d.targets.Get("mock_pchannel_0_2v0")
|
|
assert.True(t, ok)
|
|
assert.NotNil(t, replicateTarget.replicateConfig)
|
|
packs := d.groupAndParseMsgs(msgstream.BuildConsumeMsgPack(&MsgPack{
|
|
BeginTs: 1,
|
|
EndTs: 10,
|
|
StartPositions: []*msgstream.MsgPosition{
|
|
{
|
|
ChannelName: "mock_pchannel_0",
|
|
MsgID: []byte("1"),
|
|
Timestamp: 1,
|
|
},
|
|
},
|
|
EndPositions: []*msgstream.MsgPosition{
|
|
{
|
|
ChannelName: "mock_pchannel_0",
|
|
MsgID: []byte("10"),
|
|
Timestamp: 10,
|
|
},
|
|
},
|
|
Msgs: []msgstream.TsMsg{
|
|
&msgstream.ReplicateMsg{
|
|
BaseMsg: msgstream.BaseMsg{
|
|
BeginTimestamp: 100,
|
|
EndTimestamp: 100,
|
|
},
|
|
ReplicateMsg: &msgpb.ReplicateMsg{
|
|
Base: &commonpb.MsgBase{
|
|
MsgType: commonpb.MsgType_Replicate,
|
|
Timestamp: 100,
|
|
ReplicateInfo: &commonpb.ReplicateInfo{
|
|
ReplicateID: "local-test",
|
|
},
|
|
},
|
|
IsEnd: true,
|
|
Database: "foo",
|
|
},
|
|
},
|
|
},
|
|
}), nil)
|
|
assert.Len(t, packs, 2)
|
|
replicatePack := packs["mock_pchannel_0_2v0"]
|
|
assert.EqualValues(t, 100, replicatePack.BeginTs)
|
|
assert.EqualValues(t, 100, replicatePack.EndTs)
|
|
assert.EqualValues(t, 100, replicatePack.StartPositions[0].Timestamp)
|
|
assert.EqualValues(t, 100, replicatePack.EndPositions[0].Timestamp)
|
|
assert.Nil(t, replicateTarget.replicateConfig)
|
|
}
|
|
}
|