mirror of
https://gitee.com/milvus-io/milvus.git
synced 2026-01-07 19:31:51 +08:00
issue: https://github.com/milvus-io/milvus/issues/44123 <!-- This is an auto-generated comment: release notes by coderabbit.ai --> - Core invariant: legacy in-cluster CDC/replication plumbing (ReplicateMsg types, ReplicateID-based guards and flags) is obsolete — the system relies on standard msgstream positions, subPos/end-ts semantics and timetick ordering as the single source of truth for message ordering and skipping, so replication-specific channels/types/guards can be removed safely. - Removed/simplified logic (what and why): removed replication feature flags and params (ReplicateMsgChannel, TTMsgEnabled, CollectionReplicateEnable), ReplicateMsg type and its tests, ReplicateID constants/helpers and MergeProperties hooks, ReplicateConfig and its propagation (streamPipeline, StreamConfig, dispatcher, target), replicate-aware dispatcher/pipeline branches, and replicate-mode pre-checks/timestamp-allocation in proxy tasks — these implemented a redundant alternate “replicate-mode” pathway that duplicated position/end-ts and timetick logic. - Why this does NOT cause data loss or regression (concrete code paths): no persistence or core write paths were removed — proxy PreExecute flows (internal/proxy/task_*.go) still perform the same schema/ID/size validations and then follow the normal non-replicate execution path; dispatcher and pipeline continue to use position/subPos and pullback/end-ts in Seek/grouping (pkg/mq/msgdispatcher/dispatcher.go, internal/util/pipeline/stream_pipeline.go), so skipping and ordering behavior remains unchanged; timetick emission in rootcoord (sendMinDdlTsAsTt) is now ungated (no silent suppression), preserving or increasing timetick delivery rather than removing it. - PR type and net effect: Enhancement/Refactor — removes deprecated replication API surface (types, helpers, config, tests) and replication branches, simplifies public APIs and constructor signatures, and reduces surface area for future maintenance while keeping DML/DDL persistence, ordering, and seek semantics intact. <!-- end of auto-generated comment: release notes by coderabbit.ai --> --------- Signed-off-by: bigsheeper <yihao.dai@zilliz.com>
64 lines
1.3 KiB
Go
64 lines
1.3 KiB
Go
package proxy
|
|
|
|
import (
|
|
"context"
|
|
|
|
"github.com/cockroachdb/errors"
|
|
|
|
"github.com/milvus-io/milvus/pkg/v2/mq/msgstream"
|
|
)
|
|
|
|
type mockMsgStream struct {
|
|
msgstream.MsgStream
|
|
asProducer func([]string)
|
|
setRepack func(repackFunc msgstream.RepackFunc)
|
|
close func()
|
|
}
|
|
|
|
func (m *mockMsgStream) AsProducer(ctx context.Context, producers []string) {
|
|
if m.asProducer != nil {
|
|
m.asProducer(producers)
|
|
}
|
|
}
|
|
|
|
func (m *mockMsgStream) SetRepackFunc(repackFunc msgstream.RepackFunc) {
|
|
if m.setRepack != nil {
|
|
m.setRepack(repackFunc)
|
|
}
|
|
}
|
|
|
|
func (m *mockMsgStream) Close() {
|
|
if m.close != nil {
|
|
m.close()
|
|
}
|
|
}
|
|
|
|
func newMockMsgStream() *mockMsgStream {
|
|
return &mockMsgStream{}
|
|
}
|
|
|
|
type mockMsgStreamFactory struct {
|
|
msgstream.Factory
|
|
f func(ctx context.Context) (msgstream.MsgStream, error)
|
|
fQStream func(ctx context.Context) (msgstream.MsgStream, error)
|
|
fTtStream func(ctx context.Context) (msgstream.MsgStream, error)
|
|
}
|
|
|
|
func (m *mockMsgStreamFactory) NewMsgStream(ctx context.Context) (msgstream.MsgStream, error) {
|
|
if m.f != nil {
|
|
return m.f(ctx)
|
|
}
|
|
return nil, errors.New("mock")
|
|
}
|
|
|
|
func (m *mockMsgStreamFactory) NewTtMsgStream(ctx context.Context) (msgstream.MsgStream, error) {
|
|
if m.fTtStream != nil {
|
|
return m.fTtStream(ctx)
|
|
}
|
|
return nil, errors.New("mock")
|
|
}
|
|
|
|
func newMockMsgStreamFactory() *mockMsgStreamFactory {
|
|
return &mockMsgStreamFactory{}
|
|
}
|