mirror of
https://gitee.com/milvus-io/milvus.git
synced 2025-12-06 17:18:35 +08:00
cfeb095ad7
relate: https://github.com/milvus-io/milvus/issues/43687 We used to run the temporary analyzer and validate analyzer on the proxy, but the proxy should not be a computation-heavy node. This PR move all analyzer calculations to the streaming node. --------- Signed-off-by: aoiasd <zhicheng.yue@zilliz.com>
2157 lines
66 KiB
Go
2157 lines
66 KiB
Go
// Licensed to the LF AI & Data foundation under one
|
|
// or more contributor license agreements. See the NOTICE file
|
|
// distributed with this work for additional information
|
|
// regarding copyright ownership. The ASF licenses this file
|
|
// to you under the Apache License, Version 2.0 (the
|
|
// "License"); you may not use this file except in compliance
|
|
// with the License. You may obtain a copy of the License at
|
|
//
|
|
// http://www.apache.org/licenses/LICENSE-2.0
|
|
//
|
|
// Unless required by applicable law or agreed to in writing, software
|
|
// distributed under the License is distributed on an "AS IS" BASIS,
|
|
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
// See the License for the specific language governing permissions and
|
|
// limitations under the License.
|
|
|
|
package rootcoord
|
|
|
|
import (
|
|
"context"
|
|
"math"
|
|
"strconv"
|
|
"strings"
|
|
"testing"
|
|
"time"
|
|
|
|
"github.com/cockroachdb/errors"
|
|
"github.com/stretchr/testify/assert"
|
|
"github.com/stretchr/testify/mock"
|
|
"github.com/stretchr/testify/require"
|
|
"google.golang.org/protobuf/proto"
|
|
|
|
"github.com/milvus-io/milvus-proto/go-api/v2/commonpb"
|
|
"github.com/milvus-io/milvus-proto/go-api/v2/milvuspb"
|
|
"github.com/milvus-io/milvus-proto/go-api/v2/schemapb"
|
|
"github.com/milvus-io/milvus/internal/metastore/model"
|
|
"github.com/milvus-io/milvus/internal/mocks"
|
|
mockrootcoord "github.com/milvus-io/milvus/internal/rootcoord/mocks"
|
|
"github.com/milvus-io/milvus/pkg/v2/common"
|
|
"github.com/milvus-io/milvus/pkg/v2/proto/datapb"
|
|
"github.com/milvus-io/milvus/pkg/v2/proto/querypb"
|
|
"github.com/milvus-io/milvus/pkg/v2/util"
|
|
"github.com/milvus-io/milvus/pkg/v2/util/funcutil"
|
|
"github.com/milvus-io/milvus/pkg/v2/util/merr"
|
|
"github.com/milvus-io/milvus/pkg/v2/util/paramtable"
|
|
)
|
|
|
|
func Test_createCollectionTask_validate(t *testing.T) {
|
|
paramtable.Init()
|
|
t.Run("empty request", func(t *testing.T) {
|
|
task := createCollectionTask{
|
|
Req: nil,
|
|
}
|
|
err := task.validate(context.TODO())
|
|
assert.Error(t, err)
|
|
})
|
|
|
|
t.Run("create ts", func(t *testing.T) {
|
|
task := createCollectionTask{
|
|
Req: nil,
|
|
}
|
|
{
|
|
task.SetTs(1000)
|
|
ts, err := task.getCreateTs(context.TODO())
|
|
assert.NoError(t, err)
|
|
assert.EqualValues(t, 1000, ts)
|
|
}
|
|
|
|
task.Req = &milvuspb.CreateCollectionRequest{
|
|
Base: &commonpb.MsgBase{
|
|
MsgType: commonpb.MsgType_CreateCollection,
|
|
ReplicateInfo: &commonpb.ReplicateInfo{
|
|
IsReplicate: true,
|
|
},
|
|
},
|
|
}
|
|
{
|
|
task.SetTs(1000)
|
|
_, err := task.getCreateTs(context.TODO())
|
|
assert.Error(t, err)
|
|
err = task.Execute(context.Background())
|
|
assert.Error(t, err)
|
|
}
|
|
{
|
|
task.Req.Base.ReplicateInfo.MsgTimestamp = 2000
|
|
ts, err := task.getCreateTs(context.TODO())
|
|
assert.NoError(t, err)
|
|
assert.EqualValues(t, 2000, ts)
|
|
}
|
|
})
|
|
|
|
t.Run("invalid msg type", func(t *testing.T) {
|
|
task := createCollectionTask{
|
|
Req: &milvuspb.CreateCollectionRequest{
|
|
Base: &commonpb.MsgBase{MsgType: commonpb.MsgType_DropCollection},
|
|
},
|
|
}
|
|
err := task.validate(context.TODO())
|
|
assert.Error(t, err)
|
|
})
|
|
|
|
t.Run("shard num exceeds max configuration", func(t *testing.T) {
|
|
// TODO: better to have a `Set` method for ParamItem.
|
|
var cfgMaxShardNum int32
|
|
if Params.CommonCfg.PreCreatedTopicEnabled.GetAsBool() {
|
|
cfgMaxShardNum = int32(len(Params.CommonCfg.TopicNames.GetAsStrings()))
|
|
} else {
|
|
cfgMaxShardNum = Params.RootCoordCfg.DmlChannelNum.GetAsInt32()
|
|
}
|
|
task := createCollectionTask{
|
|
Req: &milvuspb.CreateCollectionRequest{
|
|
Base: &commonpb.MsgBase{MsgType: commonpb.MsgType_CreateCollection},
|
|
ShardsNum: cfgMaxShardNum + 1,
|
|
},
|
|
}
|
|
err := task.validate(context.TODO())
|
|
assert.Error(t, err)
|
|
})
|
|
|
|
t.Run("shard num exceeds limit", func(t *testing.T) {
|
|
// TODO: better to have a `Set` method for ParamItem.
|
|
cfgShardLimit := paramtable.Get().ProxyCfg.MaxShardNum.GetAsInt32()
|
|
task := createCollectionTask{
|
|
Req: &milvuspb.CreateCollectionRequest{
|
|
Base: &commonpb.MsgBase{MsgType: commonpb.MsgType_CreateCollection},
|
|
ShardsNum: cfgShardLimit + 1,
|
|
},
|
|
}
|
|
err := task.validate(context.TODO())
|
|
assert.Error(t, err)
|
|
})
|
|
|
|
t.Run("total collection num exceeds limit", func(t *testing.T) {
|
|
paramtable.Get().Save(Params.QuotaConfig.MaxCollectionNum.Key, strconv.Itoa(2))
|
|
defer paramtable.Get().Reset(Params.QuotaConfig.MaxCollectionNum.Key)
|
|
|
|
meta := mockrootcoord.NewIMetaTable(t)
|
|
meta.EXPECT().ListAllAvailCollections(
|
|
mock.Anything,
|
|
).Return(map[int64][]int64{1: {1, 2}})
|
|
|
|
meta.EXPECT().GetDatabaseByName(mock.Anything, mock.Anything, mock.Anything).
|
|
Return(&model.Database{Name: "db1"}, nil).Once()
|
|
|
|
core := newTestCore(withMeta(meta))
|
|
task := createCollectionTask{
|
|
baseTask: newBaseTask(context.TODO(), core),
|
|
Req: &milvuspb.CreateCollectionRequest{
|
|
Base: &commonpb.MsgBase{MsgType: commonpb.MsgType_CreateCollection},
|
|
},
|
|
}
|
|
err := task.validate(context.TODO())
|
|
assert.Error(t, err)
|
|
|
|
task = createCollectionTask{
|
|
baseTask: newBaseTask(context.TODO(), core),
|
|
Req: &milvuspb.CreateCollectionRequest{
|
|
Base: &commonpb.MsgBase{MsgType: commonpb.MsgType_CreateCollection},
|
|
},
|
|
dbID: util.DefaultDBID,
|
|
}
|
|
err = task.validate(context.TODO())
|
|
assert.Error(t, err)
|
|
})
|
|
|
|
t.Run("collection num per db exceeds limit with db properties", func(t *testing.T) {
|
|
paramtable.Get().Save(Params.QuotaConfig.MaxCollectionNumPerDB.Key, strconv.Itoa(2))
|
|
defer paramtable.Get().Reset(Params.QuotaConfig.MaxCollectionNumPerDB.Key)
|
|
|
|
meta := mockrootcoord.NewIMetaTable(t)
|
|
meta.EXPECT().ListAllAvailCollections(mock.Anything).Return(map[int64][]int64{util.DefaultDBID: {1, 2}})
|
|
|
|
// test reach limit
|
|
meta.EXPECT().GetDatabaseByName(mock.Anything, mock.Anything, mock.Anything).
|
|
Return(&model.Database{
|
|
Name: "db1",
|
|
Properties: []*commonpb.KeyValuePair{
|
|
{
|
|
Key: common.DatabaseMaxCollectionsKey,
|
|
Value: "2",
|
|
},
|
|
},
|
|
}, nil).Once()
|
|
|
|
core := newTestCore(withMeta(meta))
|
|
task := createCollectionTask{
|
|
baseTask: newBaseTask(context.TODO(), core),
|
|
Req: &milvuspb.CreateCollectionRequest{
|
|
Base: &commonpb.MsgBase{MsgType: commonpb.MsgType_CreateCollection},
|
|
},
|
|
dbID: util.DefaultDBID,
|
|
}
|
|
err := task.validate(context.TODO())
|
|
assert.Error(t, err)
|
|
|
|
// invalid properties
|
|
meta.EXPECT().GetDatabaseByName(mock.Anything, mock.Anything, mock.Anything).
|
|
Return(&model.Database{
|
|
Name: "db1",
|
|
Properties: []*commonpb.KeyValuePair{
|
|
{
|
|
Key: common.DatabaseMaxCollectionsKey,
|
|
Value: "invalid-value",
|
|
},
|
|
},
|
|
}, nil).Once()
|
|
core = newTestCore(withMeta(meta))
|
|
task = createCollectionTask{
|
|
baseTask: newBaseTask(context.TODO(), core),
|
|
Req: &milvuspb.CreateCollectionRequest{
|
|
Base: &commonpb.MsgBase{MsgType: commonpb.MsgType_CreateCollection},
|
|
},
|
|
dbID: util.DefaultDBID,
|
|
}
|
|
|
|
err = task.validate(context.TODO())
|
|
assert.Error(t, err)
|
|
})
|
|
|
|
t.Run("collection num per db exceeds limit with global configuration", func(t *testing.T) {
|
|
paramtable.Get().Save(Params.QuotaConfig.MaxCollectionNumPerDB.Key, strconv.Itoa(2))
|
|
defer paramtable.Get().Reset(Params.QuotaConfig.MaxCollectionNumPerDB.Key)
|
|
|
|
meta := mockrootcoord.NewIMetaTable(t)
|
|
meta.EXPECT().ListAllAvailCollections(mock.Anything).Return(map[int64][]int64{1: {1, 2}})
|
|
meta.EXPECT().GetDatabaseByName(mock.Anything, mock.Anything, mock.Anything).
|
|
Return(&model.Database{Name: "db1"}, nil).Once()
|
|
|
|
core := newTestCore(withMeta(meta))
|
|
task := createCollectionTask{
|
|
baseTask: newBaseTask(context.TODO(), core),
|
|
Req: &milvuspb.CreateCollectionRequest{
|
|
Base: &commonpb.MsgBase{MsgType: commonpb.MsgType_CreateCollection},
|
|
},
|
|
}
|
|
err := task.validate(context.TODO())
|
|
assert.Error(t, err)
|
|
|
|
task = createCollectionTask{
|
|
baseTask: newBaseTask(context.TODO(), core),
|
|
Req: &milvuspb.CreateCollectionRequest{
|
|
Base: &commonpb.MsgBase{MsgType: commonpb.MsgType_CreateCollection},
|
|
},
|
|
dbID: util.DefaultDBID,
|
|
}
|
|
err = task.validate(context.TODO())
|
|
assert.Error(t, err)
|
|
})
|
|
|
|
t.Run("collection general number exceeds limit", func(t *testing.T) {
|
|
paramtable.Get().Save(Params.RootCoordCfg.MaxGeneralCapacity.Key, strconv.Itoa(1))
|
|
defer paramtable.Get().Reset(Params.RootCoordCfg.MaxGeneralCapacity.Key)
|
|
|
|
meta := mockrootcoord.NewIMetaTable(t)
|
|
meta.EXPECT().ListAllAvailCollections(mock.Anything).Return(map[int64][]int64{1: {1, 2}})
|
|
meta.EXPECT().GetDatabaseByName(mock.Anything, mock.Anything, mock.Anything).
|
|
Return(&model.Database{Name: "db1"}, nil).Once()
|
|
meta.EXPECT().GetGeneralCount(mock.Anything).Return(1)
|
|
|
|
core := newTestCore(withMeta(meta))
|
|
|
|
task := createCollectionTask{
|
|
baseTask: newBaseTask(context.TODO(), core),
|
|
Req: &milvuspb.CreateCollectionRequest{
|
|
Base: &commonpb.MsgBase{MsgType: commonpb.MsgType_CreateCollection},
|
|
NumPartitions: 256,
|
|
ShardsNum: 2,
|
|
},
|
|
dbID: util.DefaultDBID,
|
|
}
|
|
err := task.validate(context.TODO())
|
|
assert.ErrorIs(t, err, merr.ErrGeneralCapacityExceeded)
|
|
})
|
|
|
|
t.Run("ok", func(t *testing.T) {
|
|
paramtable.Get().Save(Params.QuotaConfig.MaxCollectionNumPerDB.Key, "1")
|
|
defer paramtable.Get().Reset(Params.QuotaConfig.MaxCollectionNumPerDB.Key)
|
|
|
|
meta := mockrootcoord.NewIMetaTable(t)
|
|
meta.EXPECT().ListAllAvailCollections(mock.Anything).Return(map[int64][]int64{1: {1, 2}})
|
|
meta.EXPECT().GetDatabaseByName(mock.Anything, mock.Anything, mock.Anything).
|
|
Return(&model.Database{
|
|
Name: "db1",
|
|
Properties: []*commonpb.KeyValuePair{
|
|
{
|
|
Key: common.DatabaseMaxCollectionsKey,
|
|
Value: "3",
|
|
},
|
|
},
|
|
}, nil).Once()
|
|
meta.EXPECT().GetGeneralCount(mock.Anything).Return(0)
|
|
|
|
core := newTestCore(withMeta(meta))
|
|
task := createCollectionTask{
|
|
baseTask: newBaseTask(context.TODO(), core),
|
|
Req: &milvuspb.CreateCollectionRequest{
|
|
Base: &commonpb.MsgBase{MsgType: commonpb.MsgType_CreateCollection},
|
|
NumPartitions: 2,
|
|
ShardsNum: 2,
|
|
},
|
|
dbID: 1,
|
|
}
|
|
|
|
paramtable.Get().Save(Params.QuotaConfig.MaxCollectionNum.Key, strconv.Itoa(math.MaxInt64))
|
|
defer paramtable.Get().Reset(Params.QuotaConfig.MaxCollectionNum.Key)
|
|
|
|
err := task.validate(context.TODO())
|
|
assert.NoError(t, err)
|
|
})
|
|
}
|
|
|
|
func Test_createCollectionTask_validateSchema(t *testing.T) {
|
|
t.Run("name mismatch", func(t *testing.T) {
|
|
collectionName := funcutil.GenRandomStr()
|
|
otherName := collectionName + "_other"
|
|
task := createCollectionTask{
|
|
Req: &milvuspb.CreateCollectionRequest{
|
|
Base: &commonpb.MsgBase{MsgType: commonpb.MsgType_CreateCollection},
|
|
CollectionName: collectionName,
|
|
},
|
|
}
|
|
schema := &schemapb.CollectionSchema{
|
|
Name: otherName,
|
|
}
|
|
err := task.validateSchema(context.TODO(), schema)
|
|
assert.Error(t, err)
|
|
})
|
|
|
|
t.Run("primary field set nullable", func(t *testing.T) {
|
|
collectionName := funcutil.GenRandomStr()
|
|
task := createCollectionTask{
|
|
Req: &milvuspb.CreateCollectionRequest{
|
|
Base: &commonpb.MsgBase{MsgType: commonpb.MsgType_CreateCollection},
|
|
CollectionName: collectionName,
|
|
},
|
|
}
|
|
schema := &schemapb.CollectionSchema{
|
|
Name: collectionName,
|
|
Fields: []*schemapb.FieldSchema{
|
|
{
|
|
Name: "pk",
|
|
IsPrimaryKey: true,
|
|
Nullable: true,
|
|
},
|
|
},
|
|
}
|
|
err := task.validateSchema(context.TODO(), schema)
|
|
assert.Error(t, err)
|
|
})
|
|
|
|
t.Run("primary field set default_value", func(t *testing.T) {
|
|
collectionName := funcutil.GenRandomStr()
|
|
task := createCollectionTask{
|
|
Req: &milvuspb.CreateCollectionRequest{
|
|
Base: &commonpb.MsgBase{MsgType: commonpb.MsgType_CreateCollection},
|
|
CollectionName: collectionName,
|
|
},
|
|
}
|
|
schema := &schemapb.CollectionSchema{
|
|
Name: collectionName,
|
|
Fields: []*schemapb.FieldSchema{
|
|
{
|
|
Name: "pk",
|
|
IsPrimaryKey: true,
|
|
DefaultValue: &schemapb.ValueField{
|
|
Data: &schemapb.ValueField_LongData{
|
|
LongData: 1,
|
|
},
|
|
},
|
|
},
|
|
},
|
|
}
|
|
err := task.validateSchema(context.TODO(), schema)
|
|
assert.Error(t, err)
|
|
})
|
|
|
|
t.Run("has system fields", func(t *testing.T) {
|
|
collectionName := funcutil.GenRandomStr()
|
|
task := createCollectionTask{
|
|
Req: &milvuspb.CreateCollectionRequest{
|
|
Base: &commonpb.MsgBase{MsgType: commonpb.MsgType_CreateCollection},
|
|
CollectionName: collectionName,
|
|
},
|
|
}
|
|
schema := &schemapb.CollectionSchema{
|
|
Name: collectionName,
|
|
Fields: []*schemapb.FieldSchema{
|
|
{Name: RowIDFieldName},
|
|
},
|
|
}
|
|
err := task.validateSchema(context.TODO(), schema)
|
|
assert.Error(t, err)
|
|
})
|
|
|
|
t.Run("default value type mismatch", func(t *testing.T) {
|
|
collectionName := funcutil.GenRandomStr()
|
|
task := createCollectionTask{
|
|
Req: &milvuspb.CreateCollectionRequest{
|
|
Base: &commonpb.MsgBase{MsgType: commonpb.MsgType_CreateCollection},
|
|
CollectionName: collectionName,
|
|
},
|
|
}
|
|
schema := &schemapb.CollectionSchema{
|
|
Name: collectionName,
|
|
Fields: []*schemapb.FieldSchema{
|
|
{
|
|
DataType: schemapb.DataType_BinaryVector,
|
|
DefaultValue: &schemapb.ValueField{
|
|
Data: &schemapb.ValueField_BoolData{
|
|
BoolData: false,
|
|
},
|
|
},
|
|
},
|
|
},
|
|
}
|
|
err := task.validateSchema(context.TODO(), schema)
|
|
assert.ErrorIs(t, err, merr.ErrParameterInvalid)
|
|
|
|
schema1 := &schemapb.CollectionSchema{
|
|
Name: collectionName,
|
|
Fields: []*schemapb.FieldSchema{
|
|
{
|
|
DataType: schemapb.DataType_Int16,
|
|
DefaultValue: &schemapb.ValueField{
|
|
Data: &schemapb.ValueField_BoolData{
|
|
BoolData: false,
|
|
},
|
|
},
|
|
},
|
|
},
|
|
}
|
|
err1 := task.validateSchema(context.TODO(), schema1)
|
|
assert.ErrorIs(t, err1, merr.ErrParameterInvalid)
|
|
|
|
schema2 := &schemapb.CollectionSchema{
|
|
Name: collectionName,
|
|
Fields: []*schemapb.FieldSchema{
|
|
{
|
|
DataType: schemapb.DataType_Bool,
|
|
DefaultValue: &schemapb.ValueField{
|
|
Data: &schemapb.ValueField_IntData{
|
|
IntData: 1,
|
|
},
|
|
},
|
|
},
|
|
},
|
|
}
|
|
err2 := task.validateSchema(context.TODO(), schema2)
|
|
assert.ErrorIs(t, err2, merr.ErrParameterInvalid)
|
|
|
|
schema3 := &schemapb.CollectionSchema{
|
|
Name: collectionName,
|
|
Fields: []*schemapb.FieldSchema{
|
|
{
|
|
DataType: schemapb.DataType_Bool,
|
|
DefaultValue: &schemapb.ValueField{
|
|
Data: &schemapb.ValueField_LongData{
|
|
LongData: 1,
|
|
},
|
|
},
|
|
},
|
|
},
|
|
}
|
|
err3 := task.validateSchema(context.TODO(), schema3)
|
|
assert.ErrorIs(t, err3, merr.ErrParameterInvalid)
|
|
|
|
schema4 := &schemapb.CollectionSchema{
|
|
Name: collectionName,
|
|
Fields: []*schemapb.FieldSchema{
|
|
{
|
|
DataType: schemapb.DataType_Bool,
|
|
DefaultValue: &schemapb.ValueField{
|
|
Data: &schemapb.ValueField_FloatData{
|
|
FloatData: 1,
|
|
},
|
|
},
|
|
},
|
|
},
|
|
}
|
|
err4 := task.validateSchema(context.TODO(), schema4)
|
|
assert.ErrorIs(t, err4, merr.ErrParameterInvalid)
|
|
|
|
schema5 := &schemapb.CollectionSchema{
|
|
Name: collectionName,
|
|
Fields: []*schemapb.FieldSchema{
|
|
{
|
|
DataType: schemapb.DataType_Bool,
|
|
DefaultValue: &schemapb.ValueField{
|
|
Data: &schemapb.ValueField_DoubleData{
|
|
DoubleData: 1,
|
|
},
|
|
},
|
|
},
|
|
},
|
|
}
|
|
err5 := task.validateSchema(context.TODO(), schema5)
|
|
assert.ErrorIs(t, err5, merr.ErrParameterInvalid)
|
|
|
|
schema6 := &schemapb.CollectionSchema{
|
|
Name: collectionName,
|
|
Fields: []*schemapb.FieldSchema{
|
|
{
|
|
DataType: schemapb.DataType_Bool,
|
|
DefaultValue: &schemapb.ValueField{
|
|
Data: &schemapb.ValueField_StringData{
|
|
StringData: "a",
|
|
},
|
|
},
|
|
},
|
|
},
|
|
}
|
|
err6 := task.validateSchema(context.TODO(), schema6)
|
|
assert.ErrorIs(t, err6, merr.ErrParameterInvalid)
|
|
|
|
schema7 := &schemapb.CollectionSchema{
|
|
Name: collectionName,
|
|
Fields: []*schemapb.FieldSchema{
|
|
{
|
|
DataType: schemapb.DataType_Int16,
|
|
DefaultValue: &schemapb.ValueField{
|
|
Data: &schemapb.ValueField_IntData{
|
|
IntData: math.MaxInt32,
|
|
},
|
|
},
|
|
},
|
|
},
|
|
}
|
|
err7 := task.validateSchema(context.TODO(), schema7)
|
|
assert.ErrorIs(t, err7, merr.ErrParameterInvalid)
|
|
|
|
schema8 := &schemapb.CollectionSchema{
|
|
Name: collectionName,
|
|
Fields: []*schemapb.FieldSchema{
|
|
{
|
|
DataType: schemapb.DataType_Int8,
|
|
DefaultValue: &schemapb.ValueField{
|
|
Data: &schemapb.ValueField_IntData{
|
|
IntData: math.MaxInt32,
|
|
},
|
|
},
|
|
},
|
|
},
|
|
}
|
|
err8 := task.validateSchema(context.TODO(), schema8)
|
|
assert.ErrorIs(t, err8, merr.ErrParameterInvalid)
|
|
})
|
|
|
|
t.Run("default value length exceeds", func(t *testing.T) {
|
|
collectionName := funcutil.GenRandomStr()
|
|
task := createCollectionTask{
|
|
Req: &milvuspb.CreateCollectionRequest{
|
|
Base: &commonpb.MsgBase{MsgType: commonpb.MsgType_CreateCollection},
|
|
CollectionName: collectionName,
|
|
},
|
|
}
|
|
schema := &schemapb.CollectionSchema{
|
|
Name: collectionName,
|
|
Fields: []*schemapb.FieldSchema{
|
|
{
|
|
DataType: schemapb.DataType_VarChar,
|
|
TypeParams: []*commonpb.KeyValuePair{
|
|
{
|
|
Key: common.MaxLengthKey,
|
|
Value: "2",
|
|
},
|
|
},
|
|
DefaultValue: &schemapb.ValueField{
|
|
Data: &schemapb.ValueField_StringData{
|
|
StringData: "abc",
|
|
},
|
|
},
|
|
},
|
|
},
|
|
}
|
|
err := task.validateSchema(context.TODO(), schema)
|
|
assert.ErrorIs(t, err, merr.ErrParameterInvalid)
|
|
})
|
|
|
|
t.Run("duplicate_type_params", func(t *testing.T) {
|
|
collectionName := funcutil.GenRandomStr()
|
|
task := createCollectionTask{
|
|
Req: &milvuspb.CreateCollectionRequest{
|
|
Base: &commonpb.MsgBase{MsgType: commonpb.MsgType_CreateCollection},
|
|
CollectionName: collectionName,
|
|
},
|
|
}
|
|
schema := &schemapb.CollectionSchema{
|
|
Name: collectionName,
|
|
Fields: []*schemapb.FieldSchema{
|
|
{
|
|
DataType: schemapb.DataType_VarChar,
|
|
TypeParams: []*commonpb.KeyValuePair{
|
|
{
|
|
Key: common.MaxLengthKey,
|
|
Value: "256",
|
|
},
|
|
{
|
|
Key: common.MmapEnabledKey,
|
|
Value: "true",
|
|
},
|
|
{
|
|
Key: common.MmapEnabledKey,
|
|
Value: "True",
|
|
},
|
|
},
|
|
},
|
|
},
|
|
}
|
|
err := task.validateSchema(context.TODO(), schema)
|
|
assert.ErrorIs(t, err, merr.ErrParameterInvalid)
|
|
})
|
|
|
|
t.Run("duplicate_index_params", func(t *testing.T) {
|
|
collectionName := funcutil.GenRandomStr()
|
|
task := createCollectionTask{
|
|
Req: &milvuspb.CreateCollectionRequest{
|
|
Base: &commonpb.MsgBase{MsgType: commonpb.MsgType_CreateCollection},
|
|
CollectionName: collectionName,
|
|
},
|
|
}
|
|
schema := &schemapb.CollectionSchema{
|
|
Name: collectionName,
|
|
Fields: []*schemapb.FieldSchema{
|
|
{
|
|
DataType: schemapb.DataType_FloatVector,
|
|
TypeParams: []*commonpb.KeyValuePair{
|
|
{
|
|
Key: common.DimKey,
|
|
Value: "256",
|
|
},
|
|
},
|
|
IndexParams: []*commonpb.KeyValuePair{
|
|
{Key: common.MetricTypeKey, Value: "L2"},
|
|
{Key: common.MetricTypeKey, Value: "IP"},
|
|
},
|
|
},
|
|
},
|
|
}
|
|
err := task.validateSchema(context.TODO(), schema)
|
|
assert.ErrorIs(t, err, merr.ErrParameterInvalid)
|
|
})
|
|
|
|
t.Run("normal case", func(t *testing.T) {
|
|
collectionName := funcutil.GenRandomStr()
|
|
task := createCollectionTask{
|
|
Req: &milvuspb.CreateCollectionRequest{
|
|
Base: &commonpb.MsgBase{MsgType: commonpb.MsgType_CreateCollection},
|
|
CollectionName: collectionName,
|
|
},
|
|
}
|
|
schema := &schemapb.CollectionSchema{
|
|
Name: collectionName,
|
|
Fields: []*schemapb.FieldSchema{},
|
|
}
|
|
err := task.validateSchema(context.TODO(), schema)
|
|
assert.NoError(t, err)
|
|
})
|
|
|
|
t.Run("struct array field - empty fields", func(t *testing.T) {
|
|
collectionName := funcutil.GenRandomStr()
|
|
task := createCollectionTask{
|
|
Req: &milvuspb.CreateCollectionRequest{
|
|
Base: &commonpb.MsgBase{MsgType: commonpb.MsgType_CreateCollection},
|
|
CollectionName: collectionName,
|
|
},
|
|
}
|
|
schema := &schemapb.CollectionSchema{
|
|
Name: collectionName,
|
|
StructArrayFields: []*schemapb.StructArrayFieldSchema{
|
|
{
|
|
Name: "struct_field",
|
|
Fields: []*schemapb.FieldSchema{},
|
|
},
|
|
},
|
|
}
|
|
err := task.validateSchema(context.TODO(), schema)
|
|
assert.Error(t, err)
|
|
assert.Contains(t, err.Error(), "empty fields in StructArrayField")
|
|
})
|
|
|
|
t.Run("struct array field - vector type with nullable", func(t *testing.T) {
|
|
collectionName := funcutil.GenRandomStr()
|
|
task := createCollectionTask{
|
|
Req: &milvuspb.CreateCollectionRequest{
|
|
Base: &commonpb.MsgBase{MsgType: commonpb.MsgType_CreateCollection},
|
|
CollectionName: collectionName,
|
|
},
|
|
}
|
|
schema := &schemapb.CollectionSchema{
|
|
Name: collectionName,
|
|
StructArrayFields: []*schemapb.StructArrayFieldSchema{
|
|
{
|
|
Name: "struct_field",
|
|
Fields: []*schemapb.FieldSchema{
|
|
{
|
|
Name: "vector_array_field",
|
|
DataType: schemapb.DataType_ArrayOfVector,
|
|
ElementType: schemapb.DataType_FloatVector,
|
|
Nullable: true,
|
|
},
|
|
},
|
|
},
|
|
},
|
|
}
|
|
err := task.validateSchema(context.TODO(), schema)
|
|
assert.Error(t, err)
|
|
assert.Contains(t, err.Error(), "vector type not support null")
|
|
})
|
|
|
|
t.Run("struct array field - field with default value", func(t *testing.T) {
|
|
collectionName := funcutil.GenRandomStr()
|
|
task := createCollectionTask{
|
|
Req: &milvuspb.CreateCollectionRequest{
|
|
Base: &commonpb.MsgBase{MsgType: commonpb.MsgType_CreateCollection},
|
|
CollectionName: collectionName,
|
|
},
|
|
}
|
|
schema := &schemapb.CollectionSchema{
|
|
Name: collectionName,
|
|
StructArrayFields: []*schemapb.StructArrayFieldSchema{
|
|
{
|
|
Name: "struct_field",
|
|
Fields: []*schemapb.FieldSchema{
|
|
{
|
|
Name: "array_field",
|
|
DataType: schemapb.DataType_Array,
|
|
ElementType: schemapb.DataType_Int32,
|
|
DefaultValue: &schemapb.ValueField{
|
|
Data: &schemapb.ValueField_IntData{
|
|
IntData: 1,
|
|
},
|
|
},
|
|
},
|
|
},
|
|
},
|
|
},
|
|
}
|
|
err := task.validateSchema(context.TODO(), schema)
|
|
assert.Error(t, err)
|
|
assert.Contains(t, err.Error(), "fields in struct array field not support default_value")
|
|
})
|
|
|
|
t.Run("struct array field - duplicate type params", func(t *testing.T) {
|
|
collectionName := funcutil.GenRandomStr()
|
|
task := createCollectionTask{
|
|
Req: &milvuspb.CreateCollectionRequest{
|
|
Base: &commonpb.MsgBase{MsgType: commonpb.MsgType_CreateCollection},
|
|
CollectionName: collectionName,
|
|
},
|
|
}
|
|
schema := &schemapb.CollectionSchema{
|
|
Name: collectionName,
|
|
StructArrayFields: []*schemapb.StructArrayFieldSchema{
|
|
{
|
|
Name: "struct_field",
|
|
Fields: []*schemapb.FieldSchema{
|
|
{
|
|
Name: "array_field",
|
|
DataType: schemapb.DataType_Array,
|
|
ElementType: schemapb.DataType_VarChar,
|
|
TypeParams: []*commonpb.KeyValuePair{
|
|
{Key: common.MaxLengthKey, Value: "100"},
|
|
{Key: common.MaxLengthKey, Value: "200"},
|
|
},
|
|
},
|
|
},
|
|
},
|
|
},
|
|
}
|
|
err := task.validateSchema(context.TODO(), schema)
|
|
assert.Error(t, err)
|
|
assert.Contains(t, err.Error(), "duplicated type param key")
|
|
})
|
|
|
|
t.Run("struct array field - duplicate index params", func(t *testing.T) {
|
|
collectionName := funcutil.GenRandomStr()
|
|
task := createCollectionTask{
|
|
Req: &milvuspb.CreateCollectionRequest{
|
|
Base: &commonpb.MsgBase{MsgType: commonpb.MsgType_CreateCollection},
|
|
CollectionName: collectionName,
|
|
},
|
|
}
|
|
schema := &schemapb.CollectionSchema{
|
|
Name: collectionName,
|
|
StructArrayFields: []*schemapb.StructArrayFieldSchema{
|
|
{
|
|
Name: "struct_field",
|
|
Fields: []*schemapb.FieldSchema{
|
|
{
|
|
Name: "vector_array_field",
|
|
DataType: schemapb.DataType_ArrayOfVector,
|
|
ElementType: schemapb.DataType_FloatVector,
|
|
IndexParams: []*commonpb.KeyValuePair{
|
|
{Key: common.MetricTypeKey, Value: "L2"},
|
|
{Key: common.MetricTypeKey, Value: "IP"},
|
|
},
|
|
},
|
|
},
|
|
},
|
|
},
|
|
}
|
|
err := task.validateSchema(context.TODO(), schema)
|
|
assert.Error(t, err)
|
|
assert.Contains(t, err.Error(), "duplicated index param key")
|
|
})
|
|
|
|
t.Run("struct array field - invalid data type", func(t *testing.T) {
|
|
collectionName := funcutil.GenRandomStr()
|
|
task := createCollectionTask{
|
|
Req: &milvuspb.CreateCollectionRequest{
|
|
Base: &commonpb.MsgBase{MsgType: commonpb.MsgType_CreateCollection},
|
|
CollectionName: collectionName,
|
|
},
|
|
}
|
|
schema := &schemapb.CollectionSchema{
|
|
Name: collectionName,
|
|
StructArrayFields: []*schemapb.StructArrayFieldSchema{
|
|
{
|
|
Name: "struct_field",
|
|
Fields: []*schemapb.FieldSchema{
|
|
{
|
|
Name: "invalid_field",
|
|
DataType: schemapb.DataType_Int64,
|
|
ElementType: schemapb.DataType_Int64,
|
|
},
|
|
},
|
|
},
|
|
},
|
|
}
|
|
err := task.validateSchema(context.TODO(), schema)
|
|
assert.Error(t, err)
|
|
assert.Contains(t, err.Error(), "Fields in StructArrayField can only be array or array of vector")
|
|
})
|
|
|
|
t.Run("struct array field - nested array", func(t *testing.T) {
|
|
collectionName := funcutil.GenRandomStr()
|
|
task := createCollectionTask{
|
|
Req: &milvuspb.CreateCollectionRequest{
|
|
Base: &commonpb.MsgBase{MsgType: commonpb.MsgType_CreateCollection},
|
|
CollectionName: collectionName,
|
|
},
|
|
}
|
|
schema := &schemapb.CollectionSchema{
|
|
Name: collectionName,
|
|
StructArrayFields: []*schemapb.StructArrayFieldSchema{
|
|
{
|
|
Name: "struct_field",
|
|
Fields: []*schemapb.FieldSchema{
|
|
{
|
|
Name: "nested_array",
|
|
DataType: schemapb.DataType_Array,
|
|
ElementType: schemapb.DataType_Array,
|
|
},
|
|
},
|
|
},
|
|
},
|
|
}
|
|
err := task.validateSchema(context.TODO(), schema)
|
|
assert.Error(t, err)
|
|
assert.Contains(t, err.Error(), "Nested array is not supported")
|
|
})
|
|
|
|
t.Run("struct array field - invalid element type", func(t *testing.T) {
|
|
collectionName := funcutil.GenRandomStr()
|
|
task := createCollectionTask{
|
|
Req: &milvuspb.CreateCollectionRequest{
|
|
Base: &commonpb.MsgBase{MsgType: commonpb.MsgType_CreateCollection},
|
|
CollectionName: collectionName,
|
|
},
|
|
}
|
|
schema := &schemapb.CollectionSchema{
|
|
Name: collectionName,
|
|
StructArrayFields: []*schemapb.StructArrayFieldSchema{
|
|
{
|
|
Name: "struct_field",
|
|
Fields: []*schemapb.FieldSchema{
|
|
{
|
|
Name: "array_field",
|
|
DataType: schemapb.DataType_Array,
|
|
ElementType: schemapb.DataType_None,
|
|
},
|
|
},
|
|
},
|
|
},
|
|
}
|
|
err := task.validateSchema(context.TODO(), schema)
|
|
assert.Error(t, err)
|
|
assert.Contains(t, err.Error(), "field data type: None is not supported")
|
|
})
|
|
|
|
t.Run("struct array field - valid case", func(t *testing.T) {
|
|
collectionName := funcutil.GenRandomStr()
|
|
task := createCollectionTask{
|
|
Req: &milvuspb.CreateCollectionRequest{
|
|
Base: &commonpb.MsgBase{MsgType: commonpb.MsgType_CreateCollection},
|
|
CollectionName: collectionName,
|
|
},
|
|
}
|
|
schema := &schemapb.CollectionSchema{
|
|
Name: collectionName,
|
|
StructArrayFields: []*schemapb.StructArrayFieldSchema{
|
|
{
|
|
Name: "struct_field",
|
|
Fields: []*schemapb.FieldSchema{
|
|
{
|
|
Name: "text_array",
|
|
DataType: schemapb.DataType_Array,
|
|
ElementType: schemapb.DataType_VarChar,
|
|
TypeParams: []*commonpb.KeyValuePair{
|
|
{Key: common.MaxLengthKey, Value: "100"},
|
|
},
|
|
},
|
|
{
|
|
Name: "int_array",
|
|
DataType: schemapb.DataType_Array,
|
|
ElementType: schemapb.DataType_Int32,
|
|
},
|
|
{
|
|
Name: "vector_array",
|
|
DataType: schemapb.DataType_ArrayOfVector,
|
|
ElementType: schemapb.DataType_FloatVector,
|
|
TypeParams: []*commonpb.KeyValuePair{
|
|
{Key: common.DimKey, Value: "128"},
|
|
},
|
|
},
|
|
},
|
|
},
|
|
},
|
|
}
|
|
err := task.validateSchema(context.TODO(), schema)
|
|
assert.NoError(t, err)
|
|
})
|
|
}
|
|
|
|
func Test_createCollectionTask_prepareSchema(t *testing.T) {
|
|
t.Run("failed to unmarshal", func(t *testing.T) {
|
|
collectionName := funcutil.GenRandomStr()
|
|
task := createCollectionTask{
|
|
Req: &milvuspb.CreateCollectionRequest{
|
|
Base: &commonpb.MsgBase{MsgType: commonpb.MsgType_CreateCollection},
|
|
CollectionName: collectionName,
|
|
Schema: []byte("invalid schema"),
|
|
},
|
|
}
|
|
err := task.prepareSchema(context.TODO())
|
|
assert.Error(t, err)
|
|
})
|
|
|
|
t.Run("contain system fields", func(t *testing.T) {
|
|
collectionName := funcutil.GenRandomStr()
|
|
schema := &schemapb.CollectionSchema{
|
|
Name: collectionName,
|
|
Description: "",
|
|
AutoID: false,
|
|
Fields: []*schemapb.FieldSchema{
|
|
{Name: TimeStampFieldName},
|
|
},
|
|
}
|
|
marshaledSchema, err := proto.Marshal(schema)
|
|
assert.NoError(t, err)
|
|
task := createCollectionTask{
|
|
Req: &milvuspb.CreateCollectionRequest{
|
|
Base: &commonpb.MsgBase{MsgType: commonpb.MsgType_CreateCollection},
|
|
CollectionName: collectionName,
|
|
Schema: marshaledSchema,
|
|
},
|
|
}
|
|
err = task.prepareSchema(context.TODO())
|
|
assert.Error(t, err)
|
|
})
|
|
|
|
t.Run("normal case", func(t *testing.T) {
|
|
collectionName := funcutil.GenRandomStr()
|
|
field1 := funcutil.GenRandomStr()
|
|
schema := &schemapb.CollectionSchema{
|
|
Name: collectionName,
|
|
Description: "",
|
|
AutoID: false,
|
|
Fields: []*schemapb.FieldSchema{
|
|
{
|
|
Name: field1,
|
|
DataType: schemapb.DataType_Int64,
|
|
},
|
|
},
|
|
}
|
|
marshaledSchema, err := proto.Marshal(schema)
|
|
assert.NoError(t, err)
|
|
task := createCollectionTask{
|
|
Req: &milvuspb.CreateCollectionRequest{
|
|
Base: &commonpb.MsgBase{MsgType: commonpb.MsgType_CreateCollection},
|
|
CollectionName: collectionName,
|
|
Schema: marshaledSchema,
|
|
},
|
|
}
|
|
err = task.prepareSchema(context.TODO())
|
|
assert.NoError(t, err)
|
|
})
|
|
|
|
t.Run("invalid data type", func(t *testing.T) {
|
|
collectionName := funcutil.GenRandomStr()
|
|
field1 := funcutil.GenRandomStr()
|
|
schema := &schemapb.CollectionSchema{
|
|
Name: collectionName,
|
|
Description: "",
|
|
AutoID: false,
|
|
Fields: []*schemapb.FieldSchema{
|
|
{
|
|
Name: field1,
|
|
DataType: 300,
|
|
},
|
|
},
|
|
}
|
|
marshaledSchema, err := proto.Marshal(schema)
|
|
assert.NoError(t, err)
|
|
task := createCollectionTask{
|
|
Req: &milvuspb.CreateCollectionRequest{
|
|
Base: &commonpb.MsgBase{MsgType: commonpb.MsgType_CreateCollection},
|
|
CollectionName: collectionName,
|
|
Schema: marshaledSchema,
|
|
},
|
|
}
|
|
err = task.prepareSchema(context.TODO())
|
|
assert.Error(t, err)
|
|
})
|
|
|
|
t.Run("vector type not support null", func(t *testing.T) {
|
|
collectionName := funcutil.GenRandomStr()
|
|
field1 := funcutil.GenRandomStr()
|
|
schema := &schemapb.CollectionSchema{
|
|
Name: collectionName,
|
|
Description: "",
|
|
AutoID: false,
|
|
Fields: []*schemapb.FieldSchema{
|
|
{
|
|
Name: field1,
|
|
DataType: 101,
|
|
Nullable: true,
|
|
},
|
|
},
|
|
}
|
|
marshaledSchema, err := proto.Marshal(schema)
|
|
assert.NoError(t, err)
|
|
task := createCollectionTask{
|
|
Req: &milvuspb.CreateCollectionRequest{
|
|
Base: &commonpb.MsgBase{MsgType: commonpb.MsgType_CreateCollection},
|
|
CollectionName: collectionName,
|
|
Schema: marshaledSchema,
|
|
},
|
|
}
|
|
err = task.prepareSchema(context.TODO())
|
|
assert.Error(t, err)
|
|
})
|
|
}
|
|
|
|
func Test_createCollectionTask_Prepare(t *testing.T) {
|
|
paramtable.Init()
|
|
meta := mockrootcoord.NewIMetaTable(t)
|
|
meta.On("GetDatabaseByName",
|
|
mock.Anything,
|
|
mock.Anything,
|
|
mock.Anything,
|
|
).Return(model.NewDefaultDatabase(nil), nil)
|
|
meta.On("ListAllAvailCollections",
|
|
mock.Anything,
|
|
).Return(map[int64][]int64{
|
|
util.DefaultDBID: {1, 2},
|
|
}, nil)
|
|
meta.EXPECT().GetGeneralCount(mock.Anything).Return(0)
|
|
|
|
paramtable.Get().Save(Params.QuotaConfig.MaxCollectionNum.Key, strconv.Itoa(math.MaxInt64))
|
|
defer paramtable.Get().Reset(Params.QuotaConfig.MaxCollectionNum.Key)
|
|
|
|
paramtable.Get().Save(Params.QuotaConfig.MaxCollectionNumPerDB.Key, strconv.Itoa(math.MaxInt64))
|
|
defer paramtable.Get().Reset(Params.QuotaConfig.MaxCollectionNumPerDB.Key)
|
|
|
|
t.Run("invalid msg type", func(t *testing.T) {
|
|
core := newTestCore(withMeta(meta))
|
|
task := &createCollectionTask{
|
|
baseTask: newBaseTask(context.TODO(), core),
|
|
Req: &milvuspb.CreateCollectionRequest{
|
|
Base: &commonpb.MsgBase{MsgType: commonpb.MsgType_DropCollection},
|
|
},
|
|
}
|
|
err := task.Prepare(context.Background())
|
|
assert.Error(t, err)
|
|
})
|
|
|
|
t.Run("invalid schema", func(t *testing.T) {
|
|
core := newTestCore(withMeta(meta))
|
|
collectionName := funcutil.GenRandomStr()
|
|
task := &createCollectionTask{
|
|
baseTask: newBaseTask(context.TODO(), core),
|
|
Req: &milvuspb.CreateCollectionRequest{
|
|
Base: &commonpb.MsgBase{MsgType: commonpb.MsgType_CreateCollection},
|
|
CollectionName: collectionName,
|
|
Schema: []byte("invalid schema"),
|
|
},
|
|
dbID: 1,
|
|
}
|
|
err := task.Prepare(context.Background())
|
|
assert.Error(t, err)
|
|
})
|
|
|
|
t.Run("failed to assign id", func(t *testing.T) {
|
|
collectionName := funcutil.GenRandomStr()
|
|
field1 := funcutil.GenRandomStr()
|
|
schema := &schemapb.CollectionSchema{
|
|
Name: collectionName,
|
|
Description: "",
|
|
AutoID: false,
|
|
Fields: []*schemapb.FieldSchema{
|
|
{Name: field1},
|
|
},
|
|
}
|
|
marshaledSchema, err := proto.Marshal(schema)
|
|
assert.NoError(t, err)
|
|
core := newTestCore(withInvalidIDAllocator(), withMeta(meta))
|
|
|
|
task := createCollectionTask{
|
|
baseTask: newBaseTask(context.Background(), core),
|
|
Req: &milvuspb.CreateCollectionRequest{
|
|
Base: &commonpb.MsgBase{MsgType: commonpb.MsgType_CreateCollection},
|
|
CollectionName: collectionName,
|
|
Schema: marshaledSchema,
|
|
},
|
|
dbID: 1,
|
|
}
|
|
err = task.Prepare(context.Background())
|
|
assert.Error(t, err)
|
|
})
|
|
|
|
t.Run("normal case", func(t *testing.T) {
|
|
defer cleanTestEnv()
|
|
|
|
collectionName := funcutil.GenRandomStr()
|
|
field1 := funcutil.GenRandomStr()
|
|
|
|
ticker := newRocksMqTtSynchronizer()
|
|
|
|
core := newTestCore(withValidIDAllocator(), withTtSynchronizer(ticker), withMeta(meta))
|
|
|
|
schema := &schemapb.CollectionSchema{
|
|
Name: collectionName,
|
|
Description: "",
|
|
AutoID: false,
|
|
Fields: []*schemapb.FieldSchema{
|
|
{
|
|
Name: field1,
|
|
DataType: schemapb.DataType_Int64,
|
|
},
|
|
},
|
|
}
|
|
marshaledSchema, err := proto.Marshal(schema)
|
|
assert.NoError(t, err)
|
|
|
|
task := createCollectionTask{
|
|
baseTask: newBaseTask(context.Background(), core),
|
|
Req: &milvuspb.CreateCollectionRequest{
|
|
Base: &commonpb.MsgBase{MsgType: commonpb.MsgType_CreateCollection},
|
|
CollectionName: collectionName,
|
|
Schema: marshaledSchema,
|
|
},
|
|
dbID: 1,
|
|
}
|
|
task.Req.ShardsNum = int32(Params.RootCoordCfg.DmlChannelNum.GetAsInt() + 1) // no enough channels.
|
|
err = task.Prepare(context.Background())
|
|
assert.Error(t, err)
|
|
task.Req.ShardsNum = common.DefaultShardsNum
|
|
err = task.Prepare(context.Background())
|
|
assert.NoError(t, err)
|
|
})
|
|
}
|
|
|
|
func TestCreateCollectionTask_Prepare_WithProperty(t *testing.T) {
|
|
paramtable.Init()
|
|
meta := mockrootcoord.NewIMetaTable(t)
|
|
t.Run("with db properties", func(t *testing.T) {
|
|
meta.EXPECT().GetDatabaseByName(mock.Anything, mock.Anything, mock.Anything).Return(&model.Database{
|
|
Name: "foo",
|
|
ID: 1,
|
|
Properties: []*commonpb.KeyValuePair{
|
|
{
|
|
Key: common.ReplicateIDKey,
|
|
Value: "local-test",
|
|
},
|
|
},
|
|
}, nil).Twice()
|
|
meta.EXPECT().ListAllAvailCollections(mock.Anything).Return(map[int64][]int64{
|
|
util.DefaultDBID: {1, 2},
|
|
}).Once()
|
|
meta.EXPECT().GetGeneralCount(mock.Anything).Return(0).Once()
|
|
|
|
defer cleanTestEnv()
|
|
|
|
collectionName := funcutil.GenRandomStr()
|
|
field1 := funcutil.GenRandomStr()
|
|
|
|
ticker := newRocksMqTtSynchronizer()
|
|
core := newTestCore(withValidIDAllocator(), withTtSynchronizer(ticker), withMeta(meta))
|
|
|
|
schema := &schemapb.CollectionSchema{
|
|
Name: collectionName,
|
|
Description: "",
|
|
AutoID: false,
|
|
Fields: []*schemapb.FieldSchema{
|
|
{
|
|
Name: field1,
|
|
DataType: schemapb.DataType_Int64,
|
|
},
|
|
},
|
|
}
|
|
marshaledSchema, err := proto.Marshal(schema)
|
|
assert.NoError(t, err)
|
|
|
|
task := createCollectionTask{
|
|
baseTask: newBaseTask(context.Background(), core),
|
|
Req: &milvuspb.CreateCollectionRequest{
|
|
Base: &commonpb.MsgBase{MsgType: commonpb.MsgType_CreateCollection},
|
|
CollectionName: collectionName,
|
|
Schema: marshaledSchema,
|
|
Properties: []*commonpb.KeyValuePair{
|
|
{
|
|
Key: common.ReplicateIDKey,
|
|
Value: "hoo",
|
|
},
|
|
},
|
|
},
|
|
dbID: 1,
|
|
}
|
|
task.Req.ShardsNum = common.DefaultShardsNum
|
|
err = task.Prepare(context.Background())
|
|
assert.Len(t, task.dbProperties, 1)
|
|
assert.Len(t, task.Req.Properties, 1)
|
|
assert.NoError(t, err)
|
|
})
|
|
}
|
|
|
|
func Test_createCollectionTask_Execute(t *testing.T) {
|
|
t.Run("add same collection with different parameters", func(t *testing.T) {
|
|
defer cleanTestEnv()
|
|
ticker := newRocksMqTtSynchronizer()
|
|
|
|
collectionName := funcutil.GenRandomStr()
|
|
field1 := funcutil.GenRandomStr()
|
|
coll := &model.Collection{Name: collectionName}
|
|
|
|
meta := mockrootcoord.NewIMetaTable(t)
|
|
meta.On("GetCollectionByName",
|
|
mock.Anything,
|
|
mock.Anything,
|
|
mock.Anything,
|
|
mock.Anything,
|
|
).Return(coll, nil)
|
|
meta.EXPECT().DescribeAlias(mock.Anything, mock.Anything, mock.Anything, mock.Anything).
|
|
Return("", merr.WrapErrAliasNotFound("", ""))
|
|
|
|
core := newTestCore(withMeta(meta), withTtSynchronizer(ticker))
|
|
|
|
task := &createCollectionTask{
|
|
baseTask: newBaseTask(context.Background(), core),
|
|
Req: &milvuspb.CreateCollectionRequest{
|
|
Base: &commonpb.MsgBase{MsgType: commonpb.MsgType_CreateCollection},
|
|
CollectionName: collectionName,
|
|
},
|
|
schema: &schemapb.CollectionSchema{Name: collectionName, Fields: []*schemapb.FieldSchema{{Name: field1}}},
|
|
}
|
|
|
|
err := task.Execute(context.Background())
|
|
assert.Error(t, err)
|
|
})
|
|
|
|
t.Run("add duplicate collection", func(t *testing.T) {
|
|
defer cleanTestEnv()
|
|
ticker := newRocksMqTtSynchronizer()
|
|
shardNum := 2
|
|
pchans := ticker.getDmlChannelNames(shardNum)
|
|
|
|
collectionName := funcutil.GenRandomStr()
|
|
field1 := funcutil.GenRandomStr()
|
|
collID := UniqueID(1)
|
|
schema := &schemapb.CollectionSchema{Name: collectionName, Fields: []*schemapb.FieldSchema{{Name: field1}}}
|
|
channels := collectionChannels{
|
|
virtualChannels: []string{funcutil.GenRandomStr(), funcutil.GenRandomStr()},
|
|
physicalChannels: pchans,
|
|
}
|
|
coll := &model.Collection{
|
|
CollectionID: collID,
|
|
Name: schema.Name,
|
|
Description: schema.Description,
|
|
AutoID: schema.AutoID,
|
|
Fields: model.UnmarshalFieldModels(schema.GetFields()),
|
|
StructArrayFields: model.UnmarshalStructArrayFieldModels(schema.GetStructArrayFields()),
|
|
VirtualChannelNames: channels.virtualChannels,
|
|
PhysicalChannelNames: channels.physicalChannels,
|
|
}
|
|
|
|
meta := mockrootcoord.NewIMetaTable(t)
|
|
meta.On("GetCollectionByName",
|
|
mock.Anything,
|
|
mock.Anything,
|
|
mock.Anything,
|
|
mock.Anything,
|
|
).Return(coll, nil)
|
|
meta.EXPECT().DescribeAlias(mock.Anything, mock.Anything, mock.Anything, mock.Anything).
|
|
Return("", merr.WrapErrAliasNotFound("", ""))
|
|
|
|
core := newTestCore(withMeta(meta), withTtSynchronizer(ticker))
|
|
|
|
task := &createCollectionTask{
|
|
baseTask: newBaseTask(context.Background(), core),
|
|
Req: &milvuspb.CreateCollectionRequest{
|
|
Base: &commonpb.MsgBase{MsgType: commonpb.MsgType_CreateCollection},
|
|
CollectionName: collectionName,
|
|
},
|
|
collID: collID,
|
|
schema: schema,
|
|
channels: channels,
|
|
}
|
|
|
|
err := task.Execute(context.Background())
|
|
assert.NoError(t, err)
|
|
})
|
|
|
|
t.Run("failed to get start positions", func(t *testing.T) {
|
|
ticker := newTickerWithMockFailStream()
|
|
shardNum := 2
|
|
pchans := ticker.getDmlChannelNames(shardNum)
|
|
meta := mockrootcoord.NewIMetaTable(t)
|
|
meta.EXPECT().GetCollectionByName(mock.Anything, mock.Anything, mock.Anything, mock.Anything).
|
|
Return(nil, errors.New("error mock GetCollectionByName"))
|
|
meta.EXPECT().DescribeAlias(mock.Anything, mock.Anything, mock.Anything, mock.Anything).
|
|
Return("", merr.WrapErrAliasNotFound("", ""))
|
|
core := newTestCore(withTtSynchronizer(ticker), withMeta(meta))
|
|
schema := &schemapb.CollectionSchema{Name: "", Fields: []*schemapb.FieldSchema{{}}}
|
|
task := &createCollectionTask{
|
|
baseTask: newBaseTask(context.Background(), core),
|
|
channels: collectionChannels{
|
|
physicalChannels: pchans,
|
|
virtualChannels: []string{funcutil.GenRandomStr(), funcutil.GenRandomStr()},
|
|
},
|
|
Req: &milvuspb.CreateCollectionRequest{
|
|
Base: &commonpb.MsgBase{MsgType: commonpb.MsgType_CreateCollection},
|
|
CollectionName: "",
|
|
Schema: []byte{},
|
|
ShardsNum: int32(shardNum),
|
|
},
|
|
schema: schema,
|
|
}
|
|
err := task.Execute(context.Background())
|
|
assert.Error(t, err)
|
|
})
|
|
|
|
t.Run("collection name duplicates an alias", func(t *testing.T) {
|
|
defer cleanTestEnv()
|
|
|
|
collectionName := funcutil.GenRandomStr()
|
|
ticker := newRocksMqTtSynchronizer()
|
|
field1 := funcutil.GenRandomStr()
|
|
schema := &schemapb.CollectionSchema{Name: collectionName, Fields: []*schemapb.FieldSchema{{Name: field1}}}
|
|
|
|
meta := mockrootcoord.NewIMetaTable(t)
|
|
// mock collection name duplicates an alias
|
|
meta.EXPECT().DescribeAlias(mock.Anything, mock.Anything, mock.Anything, mock.Anything).
|
|
Return(collectionName, nil)
|
|
|
|
core := newTestCore(withMeta(meta), withTtSynchronizer(ticker))
|
|
task := &createCollectionTask{
|
|
baseTask: newBaseTask(context.Background(), core),
|
|
Req: &milvuspb.CreateCollectionRequest{
|
|
Base: &commonpb.MsgBase{MsgType: commonpb.MsgType_CreateCollection},
|
|
DbName: "mock-db",
|
|
CollectionName: collectionName,
|
|
Properties: []*commonpb.KeyValuePair{
|
|
{
|
|
Key: common.ConsistencyLevel,
|
|
Value: "1",
|
|
},
|
|
},
|
|
},
|
|
schema: schema,
|
|
}
|
|
err := task.Execute(context.Background())
|
|
assert.Error(t, err)
|
|
assert.True(t, strings.Contains(err.Error(), "conflicts with an existing alias"))
|
|
})
|
|
|
|
t.Run("normal case", func(t *testing.T) {
|
|
t.Skip("normal case")
|
|
defer cleanTestEnv()
|
|
|
|
collectionName := funcutil.GenRandomStr()
|
|
field1 := funcutil.GenRandomStr()
|
|
shardNum := 2
|
|
|
|
ticker := newRocksMqTtSynchronizer()
|
|
pchans := ticker.getDmlChannelNames(shardNum)
|
|
|
|
meta := mockrootcoord.NewIMetaTable(t)
|
|
meta.On("GetCollectionByName",
|
|
mock.Anything,
|
|
mock.Anything,
|
|
mock.Anything,
|
|
mock.Anything,
|
|
).Return(nil, errors.New("error mock GetCollectionByName"))
|
|
meta.On("AddCollection",
|
|
mock.Anything,
|
|
mock.Anything,
|
|
).Return(nil)
|
|
meta.On("ChangeCollectionState",
|
|
mock.Anything,
|
|
mock.Anything,
|
|
mock.Anything,
|
|
mock.Anything,
|
|
).Return(nil)
|
|
meta.EXPECT().DescribeAlias(mock.Anything, mock.Anything, mock.Anything, mock.Anything).
|
|
Return("", merr.WrapErrAliasNotFound("", ""))
|
|
|
|
dc := mocks.NewMixCoord(t)
|
|
dc.EXPECT().GetComponentStates(mock.Anything, mock.Anything).Return(
|
|
&milvuspb.ComponentStates{
|
|
State: &milvuspb.ComponentInfo{
|
|
NodeID: TestRootCoordID,
|
|
StateCode: commonpb.StateCode_Healthy,
|
|
},
|
|
SubcomponentStates: nil,
|
|
Status: merr.Success(),
|
|
}, nil)
|
|
dc.EXPECT().WatchChannels(mock.Anything, mock.Anything).Return(
|
|
&datapb.WatchChannelsResponse{Status: merr.Success()}, nil)
|
|
|
|
core := newTestCore(withValidIDAllocator(),
|
|
withMeta(meta),
|
|
withTtSynchronizer(ticker),
|
|
withValidProxyManager(),
|
|
withMixCoord(dc))
|
|
core.broker = newServerBroker(core)
|
|
|
|
schema := &schemapb.CollectionSchema{
|
|
Name: collectionName,
|
|
Description: "",
|
|
AutoID: false,
|
|
Fields: []*schemapb.FieldSchema{
|
|
{Name: field1},
|
|
},
|
|
}
|
|
marshaledSchema, err := proto.Marshal(schema)
|
|
assert.NoError(t, err)
|
|
|
|
task := createCollectionTask{
|
|
baseTask: newBaseTask(context.Background(), core),
|
|
Req: &milvuspb.CreateCollectionRequest{
|
|
Base: &commonpb.MsgBase{MsgType: commonpb.MsgType_CreateCollection},
|
|
DbName: "mock-db",
|
|
CollectionName: collectionName,
|
|
Schema: marshaledSchema,
|
|
ShardsNum: int32(shardNum),
|
|
Properties: []*commonpb.KeyValuePair{
|
|
{
|
|
Key: common.ConsistencyLevel,
|
|
Value: "1",
|
|
},
|
|
},
|
|
},
|
|
channels: collectionChannels{physicalChannels: pchans},
|
|
schema: schema,
|
|
}
|
|
|
|
err = task.Execute(context.Background())
|
|
assert.NoError(t, err)
|
|
})
|
|
|
|
t.Run("partial error, check if undo worked", func(t *testing.T) {
|
|
defer cleanTestEnv()
|
|
|
|
collectionName := funcutil.GenRandomStr()
|
|
field1 := funcutil.GenRandomStr()
|
|
shardNum := 2
|
|
|
|
ticker := newRocksMqTtSynchronizer()
|
|
pchans := ticker.getDmlChannelNames(shardNum)
|
|
|
|
meta := mockrootcoord.NewIMetaTable(t)
|
|
meta.On("GetCollectionByName",
|
|
mock.Anything,
|
|
mock.Anything,
|
|
mock.Anything,
|
|
mock.Anything,
|
|
).Return(nil, errors.New("error mock GetCollectionByName"))
|
|
meta.On("AddCollection",
|
|
mock.Anything,
|
|
mock.Anything,
|
|
).Return(nil)
|
|
meta.On("ChangeCollectionState",
|
|
mock.Anything,
|
|
mock.Anything,
|
|
mock.Anything,
|
|
mock.Anything,
|
|
).Return(errors.New("error mock ChangeCollectionState"))
|
|
meta.EXPECT().DescribeAlias(mock.Anything, mock.Anything, mock.Anything, mock.Anything).
|
|
Return("", merr.WrapErrAliasNotFound("", ""))
|
|
|
|
removeCollectionCalled := false
|
|
removeCollectionChan := make(chan struct{}, 1)
|
|
meta.On("RemoveCollection",
|
|
mock.Anything,
|
|
mock.Anything,
|
|
mock.Anything,
|
|
).Return(func(ctx context.Context, collID UniqueID, ts Timestamp) error {
|
|
removeCollectionCalled = true
|
|
removeCollectionChan <- struct{}{}
|
|
return nil
|
|
})
|
|
|
|
broker := newMockBroker()
|
|
broker.WatchChannelsFunc = func(ctx context.Context, info *watchInfo) error {
|
|
return nil
|
|
}
|
|
|
|
unwatchChannelsCalled := false
|
|
unwatchChannelsChan := make(chan struct{}, 1)
|
|
gc := mockrootcoord.NewGarbageCollector(t)
|
|
gc.On("GcCollectionData",
|
|
mock.Anything, // context.Context
|
|
mock.Anything, // *model.Collection
|
|
).Return(func(ctx context.Context, collection *model.Collection) (ddlTs Timestamp) {
|
|
for _, pchan := range pchans {
|
|
ticker.syncedTtHistogram.update(pchan, 101)
|
|
}
|
|
unwatchChannelsCalled = true
|
|
unwatchChannelsChan <- struct{}{}
|
|
return 100
|
|
}, nil)
|
|
|
|
core := newTestCore(withValidIDAllocator(),
|
|
withMeta(meta),
|
|
withTtSynchronizer(ticker),
|
|
withGarbageCollector(gc),
|
|
withValidProxyManager(),
|
|
withBroker(broker))
|
|
|
|
schema := &schemapb.CollectionSchema{
|
|
Name: collectionName,
|
|
Description: "",
|
|
AutoID: false,
|
|
Fields: []*schemapb.FieldSchema{
|
|
{Name: field1},
|
|
},
|
|
}
|
|
marshaledSchema, err := proto.Marshal(schema)
|
|
assert.NoError(t, err)
|
|
|
|
task := createCollectionTask{
|
|
baseTask: newBaseTask(context.Background(), core),
|
|
Req: &milvuspb.CreateCollectionRequest{
|
|
Base: &commonpb.MsgBase{MsgType: commonpb.MsgType_CreateCollection},
|
|
CollectionName: collectionName,
|
|
Schema: marshaledSchema,
|
|
ShardsNum: int32(shardNum),
|
|
},
|
|
channels: collectionChannels{physicalChannels: pchans},
|
|
schema: schema,
|
|
}
|
|
|
|
err = task.Execute(context.Background())
|
|
assert.Error(t, err)
|
|
|
|
// check if undo worked.
|
|
|
|
// undo watch.
|
|
<-unwatchChannelsChan
|
|
assert.True(t, unwatchChannelsCalled)
|
|
|
|
// undo adding collection.
|
|
<-removeCollectionChan
|
|
assert.True(t, removeCollectionCalled)
|
|
|
|
time.Sleep(time.Second * 2) // wait for asynchronous step done.
|
|
// undo add channels.
|
|
assert.Zero(t, len(ticker.listDmlChannels()))
|
|
})
|
|
}
|
|
|
|
func Test_createCollectionTask_PartitionKey(t *testing.T) {
|
|
paramtable.Init()
|
|
defer cleanTestEnv()
|
|
|
|
collectionName := funcutil.GenRandomStr()
|
|
field1 := funcutil.GenRandomStr()
|
|
ticker := newRocksMqTtSynchronizer()
|
|
|
|
meta := mockrootcoord.NewIMetaTable(t)
|
|
meta.On("GetDatabaseByName",
|
|
mock.Anything,
|
|
mock.Anything,
|
|
mock.Anything,
|
|
).Return(model.NewDefaultDatabase(nil), nil)
|
|
meta.On("ListAllAvailCollections",
|
|
mock.Anything,
|
|
).Return(map[int64][]int64{
|
|
util.DefaultDBID: {1, 2},
|
|
}, nil)
|
|
meta.EXPECT().GetGeneralCount(mock.Anything).Return(0)
|
|
|
|
paramtable.Get().Save(Params.QuotaConfig.MaxCollectionNum.Key, strconv.Itoa(math.MaxInt64))
|
|
defer paramtable.Get().Reset(Params.QuotaConfig.MaxCollectionNum.Key)
|
|
|
|
paramtable.Get().Save(Params.QuotaConfig.MaxCollectionNumPerDB.Key, strconv.Itoa(math.MaxInt64))
|
|
defer paramtable.Get().Reset(Params.QuotaConfig.MaxCollectionNumPerDB.Key)
|
|
|
|
core := newTestCore(withValidIDAllocator(), withTtSynchronizer(ticker), withMeta(meta))
|
|
|
|
partitionKeyField := &schemapb.FieldSchema{
|
|
Name: field1,
|
|
DataType: schemapb.DataType_Int64,
|
|
IsPartitionKey: true,
|
|
}
|
|
|
|
schema := &schemapb.CollectionSchema{
|
|
Name: collectionName,
|
|
Description: "",
|
|
AutoID: false,
|
|
Fields: []*schemapb.FieldSchema{partitionKeyField},
|
|
}
|
|
marshaledSchema, err := proto.Marshal(schema)
|
|
assert.NoError(t, err)
|
|
|
|
task := createCollectionTask{
|
|
baseTask: newBaseTask(context.TODO(), core),
|
|
Req: &milvuspb.CreateCollectionRequest{
|
|
Base: &commonpb.MsgBase{MsgType: commonpb.MsgType_CreateCollection},
|
|
CollectionName: collectionName,
|
|
Schema: marshaledSchema,
|
|
ShardsNum: common.DefaultShardsNum,
|
|
},
|
|
}
|
|
|
|
t.Run("without num partition", func(t *testing.T) {
|
|
task.Req.NumPartitions = 0
|
|
err = task.Prepare(context.Background())
|
|
assert.Error(t, err)
|
|
})
|
|
|
|
t.Run("num partition too large", func(t *testing.T) {
|
|
task.Req.NumPartitions = Params.RootCoordCfg.MaxPartitionNum.GetAsInt64() + 1
|
|
err = task.Prepare(context.Background())
|
|
assert.Error(t, err)
|
|
})
|
|
|
|
task.Req.NumPartitions = common.DefaultPartitionsWithPartitionKey
|
|
|
|
t.Run("normal case", func(t *testing.T) {
|
|
err = task.Prepare(context.Background())
|
|
assert.NoError(t, err)
|
|
})
|
|
}
|
|
|
|
func TestNamespaceProperty(t *testing.T) {
|
|
paramtable.Init()
|
|
paramtable.Get().CommonCfg.EnableNamespace.SwapTempValue("true")
|
|
defer paramtable.Get().CommonCfg.EnableNamespace.SwapTempValue("false")
|
|
ctx := context.Background()
|
|
prefix := "TestNamespaceProperty"
|
|
collectionName := prefix + funcutil.GenRandomStr()
|
|
|
|
initSchema := func() *schemapb.CollectionSchema {
|
|
return &schemapb.CollectionSchema{
|
|
Name: collectionName,
|
|
Fields: []*schemapb.FieldSchema{
|
|
{
|
|
FieldID: 100,
|
|
Name: "field1",
|
|
DataType: schemapb.DataType_Int64,
|
|
IsPrimaryKey: true,
|
|
},
|
|
{
|
|
FieldID: 101,
|
|
Name: "vector",
|
|
DataType: schemapb.DataType_FloatVector,
|
|
TypeParams: []*commonpb.KeyValuePair{
|
|
{
|
|
Key: common.DimKey,
|
|
Value: strconv.Itoa(1024),
|
|
},
|
|
},
|
|
},
|
|
},
|
|
}
|
|
}
|
|
hasNamespaceField := func(schema *schemapb.CollectionSchema) bool {
|
|
for _, f := range schema.Fields {
|
|
if f.Name == common.NamespaceFieldName {
|
|
return true
|
|
}
|
|
}
|
|
return false
|
|
}
|
|
|
|
t.Run("test namespace enabled", func(t *testing.T) {
|
|
schema := initSchema()
|
|
marshaledSchema, err := proto.Marshal(schema)
|
|
assert.NoError(t, err)
|
|
|
|
task := &createCollectionTask{
|
|
Req: &milvuspb.CreateCollectionRequest{
|
|
CollectionName: collectionName,
|
|
Schema: marshaledSchema,
|
|
Properties: []*commonpb.KeyValuePair{
|
|
{
|
|
Key: common.NamespaceEnabledKey,
|
|
Value: "true",
|
|
},
|
|
},
|
|
},
|
|
}
|
|
|
|
err = task.handleNamespaceField(ctx, schema)
|
|
assert.NoError(t, err)
|
|
assert.True(t, hasNamespaceField(schema))
|
|
})
|
|
|
|
t.Run("test namespace disabled with isolation and partition key", func(t *testing.T) {
|
|
schema := initSchema()
|
|
schema.Fields = append(schema.Fields, &schemapb.FieldSchema{
|
|
FieldID: 102,
|
|
Name: "field2",
|
|
DataType: schemapb.DataType_Int64,
|
|
IsPartitionKey: true,
|
|
})
|
|
marshaledSchema, err := proto.Marshal(schema)
|
|
assert.NoError(t, err)
|
|
|
|
task := &createCollectionTask{
|
|
Req: &milvuspb.CreateCollectionRequest{
|
|
CollectionName: collectionName,
|
|
Schema: marshaledSchema,
|
|
Properties: []*commonpb.KeyValuePair{
|
|
{
|
|
Key: common.PartitionKeyIsolationKey,
|
|
Value: "true",
|
|
},
|
|
},
|
|
},
|
|
}
|
|
|
|
err = task.handleNamespaceField(ctx, schema)
|
|
assert.NoError(t, err)
|
|
assert.False(t, hasNamespaceField(schema))
|
|
})
|
|
|
|
t.Run("test namespace enabled with isolation", func(t *testing.T) {
|
|
schema := initSchema()
|
|
marshaledSchema, err := proto.Marshal(schema)
|
|
assert.NoError(t, err)
|
|
|
|
task := &createCollectionTask{
|
|
Req: &milvuspb.CreateCollectionRequest{
|
|
CollectionName: collectionName,
|
|
Schema: marshaledSchema,
|
|
Properties: []*commonpb.KeyValuePair{
|
|
{
|
|
Key: common.NamespaceEnabledKey,
|
|
Value: "true",
|
|
},
|
|
{
|
|
Key: common.PartitionKeyIsolationKey,
|
|
Value: "true",
|
|
},
|
|
},
|
|
},
|
|
}
|
|
|
|
err = task.handleNamespaceField(ctx, schema)
|
|
assert.NoError(t, err)
|
|
assert.True(t, hasNamespaceField(schema))
|
|
})
|
|
|
|
t.Run("test namespace enabled with partition key", func(t *testing.T) {
|
|
schema := initSchema()
|
|
schema.Fields = append(schema.Fields, &schemapb.FieldSchema{
|
|
FieldID: 102,
|
|
Name: "field2",
|
|
DataType: schemapb.DataType_Int64,
|
|
IsPartitionKey: true,
|
|
})
|
|
marshaledSchema, err := proto.Marshal(schema)
|
|
assert.NoError(t, err)
|
|
|
|
task := &createCollectionTask{
|
|
Req: &milvuspb.CreateCollectionRequest{
|
|
CollectionName: collectionName,
|
|
Schema: marshaledSchema,
|
|
Properties: []*commonpb.KeyValuePair{
|
|
{
|
|
Key: common.NamespaceEnabledKey,
|
|
Value: "true",
|
|
},
|
|
},
|
|
},
|
|
}
|
|
|
|
err = task.handleNamespaceField(ctx, schema)
|
|
assert.Error(t, err)
|
|
})
|
|
}
|
|
|
|
func Test_validateMultiAnalyzerParams(t *testing.T) {
|
|
createTestCollectionSchema := func(fields []*schemapb.FieldSchema) *schemapb.CollectionSchema {
|
|
return &schemapb.CollectionSchema{
|
|
Name: "test_collection",
|
|
Fields: fields,
|
|
}
|
|
}
|
|
|
|
createTestFieldSchema := func(name string, dataType schemapb.DataType) *schemapb.FieldSchema {
|
|
return &schemapb.FieldSchema{
|
|
Name: name,
|
|
DataType: dataType,
|
|
}
|
|
}
|
|
|
|
t.Run("invalid json params", func(t *testing.T) {
|
|
coll := createTestCollectionSchema([]*schemapb.FieldSchema{})
|
|
fieldSchema := createTestFieldSchema("test_field", schemapb.DataType_VarChar)
|
|
infos := make([]*querypb.AnalyzerInfo, 0)
|
|
|
|
err := validateMultiAnalyzerParams("invalid json", coll, fieldSchema, &infos)
|
|
assert.Error(t, err)
|
|
})
|
|
|
|
t.Run("missing by_field", func(t *testing.T) {
|
|
coll := createTestCollectionSchema([]*schemapb.FieldSchema{})
|
|
fieldSchema := createTestFieldSchema("test_field", schemapb.DataType_VarChar)
|
|
infos := make([]*querypb.AnalyzerInfo, 0)
|
|
|
|
params := `{"analyzers": {"default": {}}}`
|
|
err := validateMultiAnalyzerParams(params, coll, fieldSchema, &infos)
|
|
assert.Error(t, err)
|
|
})
|
|
|
|
t.Run("by_field not string", func(t *testing.T) {
|
|
coll := createTestCollectionSchema([]*schemapb.FieldSchema{})
|
|
fieldSchema := createTestFieldSchema("test_field", schemapb.DataType_VarChar)
|
|
infos := make([]*querypb.AnalyzerInfo, 0)
|
|
|
|
params := `{"by_field": 123, "analyzers": {"default": {}}}`
|
|
err := validateMultiAnalyzerParams(params, coll, fieldSchema, &infos)
|
|
assert.Error(t, err)
|
|
})
|
|
|
|
t.Run("by_field references non-existent field", func(t *testing.T) {
|
|
coll := createTestCollectionSchema([]*schemapb.FieldSchema{
|
|
createTestFieldSchema("existing_field", schemapb.DataType_VarChar),
|
|
})
|
|
fieldSchema := createTestFieldSchema("test_field", schemapb.DataType_VarChar)
|
|
infos := make([]*querypb.AnalyzerInfo, 0)
|
|
|
|
params := `{"by_field": "non_existent_field", "analyzers": {"default": {}}}`
|
|
err := validateMultiAnalyzerParams(params, coll, fieldSchema, &infos)
|
|
assert.Error(t, err)
|
|
})
|
|
|
|
t.Run("by_field references non-string field", func(t *testing.T) {
|
|
coll := createTestCollectionSchema([]*schemapb.FieldSchema{
|
|
createTestFieldSchema("int_field", schemapb.DataType_Int64),
|
|
})
|
|
fieldSchema := createTestFieldSchema("test_field", schemapb.DataType_VarChar)
|
|
infos := make([]*querypb.AnalyzerInfo, 0)
|
|
|
|
params := `{"by_field": "int_field", "analyzers": {"default": {}}}`
|
|
err := validateMultiAnalyzerParams(params, coll, fieldSchema, &infos)
|
|
assert.Error(t, err)
|
|
})
|
|
|
|
t.Run("invalid alias format", func(t *testing.T) {
|
|
coll := createTestCollectionSchema([]*schemapb.FieldSchema{
|
|
createTestFieldSchema("string_field", schemapb.DataType_VarChar),
|
|
})
|
|
fieldSchema := createTestFieldSchema("test_field", schemapb.DataType_VarChar)
|
|
infos := make([]*querypb.AnalyzerInfo, 0)
|
|
|
|
params := `{"by_field": "string_field", "alias": "invalid_alias", "analyzers": {"default": {}}}`
|
|
err := validateMultiAnalyzerParams(params, coll, fieldSchema, &infos)
|
|
assert.Error(t, err)
|
|
})
|
|
|
|
t.Run("missing analyzers", func(t *testing.T) {
|
|
coll := createTestCollectionSchema([]*schemapb.FieldSchema{
|
|
createTestFieldSchema("string_field", schemapb.DataType_VarChar),
|
|
})
|
|
fieldSchema := createTestFieldSchema("test_field", schemapb.DataType_VarChar)
|
|
infos := make([]*querypb.AnalyzerInfo, 0)
|
|
|
|
params := `{"by_field": "string_field"}`
|
|
err := validateMultiAnalyzerParams(params, coll, fieldSchema, &infos)
|
|
assert.Error(t, err)
|
|
})
|
|
|
|
t.Run("invalid analyzers format", func(t *testing.T) {
|
|
coll := createTestCollectionSchema([]*schemapb.FieldSchema{
|
|
createTestFieldSchema("string_field", schemapb.DataType_VarChar),
|
|
})
|
|
fieldSchema := createTestFieldSchema("test_field", schemapb.DataType_VarChar)
|
|
infos := make([]*querypb.AnalyzerInfo, 0)
|
|
|
|
params := `{"by_field": "string_field", "analyzers": "invalid_analyzers"}`
|
|
err := validateMultiAnalyzerParams(params, coll, fieldSchema, &infos)
|
|
assert.Error(t, err)
|
|
})
|
|
|
|
t.Run("missing default analyzer", func(t *testing.T) {
|
|
coll := createTestCollectionSchema([]*schemapb.FieldSchema{
|
|
createTestFieldSchema("string_field", schemapb.DataType_VarChar),
|
|
})
|
|
fieldSchema := createTestFieldSchema("test_field", schemapb.DataType_VarChar)
|
|
infos := make([]*querypb.AnalyzerInfo, 0)
|
|
|
|
params := `{"by_field": "string_field", "analyzers": {"custom": {}}}`
|
|
err := validateMultiAnalyzerParams(params, coll, fieldSchema, &infos)
|
|
assert.Error(t, err)
|
|
})
|
|
|
|
t.Run("valid params", func(t *testing.T) {
|
|
coll := createTestCollectionSchema([]*schemapb.FieldSchema{
|
|
createTestFieldSchema("string_field", schemapb.DataType_VarChar),
|
|
})
|
|
fieldSchema := createTestFieldSchema("test_field", schemapb.DataType_VarChar)
|
|
infos := make([]*querypb.AnalyzerInfo, 0)
|
|
|
|
params := `{
|
|
"by_field": "string_field",
|
|
"alias": {"en": "english", "zh": "chinese"},
|
|
"analyzers": {
|
|
"default": {"type": "standard"},
|
|
"english": {"type": "english"},
|
|
"chinese": {"type": "chinese"}
|
|
}
|
|
}`
|
|
err := validateMultiAnalyzerParams(params, coll, fieldSchema, &infos)
|
|
assert.NoError(t, err)
|
|
assert.Len(t, infos, 3)
|
|
|
|
analyzerNames := make(map[string]bool)
|
|
for _, info := range infos {
|
|
assert.Equal(t, "test_field", info.Field)
|
|
analyzerNames[info.Name] = true
|
|
}
|
|
assert.True(t, analyzerNames["default"])
|
|
assert.True(t, analyzerNames["english"])
|
|
assert.True(t, analyzerNames["chinese"])
|
|
})
|
|
|
|
t.Run("valid params with minimal config", func(t *testing.T) {
|
|
coll := createTestCollectionSchema([]*schemapb.FieldSchema{
|
|
createTestFieldSchema("string_field", schemapb.DataType_VarChar),
|
|
})
|
|
fieldSchema := createTestFieldSchema("test_field", schemapb.DataType_VarChar)
|
|
infos := make([]*querypb.AnalyzerInfo, 0)
|
|
|
|
params := `{
|
|
"by_field": "string_field",
|
|
"analyzers": {"default": {"type": "standard"}}
|
|
}`
|
|
err := validateMultiAnalyzerParams(params, coll, fieldSchema, &infos)
|
|
assert.NoError(t, err)
|
|
assert.Len(t, infos, 1)
|
|
assert.Equal(t, "default", infos[0].Name)
|
|
assert.Equal(t, "test_field", infos[0].Field)
|
|
assert.Equal(t, `{"type": "standard"}`, infos[0].Params)
|
|
})
|
|
}
|
|
|
|
func Test_validateAnalyzer(t *testing.T) {
|
|
createTestCollectionSchemaWithBM25 := func(fields []*schemapb.FieldSchema, inputFieldName string) *schemapb.CollectionSchema {
|
|
return &schemapb.CollectionSchema{
|
|
Name: "test_collection",
|
|
Fields: fields,
|
|
Functions: []*schemapb.FunctionSchema{
|
|
{
|
|
Name: "bm25_func",
|
|
Type: schemapb.FunctionType_BM25,
|
|
InputFieldNames: []string{inputFieldName},
|
|
OutputFieldNames: []string{"bm25_output"},
|
|
},
|
|
},
|
|
}
|
|
}
|
|
|
|
createTestFieldSchema := func(name string, dataType schemapb.DataType, typeParams []*commonpb.KeyValuePair) *schemapb.FieldSchema {
|
|
return &schemapb.FieldSchema{
|
|
Name: name,
|
|
DataType: dataType,
|
|
TypeParams: typeParams,
|
|
}
|
|
}
|
|
|
|
t.Run("field without enable_match and not BM25 input", func(t *testing.T) {
|
|
fieldSchema := createTestFieldSchema("text_field", schemapb.DataType_VarChar, []*commonpb.KeyValuePair{
|
|
{Key: common.MaxLengthKey, Value: "100"},
|
|
})
|
|
collSchema := createTestCollectionSchemaWithBM25([]*schemapb.FieldSchema{fieldSchema}, "invalid_field")
|
|
infos := make([]*querypb.AnalyzerInfo, 0)
|
|
|
|
err := validateAnalyzer(collSchema, fieldSchema, &infos)
|
|
assert.NoError(t, err)
|
|
assert.Len(t, infos, 0)
|
|
})
|
|
|
|
t.Run("field with enable_match but no enable_analyzer", func(t *testing.T) {
|
|
fieldSchema := createTestFieldSchema("text_field", schemapb.DataType_VarChar, []*commonpb.KeyValuePair{
|
|
{Key: common.MaxLengthKey, Value: "100"},
|
|
{Key: "enable_match", Value: "true"},
|
|
})
|
|
collSchema := createTestCollectionSchemaWithBM25([]*schemapb.FieldSchema{fieldSchema}, "text_field")
|
|
infos := make([]*querypb.AnalyzerInfo, 0)
|
|
|
|
err := validateAnalyzer(collSchema, fieldSchema, &infos)
|
|
assert.Error(t, err)
|
|
})
|
|
|
|
t.Run("field with enable_match and enable_analyzer", func(t *testing.T) {
|
|
fieldSchema := createTestFieldSchema("text_field", schemapb.DataType_VarChar, []*commonpb.KeyValuePair{
|
|
{Key: common.MaxLengthKey, Value: "100"},
|
|
{Key: "enable_match", Value: "true"},
|
|
{Key: "enable_analyzer", Value: "true"},
|
|
{Key: "analyzer_params", Value: "{\"type\": \"standard\"}"},
|
|
})
|
|
collSchema := createTestCollectionSchemaWithBM25([]*schemapb.FieldSchema{fieldSchema}, "text_field")
|
|
infos := make([]*querypb.AnalyzerInfo, 0)
|
|
|
|
err := validateAnalyzer(collSchema, fieldSchema, &infos)
|
|
assert.NoError(t, err)
|
|
assert.Len(t, infos, 1)
|
|
assert.Equal(t, "text_field", infos[0].Field)
|
|
assert.Equal(t, "{\"type\": \"standard\"}", infos[0].Params)
|
|
})
|
|
|
|
t.Run("field with multi analyzer and enable_match", func(t *testing.T) {
|
|
fieldSchema := createTestFieldSchema("text_field", schemapb.DataType_VarChar, []*commonpb.KeyValuePair{
|
|
{Key: common.MaxLengthKey, Value: "100"},
|
|
{Key: "enable_match", Value: "true"},
|
|
{Key: "enable_analyzer", Value: "true"},
|
|
{Key: "multi_analyzer_params", Value: `{"by_field": "lang", "analyzers": {"default": "{}"}}`},
|
|
})
|
|
collSchema := createTestCollectionSchemaWithBM25([]*schemapb.FieldSchema{
|
|
fieldSchema,
|
|
createTestFieldSchema("lang", schemapb.DataType_VarChar, []*commonpb.KeyValuePair{
|
|
{Key: common.MaxLengthKey, Value: "10"},
|
|
}),
|
|
}, "text_field")
|
|
infos := make([]*querypb.AnalyzerInfo, 0)
|
|
|
|
err := validateAnalyzer(collSchema, fieldSchema, &infos)
|
|
assert.Error(t, err)
|
|
})
|
|
|
|
t.Run("field with multi analyzer and analyzer_params", func(t *testing.T) {
|
|
fieldSchema := createTestFieldSchema("text_field", schemapb.DataType_VarChar, []*commonpb.KeyValuePair{
|
|
{Key: common.MaxLengthKey, Value: "100"},
|
|
{Key: "enable_analyzer", Value: "true"},
|
|
{Key: "multi_analyzer_params", Value: `{"by_field": "lang", "analyzers": {"default": "{}"}}`},
|
|
{Key: "analyzer_params", Value: `{"type": "standard"}`},
|
|
})
|
|
collSchema := createTestCollectionSchemaWithBM25([]*schemapb.FieldSchema{
|
|
fieldSchema,
|
|
createTestFieldSchema("lang", schemapb.DataType_VarChar, []*commonpb.KeyValuePair{
|
|
{Key: common.MaxLengthKey, Value: "10"},
|
|
}),
|
|
}, "text_field")
|
|
infos := make([]*querypb.AnalyzerInfo, 0)
|
|
|
|
err := validateAnalyzer(collSchema, fieldSchema, &infos)
|
|
assert.Error(t, err)
|
|
})
|
|
|
|
t.Run("field with valid multi analyzer", func(t *testing.T) {
|
|
// Create a field with valid multi analyzer
|
|
fieldSchema := createTestFieldSchema("text_field", schemapb.DataType_VarChar, []*commonpb.KeyValuePair{
|
|
{Key: common.MaxLengthKey, Value: "100"},
|
|
{Key: "enable_analyzer", Value: "true"},
|
|
{Key: "multi_analyzer_params", Value: `{
|
|
"by_field": "lang",
|
|
"analyzers": {
|
|
"default": {"type": "standard"},
|
|
"english": {"type": "english"}
|
|
}
|
|
}`},
|
|
})
|
|
collSchema := createTestCollectionSchemaWithBM25([]*schemapb.FieldSchema{
|
|
fieldSchema,
|
|
createTestFieldSchema("lang", schemapb.DataType_VarChar, []*commonpb.KeyValuePair{
|
|
{Key: common.MaxLengthKey, Value: "10"},
|
|
}),
|
|
}, "text_field")
|
|
infos := make([]*querypb.AnalyzerInfo, 0)
|
|
|
|
err := validateAnalyzer(collSchema, fieldSchema, &infos)
|
|
assert.NoError(t, err)
|
|
assert.Len(t, infos, 2)
|
|
|
|
// Verify analyzer info content
|
|
analyzerNames := make(map[string]bool)
|
|
for _, info := range infos {
|
|
assert.Equal(t, "text_field", info.Field)
|
|
analyzerNames[info.Name] = true
|
|
}
|
|
assert.True(t, analyzerNames["default"])
|
|
assert.True(t, analyzerNames["english"])
|
|
})
|
|
|
|
t.Run("field with invalid multi analyzer params", func(t *testing.T) {
|
|
// Create a field with invalid multi analyzer params
|
|
fieldSchema := createTestFieldSchema("text_field", schemapb.DataType_VarChar, []*commonpb.KeyValuePair{
|
|
{Key: common.MaxLengthKey, Value: "100"},
|
|
{Key: "enable_analyzer", Value: "true"},
|
|
{Key: "multi_analyzer_params", Value: `{"by_field": "non_existent_field", "analyzers": {"default": "{}"}}`},
|
|
})
|
|
collSchema := createTestCollectionSchemaWithBM25([]*schemapb.FieldSchema{fieldSchema}, "text_field")
|
|
infos := make([]*querypb.AnalyzerInfo, 0)
|
|
|
|
err := validateAnalyzer(collSchema, fieldSchema, &infos)
|
|
assert.Error(t, err)
|
|
})
|
|
|
|
t.Run("field with analyzer_params only", func(t *testing.T) {
|
|
// Create a field with analyzer_params only
|
|
fieldSchema := createTestFieldSchema("text_field", schemapb.DataType_VarChar, []*commonpb.KeyValuePair{
|
|
{Key: common.MaxLengthKey, Value: "100"},
|
|
{Key: "enable_analyzer", Value: "true"},
|
|
{Key: "analyzer_params", Value: `{"type": "standard"}`},
|
|
})
|
|
collSchema := createTestCollectionSchemaWithBM25([]*schemapb.FieldSchema{fieldSchema}, "text_field")
|
|
infos := make([]*querypb.AnalyzerInfo, 0)
|
|
|
|
err := validateAnalyzer(collSchema, fieldSchema, &infos)
|
|
require.NoError(t, err)
|
|
require.Len(t, infos, 1)
|
|
assert.Equal(t, "text_field", infos[0].Field)
|
|
assert.Equal(t, "", infos[0].Name) // Regular analyzer has no name
|
|
assert.Equal(t, `{"type": "standard"}`, infos[0].Params)
|
|
})
|
|
|
|
t.Run("field with enable_analyzer but no analyzer_params", func(t *testing.T) {
|
|
// Create a field with enable_analyzer but no analyzer_params (uses default analyzer)
|
|
fieldSchema := createTestFieldSchema("text_field", schemapb.DataType_VarChar, []*commonpb.KeyValuePair{
|
|
{Key: common.MaxLengthKey, Value: "100"},
|
|
{Key: "enable_match", Value: "true"},
|
|
{Key: "enable_analyzer", Value: "true"},
|
|
})
|
|
collSchema := createTestCollectionSchemaWithBM25([]*schemapb.FieldSchema{fieldSchema}, "text_field")
|
|
infos := make([]*querypb.AnalyzerInfo, 0)
|
|
|
|
err := validateAnalyzer(collSchema, fieldSchema, &infos)
|
|
assert.NoError(t, err)
|
|
assert.Len(t, infos, 0) // No analyzer_params, uses default analyzer
|
|
})
|
|
}
|