mirror of
https://gitee.com/milvus-io/milvus.git
synced 2026-01-07 19:31:51 +08:00
issue: #45841 - CPP log make the multi log line in one debug, remove the "\n\t". - remove some log that make no sense. - slow down some log like ChannelDistManager. <!-- This is an auto-generated comment: release notes by coderabbit.ai --> - Core invariant: logging is purely observational — this PR only reduces, consolidates, or reformats diagnostic output (removing per-item/noise logs, consolidating batched logs, and converting multi-line log strings) while preserving all control flow, return values, and state mutations across affected code paths. - Removed / simplified logic: deleted low-value per-operation debug/info logs (e.g., ListIndexes, GetRecoveryInfo, GcConfirm, push-to-reorder-buffer, several streaming/wal/debug traces), replaced per-item inline logs with single batched deferred logs in querynodev2/delegator (logExcludeInfo) and CleanInvalid, changed C++ PlanNode ToString() multi-line output to compact single-line bracketed format (removed "\n\t"), and added thresholded interceptor logging (InterceptorMetrics.ShouldBeLogged) and message-type-driven log levels to avoid verbose entries. - Why this does NOT cause data loss or behavioral regression: no function signatures, branching, state updates, persistence calls, or return values were changed — examples: ListIndexes still returns the same Status/IndexInfos; GcConfirm still constructs and returns resp.GetGcFinished(); Insert and CleanInvalid still perform the same insert/removal operations (only their per-item logging was aggregated); PlanNode ToString changes only affect emitted debug strings. All error handling and control flow paths remain intact. - Enhancement intent: reduce log volume and improve signal-to-noise for debugging by removing redundant, noisy logs and emitting concise, rate-/threshold-limited summaries while preserving necessary diagnostics and original program behavior. <!-- end of auto-generated comment: release notes by coderabbit.ai --> --------- Signed-off-by: chyezh <chyezh@outlook.com>
172 lines
4.6 KiB
Go
172 lines
4.6 KiB
Go
package metricsutil
|
|
|
|
import (
|
|
"fmt"
|
|
"time"
|
|
|
|
"go.uber.org/zap"
|
|
|
|
"github.com/milvus-io/milvus/pkg/v2/log"
|
|
"github.com/milvus-io/milvus/pkg/v2/streaming/util/message"
|
|
"github.com/milvus-io/milvus/pkg/v2/streaming/util/types"
|
|
)
|
|
|
|
const (
|
|
maxLogged = 3
|
|
logThreshold = 10 * time.Millisecond
|
|
)
|
|
|
|
type InterceptorMetrics struct {
|
|
Before time.Duration
|
|
BeforeErr error
|
|
After time.Duration
|
|
}
|
|
|
|
func (im *InterceptorMetrics) ShouldBeLogged() bool {
|
|
return im.Before > logThreshold || im.After > logThreshold || im.BeforeErr != nil
|
|
}
|
|
|
|
func (im *InterceptorMetrics) String() string {
|
|
return fmt.Sprintf("b:%s,a:%s,err:%s", im.Before, im.After, im.BeforeErr)
|
|
}
|
|
|
|
// AppendMetrics is the metrics for append operation.
|
|
type AppendMetrics struct {
|
|
wm *WriteMetrics
|
|
msg message.MutableMessage
|
|
|
|
result *types.AppendResult
|
|
err error
|
|
appendDuration time.Duration
|
|
implAppendDuration time.Duration
|
|
interceptors map[string][]*InterceptorMetrics
|
|
}
|
|
|
|
type AppendMetricsGuard struct {
|
|
inner *AppendMetrics
|
|
startAppend time.Time
|
|
startImplAppend time.Time
|
|
}
|
|
|
|
// StartInterceptorCollector start the interceptor to collect the duration.
|
|
func (m *AppendMetrics) StartInterceptorCollector(name string) *InterceptorCollectGuard {
|
|
if _, ok := m.interceptors[name]; !ok {
|
|
m.interceptors[name] = make([]*InterceptorMetrics, 0, 2)
|
|
}
|
|
im := &InterceptorMetrics{}
|
|
m.interceptors[name] = append(m.interceptors[name], im)
|
|
return &InterceptorCollectGuard{
|
|
start: time.Now(),
|
|
afterStarted: false,
|
|
interceptor: im,
|
|
}
|
|
}
|
|
|
|
// StartAppendGuard start the append operation.
|
|
func (m *AppendMetrics) StartAppendGuard() *AppendMetricsGuard {
|
|
return &AppendMetricsGuard{
|
|
inner: m,
|
|
startAppend: time.Now(),
|
|
}
|
|
}
|
|
|
|
// IntoLogFields convert the metrics to log fields.
|
|
func (m *AppendMetrics) IntoLogFields() []zap.Field {
|
|
fields := []zap.Field{
|
|
log.FieldMessage(m.msg),
|
|
zap.Duration("duration", m.appendDuration),
|
|
zap.Duration("implDuration", m.implAppendDuration),
|
|
}
|
|
|
|
if m.err != nil {
|
|
fields = append(fields, zap.Error(m.err))
|
|
} else {
|
|
fields = append(fields, zap.String("messageID", m.result.MessageID.String()))
|
|
fields = append(fields, zap.String("lcMessageID", m.result.LastConfirmedMessageID.String()))
|
|
fields = append(fields, zap.Uint64("timetick", m.result.TimeTick))
|
|
if m.result.TxnCtx != nil {
|
|
fields = append(fields, zap.Int64("txnID", int64(m.result.TxnCtx.TxnID)))
|
|
}
|
|
}
|
|
loggedInterceptorCount := 0
|
|
L:
|
|
for name, ims := range m.interceptors {
|
|
for i, im := range ims {
|
|
if !im.ShouldBeLogged() {
|
|
continue
|
|
}
|
|
if loggedInterceptorCount <= maxLogged {
|
|
fields = append(fields, zap.Stringer(fmt.Sprintf("%s_%d", name, i), im))
|
|
loggedInterceptorCount++
|
|
}
|
|
if loggedInterceptorCount >= maxLogged {
|
|
break L
|
|
}
|
|
}
|
|
}
|
|
return fields
|
|
}
|
|
|
|
// StartWALImplAppend start the implementation append operation.
|
|
func (m *AppendMetricsGuard) StartWALImplAppend() {
|
|
m.startImplAppend = time.Now()
|
|
}
|
|
|
|
// FinishImplAppend finish the implementation append operation.
|
|
func (m *AppendMetricsGuard) FinishWALImplAppend() {
|
|
m.inner.implAppendDuration = time.Since(m.startImplAppend)
|
|
}
|
|
|
|
// FinishAppend finish the append operation.
|
|
func (m *AppendMetricsGuard) FinishAppend() {
|
|
m.inner.appendDuration = time.Since(m.startAppend)
|
|
}
|
|
|
|
// RangeOverInterceptors range over the interceptors.
|
|
func (m *AppendMetrics) RangeOverInterceptors(f func(name string, ims []*InterceptorMetrics)) {
|
|
for name, ims := range m.interceptors {
|
|
f(name, ims)
|
|
}
|
|
}
|
|
|
|
// Done push the metrics.
|
|
func (m *AppendMetrics) Done(result *types.AppendResult, err error) {
|
|
m.err = err
|
|
m.result = result
|
|
m.wm.done(m)
|
|
}
|
|
|
|
// InterceptorCollectGuard is used to collect the metrics of interceptor.
|
|
type InterceptorCollectGuard struct {
|
|
start time.Time
|
|
afterStarted bool
|
|
interceptor *InterceptorMetrics
|
|
}
|
|
|
|
// BeforeDone mark the before append operation is done.
|
|
func (g *InterceptorCollectGuard) BeforeDone() {
|
|
g.interceptor.Before = time.Since(g.start)
|
|
}
|
|
|
|
// BeforeFailure mark the operation before append is failed.
|
|
func (g *InterceptorCollectGuard) BeforeFailure(err error) {
|
|
if g.interceptor.Before == 0 {
|
|
// if before duration is not set, means the operation is failed before the interceptor.
|
|
g.interceptor.Before = time.Since(g.start)
|
|
g.interceptor.BeforeErr = err
|
|
}
|
|
}
|
|
|
|
// AfterStart mark the after append operation is started.
|
|
func (g *InterceptorCollectGuard) AfterStart() {
|
|
g.start = time.Now()
|
|
g.afterStarted = true
|
|
}
|
|
|
|
// AfterDone mark the after append operation is done.
|
|
func (g *InterceptorCollectGuard) AfterDone() {
|
|
if g.afterStarted {
|
|
g.interceptor.After += time.Since(g.start)
|
|
}
|
|
}
|