mirror of
https://gitee.com/milvus-io/milvus.git
synced 2026-01-07 19:31:51 +08:00
63e191a347
issue: #46636 ## Summary - Fix spelling error in comment: `Seperate` -> `Separate` - Location: `build/build_image_gpu.sh` line 38 ## Test Plan - [x] Comment-only change, no functional impact <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## PR Summary: Typo Correction in Build Script Comment • **Core Assumption**: This change relies on the assumption that documentation and comments should reflect correct spelling to maintain code quality and readability for maintainers. The comment is purely informational describing the conditional logic below it. • **What Changed**: A single spelling correction in a comment on line 38 of `build/build_image_gpu.sh`, changing "Seperate" to "Separate". No code logic, control flow, or build behavior is altered—this is a comment-only edit. • **No Regression**: This change introduces zero behavioral or functional impact because the modified content is a comment that does not execute. The conditional logic immediately following (lines 39-42) and the docker build command remain completely unchanged. Build output, image creation, dependency installation, and all runtime behavior are identical before and after this change. • **Rationale**: Correcting obvious spelling errors in comments improves code maintainability and reduces potential confusion for developers reading the build script, while incurring zero risk to the system. <!-- end of auto-generated comment: release notes by coderabbit.ai --> Signed-off-by: majiayu000 <1835304752@qq.com>
51 lines
2.0 KiB
Bash
Executable File
51 lines
2.0 KiB
Bash
Executable File
#!/bin/bash
|
|
|
|
# Licensed to the LF AI & Data foundation under one
|
|
# or more contributor license agreements. See the NOTICE file
|
|
# distributed with this work for additional information
|
|
# regarding copyright ownership. The ASF licenses this file
|
|
# to you under the Apache License, Version 2.0 (the
|
|
# "License"); you may not use this file except in compliance
|
|
# with the License. You may obtain a copy of the License at
|
|
#
|
|
# http://www.apache.org/licenses/LICENSE-2.0
|
|
#
|
|
# Unless required by applicable law or agreed to in writing, software
|
|
# distributed under the License is distributed on an "AS IS" BASIS,
|
|
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
# See the License for the specific language governing permissions and
|
|
# limitations under the License.
|
|
|
|
# Exit immediately for non zero status
|
|
set -e
|
|
# Print commands
|
|
set -x
|
|
|
|
# Absolute path to the toplevel milvus directory.
|
|
toplevel=$(dirname "$(cd "$(dirname "${0}")"; pwd)")
|
|
|
|
OS_NAME="${OS_NAME:-ubuntu22.04}"
|
|
MILVUS_IMAGE_REPO="${MILVUS_IMAGE_REPO:-milvusdb/milvus}"
|
|
MILVUS_IMAGE_TAG="${MILVUS_IMAGE_TAG:-gpu-latest}"
|
|
|
|
MILVUS_BASE_IMAGE_REPO="${MILVUS_BASE_IMAGE_REPO:-milvusdb/milvus-base}"
|
|
MILVUS_BASE_IMAGE_TAG="gpu-local"
|
|
BUILD_ARGS=""
|
|
|
|
pushd "${toplevel}"
|
|
BUILD_BASE_IMAGE=${BUILD_BASE_IMAGE:-"false"}
|
|
|
|
# Separate base dockerfile to ignore install dependencies when build milvus image
|
|
if [[ ${OS_NAME} == "ubuntu20.04" && ${BUILD_BASE_IMAGE} == "true" ]]; then
|
|
docker build -f "./build/docker/milvus/gpu/${OS_NAME}/Dockerfile.base" -t "${MILVUS_BASE_IMAGE_REPO}:${MILVUS_BASE_IMAGE_TAG}" .
|
|
BUILD_ARGS="--build-arg MILVUS_BASE_IMAGE_REPO=${MILVUS_BASE_IMAGE_REPO} --build-arg MILVUS_BASE_IMAGE_TAG=${MILVUS_BASE_IMAGE_TAG}"
|
|
fi
|
|
|
|
docker build --network host ${BUILD_ARGS} -f "./build/docker/milvus/gpu/${OS_NAME}/Dockerfile" -t "${MILVUS_IMAGE_REPO}:${MILVUS_IMAGE_TAG}" .
|
|
|
|
image_size=$(docker inspect ${MILVUS_IMAGE_REPO}:${MILVUS_IMAGE_TAG} -f '{{.Size}}'| awk '{ byte =$1 /1024/1024/1024; print byte " GB" }')
|
|
|
|
echo "Image Size for ${MILVUS_IMAGE_REPO}:${MILVUS_IMAGE_TAG} is ${image_size}"
|
|
|
|
popd
|