mirror of
https://gitee.com/milvus-io/milvus.git
synced 2025-12-07 17:48:29 +08:00
c84ea5465c
issue: #35846 querycoord will notify proxy to update shard leader cache after delegator location changes, but during querynode's failure recovery, some delegator may become unserviceable due to lacking of segments, and back to serviceable after segment loaded, so we also need to notify proxy to invalidate shard leader cache when delegator serviceable state changes. This PR will maintain querynode's serviceable state during heartbeat, and notify proxy to invalidate shard leader cache if serviceable state changes. Signed-off-by: Wei Liu <wei.liu@zilliz.com>
320 lines
8.0 KiB
Go
320 lines
8.0 KiB
Go
// Licensed to the LF AI & Data foundation under one
|
|
// or more contributor license agreements. See the NOTICE file
|
|
// distributed with this work for additional information
|
|
// regarding copyright ownership. The ASF licenses this file
|
|
// to you under the Apache License, Version 2.0 (the
|
|
// "License"); you may not use this file except in compliance
|
|
// with the License. You may obtain a copy of the License at
|
|
//
|
|
// http://www.apache.org/licenses/LICENSE-2.0
|
|
//
|
|
// Unless required by applicable law or agreed to in writing, software
|
|
// distributed under the License is distributed on an "AS IS" BASIS,
|
|
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
// See the License for the specific language governing permissions and
|
|
// limitations under the License.
|
|
|
|
package meta
|
|
|
|
import (
|
|
"testing"
|
|
|
|
"github.com/cockroachdb/errors"
|
|
"github.com/samber/lo"
|
|
"github.com/stretchr/testify/suite"
|
|
|
|
"github.com/milvus-io/milvus/internal/proto/querypb"
|
|
"github.com/milvus-io/milvus/pkg/util/typeutil"
|
|
)
|
|
|
|
type LeaderViewManagerSuite struct {
|
|
suite.Suite
|
|
// Data
|
|
collections []int64
|
|
channels map[int64][]string
|
|
growingSegments map[int64]map[string]int64
|
|
segments map[int64]map[string][]int64
|
|
nodes []int64
|
|
leaders map[int64]map[string]*LeaderView
|
|
|
|
// Test object
|
|
mgr *LeaderViewManager
|
|
}
|
|
|
|
func (suite *LeaderViewManagerSuite) SetupSuite() {
|
|
suite.collections = []int64{100, 101}
|
|
suite.channels = map[int64][]string{
|
|
100: {"100-dmc0", "100-dmc1"},
|
|
101: {"101-dmc0", "101-dmc1"},
|
|
}
|
|
suite.growingSegments = map[int64]map[string]int64{
|
|
100: {
|
|
"100-dmc0": 10,
|
|
"100-dmc1": 11,
|
|
},
|
|
101: {
|
|
"101-dmc0": 12,
|
|
"101-dmc1": 13,
|
|
},
|
|
}
|
|
suite.segments = map[int64]map[string][]int64{
|
|
100: {
|
|
"100-dmc0": []int64{1, 2},
|
|
"100-dmc1": {3, 4},
|
|
},
|
|
101: {
|
|
"101-dmc0": {5, 6},
|
|
"101-dmc1": {7, 8},
|
|
},
|
|
}
|
|
suite.nodes = []int64{1, 2}
|
|
|
|
// Leaders: 1, 2
|
|
suite.leaders = make(map[int64]map[string]*LeaderView)
|
|
for _, collection := range suite.collections {
|
|
for j := 0; j < 2; j++ {
|
|
channel := suite.channels[collection][j]
|
|
node := suite.nodes[j]
|
|
view := &LeaderView{
|
|
ID: node,
|
|
CollectionID: collection,
|
|
Channel: channel,
|
|
GrowingSegments: map[int64]*Segment{suite.growingSegments[collection][channel]: nil},
|
|
Segments: make(map[int64]*querypb.SegmentDist),
|
|
}
|
|
|
|
for _, segment := range suite.segments[collection][channel] {
|
|
view.Segments[segment] = &querypb.SegmentDist{
|
|
NodeID: node,
|
|
Version: 0,
|
|
}
|
|
}
|
|
if suite.leaders[node] == nil {
|
|
suite.leaders[node] = map[string]*LeaderView{
|
|
channel: view,
|
|
}
|
|
} else {
|
|
suite.leaders[node][channel] = view
|
|
}
|
|
}
|
|
}
|
|
}
|
|
|
|
func (suite *LeaderViewManagerSuite) SetupTest() {
|
|
suite.mgr = NewLeaderViewManager()
|
|
for id, views := range suite.leaders {
|
|
suite.mgr.Update(id, lo.Values(views)...)
|
|
}
|
|
}
|
|
|
|
func (suite *LeaderViewManagerSuite) TestGetByFilter() {
|
|
// Test WithChannelName
|
|
for collectionID, channels := range suite.channels {
|
|
for _, channel := range channels {
|
|
views := suite.mgr.GetByFilter(WithChannelName2LeaderView(channel))
|
|
suite.Len(views, 1)
|
|
suite.Equal(collectionID, views[0].CollectionID)
|
|
}
|
|
}
|
|
|
|
// Test WithCollection
|
|
for _, collectionID := range suite.collections {
|
|
views := suite.mgr.GetByFilter(WithCollectionID2LeaderView(collectionID))
|
|
suite.Len(views, 2)
|
|
suite.Equal(collectionID, views[0].CollectionID)
|
|
}
|
|
|
|
// Test WithNodeID
|
|
for _, nodeID := range suite.nodes {
|
|
views := suite.mgr.GetByFilter(WithNodeID2LeaderView(nodeID))
|
|
suite.Len(views, 2)
|
|
for _, view := range views {
|
|
suite.Equal(nodeID, view.ID)
|
|
}
|
|
}
|
|
|
|
// Test WithReplica
|
|
for i, collectionID := range suite.collections {
|
|
replica := newReplica(&querypb.Replica{
|
|
ID: int64(i),
|
|
CollectionID: collectionID,
|
|
Nodes: suite.nodes,
|
|
})
|
|
views := suite.mgr.GetByFilter(WithReplica2LeaderView(replica))
|
|
suite.Len(views, 2)
|
|
}
|
|
|
|
// Test WithSegment
|
|
for _, leaders := range suite.leaders {
|
|
for _, leader := range leaders {
|
|
for sid := range leader.Segments {
|
|
views := suite.mgr.GetByFilter(WithSegment2LeaderView(sid, false))
|
|
suite.Len(views, 1)
|
|
suite.Equal(views[0].ID, leader.ID)
|
|
suite.Equal(views[0].Channel, leader.Channel)
|
|
}
|
|
|
|
for sid := range leader.GrowingSegments {
|
|
views := suite.mgr.GetByFilter(WithSegment2LeaderView(sid, true))
|
|
suite.Len(views, 1)
|
|
suite.Equal(views[0].ID, leader.ID)
|
|
suite.Equal(views[0].Channel, leader.Channel)
|
|
}
|
|
|
|
view := suite.mgr.GetLeaderShardView(leader.ID, leader.Channel)
|
|
suite.Equal(view.ID, leader.ID)
|
|
suite.Equal(view.Channel, leader.Channel)
|
|
}
|
|
}
|
|
}
|
|
|
|
func (suite *LeaderViewManagerSuite) TestGetLatestShardLeader() {
|
|
nodeID := int64(1001)
|
|
collectionID := suite.collections[0]
|
|
channel := suite.channels[collectionID][0]
|
|
// add duplicate shard leader
|
|
view := &LeaderView{
|
|
ID: nodeID,
|
|
CollectionID: collectionID,
|
|
Channel: channel,
|
|
GrowingSegments: map[int64]*Segment{suite.growingSegments[collectionID][channel]: nil},
|
|
Segments: make(map[int64]*querypb.SegmentDist),
|
|
}
|
|
|
|
for _, segment := range suite.segments[collectionID][channel] {
|
|
view.Segments[segment] = &querypb.SegmentDist{
|
|
NodeID: nodeID,
|
|
Version: 1000,
|
|
}
|
|
}
|
|
view.Version = 1000
|
|
|
|
suite.mgr.Update(nodeID, view)
|
|
|
|
leader := suite.mgr.GetLatestShardLeaderByFilter(WithChannelName2LeaderView(channel))
|
|
suite.Equal(nodeID, leader.ID)
|
|
|
|
// test replica is nil
|
|
leader = suite.mgr.GetLatestShardLeaderByFilter(WithReplica2LeaderView(nil))
|
|
suite.Nil(leader)
|
|
}
|
|
|
|
func (suite *LeaderViewManagerSuite) TestClone() {
|
|
for _, leaders := range suite.leaders {
|
|
for _, leader := range leaders {
|
|
clone := leader.Clone()
|
|
suite.Equal(leader.ID, clone.ID)
|
|
suite.Equal(leader.Channel, clone.Channel)
|
|
suite.Equal(leader.CollectionID, clone.CollectionID)
|
|
}
|
|
}
|
|
}
|
|
|
|
func (suite *LeaderViewManagerSuite) TestNotifyDelegatorChanges() {
|
|
mgr := NewLeaderViewManager()
|
|
|
|
oldViews := []*LeaderView{
|
|
{
|
|
ID: 1,
|
|
CollectionID: 100,
|
|
Channel: "test-channel-1",
|
|
},
|
|
{
|
|
ID: 1,
|
|
CollectionID: 101,
|
|
Channel: "test-channel-2",
|
|
},
|
|
{
|
|
ID: 1,
|
|
CollectionID: 102,
|
|
Channel: "test-channel-3",
|
|
},
|
|
}
|
|
mgr.Update(1, oldViews...)
|
|
|
|
newViews := []*LeaderView{
|
|
{
|
|
ID: 1,
|
|
CollectionID: 101,
|
|
Channel: "test-channel-2",
|
|
},
|
|
{
|
|
ID: 1,
|
|
CollectionID: 102,
|
|
Channel: "test-channel-3",
|
|
},
|
|
{
|
|
ID: 1,
|
|
CollectionID: 103,
|
|
Channel: "test-channel-4",
|
|
},
|
|
}
|
|
|
|
retSet := typeutil.NewUniqueSet()
|
|
mgr.SetNotifyFunc(func(collectionIDs ...int64) {
|
|
retSet.Insert(collectionIDs...)
|
|
})
|
|
|
|
mgr.Update(1, newViews...)
|
|
suite.Equal(2, retSet.Len())
|
|
suite.True(retSet.Contain(100))
|
|
suite.True(retSet.Contain(103))
|
|
|
|
newViews1 := []*LeaderView{
|
|
{
|
|
ID: 1,
|
|
CollectionID: 101,
|
|
Channel: "test-channel-2",
|
|
UnServiceableError: errors.New("test error"),
|
|
},
|
|
{
|
|
ID: 1,
|
|
CollectionID: 102,
|
|
Channel: "test-channel-3",
|
|
UnServiceableError: errors.New("test error"),
|
|
},
|
|
{
|
|
ID: 1,
|
|
CollectionID: 103,
|
|
Channel: "test-channel-4",
|
|
UnServiceableError: errors.New("test error"),
|
|
},
|
|
}
|
|
|
|
retSet.Clear()
|
|
mgr.Update(1, newViews1...)
|
|
suite.Equal(3, len(retSet))
|
|
suite.True(retSet.Contain(101))
|
|
suite.True(retSet.Contain(102))
|
|
suite.True(retSet.Contain(103))
|
|
|
|
newViews2 := []*LeaderView{
|
|
{
|
|
ID: 1,
|
|
CollectionID: 101,
|
|
Channel: "test-channel-2",
|
|
UnServiceableError: errors.New("test error"),
|
|
},
|
|
{
|
|
ID: 1,
|
|
CollectionID: 102,
|
|
Channel: "test-channel-3",
|
|
},
|
|
{
|
|
ID: 1,
|
|
CollectionID: 103,
|
|
Channel: "test-channel-4",
|
|
},
|
|
}
|
|
|
|
retSet.Clear()
|
|
mgr.Update(1, newViews2...)
|
|
suite.Equal(2, len(retSet))
|
|
suite.True(retSet.Contain(102))
|
|
suite.True(retSet.Contain(103))
|
|
}
|
|
|
|
func TestLeaderViewManager(t *testing.T) {
|
|
suite.Run(t, new(LeaderViewManagerSuite))
|
|
}
|