mirror of
https://gitee.com/milvus-io/milvus.git
synced 2026-01-07 19:31:51 +08:00
issue: https://github.com/milvus-io/milvus/issues/44123 <!-- This is an auto-generated comment: release notes by coderabbit.ai --> - Core invariant: legacy in-cluster CDC/replication plumbing (ReplicateMsg types, ReplicateID-based guards and flags) is obsolete — the system relies on standard msgstream positions, subPos/end-ts semantics and timetick ordering as the single source of truth for message ordering and skipping, so replication-specific channels/types/guards can be removed safely. - Removed/simplified logic (what and why): removed replication feature flags and params (ReplicateMsgChannel, TTMsgEnabled, CollectionReplicateEnable), ReplicateMsg type and its tests, ReplicateID constants/helpers and MergeProperties hooks, ReplicateConfig and its propagation (streamPipeline, StreamConfig, dispatcher, target), replicate-aware dispatcher/pipeline branches, and replicate-mode pre-checks/timestamp-allocation in proxy tasks — these implemented a redundant alternate “replicate-mode” pathway that duplicated position/end-ts and timetick logic. - Why this does NOT cause data loss or regression (concrete code paths): no persistence or core write paths were removed — proxy PreExecute flows (internal/proxy/task_*.go) still perform the same schema/ID/size validations and then follow the normal non-replicate execution path; dispatcher and pipeline continue to use position/subPos and pullback/end-ts in Seek/grouping (pkg/mq/msgdispatcher/dispatcher.go, internal/util/pipeline/stream_pipeline.go), so skipping and ordering behavior remains unchanged; timetick emission in rootcoord (sendMinDdlTsAsTt) is now ungated (no silent suppression), preserving or increasing timetick delivery rather than removing it. - PR type and net effect: Enhancement/Refactor — removes deprecated replication API surface (types, helpers, config, tests) and replication branches, simplifies public APIs and constructor signatures, and reduces surface area for future maintenance while keeping DML/DDL persistence, ordering, and seek semantics intact. <!-- end of auto-generated comment: release notes by coderabbit.ai --> --------- Signed-off-by: bigsheeper <yihao.dai@zilliz.com>
115 lines
3.9 KiB
Go
115 lines
3.9 KiB
Go
// Licensed to the LF AI & Data foundation under one
|
|
// or more contributor license agreements. See the NOTICE file
|
|
// distributed with this work for additional information
|
|
// regarding copyright ownership. The ASF licenses this file
|
|
// to you under the Apache License, Version 2.0 (the
|
|
// "License"); you may not use this file except in compliance
|
|
// with the License. You may obtain a copy of the License at
|
|
//
|
|
// http://www.apache.org/licenses/LICENSE-2.0
|
|
//
|
|
// Unless required by applicable law or agreed to in writing, software
|
|
// distributed under the License is distributed on an "AS IS" BASIS,
|
|
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
// See the License for the specific language governing permissions and
|
|
// limitations under the License.
|
|
|
|
package common
|
|
|
|
import (
|
|
"fmt"
|
|
|
|
"github.com/cockroachdb/errors"
|
|
"google.golang.org/protobuf/proto"
|
|
|
|
"github.com/milvus-io/milvus-proto/go-api/v2/commonpb"
|
|
)
|
|
|
|
// ProducerOptions contains the options of a producer
|
|
type ProducerOptions struct {
|
|
// The topic that this Producer will publish
|
|
Topic string
|
|
|
|
// Enable compression
|
|
// For Pulsar, this enables ZSTD compression with default compression level
|
|
EnableCompression bool
|
|
}
|
|
|
|
// ProducerMessage contains the messages of a producer
|
|
type ProducerMessage struct {
|
|
// Payload get the payload of the message
|
|
Payload []byte
|
|
// Properties are application defined key/value pairs that will be attached to the message.
|
|
// Return the properties attached to the message.
|
|
Properties map[string]string
|
|
}
|
|
|
|
// Message is the interface that provides operations of a consumer
|
|
type Message interface {
|
|
// Topic get the topic from which this message originated from
|
|
Topic() string
|
|
|
|
// Properties are application defined key/value pairs that will be attached to the message.
|
|
// Return the properties attached to the message.
|
|
Properties() map[string]string
|
|
|
|
// Payload get the payload of the message
|
|
Payload() []byte
|
|
|
|
// ID get the unique message ID associated with this message.
|
|
// The message id can be used to univocally refer to a message without having the keep the entire payload in memory.
|
|
ID() MessageID
|
|
}
|
|
|
|
// SubscriptionInitialPosition is the type of a subscription initial position
|
|
type SubscriptionInitialPosition int
|
|
|
|
const (
|
|
// SubscriptionPositionLatest is latest position which means the start consuming position will be the last message
|
|
SubscriptionPositionLatest SubscriptionInitialPosition = iota
|
|
|
|
// SubscriptionPositionEarliest is earliest position which means the start consuming position will be the first message
|
|
SubscriptionPositionEarliest
|
|
|
|
// SubscriptionPositionUnkown indicates we don't care about the consumer location, since we are doing another seek or only some meta api over that
|
|
SubscriptionPositionUnknown
|
|
)
|
|
|
|
const (
|
|
MsgTypeKey = "msg_type"
|
|
MsgIdTypeKey = "msg_id"
|
|
TimestampTypeKey = "timestamp"
|
|
ChannelTypeKey = "vchannel"
|
|
CollectionIDTypeKey = "collection_id"
|
|
)
|
|
|
|
// GetMsgType gets the message type from message.
|
|
func GetMsgType(msg Message) (commonpb.MsgType, error) {
|
|
return GetMsgTypeFromRaw(msg.Payload(), msg.Properties())
|
|
}
|
|
|
|
// GetMsgTypeFromRaw gets the message type from payload and properties.
|
|
func GetMsgTypeFromRaw(payload []byte, properties map[string]string) (commonpb.MsgType, error) {
|
|
msgType := commonpb.MsgType_Undefined
|
|
if properties != nil {
|
|
if val, ok := properties[MsgTypeKey]; ok {
|
|
msgType = commonpb.MsgType(commonpb.MsgType_value[val])
|
|
}
|
|
}
|
|
if msgType == commonpb.MsgType_Undefined {
|
|
header := commonpb.MsgHeader{}
|
|
if payload == nil {
|
|
return msgType, errors.New("failed to unmarshal message header, payload is empty")
|
|
}
|
|
err := proto.Unmarshal(payload, &header)
|
|
if err != nil {
|
|
return msgType, fmt.Errorf("failed to unmarshal message header, err %s", err.Error())
|
|
}
|
|
if header.Base == nil {
|
|
return msgType, errors.New("failed to unmarshal message, header is uncomplete")
|
|
}
|
|
msgType = header.Base.MsgType
|
|
}
|
|
return msgType, nil
|
|
}
|