mirror of
https://gitee.com/milvus-io/milvus.git
synced 2026-01-07 19:31:51 +08:00
issue: https://github.com/milvus-io/milvus/issues/44123 <!-- This is an auto-generated comment: release notes by coderabbit.ai --> - Core invariant: legacy in-cluster CDC/replication plumbing (ReplicateMsg types, ReplicateID-based guards and flags) is obsolete — the system relies on standard msgstream positions, subPos/end-ts semantics and timetick ordering as the single source of truth for message ordering and skipping, so replication-specific channels/types/guards can be removed safely. - Removed/simplified logic (what and why): removed replication feature flags and params (ReplicateMsgChannel, TTMsgEnabled, CollectionReplicateEnable), ReplicateMsg type and its tests, ReplicateID constants/helpers and MergeProperties hooks, ReplicateConfig and its propagation (streamPipeline, StreamConfig, dispatcher, target), replicate-aware dispatcher/pipeline branches, and replicate-mode pre-checks/timestamp-allocation in proxy tasks — these implemented a redundant alternate “replicate-mode” pathway that duplicated position/end-ts and timetick logic. - Why this does NOT cause data loss or regression (concrete code paths): no persistence or core write paths were removed — proxy PreExecute flows (internal/proxy/task_*.go) still perform the same schema/ID/size validations and then follow the normal non-replicate execution path; dispatcher and pipeline continue to use position/subPos and pullback/end-ts in Seek/grouping (pkg/mq/msgdispatcher/dispatcher.go, internal/util/pipeline/stream_pipeline.go), so skipping and ordering behavior remains unchanged; timetick emission in rootcoord (sendMinDdlTsAsTt) is now ungated (no silent suppression), preserving or increasing timetick delivery rather than removing it. - PR type and net effect: Enhancement/Refactor — removes deprecated replication API surface (types, helpers, config, tests) and replication branches, simplifies public APIs and constructor signatures, and reduces surface area for future maintenance while keeping DML/DDL persistence, ordering, and seek semantics intact. <!-- end of auto-generated comment: release notes by coderabbit.ai --> --------- Signed-off-by: bigsheeper <yihao.dai@zilliz.com>
152 lines
6.4 KiB
Go
152 lines
6.4 KiB
Go
// Licensed to the LF AI & Data foundation under one
|
|
// or more contributor license agreements. See the NOTICE file
|
|
// distributed with this work for additional information
|
|
// regarding copyright ownership. The ASF licenses this file
|
|
// to you under the Apache License, Version 2.0 (the
|
|
// "License"); you may not use this file except in compliance
|
|
// with the License. You may obtain a copy of the License at
|
|
//
|
|
// http://www.apache.org/licenses/LICENSE-2.0
|
|
//
|
|
// Unless required by applicable law or agreed to in writing, software
|
|
// distributed under the License is distributed on an "AS IS" BASIS,
|
|
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
// See the License for the specific language governing permissions and
|
|
// limitations under the License.
|
|
|
|
package msgstream
|
|
|
|
import (
|
|
"github.com/cockroachdb/errors"
|
|
|
|
"github.com/milvus-io/milvus-proto/go-api/v2/commonpb"
|
|
)
|
|
|
|
// UnmarshalFunc is an interface that has been implemented by each Msg
|
|
type UnmarshalFunc func(interface{}) (TsMsg, error)
|
|
|
|
// UnmarshalDispatcher is an interface contains method Unmarshal
|
|
type UnmarshalDispatcher interface {
|
|
Unmarshal(input interface{}, msgType commonpb.MsgType) (TsMsg, error)
|
|
}
|
|
|
|
// UnmarshalDispatcherFactory is a factory to generate an object which implement interface UnmarshalDispatcher
|
|
type UnmarshalDispatcherFactory interface {
|
|
NewUnmarshalDispatcher() *UnmarshalDispatcher
|
|
}
|
|
|
|
// ProtoUnmarshalDispatcher is Unmarshal Dispatcher which used for data of proto type
|
|
type ProtoUnmarshalDispatcher struct {
|
|
TempMap map[commonpb.MsgType]UnmarshalFunc
|
|
}
|
|
|
|
// Unmarshal will forward unmarshal request to msg type specified unmarshal function
|
|
func (p *ProtoUnmarshalDispatcher) Unmarshal(input interface{}, msgType commonpb.MsgType) (TsMsg, error) {
|
|
unmarshalFunc, ok := p.TempMap[msgType]
|
|
if !ok {
|
|
return nil, errors.New("not set unmarshalFunc for this messageType")
|
|
}
|
|
return unmarshalFunc(input)
|
|
}
|
|
|
|
// ProtoUDFactory is a factory to generate ProtoUnmarshalDispatcher object
|
|
type ProtoUDFactory struct{}
|
|
|
|
// NewUnmarshalDispatcher returns a new UnmarshalDispatcher
|
|
func (pudf *ProtoUDFactory) NewUnmarshalDispatcher() *ProtoUnmarshalDispatcher {
|
|
insertMsg := InsertMsg{}
|
|
deleteMsg := DeleteMsg{}
|
|
timeTickMsg := TimeTickMsg{}
|
|
createCollectionMsg := CreateCollectionMsg{}
|
|
dropCollectionMsg := DropCollectionMsg{}
|
|
alterCollectionMsg := AlterCollectionMsg{}
|
|
alterCollectionFieldMsg := AlterCollectionFieldMsg{}
|
|
renameCollectionMsg := RenameCollectionMsg{}
|
|
|
|
createPartitionMsg := CreatePartitionMsg{}
|
|
dropPartitionMsg := DropPartitionMsg{}
|
|
dataNodeTtMsg := DataNodeTtMsg{}
|
|
|
|
createIndexMsg := CreateIndexMsg{}
|
|
dropIndexMsg := DropIndexMsg{}
|
|
alterIndexMsg := AlterIndexMsg{}
|
|
|
|
loadCollectionMsg := LoadCollectionMsg{}
|
|
releaseCollectionMsg := ReleaseCollectionMsg{}
|
|
flushMsg := FlushMsg{}
|
|
loadPartitionsMsg := LoadPartitionsMsg{}
|
|
releasePartitionsMsg := ReleasePartitionsMsg{}
|
|
|
|
createDatabaseMsg := CreateDatabaseMsg{}
|
|
dropDatabaseMsg := DropDatabaseMsg{}
|
|
alterDatabaseMsg := AlterDatabaseMsg{}
|
|
|
|
createCredentialMsg := CreateUserMsg{}
|
|
deleteCredentialMsg := DeleteUserMsg{}
|
|
updateCredentialMsg := UpdateUserMsg{}
|
|
createRoleMsg := CreateRoleMsg{}
|
|
dropRoleMsg := DropRoleMsg{}
|
|
operateUserRoleMsg := OperateUserRoleMsg{}
|
|
operatePrivilegeMsg := OperatePrivilegeMsg{}
|
|
operatePrivilegeV2Msg := OperatePrivilegeV2Msg{}
|
|
createPrivilegeGroupMsg := CreatePrivilegeGroupMsg{}
|
|
dropPrivilegeGroupMsg := DropPrivilegeGroupMsg{}
|
|
operatePrivilegeGroupMsg := OperatePrivilegeGroupMsg{}
|
|
importMsg := ImportMsg{}
|
|
|
|
createAliasMsg := CreateAliasMsg{}
|
|
dropAliasMsg := DropAliasMsg{}
|
|
alterAliasMsg := AlterAliasMsg{}
|
|
|
|
p := &ProtoUnmarshalDispatcher{}
|
|
p.TempMap = make(map[commonpb.MsgType]UnmarshalFunc)
|
|
p.TempMap[commonpb.MsgType_Insert] = insertMsg.Unmarshal
|
|
p.TempMap[commonpb.MsgType_Delete] = deleteMsg.Unmarshal
|
|
p.TempMap[commonpb.MsgType_TimeTick] = timeTickMsg.Unmarshal
|
|
p.TempMap[commonpb.MsgType_CreateCollection] = createCollectionMsg.Unmarshal
|
|
p.TempMap[commonpb.MsgType_DropCollection] = dropCollectionMsg.Unmarshal
|
|
p.TempMap[commonpb.MsgType_CreatePartition] = createPartitionMsg.Unmarshal
|
|
p.TempMap[commonpb.MsgType_AlterCollection] = alterCollectionMsg.Unmarshal
|
|
p.TempMap[commonpb.MsgType_AlterCollectionField] = alterCollectionFieldMsg.Unmarshal
|
|
p.TempMap[commonpb.MsgType_RenameCollection] = renameCollectionMsg.Unmarshal
|
|
p.TempMap[commonpb.MsgType_DropPartition] = dropPartitionMsg.Unmarshal
|
|
p.TempMap[commonpb.MsgType_DataNodeTt] = dataNodeTtMsg.Unmarshal
|
|
p.TempMap[commonpb.MsgType_CreateIndex] = createIndexMsg.Unmarshal
|
|
p.TempMap[commonpb.MsgType_DropIndex] = dropIndexMsg.Unmarshal
|
|
p.TempMap[commonpb.MsgType_AlterIndex] = alterIndexMsg.Unmarshal
|
|
p.TempMap[commonpb.MsgType_LoadCollection] = loadCollectionMsg.Unmarshal
|
|
p.TempMap[commonpb.MsgType_ReleaseCollection] = releaseCollectionMsg.Unmarshal
|
|
p.TempMap[commonpb.MsgType_LoadPartitions] = loadPartitionsMsg.Unmarshal
|
|
p.TempMap[commonpb.MsgType_ReleasePartitions] = releasePartitionsMsg.Unmarshal
|
|
p.TempMap[commonpb.MsgType_Flush] = flushMsg.Unmarshal
|
|
p.TempMap[commonpb.MsgType_CreateDatabase] = createDatabaseMsg.Unmarshal
|
|
p.TempMap[commonpb.MsgType_DropDatabase] = dropDatabaseMsg.Unmarshal
|
|
p.TempMap[commonpb.MsgType_AlterDatabase] = alterDatabaseMsg.Unmarshal
|
|
p.TempMap[commonpb.MsgType_CreateCredential] = createCredentialMsg.Unmarshal
|
|
p.TempMap[commonpb.MsgType_DeleteCredential] = deleteCredentialMsg.Unmarshal
|
|
p.TempMap[commonpb.MsgType_UpdateCredential] = updateCredentialMsg.Unmarshal
|
|
p.TempMap[commonpb.MsgType_CreateRole] = createRoleMsg.Unmarshal
|
|
p.TempMap[commonpb.MsgType_DropRole] = dropRoleMsg.Unmarshal
|
|
p.TempMap[commonpb.MsgType_OperateUserRole] = operateUserRoleMsg.Unmarshal
|
|
p.TempMap[commonpb.MsgType_OperatePrivilege] = operatePrivilegeMsg.Unmarshal
|
|
p.TempMap[commonpb.MsgType_OperatePrivilegeV2] = operatePrivilegeV2Msg.Unmarshal
|
|
p.TempMap[commonpb.MsgType_CreatePrivilegeGroup] = createPrivilegeGroupMsg.Unmarshal
|
|
p.TempMap[commonpb.MsgType_DropPrivilegeGroup] = dropPrivilegeGroupMsg.Unmarshal
|
|
p.TempMap[commonpb.MsgType_OperatePrivilegeGroup] = operatePrivilegeGroupMsg.Unmarshal
|
|
p.TempMap[commonpb.MsgType_Import] = importMsg.Unmarshal
|
|
p.TempMap[commonpb.MsgType_CreateAlias] = createAliasMsg.Unmarshal
|
|
p.TempMap[commonpb.MsgType_DropAlias] = dropAliasMsg.Unmarshal
|
|
p.TempMap[commonpb.MsgType_AlterAlias] = alterAliasMsg.Unmarshal
|
|
|
|
return p
|
|
}
|
|
|
|
// MemUnmarshalDispatcher ant its factory
|
|
|
|
//type MemUDFactory struct {
|
|
//
|
|
//}
|
|
//func (mudf *MemUDFactory) NewUnmarshalDispatcher() *UnmarshalDispatcher {
|
|
//
|
|
//}
|