mirror of
https://gitee.com/milvus-io/milvus.git
synced 2025-12-07 09:38:39 +08:00
a68b32134a
See also #27675 #30469 For a sync task, the segment could be compacted during sync task. In previous implementation, this sync task will hold only the old segment id as KeyLock, in which case compaction on compacted to segment may run in parallel with delta sync of this sync task. This PR introduces sync target segment verification logic. It shall check target segment lock it's holding beforing actually syncing logic. If this check failed, sync task shall return`errTargetSegementNotMatch` error and make manager re-fetch the current target segment id. Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
331 lines
9.1 KiB
Go
331 lines
9.1 KiB
Go
package syncmgr
|
|
|
|
import (
|
|
"context"
|
|
"math/rand"
|
|
"strconv"
|
|
"testing"
|
|
"time"
|
|
|
|
"github.com/samber/lo"
|
|
"github.com/stretchr/testify/mock"
|
|
"github.com/stretchr/testify/suite"
|
|
"go.uber.org/atomic"
|
|
|
|
"github.com/milvus-io/milvus-proto/go-api/v2/commonpb"
|
|
"github.com/milvus-io/milvus-proto/go-api/v2/msgpb"
|
|
"github.com/milvus-io/milvus-proto/go-api/v2/schemapb"
|
|
"github.com/milvus-io/milvus/internal/allocator"
|
|
"github.com/milvus-io/milvus/internal/datanode/broker"
|
|
"github.com/milvus-io/milvus/internal/datanode/metacache"
|
|
"github.com/milvus-io/milvus/internal/mocks"
|
|
"github.com/milvus-io/milvus/internal/proto/datapb"
|
|
"github.com/milvus-io/milvus/internal/storage"
|
|
"github.com/milvus-io/milvus/pkg/common"
|
|
"github.com/milvus-io/milvus/pkg/config"
|
|
"github.com/milvus-io/milvus/pkg/util/paramtable"
|
|
"github.com/milvus-io/milvus/pkg/util/tsoutil"
|
|
)
|
|
|
|
type SyncManagerSuite struct {
|
|
suite.Suite
|
|
|
|
collectionID int64
|
|
partitionID int64
|
|
segmentID int64
|
|
channelName string
|
|
|
|
metacache *metacache.MockMetaCache
|
|
allocator *allocator.MockGIDAllocator
|
|
schema *schemapb.CollectionSchema
|
|
chunkManager *mocks.ChunkManager
|
|
broker *broker.MockBroker
|
|
}
|
|
|
|
func (s *SyncManagerSuite) SetupSuite() {
|
|
paramtable.Get().Init(paramtable.NewBaseTable(paramtable.SkipRemote(true)))
|
|
|
|
s.collectionID = 100
|
|
s.partitionID = 101
|
|
s.segmentID = 1001
|
|
s.channelName = "by-dev-rootcoord-dml_0_100v0"
|
|
|
|
s.schema = &schemapb.CollectionSchema{
|
|
Name: "sync_task_test_col",
|
|
Fields: []*schemapb.FieldSchema{
|
|
{FieldID: common.RowIDField, DataType: schemapb.DataType_Int64},
|
|
{FieldID: common.TimeStampField, DataType: schemapb.DataType_Int64},
|
|
{
|
|
FieldID: 100,
|
|
Name: "pk",
|
|
DataType: schemapb.DataType_Int64,
|
|
IsPrimaryKey: true,
|
|
},
|
|
{
|
|
FieldID: 101,
|
|
Name: "vector",
|
|
DataType: schemapb.DataType_FloatVector,
|
|
TypeParams: []*commonpb.KeyValuePair{
|
|
{Key: common.DimKey, Value: "128"},
|
|
},
|
|
},
|
|
},
|
|
}
|
|
}
|
|
|
|
func (s *SyncManagerSuite) SetupTest() {
|
|
s.allocator = allocator.NewMockGIDAllocator()
|
|
s.allocator.AllocF = func(count uint32) (int64, int64, error) {
|
|
return time.Now().Unix(), int64(count), nil
|
|
}
|
|
s.allocator.AllocOneF = func() (allocator.UniqueID, error) {
|
|
return time.Now().Unix(), nil
|
|
}
|
|
|
|
s.chunkManager = mocks.NewChunkManager(s.T())
|
|
s.chunkManager.EXPECT().RootPath().Return("files").Maybe()
|
|
s.chunkManager.EXPECT().MultiWrite(mock.Anything, mock.Anything).Return(nil).Maybe()
|
|
|
|
s.broker = broker.NewMockBroker(s.T())
|
|
s.metacache = metacache.NewMockMetaCache(s.T())
|
|
}
|
|
|
|
func (s *SyncManagerSuite) getEmptyInsertBuffer() *storage.InsertData {
|
|
buf, err := storage.NewInsertData(s.schema)
|
|
s.Require().NoError(err)
|
|
|
|
return buf
|
|
}
|
|
|
|
func (s *SyncManagerSuite) getInsertBuffer() *storage.InsertData {
|
|
buf := s.getEmptyInsertBuffer()
|
|
|
|
// generate data
|
|
for i := 0; i < 10; i++ {
|
|
data := make(map[storage.FieldID]any)
|
|
data[common.RowIDField] = int64(i + 1)
|
|
data[common.TimeStampField] = int64(i + 1)
|
|
data[100] = int64(i + 1)
|
|
vector := lo.RepeatBy(128, func(_ int) float32 {
|
|
return rand.Float32()
|
|
})
|
|
data[101] = vector
|
|
err := buf.Append(data)
|
|
s.Require().NoError(err)
|
|
}
|
|
return buf
|
|
}
|
|
|
|
func (s *SyncManagerSuite) getDeleteBuffer() *storage.DeleteData {
|
|
buf := &storage.DeleteData{}
|
|
for i := 0; i < 10; i++ {
|
|
pk := storage.NewInt64PrimaryKey(int64(i + 1))
|
|
ts := tsoutil.ComposeTSByTime(time.Now(), 0)
|
|
buf.Append(pk, ts)
|
|
}
|
|
return buf
|
|
}
|
|
|
|
func (s *SyncManagerSuite) getDeleteBufferZeroTs() *storage.DeleteData {
|
|
buf := &storage.DeleteData{}
|
|
for i := 0; i < 10; i++ {
|
|
pk := storage.NewInt64PrimaryKey(int64(i + 1))
|
|
buf.Append(pk, 0)
|
|
}
|
|
return buf
|
|
}
|
|
|
|
func (s *SyncManagerSuite) getSuiteSyncTask() *SyncTask {
|
|
task := NewSyncTask().WithCollectionID(s.collectionID).
|
|
WithPartitionID(s.partitionID).
|
|
WithSegmentID(s.segmentID).
|
|
WithChannelName(s.channelName).
|
|
WithSchema(s.schema).
|
|
WithChunkManager(s.chunkManager).
|
|
WithAllocator(s.allocator).
|
|
WithMetaCache(s.metacache)
|
|
|
|
return task
|
|
}
|
|
|
|
func (s *SyncManagerSuite) TestSubmit() {
|
|
s.broker.EXPECT().SaveBinlogPaths(mock.Anything, mock.Anything).Return(nil)
|
|
bfs := metacache.NewBloomFilterSet()
|
|
seg := metacache.NewSegmentInfo(&datapb.SegmentInfo{}, bfs)
|
|
metacache.UpdateNumOfRows(1000)(seg)
|
|
s.metacache.EXPECT().GetSegmentByID(s.segmentID).Return(seg, true)
|
|
s.metacache.EXPECT().GetSegmentsBy(mock.Anything).Return([]*metacache.SegmentInfo{seg})
|
|
s.metacache.EXPECT().UpdateSegments(mock.Anything, mock.Anything).Return()
|
|
|
|
manager, err := NewSyncManager(s.chunkManager, s.allocator)
|
|
s.NoError(err)
|
|
task := s.getSuiteSyncTask()
|
|
task.WithMetaWriter(BrokerMetaWriter(s.broker))
|
|
task.WithTimeRange(50, 100)
|
|
task.WithCheckpoint(&msgpb.MsgPosition{
|
|
ChannelName: s.channelName,
|
|
MsgID: []byte{1, 2, 3, 4},
|
|
Timestamp: 100,
|
|
})
|
|
|
|
f := manager.SyncData(context.Background(), task)
|
|
s.NotNil(f)
|
|
|
|
r, err := f.Await()
|
|
s.NoError(err)
|
|
s.NoError(r)
|
|
}
|
|
|
|
func (s *SyncManagerSuite) TestCompacted() {
|
|
var segmentID atomic.Int64
|
|
s.broker.EXPECT().SaveBinlogPaths(mock.Anything, mock.Anything).Run(func(_ context.Context, req *datapb.SaveBinlogPathsRequest) {
|
|
segmentID.Store(req.GetSegmentID())
|
|
}).Return(nil)
|
|
bfs := metacache.NewBloomFilterSet()
|
|
seg := metacache.NewSegmentInfo(&datapb.SegmentInfo{}, bfs)
|
|
metacache.UpdateNumOfRows(1000)(seg)
|
|
metacache.CompactTo(1001)(seg)
|
|
s.metacache.EXPECT().GetSegmentByID(s.segmentID).Return(seg, true)
|
|
s.metacache.EXPECT().GetSegmentsBy(mock.Anything).Return([]*metacache.SegmentInfo{seg})
|
|
s.metacache.EXPECT().UpdateSegments(mock.Anything, mock.Anything).Return()
|
|
|
|
manager, err := NewSyncManager(s.chunkManager, s.allocator)
|
|
s.NoError(err)
|
|
task := s.getSuiteSyncTask()
|
|
task.WithMetaWriter(BrokerMetaWriter(s.broker))
|
|
task.WithTimeRange(50, 100)
|
|
task.WithCheckpoint(&msgpb.MsgPosition{
|
|
ChannelName: s.channelName,
|
|
MsgID: []byte{1, 2, 3, 4},
|
|
Timestamp: 100,
|
|
})
|
|
|
|
f := manager.SyncData(context.Background(), task)
|
|
s.NotNil(f)
|
|
|
|
r, err := f.Await()
|
|
s.NoError(err)
|
|
s.NoError(r)
|
|
s.EqualValues(1001, segmentID.Load())
|
|
}
|
|
|
|
func (s *SyncManagerSuite) TestBlock() {
|
|
sig := make(chan struct{})
|
|
counter := atomic.NewInt32(0)
|
|
s.broker.EXPECT().SaveBinlogPaths(mock.Anything, mock.Anything).Return(nil)
|
|
bfs := metacache.NewBloomFilterSet()
|
|
seg := metacache.NewSegmentInfo(&datapb.SegmentInfo{}, bfs)
|
|
metacache.UpdateNumOfRows(1000)(seg)
|
|
s.metacache.EXPECT().GetSegmentByID(s.segmentID).Return(seg, true)
|
|
s.metacache.EXPECT().GetSegmentsBy(mock.Anything).
|
|
RunAndReturn(func(...metacache.SegmentFilter) []*metacache.SegmentInfo {
|
|
return []*metacache.SegmentInfo{seg}
|
|
})
|
|
s.metacache.EXPECT().UpdateSegments(mock.Anything, mock.Anything).Run(func(_ metacache.SegmentAction, filters ...metacache.SegmentFilter) {
|
|
if counter.Inc() == 2 {
|
|
close(sig)
|
|
}
|
|
})
|
|
|
|
manager, err := NewSyncManager(s.chunkManager, s.allocator)
|
|
s.NoError(err)
|
|
|
|
// block
|
|
manager.Block(s.segmentID)
|
|
|
|
go func() {
|
|
task := s.getSuiteSyncTask()
|
|
task.WithMetaWriter(BrokerMetaWriter(s.broker))
|
|
task.WithTimeRange(50, 100)
|
|
task.WithCheckpoint(&msgpb.MsgPosition{
|
|
ChannelName: s.channelName,
|
|
MsgID: []byte{1, 2, 3, 4},
|
|
Timestamp: 100,
|
|
})
|
|
manager.SyncData(context.Background(), task)
|
|
}()
|
|
|
|
select {
|
|
case <-sig:
|
|
s.FailNow("sync task done during block")
|
|
default:
|
|
}
|
|
|
|
manager.Unblock(s.segmentID)
|
|
<-sig
|
|
}
|
|
|
|
func (s *SyncManagerSuite) TestResizePool() {
|
|
manager, err := NewSyncManager(s.chunkManager, s.allocator)
|
|
s.NoError(err)
|
|
|
|
syncMgr, ok := manager.(*syncManager)
|
|
s.Require().True(ok)
|
|
|
|
cap := syncMgr.keyLockDispatcher.workerPool.Cap()
|
|
s.NotZero(cap)
|
|
|
|
params := paramtable.Get()
|
|
configKey := params.DataNodeCfg.MaxParallelSyncMgrTasks.Key
|
|
|
|
syncMgr.resizeHandler(&config.Event{
|
|
Key: configKey,
|
|
Value: "abc",
|
|
HasUpdated: true,
|
|
})
|
|
|
|
s.Equal(cap, syncMgr.keyLockDispatcher.workerPool.Cap())
|
|
|
|
syncMgr.resizeHandler(&config.Event{
|
|
Key: configKey,
|
|
Value: "-1",
|
|
HasUpdated: true,
|
|
})
|
|
s.Equal(cap, syncMgr.keyLockDispatcher.workerPool.Cap())
|
|
|
|
syncMgr.resizeHandler(&config.Event{
|
|
Key: configKey,
|
|
Value: strconv.FormatInt(int64(cap*2), 10),
|
|
HasUpdated: true,
|
|
})
|
|
s.Equal(cap*2, syncMgr.keyLockDispatcher.workerPool.Cap())
|
|
}
|
|
|
|
func (s *SyncManagerSuite) TestNewSyncManager() {
|
|
manager, err := NewSyncManager(s.chunkManager, s.allocator)
|
|
s.NoError(err)
|
|
|
|
_, ok := manager.(*syncManager)
|
|
s.Require().True(ok)
|
|
|
|
params := paramtable.Get()
|
|
configKey := params.DataNodeCfg.MaxParallelSyncMgrTasks.Key
|
|
defer params.Reset(configKey)
|
|
|
|
params.Save(configKey, "0")
|
|
|
|
_, err = NewSyncManager(s.chunkManager, s.allocator)
|
|
s.Error(err)
|
|
}
|
|
|
|
func (s *SyncManagerSuite) TestTargetUpdated() {
|
|
manager, err := NewSyncManager(s.chunkManager, s.allocator)
|
|
s.NoError(err)
|
|
|
|
task := NewMockTask(s.T())
|
|
task.EXPECT().SegmentID().Return(1000)
|
|
task.EXPECT().Checkpoint().Return(&msgpb.MsgPosition{})
|
|
task.EXPECT().CalcTargetSegment().Return(1000, nil).Once()
|
|
task.EXPECT().CalcTargetSegment().Return(1001, nil).Once()
|
|
task.EXPECT().Run().Return(errTargetSegmentNotMatch).Once()
|
|
task.EXPECT().Run().Return(nil).Once()
|
|
|
|
f := manager.SyncData(context.Background(), task)
|
|
err, _ = f.Await()
|
|
s.NoError(err)
|
|
}
|
|
|
|
func TestSyncManager(t *testing.T) {
|
|
suite.Run(t, new(SyncManagerSuite))
|
|
}
|