mirror of
https://gitee.com/milvus-io/milvus.git
synced 2025-12-07 17:48:29 +08:00
cb1e86e17c
after the pr merged, we can support to insert, upsert, build index, query, search in the added field. can only do the above operates in added field after add field request complete, which is a sync operate. compact will be supported in the next pr. #39718 --------- Signed-off-by: lixinguo <xinguo.li@zilliz.com> Co-authored-by: lixinguo <xinguo.li@zilliz.com>
280 lines
8.7 KiB
Go
280 lines
8.7 KiB
Go
// Licensed to the LF AI & Data foundation under one
|
|
// or more contributor license agreements. See the NOTICE file
|
|
// distributed with this work for additional information
|
|
// regarding copyright ownership. The ASF licenses this file
|
|
// to you under the Apache License, Version 2.0 (the
|
|
// "License"); you may not use this file except in compliance
|
|
// with the License. You may obtain a copy of the License at
|
|
//
|
|
// http://www.apache.org/licenses/LICENSE-2.0
|
|
//
|
|
// Unless required by applicable law or agreed to in writing, software
|
|
// distributed under the License is distributed on an "AS IS" BASIS,
|
|
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
// See the License for the specific language governing permissions and
|
|
// limitations under the License.
|
|
|
|
package rootcoord
|
|
|
|
import (
|
|
"context"
|
|
"testing"
|
|
|
|
"github.com/cockroachdb/errors"
|
|
"github.com/stretchr/testify/assert"
|
|
"github.com/stretchr/testify/mock"
|
|
"google.golang.org/protobuf/proto"
|
|
|
|
"github.com/milvus-io/milvus-proto/go-api/v2/commonpb"
|
|
"github.com/milvus-io/milvus-proto/go-api/v2/milvuspb"
|
|
"github.com/milvus-io/milvus-proto/go-api/v2/schemapb"
|
|
"github.com/milvus-io/milvus/internal/metastore/model"
|
|
mockrootcoord "github.com/milvus-io/milvus/internal/rootcoord/mocks"
|
|
"github.com/milvus-io/milvus/pkg/v2/util/merr"
|
|
)
|
|
|
|
func Test_AddCollectionFieldTask_Prepare(t *testing.T) {
|
|
t.Run("invalid msg type", func(t *testing.T) {
|
|
task := &addCollectionFieldTask{Req: &milvuspb.AddCollectionFieldRequest{Base: &commonpb.MsgBase{MsgType: commonpb.MsgType_DropCollection}}}
|
|
err := task.Prepare(context.Background())
|
|
assert.Error(t, err)
|
|
})
|
|
|
|
t.Run("check field failed", func(t *testing.T) {
|
|
fieldSchema := &schemapb.FieldSchema{
|
|
DataType: schemapb.DataType_Int64,
|
|
DefaultValue: &schemapb.ValueField{
|
|
Data: &schemapb.ValueField_BoolData{
|
|
BoolData: false,
|
|
},
|
|
},
|
|
}
|
|
bytes, err := proto.Marshal(fieldSchema)
|
|
assert.NoError(t, err)
|
|
task := &addCollectionFieldTask{Req: &milvuspb.AddCollectionFieldRequest{Base: &commonpb.MsgBase{MsgType: commonpb.MsgType_AddCollectionField}, Schema: bytes}}
|
|
err = task.Prepare(context.Background())
|
|
assert.Error(t, err)
|
|
})
|
|
|
|
t.Run("normal case", func(t *testing.T) {
|
|
fieldSchema := &schemapb.FieldSchema{
|
|
DataType: schemapb.DataType_Bool,
|
|
DefaultValue: &schemapb.ValueField{
|
|
Data: &schemapb.ValueField_BoolData{
|
|
BoolData: false,
|
|
},
|
|
},
|
|
}
|
|
bytes, err := proto.Marshal(fieldSchema)
|
|
assert.NoError(t, err)
|
|
task := &addCollectionFieldTask{Req: &milvuspb.AddCollectionFieldRequest{Base: &commonpb.MsgBase{MsgType: commonpb.MsgType_AddCollectionField}, Schema: bytes}}
|
|
err = task.Prepare(context.Background())
|
|
assert.NoError(t, err)
|
|
})
|
|
}
|
|
|
|
func Test_AddCollectionFieldTask_Execute(t *testing.T) {
|
|
t.Run("failed to get collection", func(t *testing.T) {
|
|
metaTable := mockrootcoord.NewIMetaTable(t)
|
|
metaTable.EXPECT().GetCollectionByName(mock.Anything, mock.Anything, "not_existed_coll", mock.Anything).Return(nil, merr.WrapErrCollectionNotFound("not_existed_coll"))
|
|
core := newTestCore(withMeta(metaTable))
|
|
task := &addCollectionFieldTask{
|
|
baseTask: newBaseTask(context.Background(), core),
|
|
Req: &milvuspb.AddCollectionFieldRequest{
|
|
Base: &commonpb.MsgBase{MsgType: commonpb.MsgType_AlterAlias},
|
|
CollectionName: "not_existed_coll",
|
|
},
|
|
}
|
|
err := task.Execute(context.Background())
|
|
assert.Error(t, err)
|
|
})
|
|
|
|
t.Run("add field step failed", func(t *testing.T) {
|
|
meta := mockrootcoord.NewIMetaTable(t)
|
|
meta.On("GetCollectionByName",
|
|
mock.Anything,
|
|
mock.Anything,
|
|
mock.Anything,
|
|
mock.Anything,
|
|
).Return(&model.Collection{CollectionID: int64(1), Fields: []*model.Field{
|
|
{
|
|
Name: "pk",
|
|
IsPrimaryKey: true,
|
|
DataType: schemapb.DataType_Int64,
|
|
},
|
|
{
|
|
Name: "vec",
|
|
DataType: schemapb.DataType_FloatVector,
|
|
},
|
|
}}, nil)
|
|
meta.On("AlterCollection",
|
|
mock.Anything,
|
|
mock.Anything,
|
|
mock.Anything,
|
|
mock.Anything,
|
|
).Return(errors.New("mock"))
|
|
meta.On("ListAliasesByID", mock.Anything, mock.Anything).Return([]string{})
|
|
alloc := newMockIDAllocator()
|
|
core := newTestCore(withValidProxyManager(), withMeta(meta), withIDAllocator(alloc))
|
|
task := &addCollectionFieldTask{
|
|
baseTask: newBaseTask(context.Background(), core),
|
|
Req: &milvuspb.AddCollectionFieldRequest{
|
|
Base: &commonpb.MsgBase{MsgType: commonpb.MsgType_AlterAlias},
|
|
CollectionName: "coll",
|
|
},
|
|
fieldSchema: &schemapb.FieldSchema{
|
|
Name: "fid",
|
|
DataType: schemapb.DataType_Bool,
|
|
Nullable: true,
|
|
},
|
|
}
|
|
err := task.Execute(context.Background())
|
|
assert.Error(t, err)
|
|
})
|
|
|
|
t.Run("broadcast add field step failed", func(t *testing.T) {
|
|
meta := mockrootcoord.NewIMetaTable(t)
|
|
meta.On("GetCollectionByName",
|
|
mock.Anything,
|
|
mock.Anything,
|
|
mock.Anything,
|
|
mock.Anything,
|
|
).Return(&model.Collection{CollectionID: int64(1), Fields: []*model.Field{
|
|
{
|
|
Name: "pk",
|
|
IsPrimaryKey: true,
|
|
DataType: schemapb.DataType_Int64,
|
|
},
|
|
{
|
|
Name: "vec",
|
|
DataType: schemapb.DataType_FloatVector,
|
|
},
|
|
}}, nil)
|
|
meta.On("AlterCollection",
|
|
mock.Anything,
|
|
mock.Anything,
|
|
mock.Anything,
|
|
mock.Anything,
|
|
).Return(nil)
|
|
meta.On("ListAliasesByID", mock.Anything, mock.Anything).Return([]string{})
|
|
|
|
broker := newMockBroker()
|
|
broker.BroadcastAlteredCollectionFunc = func(ctx context.Context, req *milvuspb.AlterCollectionRequest) error {
|
|
return errors.New("mock")
|
|
}
|
|
alloc := newMockIDAllocator()
|
|
core := newTestCore(withValidProxyManager(), withMeta(meta), withBroker(broker), withIDAllocator(alloc))
|
|
task := &addCollectionFieldTask{
|
|
baseTask: newBaseTask(context.Background(), core),
|
|
Req: &milvuspb.AddCollectionFieldRequest{
|
|
Base: &commonpb.MsgBase{MsgType: commonpb.MsgType_AlterAlias},
|
|
CollectionName: "coll",
|
|
},
|
|
fieldSchema: &schemapb.FieldSchema{
|
|
Name: "fid",
|
|
DataType: schemapb.DataType_Bool,
|
|
Nullable: true,
|
|
},
|
|
}
|
|
err := task.Execute(context.Background())
|
|
assert.Error(t, err)
|
|
})
|
|
|
|
t.Run("expire cache failed", func(t *testing.T) {
|
|
meta := mockrootcoord.NewIMetaTable(t)
|
|
meta.On("GetCollectionByName",
|
|
mock.Anything,
|
|
mock.Anything,
|
|
mock.Anything,
|
|
mock.Anything,
|
|
).Return(&model.Collection{CollectionID: int64(1), Fields: []*model.Field{
|
|
{
|
|
Name: "pk",
|
|
IsPrimaryKey: true,
|
|
DataType: schemapb.DataType_Int64,
|
|
},
|
|
{
|
|
Name: "vec",
|
|
DataType: schemapb.DataType_FloatVector,
|
|
},
|
|
}}, nil)
|
|
meta.On("AlterCollection",
|
|
mock.Anything,
|
|
mock.Anything,
|
|
mock.Anything,
|
|
mock.Anything,
|
|
).Return(nil)
|
|
meta.On("ListAliasesByID", mock.Anything, mock.Anything).Return([]string{})
|
|
|
|
broker := newMockBroker()
|
|
broker.BroadcastAlteredCollectionFunc = func(ctx context.Context, req *milvuspb.AlterCollectionRequest) error {
|
|
return nil
|
|
}
|
|
|
|
alloc := newMockIDAllocator()
|
|
core := newTestCore(withInvalidProxyManager(), withMeta(meta), withBroker(broker), withIDAllocator(alloc))
|
|
task := &addCollectionFieldTask{
|
|
baseTask: newBaseTask(context.Background(), core),
|
|
Req: &milvuspb.AddCollectionFieldRequest{
|
|
Base: &commonpb.MsgBase{MsgType: commonpb.MsgType_AlterAlias},
|
|
CollectionName: "coll",
|
|
},
|
|
fieldSchema: &schemapb.FieldSchema{
|
|
Name: "fid",
|
|
DataType: schemapb.DataType_Bool,
|
|
Nullable: true,
|
|
},
|
|
}
|
|
err := task.Execute(context.Background())
|
|
assert.Error(t, err)
|
|
})
|
|
|
|
t.Run("normal case", func(t *testing.T) {
|
|
meta := mockrootcoord.NewIMetaTable(t)
|
|
meta.On("GetCollectionByName",
|
|
mock.Anything,
|
|
mock.Anything,
|
|
mock.Anything,
|
|
mock.Anything,
|
|
).Return(&model.Collection{CollectionID: int64(1), Fields: []*model.Field{
|
|
{
|
|
Name: "pk",
|
|
IsPrimaryKey: true,
|
|
DataType: schemapb.DataType_Int64,
|
|
},
|
|
{
|
|
Name: "vec",
|
|
DataType: schemapb.DataType_FloatVector,
|
|
},
|
|
}}, nil)
|
|
meta.On("AlterCollection",
|
|
mock.Anything,
|
|
mock.Anything,
|
|
mock.Anything,
|
|
mock.Anything,
|
|
).Return(nil)
|
|
meta.On("ListAliasesByID", mock.Anything, mock.Anything).Return([]string{})
|
|
|
|
broker := newMockBroker()
|
|
broker.BroadcastAlteredCollectionFunc = func(ctx context.Context, req *milvuspb.AlterCollectionRequest) error {
|
|
return nil
|
|
}
|
|
alloc := newMockIDAllocator()
|
|
core := newTestCore(withValidProxyManager(), withMeta(meta), withBroker(broker), withIDAllocator(alloc))
|
|
task := &addCollectionFieldTask{
|
|
baseTask: newBaseTask(context.Background(), core),
|
|
Req: &milvuspb.AddCollectionFieldRequest{
|
|
Base: &commonpb.MsgBase{MsgType: commonpb.MsgType_AlterAlias},
|
|
CollectionName: "coll",
|
|
},
|
|
fieldSchema: &schemapb.FieldSchema{
|
|
Name: "fid",
|
|
DataType: schemapb.DataType_Bool,
|
|
Nullable: true,
|
|
},
|
|
}
|
|
err := task.Execute(context.Background())
|
|
assert.NoError(t, err)
|
|
})
|
|
}
|