mirror of
https://gitee.com/milvus-io/milvus.git
synced 2025-12-06 17:18:35 +08:00
f5f053f1d2
Related to #44761 This commit refactors the privilege management system in the proxy component by: 1. **Separation of Concerns**: Extracts privilege-related functionality from MetaCache into a dedicated `internal/proxy/privilege` package, improving code organization and maintainability. 2. **New Package Structure**: Creates `internal/proxy/privilege/` with: - `cache.go`: Core privilege cache implementation (PrivilegeCache) - `result_cache.go`: Privilege enforcement result caching - `model.go`: Casbin model and policy enforcement functions - `meta_cache_adapter.go`: Casbin adapter for MetaCache integration - Corresponding test files and mock implementations 3. **MetaCache Simplification**: Removes privilege and credential management methods from MetaCache interface and implementation: - Removed: GetCredentialInfo, RemoveCredential, UpdateCredential - Removed: GetPrivilegeInfo, GetUserRole, RefreshPolicyInfo, InitPolicyInfo - Deleted: meta_cache_adapter.go, privilege_cache.go and their tests 4. **Updated References**: Updates all callsites to use the new privilegeCache global: - Authentication interceptor now uses privilegeCache for password verification - Credential cache operations (InvalidateCredentialCache, UpdateCredentialCache, UpdateCredential) now use privilegeCache - Policy refresh operations (RefreshPolicyInfoCache) now use privilegeCache - Privilege interceptor uses new privilege.GetEnforcer() and privilege result cache 5. **Improved API**: Renames cache functions for clarity: - GetPrivilegeCache → GetResultCache - SetPrivilegeCache → SetResultCache - CleanPrivilegeCache → CleanResultCache This refactoring makes the codebase more modular, separates privilege management concerns from general metadata caching, and provides a clearer API for privilege enforcement operations. --------- Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
77 lines
2.2 KiB
Go
77 lines
2.2 KiB
Go
// Licensed to the LF AI & Data foundation under one
|
|
// or more contributor license agreements. See the NOTICE file
|
|
// distributed with this work for additional information
|
|
// regarding copyright ownership. The ASF licenses this file
|
|
// to you under the Apache License, Version 2.0 (the
|
|
// "License"); you may not use this file except in compliance
|
|
// with the License. You may obtain a copy of the License at
|
|
//
|
|
// http://www.apache.org/licenses/LICENSE-2.0
|
|
//
|
|
// Unless required by applicable law or agreed to in writing, software
|
|
// distributed under the License is distributed on an "AS IS" BASIS,
|
|
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
// See the License for the specific language governing permissions and
|
|
// limitations under the License.
|
|
|
|
package privilege
|
|
|
|
import (
|
|
"testing"
|
|
|
|
"github.com/stretchr/testify/mock"
|
|
"github.com/stretchr/testify/suite"
|
|
)
|
|
|
|
type MetaCacheCasbinAdapterSuite struct {
|
|
suite.Suite
|
|
|
|
cache *MockPrivilegeCache
|
|
adapter *MetaCacheCasbinAdapter
|
|
}
|
|
|
|
func (s *MetaCacheCasbinAdapterSuite) SetupTest() {
|
|
s.cache = NewMockPrivilegeCache(s.T())
|
|
|
|
s.adapter = NewMetaCacheCasbinAdapter(func() PrivilegeCache { return s.cache })
|
|
}
|
|
|
|
func (s *MetaCacheCasbinAdapterSuite) TestLoadPolicy() {
|
|
s.Run("normal_load", func() {
|
|
s.cache.EXPECT().GetPrivilegeInfo(mock.Anything).Return([]string{})
|
|
|
|
m := GetPolicyModel(ModelStr)
|
|
err := s.adapter.LoadPolicy(m)
|
|
s.NoError(err)
|
|
})
|
|
|
|
s.Run("source_return_nil", func() {
|
|
adapter := NewMetaCacheCasbinAdapter(func() PrivilegeCache { return nil })
|
|
|
|
m := GetPolicyModel(ModelStr)
|
|
err := adapter.LoadPolicy(m)
|
|
s.Error(err)
|
|
})
|
|
}
|
|
|
|
func (s *MetaCacheCasbinAdapterSuite) TestSavePolicy() {
|
|
m := GetPolicyModel(ModelStr)
|
|
s.Error(s.adapter.SavePolicy(m))
|
|
}
|
|
|
|
func (s *MetaCacheCasbinAdapterSuite) TestAddPolicy() {
|
|
s.Error(s.adapter.AddPolicy("", "", []string{}))
|
|
}
|
|
|
|
func (s *MetaCacheCasbinAdapterSuite) TestRemovePolicy() {
|
|
s.Error(s.adapter.RemovePolicy("", "", []string{}))
|
|
}
|
|
|
|
func (s *MetaCacheCasbinAdapterSuite) TestRemoveFiltererPolicy() {
|
|
s.Error(s.adapter.RemoveFilteredPolicy("", "", 0))
|
|
}
|
|
|
|
func TestMetaCacheCasbinAdapter(t *testing.T) {
|
|
suite.Run(t, new(MetaCacheCasbinAdapterSuite))
|
|
}
|