mirror of
https://gitee.com/milvus-io/milvus.git
synced 2026-01-07 19:31:51 +08:00
issue: https://github.com/milvus-io/milvus/issues/44123 <!-- This is an auto-generated comment: release notes by coderabbit.ai --> - Core invariant: legacy in-cluster CDC/replication plumbing (ReplicateMsg types, ReplicateID-based guards and flags) is obsolete — the system relies on standard msgstream positions, subPos/end-ts semantics and timetick ordering as the single source of truth for message ordering and skipping, so replication-specific channels/types/guards can be removed safely. - Removed/simplified logic (what and why): removed replication feature flags and params (ReplicateMsgChannel, TTMsgEnabled, CollectionReplicateEnable), ReplicateMsg type and its tests, ReplicateID constants/helpers and MergeProperties hooks, ReplicateConfig and its propagation (streamPipeline, StreamConfig, dispatcher, target), replicate-aware dispatcher/pipeline branches, and replicate-mode pre-checks/timestamp-allocation in proxy tasks — these implemented a redundant alternate “replicate-mode” pathway that duplicated position/end-ts and timetick logic. - Why this does NOT cause data loss or regression (concrete code paths): no persistence or core write paths were removed — proxy PreExecute flows (internal/proxy/task_*.go) still perform the same schema/ID/size validations and then follow the normal non-replicate execution path; dispatcher and pipeline continue to use position/subPos and pullback/end-ts in Seek/grouping (pkg/mq/msgdispatcher/dispatcher.go, internal/util/pipeline/stream_pipeline.go), so skipping and ordering behavior remains unchanged; timetick emission in rootcoord (sendMinDdlTsAsTt) is now ungated (no silent suppression), preserving or increasing timetick delivery rather than removing it. - PR type and net effect: Enhancement/Refactor — removes deprecated replication API surface (types, helpers, config, tests) and replication branches, simplifies public APIs and constructor signatures, and reduces surface area for future maintenance while keeping DML/DDL persistence, ordering, and seek semantics intact. <!-- end of auto-generated comment: release notes by coderabbit.ai --> --------- Signed-off-by: bigsheeper <yihao.dai@zilliz.com>
143 lines
4.1 KiB
Go
143 lines
4.1 KiB
Go
/*
|
|
* Licensed to the LF AI & Data foundation under one
|
|
* or more contributor license agreements. See the NOTICE file
|
|
* distributed with this work for additional information
|
|
* regarding copyright ownership. The ASF licenses this file
|
|
* to you under the Apache License, Version 2.0 (the
|
|
* "License"); you may not use this file except in compliance
|
|
* with the License. You may obtain a copy of the License at
|
|
*
|
|
* http://www.apache.org/licenses/LICENSE-2.0
|
|
*
|
|
* Unless required by applicable law or agreed to in writing, software
|
|
* distributed under the License is distributed on an "AS IS" BASIS,
|
|
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
* See the License for the specific language governing permissions and
|
|
* limitations under the License.
|
|
*/
|
|
|
|
package msgstream
|
|
|
|
import (
|
|
"testing"
|
|
|
|
"github.com/stretchr/testify/assert"
|
|
|
|
"github.com/milvus-io/milvus-proto/go-api/v2/commonpb"
|
|
"github.com/milvus-io/milvus-proto/go-api/v2/milvuspb"
|
|
)
|
|
|
|
func TestCreateDatabase(t *testing.T) {
|
|
var msg TsMsg = &CreateDatabaseMsg{
|
|
CreateDatabaseRequest: &milvuspb.CreateDatabaseRequest{
|
|
Base: &commonpb.MsgBase{
|
|
MsgType: commonpb.MsgType_CreateDatabase,
|
|
MsgID: 100,
|
|
Timestamp: 1000,
|
|
SourceID: 10000,
|
|
TargetID: 100000,
|
|
},
|
|
DbName: "unit_db",
|
|
},
|
|
}
|
|
assert.EqualValues(t, 100, msg.ID())
|
|
msg.SetID(200)
|
|
assert.EqualValues(t, 200, msg.ID())
|
|
assert.Equal(t, commonpb.MsgType_CreateDatabase, msg.Type())
|
|
assert.EqualValues(t, 10000, msg.SourceID())
|
|
|
|
msgBytes, err := msg.Marshal(msg)
|
|
assert.NoError(t, err)
|
|
|
|
var newMsg TsMsg = &CreateDatabaseMsg{}
|
|
_, err = newMsg.Unmarshal("1")
|
|
assert.Error(t, err)
|
|
|
|
newMsg, err = newMsg.Unmarshal(msgBytes)
|
|
assert.NoError(t, err)
|
|
assert.EqualValues(t, 200, newMsg.ID())
|
|
assert.EqualValues(t, 1000, newMsg.BeginTs())
|
|
assert.EqualValues(t, 1000, newMsg.EndTs())
|
|
assert.EqualValues(t, "unit_db", newMsg.(*CreateDatabaseMsg).DbName)
|
|
|
|
assert.True(t, msg.Size() > 0)
|
|
}
|
|
|
|
func TestDropDatabase(t *testing.T) {
|
|
var msg TsMsg = &DropDatabaseMsg{
|
|
DropDatabaseRequest: &milvuspb.DropDatabaseRequest{
|
|
Base: &commonpb.MsgBase{
|
|
MsgType: commonpb.MsgType_DropDatabase,
|
|
MsgID: 100,
|
|
Timestamp: 1000,
|
|
SourceID: 10000,
|
|
TargetID: 100000,
|
|
},
|
|
DbName: "unit_db",
|
|
},
|
|
}
|
|
assert.EqualValues(t, 100, msg.ID())
|
|
msg.SetID(200)
|
|
assert.EqualValues(t, 200, msg.ID())
|
|
assert.Equal(t, commonpb.MsgType_DropDatabase, msg.Type())
|
|
assert.EqualValues(t, 10000, msg.SourceID())
|
|
|
|
msgBytes, err := msg.Marshal(msg)
|
|
assert.NoError(t, err)
|
|
|
|
var newMsg TsMsg = &DropDatabaseMsg{}
|
|
_, err = newMsg.Unmarshal("1")
|
|
assert.Error(t, err)
|
|
|
|
newMsg, err = newMsg.Unmarshal(msgBytes)
|
|
assert.NoError(t, err)
|
|
assert.EqualValues(t, 200, newMsg.ID())
|
|
assert.EqualValues(t, 1000, newMsg.BeginTs())
|
|
assert.EqualValues(t, 1000, newMsg.EndTs())
|
|
assert.EqualValues(t, "unit_db", newMsg.(*DropDatabaseMsg).DbName)
|
|
|
|
assert.True(t, msg.Size() > 0)
|
|
}
|
|
|
|
func TestAlterDatabase(t *testing.T) {
|
|
var msg TsMsg = &AlterDatabaseMsg{
|
|
AlterDatabaseRequest: &milvuspb.AlterDatabaseRequest{
|
|
Base: &commonpb.MsgBase{
|
|
MsgType: commonpb.MsgType_AlterDatabase,
|
|
MsgID: 100,
|
|
Timestamp: 1000,
|
|
SourceID: 10000,
|
|
TargetID: 100000,
|
|
},
|
|
DbName: "unit_db",
|
|
Properties: []*commonpb.KeyValuePair{
|
|
{
|
|
Key: "key",
|
|
Value: "value",
|
|
},
|
|
},
|
|
},
|
|
}
|
|
assert.EqualValues(t, 100, msg.ID())
|
|
msg.SetID(200)
|
|
assert.EqualValues(t, 200, msg.ID())
|
|
assert.Equal(t, commonpb.MsgType_AlterDatabase, msg.Type())
|
|
assert.EqualValues(t, 10000, msg.SourceID())
|
|
|
|
msgBytes, err := msg.Marshal(msg)
|
|
assert.NoError(t, err)
|
|
|
|
var newMsg TsMsg = &AlterDatabaseMsg{}
|
|
_, err = newMsg.Unmarshal("1")
|
|
assert.Error(t, err)
|
|
|
|
newMsg, err = newMsg.Unmarshal(msgBytes)
|
|
assert.NoError(t, err)
|
|
assert.EqualValues(t, 200, newMsg.ID())
|
|
assert.EqualValues(t, 1000, newMsg.BeginTs())
|
|
assert.EqualValues(t, 1000, newMsg.EndTs())
|
|
assert.EqualValues(t, "unit_db", newMsg.(*AlterDatabaseMsg).DbName)
|
|
assert.EqualValues(t, "key", newMsg.(*AlterDatabaseMsg).Properties[0].Key)
|
|
assert.EqualValues(t, "value", newMsg.(*AlterDatabaseMsg).Properties[0].Value)
|
|
}
|