yihao.dai a0f6b31380
fix: Fix primary-secondary replication switch blocking (#44898)
1. Fix primary-secondary replication switchover blocking by delete
replicate pchannel meta using modRevision.
2. Stop channel replicator(scanner) when cluster role changes to prevent
continued message consumption and replication.
3. Close Milvus client to prevent goroutine leak.
4. Create Milvus client once for a channel replicator.
5. Simplify CDC controller and resources.

issue: https://github.com/milvus-io/milvus/issues/44123

---------

Signed-off-by: bigsheeper <yihao.dai@zilliz.com>
2025-10-22 10:12:04 +08:00

147 lines
3.7 KiB
Go

// Licensed to the LF AI & Data foundation under one
// or more contributor license agreements. See the NOTICE file
// distributed with this work for additional information
// regarding copyright ownership. The ASF licenses this file
// to you under the Apache License, Version 2.0 (the
// "License"); you may not use this file except in compliance
// with the License. You may obtain a copy of the License at
//
// http://www.apache.org/licenses/LICENSE-2.0
//
// Unless required by applicable law or agreed to in writing, software
// distributed under the License is distributed on an "AS IS" BASIS,
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
// See the License for the specific language governing permissions and
// limitations under the License.
package cdc
import (
"context"
"sync"
clientv3 "go.etcd.io/etcd/client/v3"
"go.uber.org/zap"
"github.com/milvus-io/milvus-proto/go-api/v2/commonpb"
"github.com/milvus-io/milvus-proto/go-api/v2/milvuspb"
"github.com/milvus-io/milvus/internal/cdc"
"github.com/milvus-io/milvus/internal/cdc/replication/replicatemanager"
"github.com/milvus-io/milvus/internal/cdc/resource"
"github.com/milvus-io/milvus/internal/util/componentutil"
kvfactory "github.com/milvus-io/milvus/internal/util/dependency/kv"
"github.com/milvus-io/milvus/pkg/v2/log"
"github.com/milvus-io/milvus/pkg/v2/util/typeutil"
)
// Server is the server of cdc.
type Server struct {
ctx context.Context
cancel context.CancelFunc
cdcServer *cdc.CDCServer
etcdCli *clientv3.Client
componentState *componentutil.ComponentStateService
stopOnce sync.Once
}
// NewServer create a new CDC server.
func NewServer(ctx context.Context) (*Server, error) {
ctx1, cancel := context.WithCancel(ctx)
return &Server{
ctx: ctx1,
cancel: cancel,
componentState: componentutil.NewComponentStateService(typeutil.CDCRole),
stopOnce: sync.Once{},
}, nil
}
func (s *Server) Prepare() error {
return nil
}
// Run runs the server.
func (s *Server) Run() error {
if err := s.init(); err != nil {
return err
}
log.Ctx(s.ctx).Info("cdc init done")
if err := s.start(); err != nil {
return err
}
log.Ctx(s.ctx).Info("cdc start done")
return nil
}
// Stop stops the server, should be call after Run returned.
func (s *Server) Stop() (err error) {
s.stopOnce.Do(s.stop)
return nil
}
// stop stops the server.
func (s *Server) stop() {
s.componentState.OnStopping()
log := log.Ctx(s.ctx)
log.Info("stopping cdc...")
// Stop CDC service.
s.cdcServer.Stop()
// Stop etcd
if s.etcdCli != nil {
if err := s.etcdCli.Close(); err != nil {
log.Warn("cdc stop etcd client failed", zap.Error(err))
}
}
log.Info("cdc stop done")
}
// Health check the health status of cdc.
func (s *Server) Health(ctx context.Context) commonpb.StateCode {
resp, _ := s.componentState.GetComponentStates(ctx, &milvuspb.GetComponentStatesRequest{})
return resp.GetState().StateCode
}
func (s *Server) init() (err error) {
log := log.Ctx(s.ctx)
defer func() {
if err != nil {
log.Error("cdc init failed", zap.Error(err))
return
}
log.Info("init cdc server finished")
}()
// Create etcd client.
s.etcdCli, _ = kvfactory.GetEtcdAndPath()
// Create CDC service.
s.cdcServer = cdc.NewCDCServer(s.ctx)
resource.Init(
resource.OptETCD(s.etcdCli),
resource.OptReplicateManagerClient(replicatemanager.NewReplicateManager()),
)
return nil
}
func (s *Server) start() (err error) {
log := log.Ctx(s.ctx)
defer func() {
if err != nil {
log.Error("CDC start failed", zap.Error(err))
return
}
log.Info("start CDC server finished")
}()
s.cdcServer.Start()
s.componentState.OnInitialized(0)
return nil
}