mirror of
https://gitee.com/milvus-io/milvus.git
synced 2026-01-07 19:31:51 +08:00
issue: https://github.com/milvus-io/milvus/issues/44123 <!-- This is an auto-generated comment: release notes by coderabbit.ai --> - Core invariant: legacy in-cluster CDC/replication plumbing (ReplicateMsg types, ReplicateID-based guards and flags) is obsolete — the system relies on standard msgstream positions, subPos/end-ts semantics and timetick ordering as the single source of truth for message ordering and skipping, so replication-specific channels/types/guards can be removed safely. - Removed/simplified logic (what and why): removed replication feature flags and params (ReplicateMsgChannel, TTMsgEnabled, CollectionReplicateEnable), ReplicateMsg type and its tests, ReplicateID constants/helpers and MergeProperties hooks, ReplicateConfig and its propagation (streamPipeline, StreamConfig, dispatcher, target), replicate-aware dispatcher/pipeline branches, and replicate-mode pre-checks/timestamp-allocation in proxy tasks — these implemented a redundant alternate “replicate-mode” pathway that duplicated position/end-ts and timetick logic. - Why this does NOT cause data loss or regression (concrete code paths): no persistence or core write paths were removed — proxy PreExecute flows (internal/proxy/task_*.go) still perform the same schema/ID/size validations and then follow the normal non-replicate execution path; dispatcher and pipeline continue to use position/subPos and pullback/end-ts in Seek/grouping (pkg/mq/msgdispatcher/dispatcher.go, internal/util/pipeline/stream_pipeline.go), so skipping and ordering behavior remains unchanged; timetick emission in rootcoord (sendMinDdlTsAsTt) is now ungated (no silent suppression), preserving or increasing timetick delivery rather than removing it. - PR type and net effect: Enhancement/Refactor — removes deprecated replication API surface (types, helpers, config, tests) and replication branches, simplifies public APIs and constructor signatures, and reduces surface area for future maintenance while keeping DML/DDL persistence, ordering, and seek semantics intact. <!-- end of auto-generated comment: release notes by coderabbit.ai --> --------- Signed-off-by: bigsheeper <yihao.dai@zilliz.com>
132 lines
4.2 KiB
Go
132 lines
4.2 KiB
Go
package streaming
|
|
|
|
import (
|
|
"context"
|
|
|
|
"go.uber.org/zap"
|
|
|
|
"github.com/milvus-io/milvus/pkg/v2/log"
|
|
"github.com/milvus-io/milvus/pkg/v2/mq/common"
|
|
"github.com/milvus-io/milvus/pkg/v2/mq/msgstream"
|
|
"github.com/milvus-io/milvus/pkg/v2/streaming/util/message"
|
|
"github.com/milvus-io/milvus/pkg/v2/streaming/util/message/adaptor"
|
|
"github.com/milvus-io/milvus/pkg/v2/streaming/util/options"
|
|
"github.com/milvus-io/milvus/pkg/v2/util/funcutil"
|
|
)
|
|
|
|
var (
|
|
_ msgstream.Factory = (*delegatorMsgstreamFactory)(nil)
|
|
_ msgstream.MsgStream = (*delegatorMsgstreamAdaptor)(nil)
|
|
)
|
|
|
|
// NewDelegatorMsgstreamFactory returns a streaming-based msgstream factory for delegator.
|
|
func NewDelegatorMsgstreamFactory() msgstream.Factory {
|
|
return &delegatorMsgstreamFactory{}
|
|
}
|
|
|
|
// Only for delegator.
|
|
type delegatorMsgstreamFactory struct{}
|
|
|
|
func (f *delegatorMsgstreamFactory) NewMsgStream(ctx context.Context) (msgstream.MsgStream, error) {
|
|
panic("should never be called")
|
|
}
|
|
|
|
func (f *delegatorMsgstreamFactory) NewTtMsgStream(ctx context.Context) (msgstream.MsgStream, error) {
|
|
return &delegatorMsgstreamAdaptor{}, nil
|
|
}
|
|
|
|
func (f *delegatorMsgstreamFactory) NewMsgStreamDisposer(ctx context.Context) func([]string, string) error {
|
|
panic("should never be called")
|
|
}
|
|
|
|
// Only for delegator.
|
|
type delegatorMsgstreamAdaptor struct {
|
|
scanner Scanner
|
|
ch <-chan *msgstream.ConsumeMsgPack
|
|
}
|
|
|
|
func (m *delegatorMsgstreamAdaptor) Close() {
|
|
if m.scanner != nil {
|
|
m.scanner.Close()
|
|
}
|
|
}
|
|
|
|
func (m *delegatorMsgstreamAdaptor) AsProducer(ctx context.Context, channels []string) {
|
|
panic("should never be called")
|
|
}
|
|
|
|
func (m *delegatorMsgstreamAdaptor) Produce(context.Context, *msgstream.MsgPack) error {
|
|
panic("should never be called")
|
|
}
|
|
|
|
func (m *delegatorMsgstreamAdaptor) SetRepackFunc(repackFunc msgstream.RepackFunc) {
|
|
panic("should never be called")
|
|
}
|
|
|
|
func (m *delegatorMsgstreamAdaptor) GetProduceChannels() []string {
|
|
panic("should never be called")
|
|
}
|
|
|
|
func (m *delegatorMsgstreamAdaptor) Broadcast(context.Context, *msgstream.MsgPack) (map[string][]msgstream.MessageID, error) {
|
|
panic("should never be called")
|
|
}
|
|
|
|
func (m *delegatorMsgstreamAdaptor) AsConsumer(ctx context.Context, channels []string, subName string, position common.SubscriptionInitialPosition) error {
|
|
// always ignored.
|
|
if position != common.SubscriptionPositionUnknown {
|
|
panic("should never be called")
|
|
}
|
|
return nil
|
|
}
|
|
|
|
func (m *delegatorMsgstreamAdaptor) Chan() <-chan *msgstream.ConsumeMsgPack {
|
|
if m.ch == nil {
|
|
panic("should never be called if seek is not done")
|
|
}
|
|
return m.ch
|
|
}
|
|
|
|
func (m *delegatorMsgstreamAdaptor) GetUnmarshalDispatcher() msgstream.UnmarshalDispatcher {
|
|
return adaptor.UnmashalerDispatcher
|
|
}
|
|
|
|
func (m *delegatorMsgstreamAdaptor) Seek(ctx context.Context, msgPositions []*msgstream.MsgPosition, includeCurrentMsg bool) error {
|
|
if len(msgPositions) != 1 {
|
|
panic("should never be called if len(msgPositions) is not 1")
|
|
}
|
|
position := msgPositions[0]
|
|
startFrom := adaptor.MustGetMessageIDFromMQWrapperIDBytes(position.MsgID)
|
|
log.Info(
|
|
"delegator msgstream adaptor seeks from position with scanner",
|
|
zap.String("channel", position.GetChannelName()),
|
|
zap.Any("startFromMessageID", startFrom),
|
|
zap.Uint64("timestamp", position.GetTimestamp()),
|
|
)
|
|
handler := adaptor.NewMsgPackAdaptorHandler()
|
|
if funcutil.IsControlChannel(position.GetChannelName()) {
|
|
panic("should never seek from control channel at delegator msgstream adaptor")
|
|
}
|
|
pchannel := funcutil.ToPhysicalChannel(position.GetChannelName())
|
|
m.scanner = WAL().Read(ctx, ReadOption{
|
|
PChannel: pchannel,
|
|
DeliverPolicy: options.DeliverPolicyStartFrom(startFrom),
|
|
DeliverFilters: []options.DeliverFilter{
|
|
// only consume messages with timestamp >= position timestamp
|
|
options.DeliverFilterTimeTickGTE(position.GetTimestamp()),
|
|
// only consume insert and delete messages
|
|
options.DeliverFilterMessageType(message.MessageTypeInsert, message.MessageTypeDelete, message.MessageTypeSchemaChange, message.MessageTypeAlterCollection),
|
|
},
|
|
MessageHandler: handler,
|
|
})
|
|
m.ch = handler.Chan()
|
|
return nil
|
|
}
|
|
|
|
func (m *delegatorMsgstreamAdaptor) GetLatestMsgID(channel string) (msgstream.MessageID, error) {
|
|
panic("should never be called")
|
|
}
|
|
|
|
func (m *delegatorMsgstreamAdaptor) CheckTopicValid(channel string) error {
|
|
panic("should never be called")
|
|
}
|