milvus/internal/rootcoord/task_test.go
Zhen Ye 122d024df4
enhance: cherry pick patch of new DDL framework and CDC 3 (#45280)
issue: #43897, #44123
pr: #45266
also pick pr: #45237, #45264,#45244,#45275

fix: kafka should auto reset the offset from earliest to read (#45237)

issue: #44172, #45210, #44851,#45244

kafka will auto reset the offset to "latest" if the offset is
Out-of-range. the recovery of milvus wal cannot read any message from
that. So once the offset is out-of-range, kafka should read from eariest
to read the latest uncleared data.


https://kafka.apache.org/documentation/#consumerconfigs_auto.offset.reset

enhance: support alter collection/database with WAL-based DDL framework
(#45266)

issue: #43897

- Alter collection/database is implemented by WAL-based DDL framework
now.
- Support AlterCollection/AlterDatabase in wal now.
- Alter operation can be synced by new CDC now.
- Refactor some UT for alter DDL.

fix: milvus role cannot stop at initializing state (#45244)

issue: #45243

fix: support upgrading from 2.6.x -> 2.6.5 (#45264)

issue: #43897

---------

Signed-off-by: chyezh <chyezh@outlook.com>
2025-11-04 20:21:37 +08:00

205 lines
6.2 KiB
Go

/*
* Licensed to the LF AI & Data foundation under one
* or more contributor license agreements. See the NOTICE file
* distributed with this work for additional information
* regarding copyright ownership. The ASF licenses this file
* to you under the Apache License, Version 2.0 (the
* "License"); you may not use this file except in compliance
* with the License. You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
*/
package rootcoord
import (
"context"
"testing"
"github.com/cockroachdb/errors"
"github.com/stretchr/testify/assert"
"github.com/stretchr/testify/mock"
"github.com/milvus-io/milvus-proto/go-api/v2/milvuspb"
"github.com/milvus-io/milvus/internal/metastore/model"
mockrootcoord "github.com/milvus-io/milvus/internal/rootcoord/mocks"
"github.com/milvus-io/milvus/pkg/v2/proto/rootcoordpb"
)
func TestLockerKey(t *testing.T) {
clusterLock := NewClusterLockerKey(true)
assert.Equal(t, clusterLock.IsWLock(), true)
assert.Equal(t, clusterLock.Level(), ClusterLock)
assert.Equal(t, clusterLock.LockKey(), "$")
dbLock := NewDatabaseLockerKey("foo", true)
assert.Equal(t, dbLock.IsWLock(), true)
assert.Equal(t, dbLock.Level(), DatabaseLock)
assert.Equal(t, dbLock.LockKey(), "foo")
collectionLock := NewCollectionLockerKey("foo", true)
assert.Equal(t, collectionLock.IsWLock(), true)
assert.Equal(t, collectionLock.Level(), CollectionLock)
assert.Equal(t, collectionLock.LockKey(), "foo")
{
lockerChain := NewLockerKeyChain(nil)
assert.Nil(t, lockerChain)
}
{
lockerChain := NewLockerKeyChain(dbLock)
assert.Nil(t, lockerChain)
}
{
lockerChain := NewLockerKeyChain(clusterLock, collectionLock, dbLock)
assert.Nil(t, lockerChain)
}
{
lockerChain := NewLockerKeyChain(clusterLock, dbLock, collectionLock)
assert.NotNil(t, lockerChain)
assert.Equal(t, lockerChain.Next(), dbLock)
assert.Equal(t, lockerChain.Next().Next(), collectionLock)
}
}
func TestGetLockerKey(t *testing.T) {
t.Run("describe collection task locker key", func(t *testing.T) {
metaMock := mockrootcoord.NewIMetaTable(t)
metaMock.EXPECT().GetCollectionByName(mock.Anything, mock.Anything, mock.Anything, mock.Anything).
RunAndReturn(func(ctx context.Context, s string, s2 string, u uint64) (*model.Collection, error) {
return nil, errors.New("not found")
})
c := &Core{
meta: metaMock,
}
tt := &describeCollectionTask{
baseTask: baseTask{core: c},
Req: &milvuspb.DescribeCollectionRequest{
DbName: "foo",
CollectionName: "bar",
},
}
key := tt.GetLockerKey()
assert.Equal(t, GetLockerKeyString(key), "$-0-false|foo-1-false|-1-2-false")
})
t.Run("describe collection task locker key by ID", func(t *testing.T) {
metaMock := mockrootcoord.NewIMetaTable(t)
c := &Core{
meta: metaMock,
}
tt := &describeCollectionTask{
baseTask: baseTask{core: c},
Req: &milvuspb.DescribeCollectionRequest{
DbName: "foo",
CollectionName: "",
CollectionID: 111,
},
}
key := tt.GetLockerKey()
assert.Equal(t, GetLockerKeyString(key), "$-0-false|foo-1-false|111-2-false")
})
t.Run("describe database task locker key", func(t *testing.T) {
tt := &describeDBTask{
Req: &rootcoordpb.DescribeDatabaseRequest{
DbName: "foo",
},
}
key := tt.GetLockerKey()
assert.Equal(t, GetLockerKeyString(key), "$-0-false|foo-1-false")
})
t.Run("has collection task locker key", func(t *testing.T) {
tt := &hasCollectionTask{
Req: &milvuspb.HasCollectionRequest{
DbName: "foo",
CollectionName: "bar",
},
}
key := tt.GetLockerKey()
assert.Equal(t, GetLockerKeyString(key), "$-0-false|foo-1-false")
})
t.Run("has partition task locker key", func(t *testing.T) {
metaMock := mockrootcoord.NewIMetaTable(t)
metaMock.EXPECT().GetCollectionByName(mock.Anything, mock.Anything, mock.Anything, mock.Anything).
RunAndReturn(func(ctx context.Context, s string, s2 string, u uint64) (*model.Collection, error) {
return &model.Collection{
Name: "real" + s2,
CollectionID: 111,
}, nil
})
c := &Core{
meta: metaMock,
}
tt := &hasPartitionTask{
baseTask: baseTask{core: c},
Req: &milvuspb.HasPartitionRequest{
DbName: "foo",
CollectionName: "bar",
PartitionName: "baz",
},
}
key := tt.GetLockerKey()
assert.Equal(t, GetLockerKeyString(key), "$-0-false|foo-1-false|111-2-false")
})
t.Run("list db task locker key", func(t *testing.T) {
tt := &listDatabaseTask{}
key := tt.GetLockerKey()
assert.Equal(t, GetLockerKeyString(key), "$-0-false")
})
t.Run("show collection task locker key", func(t *testing.T) {
tt := &showCollectionTask{
Req: &milvuspb.ShowCollectionsRequest{
DbName: "foo",
},
}
key := tt.GetLockerKey()
assert.Equal(t, GetLockerKeyString(key), "$-0-false|foo-1-false")
})
t.Run("show partition task locker key", func(t *testing.T) {
metaMock := mockrootcoord.NewIMetaTable(t)
metaMock.EXPECT().GetCollectionByName(mock.Anything, mock.Anything, mock.Anything, mock.Anything).
RunAndReturn(func(ctx context.Context, s string, s2 string, u uint64) (*model.Collection, error) {
return &model.Collection{
Name: "real" + s2,
CollectionID: 111,
}, nil
})
c := &Core{
meta: metaMock,
}
tt := &showPartitionTask{
baseTask: baseTask{core: c},
Req: &milvuspb.ShowPartitionsRequest{
DbName: "foo",
CollectionName: "bar",
},
}
key := tt.GetLockerKey()
assert.Equal(t, GetLockerKeyString(key), "$-0-false|foo-1-false|111-2-false")
})
t.Run("show partition task locker key by ID", func(t *testing.T) {
metaMock := mockrootcoord.NewIMetaTable(t)
c := &Core{
meta: metaMock,
}
tt := &showPartitionTask{
baseTask: baseTask{core: c},
Req: &milvuspb.ShowPartitionsRequest{
DbName: "foo",
CollectionName: "",
CollectionID: 111,
},
}
key := tt.GetLockerKey()
assert.Equal(t, GetLockerKeyString(key), "$-0-false|foo-1-false|111-2-false")
})
}