mirror of
https://gitee.com/milvus-io/milvus.git
synced 2026-01-04 01:42:15 +08:00
issue: #37166 cause the misuse of timer.Reset, which cause dispatcher failed to send msg to virtual channel buffer, and dispatcher do splitting again and again, which hold the dispatcher manager's lock, block watching channel progress. This PR fix the misuse of timer.Reset Signed-off-by: Wei Liu <wei.liu@zilliz.com>
181 lines
5.1 KiB
Go
181 lines
5.1 KiB
Go
// Licensed to the LF AI & Data foundation under one
|
|
// or more contributor license agreements. See the NOTICE file
|
|
// distributed with this work for additional information
|
|
// regarding copyright ownership. The ASF licenses this file
|
|
// to you under the Apache License, Version 2.0 (the
|
|
// "License"); you may not use this file except in compliance
|
|
// with the License. You may obtain a copy of the License at
|
|
//
|
|
// http://www.apache.org/licenses/LICENSE-2.0
|
|
//
|
|
// Unless required by applicable law or agreed to in writing, software
|
|
// distributed under the License is distributed on an "AS IS" BASIS,
|
|
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
// See the License for the specific language governing permissions and
|
|
// limitations under the License.
|
|
|
|
package client
|
|
|
|
import (
|
|
"context"
|
|
"fmt"
|
|
"time"
|
|
|
|
"google.golang.org/grpc"
|
|
|
|
"github.com/milvus-io/milvus-proto/go-api/v2/commonpb"
|
|
"github.com/milvus-io/milvus-proto/go-api/v2/milvuspb"
|
|
"github.com/milvus-io/milvus/client/v2/entity"
|
|
"github.com/milvus-io/milvus/client/v2/index"
|
|
"github.com/milvus-io/milvus/pkg/util/merr"
|
|
)
|
|
|
|
type CreateIndexTask struct {
|
|
client *Client
|
|
collectionName string
|
|
fieldName string
|
|
indexName string
|
|
interval time.Duration
|
|
}
|
|
|
|
func (t *CreateIndexTask) Await(ctx context.Context) error {
|
|
timer := time.NewTimer(t.interval)
|
|
defer timer.Stop()
|
|
for {
|
|
select {
|
|
case <-timer.C:
|
|
finished := false
|
|
err := t.client.callService(func(milvusService milvuspb.MilvusServiceClient) error {
|
|
resp, err := milvusService.DescribeIndex(ctx, &milvuspb.DescribeIndexRequest{
|
|
CollectionName: t.collectionName,
|
|
FieldName: t.fieldName,
|
|
IndexName: t.indexName,
|
|
})
|
|
err = merr.CheckRPCCall(resp, err)
|
|
if err != nil {
|
|
return err
|
|
}
|
|
|
|
for _, info := range resp.GetIndexDescriptions() {
|
|
if (t.indexName == "" && info.GetFieldName() == t.fieldName) || t.indexName == info.GetIndexName() {
|
|
switch info.GetState() {
|
|
case commonpb.IndexState_Finished:
|
|
finished = true
|
|
return nil
|
|
case commonpb.IndexState_Failed:
|
|
return fmt.Errorf("create index failed, reason: %s", info.GetIndexStateFailReason())
|
|
}
|
|
}
|
|
}
|
|
return nil
|
|
})
|
|
if err != nil {
|
|
return err
|
|
}
|
|
if finished {
|
|
return nil
|
|
}
|
|
if !timer.Stop() {
|
|
select {
|
|
case <-timer.C:
|
|
default:
|
|
}
|
|
}
|
|
timer.Reset(t.interval)
|
|
case <-ctx.Done():
|
|
return ctx.Err()
|
|
}
|
|
}
|
|
}
|
|
|
|
func (c *Client) CreateIndex(ctx context.Context, option CreateIndexOption, callOptions ...grpc.CallOption) (*CreateIndexTask, error) {
|
|
req := option.Request()
|
|
var task *CreateIndexTask
|
|
|
|
err := c.callService(func(milvusService milvuspb.MilvusServiceClient) error {
|
|
resp, err := milvusService.CreateIndex(ctx, req, callOptions...)
|
|
if err = merr.CheckRPCCall(resp, err); err != nil {
|
|
return err
|
|
}
|
|
|
|
task = &CreateIndexTask{
|
|
client: c,
|
|
collectionName: req.GetCollectionName(),
|
|
fieldName: req.GetFieldName(),
|
|
indexName: req.GetIndexName(),
|
|
interval: time.Millisecond * 100,
|
|
}
|
|
|
|
return nil
|
|
})
|
|
|
|
return task, err
|
|
}
|
|
|
|
func (c *Client) ListIndexes(ctx context.Context, opt ListIndexOption, callOptions ...grpc.CallOption) ([]string, error) {
|
|
req := opt.Request()
|
|
|
|
var indexes []string
|
|
|
|
err := c.callService(func(milvusService milvuspb.MilvusServiceClient) error {
|
|
resp, err := milvusService.DescribeIndex(ctx, req, callOptions...)
|
|
if err = merr.CheckRPCCall(resp, err); err != nil {
|
|
return err
|
|
}
|
|
for _, idxDef := range resp.GetIndexDescriptions() {
|
|
if opt.Matches(idxDef) {
|
|
indexes = append(indexes, idxDef.GetIndexName())
|
|
}
|
|
}
|
|
return nil
|
|
})
|
|
return indexes, err
|
|
}
|
|
|
|
type IndexDescription struct {
|
|
index.Index
|
|
State index.IndexState
|
|
PendingIndexRows int64
|
|
TotalRows int64
|
|
IndexedRows int64
|
|
}
|
|
|
|
func (c *Client) DescribeIndex(ctx context.Context, opt DescribeIndexOption, callOptions ...grpc.CallOption) (IndexDescription, error) {
|
|
req := opt.Request()
|
|
var idx IndexDescription
|
|
|
|
err := c.callService(func(milvusService milvuspb.MilvusServiceClient) error {
|
|
resp, err := milvusService.DescribeIndex(ctx, req, callOptions...)
|
|
if err = merr.CheckRPCCall(resp, err); err != nil {
|
|
return err
|
|
}
|
|
|
|
if len(resp.GetIndexDescriptions()) == 0 {
|
|
return merr.WrapErrIndexNotFound(req.GetIndexName())
|
|
}
|
|
for _, idxDef := range resp.GetIndexDescriptions() {
|
|
if idxDef.GetIndexName() == req.GetIndexName() {
|
|
idx = IndexDescription{
|
|
Index: index.NewGenericIndex(idxDef.GetIndexName(), entity.KvPairsMap(idxDef.GetParams())),
|
|
State: index.IndexState(idxDef.GetState()),
|
|
PendingIndexRows: idxDef.GetPendingIndexRows(),
|
|
IndexedRows: idxDef.GetIndexedRows(),
|
|
TotalRows: idxDef.GetTotalRows(),
|
|
}
|
|
}
|
|
}
|
|
return nil
|
|
})
|
|
|
|
return idx, err
|
|
}
|
|
|
|
func (c *Client) DropIndex(ctx context.Context, opt DropIndexOption, callOptions ...grpc.CallOption) error {
|
|
req := opt.Request()
|
|
|
|
return c.callService(func(milvusService milvuspb.MilvusServiceClient) error {
|
|
resp, err := milvusService.DropIndex(ctx, req, callOptions...)
|
|
return merr.CheckRPCCall(resp, err)
|
|
})
|
|
}
|