mirror of
https://gitee.com/milvus-io/milvus.git
synced 2025-12-08 01:58:34 +08:00
6c5be83ea1
This PR mainly did the following 3 things: - Refactor NewEtcdKV API - Add unittests for `kv/etcd/`, raise the coverage up to 94% - Correct some APIs from version to revision The old NewEtcdKV() API took `clientv3.Client` as one of the input, making everyone who using this API had to create a new `clientv3.Client`. So there're a lot of repeated codes everywhere. Meanwhile, someplace didn't even check whether the `clientv3.New()` returned error or not, and the old API also didn't check whether the clientv3.Client was Nil. This caused issue#6955. Ectd's version and revision have nothing alike, they represent different concepts, but our APIs kind of mixed them all up. So I correct those APIs' names. Resolves: #6955 Signed-off-by: yangxuan <xuan.yang@zilliz.com>
51 lines
1.5 KiB
Go
51 lines
1.5 KiB
Go
// Copyright (C) 2019-2020 Zilliz. All rights reserved.
|
|
//
|
|
// Licensed under the Apache License, Version 2.0 (the "License"); you may not use this file except in compliance
|
|
// with the License. You may obtain a copy of the License at
|
|
//
|
|
// http://www.apache.org/licenses/LICENSE-2.0
|
|
//
|
|
// Unless required by applicable law or agreed to in writing, software distributed under the License
|
|
// is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express
|
|
// or implied. See the License for the specific language governing permissions and limitations under the License.
|
|
|
|
package querycoord
|
|
|
|
import (
|
|
"testing"
|
|
|
|
"github.com/stretchr/testify/assert"
|
|
"github.com/stretchr/testify/require"
|
|
|
|
etcdkv "github.com/milvus-io/milvus/internal/kv/etcd"
|
|
)
|
|
|
|
func TestReplica_Release(t *testing.T) {
|
|
etcdKV, err := etcdkv.NewEtcdKV(Params.EtcdEndpoints, Params.MetaRootPath)
|
|
assert.Nil(t, err)
|
|
meta, err := newMeta(etcdKV)
|
|
assert.Nil(t, err)
|
|
err = meta.addCollection(1, nil)
|
|
require.NoError(t, err)
|
|
|
|
collections := meta.showCollections()
|
|
assert.Equal(t, 1, len(collections))
|
|
|
|
err = meta.addPartition(1, 100)
|
|
assert.NoError(t, err)
|
|
partitions, err := meta.showPartitions(1)
|
|
assert.NoError(t, err)
|
|
assert.Equal(t, 1, len(partitions))
|
|
|
|
meta.releasePartition(1, 100)
|
|
partitions, err = meta.showPartitions(1)
|
|
assert.NoError(t, err)
|
|
assert.Equal(t, 0, len(partitions))
|
|
meta.releasePartition(1, 100)
|
|
|
|
meta.releaseCollection(1)
|
|
collections = meta.showCollections()
|
|
assert.Equal(t, 0, len(collections))
|
|
meta.releaseCollection(1)
|
|
}
|