milvus/internal/datacoord/session/node_manager_test.go
yihao.dai 142bd2fc05
enhance: Pooling for data tasks (#41256)
1. Add global scheduler for datacoord.
2. Define and implement new CreateTask, QueryTask, DropTask interfaces.
3. Refine Import, Compaction, Stats, Index task.

issue: https://github.com/milvus-io/milvus/issues/41123

Co-authored-by: Cai Zhang <cai.zhang@zilliz.com>
2025-05-20 21:06:24 +08:00

133 lines
3.8 KiB
Go

// Licensed to the LF AI & Data foundation under one
// or more contributor license agreements. See the NOTICE file
// distributed with this work for additional information
// regarding copyright ownership. The ASF licenses this file
// to you under the Apache License, Version 2.0 (the
// "License"); you may not use this file except in compliance
// with the License. You may obtain a copy of the License at
//
// http://www.apache.org/licenses/LICENSE-2.0
//
// Unless required by applicable law or agreed to in writing, software
// distributed under the License is distributed on an "AS IS" BASIS,
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
// See the License for the specific language governing permissions and
// limitations under the License.
package session
import (
"context"
"testing"
"github.com/stretchr/testify/assert"
"github.com/milvus-io/milvus/internal/mocks"
"github.com/milvus-io/milvus/internal/types"
"github.com/milvus-io/milvus/pkg/v2/util/merr"
)
func TestNodeManager_AddNode(t *testing.T) {
t.Run("add node successfully", func(t *testing.T) {
mockClient := mocks.NewMockDataNodeClient(t)
nodeCreator := func(ctx context.Context, addr string, nodeID int64) (types.DataNodeClient, error) {
return mockClient, nil
}
nm := NewNodeManager(nodeCreator)
err := nm.AddNode(1, "localhost:8080")
assert.NoError(t, err)
client, err := nm.GetClient(1)
assert.NoError(t, err)
assert.Equal(t, mockClient, client)
})
t.Run("add node with error", func(t *testing.T) {
nodeCreator := func(ctx context.Context, addr string, nodeID int64) (types.DataNodeClient, error) {
return nil, assert.AnError
}
nm := NewNodeManager(nodeCreator)
err := nm.AddNode(1, "localhost:8080")
assert.Error(t, err)
})
}
func TestNodeManager_RemoveNode(t *testing.T) {
t.Run("remove existing node", func(t *testing.T) {
mockClient := mocks.NewMockDataNodeClient(t)
mockClient.EXPECT().Close().Return(nil)
nodeCreator := func(ctx context.Context, addr string, nodeID int64) (types.DataNodeClient, error) {
return mockClient, nil
}
nm := NewNodeManager(nodeCreator)
err := nm.AddNode(1, "localhost:8080")
assert.NoError(t, err)
nm.RemoveNode(1)
client, err := nm.GetClient(1)
assert.Error(t, err)
assert.Nil(t, client)
})
t.Run("remove non-existing node", func(t *testing.T) {
nm := NewNodeManager(nil)
nm.RemoveNode(1) // Should not panic
})
}
func TestNodeManager_GetClient(t *testing.T) {
t.Run("get existing client", func(t *testing.T) {
mockClient := mocks.NewMockDataNodeClient(t)
nodeCreator := func(ctx context.Context, addr string, nodeID int64) (types.DataNodeClient, error) {
return mockClient, nil
}
nm := NewNodeManager(nodeCreator)
err := nm.AddNode(1, "localhost:8080")
assert.NoError(t, err)
client, err := nm.GetClient(1)
assert.NoError(t, err)
assert.Equal(t, mockClient, client)
})
t.Run("get non-existing client", func(t *testing.T) {
nm := NewNodeManager(nil)
client, err := nm.GetClient(1)
assert.Error(t, err)
assert.True(t, merr.WrapErrNodeNotFound(1) != nil)
assert.Nil(t, client)
})
}
func TestNodeManager_GetClientIDs(t *testing.T) {
t.Run("get client IDs", func(t *testing.T) {
mockClient := mocks.NewMockDataNodeClient(t)
nodeCreator := func(ctx context.Context, addr string, nodeID int64) (types.DataNodeClient, error) {
return mockClient, nil
}
nm := NewNodeManager(nodeCreator)
err := nm.AddNode(1, "localhost:8080")
assert.NoError(t, err)
err = nm.AddNode(2, "localhost:8081")
assert.NoError(t, err)
ids := nm.GetClientIDs()
assert.Len(t, ids, 2)
assert.Contains(t, ids, int64(1))
assert.Contains(t, ids, int64(2))
})
t.Run("get empty client IDs", func(t *testing.T) {
nm := NewNodeManager(nil)
ids := nm.GetClientIDs()
assert.Empty(t, ids)
})
}