mirror of
https://gitee.com/milvus-io/milvus.git
synced 2026-01-07 19:31:51 +08:00
b18ebd9468
issue: https://github.com/milvus-io/milvus/issues/44123 <!-- This is an auto-generated comment: release notes by coderabbit.ai --> - Core invariant: legacy in-cluster CDC/replication plumbing (ReplicateMsg types, ReplicateID-based guards and flags) is obsolete — the system relies on standard msgstream positions, subPos/end-ts semantics and timetick ordering as the single source of truth for message ordering and skipping, so replication-specific channels/types/guards can be removed safely. - Removed/simplified logic (what and why): removed replication feature flags and params (ReplicateMsgChannel, TTMsgEnabled, CollectionReplicateEnable), ReplicateMsg type and its tests, ReplicateID constants/helpers and MergeProperties hooks, ReplicateConfig and its propagation (streamPipeline, StreamConfig, dispatcher, target), replicate-aware dispatcher/pipeline branches, and replicate-mode pre-checks/timestamp-allocation in proxy tasks — these implemented a redundant alternate “replicate-mode” pathway that duplicated position/end-ts and timetick logic. - Why this does NOT cause data loss or regression (concrete code paths): no persistence or core write paths were removed — proxy PreExecute flows (internal/proxy/task_*.go) still perform the same schema/ID/size validations and then follow the normal non-replicate execution path; dispatcher and pipeline continue to use position/subPos and pullback/end-ts in Seek/grouping (pkg/mq/msgdispatcher/dispatcher.go, internal/util/pipeline/stream_pipeline.go), so skipping and ordering behavior remains unchanged; timetick emission in rootcoord (sendMinDdlTsAsTt) is now ungated (no silent suppression), preserving or increasing timetick delivery rather than removing it. - PR type and net effect: Enhancement/Refactor — removes deprecated replication API surface (types, helpers, config, tests) and replication branches, simplifies public APIs and constructor signatures, and reduces surface area for future maintenance while keeping DML/DDL persistence, ordering, and seek semantics intact. <!-- end of auto-generated comment: release notes by coderabbit.ai --> --------- Signed-off-by: bigsheeper <yihao.dai@zilliz.com>
83 lines
2.7 KiB
Go
83 lines
2.7 KiB
Go
// Licensed to the LF AI & Data foundation under one
|
|
// or more contributor license agreements. See the NOTICE file
|
|
// distributed with this work for additional information
|
|
// regarding copyright ownership. The ASF licenses this file
|
|
// to you under the Apache License, Version 2.0 (the
|
|
// "License"); you may not use this file except in compliance
|
|
// with the License. You may obtain a copy of the License at
|
|
//
|
|
// http://www.apache.org/licenses/LICENSE-2.0
|
|
//
|
|
// Unless required by applicable law or agreed to in writing, software
|
|
// distributed under the License is distributed on an "AS IS" BASIS,
|
|
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
// See the License for the specific language governing permissions and
|
|
// limitations under the License.
|
|
|
|
package msgstream
|
|
|
|
import (
|
|
"context"
|
|
"testing"
|
|
|
|
"github.com/cockroachdb/errors"
|
|
"github.com/stretchr/testify/assert"
|
|
"github.com/stretchr/testify/mock"
|
|
|
|
"github.com/milvus-io/milvus/pkg/v2/mq/common"
|
|
)
|
|
|
|
func TestPulsarMsgUtil(t *testing.T) {
|
|
pmsFactory := NewPmsFactory(&Params.ServiceParam)
|
|
|
|
ctx := context.Background()
|
|
msgStream, err := pmsFactory.NewMsgStream(ctx)
|
|
assert.NoError(t, err)
|
|
defer msgStream.Close()
|
|
|
|
// create a topic
|
|
msgStream.AsProducer(ctx, []string{"test"})
|
|
|
|
UnsubscribeChannels(ctx, pmsFactory, "sub", []string{"test"})
|
|
}
|
|
|
|
func TestGetLatestMsgID(t *testing.T) {
|
|
factory := NewMockMqFactory()
|
|
ctx := context.Background()
|
|
{
|
|
factory.NewMsgStreamFunc = func(ctx context.Context) (MsgStream, error) {
|
|
return nil, errors.New("mock")
|
|
}
|
|
_, err := GetChannelLatestMsgID(ctx, factory, "test")
|
|
assert.Error(t, err)
|
|
}
|
|
stream := NewMockMsgStream(t)
|
|
factory.NewMsgStreamFunc = func(ctx context.Context) (MsgStream, error) {
|
|
return stream, nil
|
|
}
|
|
stream.EXPECT().Close().Return()
|
|
|
|
{
|
|
stream.EXPECT().AsConsumer(mock.Anything, mock.Anything, mock.Anything, mock.Anything).Return(errors.New("mock")).Once()
|
|
_, err := GetChannelLatestMsgID(ctx, factory, "test")
|
|
assert.Error(t, err)
|
|
}
|
|
|
|
{
|
|
stream.EXPECT().AsConsumer(mock.Anything, mock.Anything, mock.Anything, mock.Anything).Return(nil).Once()
|
|
stream.EXPECT().GetLatestMsgID(mock.Anything).Return(nil, errors.New("mock")).Once()
|
|
_, err := GetChannelLatestMsgID(ctx, factory, "test")
|
|
assert.Error(t, err)
|
|
}
|
|
|
|
{
|
|
mockMsgID := common.NewMockMessageID(t)
|
|
mockMsgID.EXPECT().Serialize().Return([]byte("mock")).Once()
|
|
stream.EXPECT().AsConsumer(mock.Anything, mock.Anything, mock.Anything, mock.Anything).Return(nil).Once()
|
|
stream.EXPECT().GetLatestMsgID(mock.Anything).Return(mockMsgID, nil).Once()
|
|
id, err := GetChannelLatestMsgID(ctx, factory, "test")
|
|
assert.NoError(t, err)
|
|
assert.Equal(t, []byte("mock"), id)
|
|
}
|
|
}
|