mirror of
https://gitee.com/milvus-io/milvus.git
synced 2025-12-28 14:35:27 +08:00
issue: #43897 also for issue: #46166 add ack_sync_up flag into broadcast message header, which indicates that whether the broadcast operation is need to be synced up between the streaming node and the coordinator. If the ack_sync_up is false, the broadcast operation will be acked once the recovery storage see the message at current vchannel, the fast ack operation can be applied to speed up the broadcast operation. If the ack_sync_up is true, the broadcast operation will be acked after the checkpoint of current vchannel reach current message. The fast ack operation can not be applied to speed up the broadcast operation, because the ack operation need to be synced up with streaming node. e.g. if truncate collection operation want to call ack once callback after the all segment are flushed at current vchannel, it should set the ack_sync_up to be true. TODO: current implementation doesn't promise the ack sync up semantic, it only promise FastAck operation will not be applied, wait for 3.0 to implement the ack sync up semantic. only for truncate api now. --------- Signed-off-by: chyezh <chyezh@outlook.com>
175 lines
6.4 KiB
Go
175 lines
6.4 KiB
Go
// Licensed to the LF AI & Data foundation under one
|
|
// or more contributor license agreements. See the NOTICE file
|
|
// distributed with this work for additional information
|
|
// regarding copyright ownership. The ASF licenses this file
|
|
// to you under the Apache License, Version 2.0 (the
|
|
// "License"); you may not use this file except in compliance
|
|
// with the License. You may obtain a copy of the License at
|
|
//
|
|
// http://www.apache.org/licenses/LICENSE-2.0
|
|
//
|
|
// Unless required by applicable law or agreed to in writing, software
|
|
// distributed under the License is distributed on an "AS IS" BASIS,
|
|
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
// See the License for the specific language governing permissions and
|
|
// limitations under the License.
|
|
|
|
package rootcoord
|
|
|
|
import (
|
|
"context"
|
|
"testing"
|
|
|
|
"github.com/samber/lo"
|
|
"github.com/stretchr/testify/require"
|
|
"google.golang.org/protobuf/proto"
|
|
|
|
"github.com/milvus-io/milvus-proto/go-api/v2/milvuspb"
|
|
"github.com/milvus-io/milvus-proto/go-api/v2/schemapb"
|
|
"github.com/milvus-io/milvus/internal/metastore/model"
|
|
"github.com/milvus-io/milvus/pkg/v2/util/funcutil"
|
|
"github.com/milvus-io/milvus/pkg/v2/util/merr"
|
|
"github.com/milvus-io/milvus/pkg/v2/util/typeutil"
|
|
)
|
|
|
|
func TestDDLCallbacksCollectionDDL(t *testing.T) {
|
|
core := initStreamingSystemAndCore(t)
|
|
|
|
ctx := context.Background()
|
|
dbName := "testDB" + funcutil.RandomString(10)
|
|
collectionName := "testCollection" + funcutil.RandomString(10)
|
|
partitionName := "testPartition" + funcutil.RandomString(10)
|
|
testSchema := &schemapb.CollectionSchema{
|
|
Name: collectionName,
|
|
Description: "",
|
|
AutoID: false,
|
|
Fields: []*schemapb.FieldSchema{
|
|
{
|
|
Name: "field1",
|
|
DataType: schemapb.DataType_Int64,
|
|
},
|
|
},
|
|
}
|
|
schemaBytes, err := proto.Marshal(testSchema)
|
|
require.NoError(t, err)
|
|
|
|
// drop a collection that db not exist should be ignored.
|
|
status, err := core.DropCollection(ctx, &milvuspb.DropCollectionRequest{
|
|
DbName: "notExistDB",
|
|
CollectionName: collectionName,
|
|
})
|
|
require.NoError(t, merr.CheckRPCCall(status, err))
|
|
|
|
// drop a collection that collection not exist should be ignored.
|
|
status, err = core.DropCollection(ctx, &milvuspb.DropCollectionRequest{
|
|
DbName: dbName,
|
|
CollectionName: "notExistCollection",
|
|
})
|
|
require.NoError(t, merr.CheckRPCCall(status, err))
|
|
|
|
// create a collection that database not exist should return error.
|
|
status, err = core.CreateCollection(ctx, &milvuspb.CreateCollectionRequest{
|
|
DbName: "notExistDB",
|
|
CollectionName: collectionName,
|
|
Schema: schemaBytes,
|
|
})
|
|
require.Error(t, merr.CheckRPCCall(status, err))
|
|
|
|
// Test CreateCollection
|
|
// create a database and a collection.
|
|
status, err = core.CreateDatabase(ctx, &milvuspb.CreateDatabaseRequest{
|
|
DbName: dbName,
|
|
})
|
|
require.NoError(t, merr.CheckRPCCall(status, err))
|
|
status, err = core.CreateCollection(ctx, &milvuspb.CreateCollectionRequest{
|
|
DbName: dbName,
|
|
CollectionName: collectionName,
|
|
Schema: schemaBytes,
|
|
})
|
|
require.NoError(t, merr.CheckRPCCall(status, err))
|
|
coll, err := core.meta.GetCollectionByName(ctx, dbName, collectionName, typeutil.MaxTimestamp)
|
|
require.NoError(t, err)
|
|
require.Equal(t, coll.Name, collectionName)
|
|
// create a collection with same schema should be idempotent.
|
|
status, err = core.CreateCollection(ctx, &milvuspb.CreateCollectionRequest{
|
|
DbName: dbName,
|
|
CollectionName: collectionName,
|
|
Schema: schemaBytes,
|
|
})
|
|
require.NoError(t, merr.CheckRPCCall(status, err))
|
|
|
|
// Test CreatePartition
|
|
status, err = core.CreatePartition(ctx, &milvuspb.CreatePartitionRequest{
|
|
DbName: dbName,
|
|
CollectionName: collectionName,
|
|
PartitionName: partitionName,
|
|
})
|
|
require.NoError(t, merr.CheckRPCCall(status, err))
|
|
coll, err = core.meta.GetCollectionByName(ctx, dbName, collectionName, typeutil.MaxTimestamp)
|
|
require.NoError(t, err)
|
|
require.Len(t, coll.Partitions, 2)
|
|
require.Contains(t, lo.Map(coll.Partitions, func(p *model.Partition, _ int) string { return p.PartitionName }), partitionName)
|
|
// create a partition with same name should be idempotent.
|
|
status, err = core.CreatePartition(ctx, &milvuspb.CreatePartitionRequest{
|
|
DbName: dbName,
|
|
CollectionName: collectionName,
|
|
PartitionName: partitionName,
|
|
})
|
|
require.NoError(t, merr.CheckRPCCall(status, err))
|
|
coll, err = core.meta.GetCollectionByName(ctx, dbName, collectionName, typeutil.MaxTimestamp)
|
|
require.NoError(t, err)
|
|
require.Len(t, coll.Partitions, 2)
|
|
|
|
status, err = core.DropPartition(ctx, &milvuspb.DropPartitionRequest{
|
|
DbName: dbName,
|
|
CollectionName: collectionName,
|
|
PartitionName: partitionName,
|
|
})
|
|
require.NoError(t, merr.CheckRPCCall(status, err))
|
|
// drop a partition that partition not exist should be idempotent.
|
|
status, err = core.DropPartition(ctx, &milvuspb.DropPartitionRequest{
|
|
DbName: dbName,
|
|
CollectionName: collectionName,
|
|
PartitionName: partitionName,
|
|
})
|
|
require.NoError(t, merr.CheckRPCCall(status, err))
|
|
|
|
// Test TruncateCollection
|
|
// truncate a collection that collection not exist should return error.
|
|
resp, err := core.TruncateCollection(ctx, &milvuspb.TruncateCollectionRequest{
|
|
DbName: dbName,
|
|
CollectionName: "notExistCollection",
|
|
})
|
|
require.Error(t, merr.CheckRPCCall(resp.GetStatus(), err))
|
|
// truncate the collection should be ok.
|
|
resp, err = core.TruncateCollection(ctx, &milvuspb.TruncateCollectionRequest{
|
|
DbName: dbName,
|
|
CollectionName: collectionName,
|
|
})
|
|
require.NoError(t, merr.CheckRPCCall(resp.GetStatus(), err))
|
|
// verify collection still exists after truncate
|
|
coll, err = core.meta.GetCollectionByName(ctx, dbName, collectionName, typeutil.MaxTimestamp)
|
|
require.NoError(t, err)
|
|
require.Equal(t, coll.Name, collectionName)
|
|
require.Equal(t, 1, len(coll.ShardInfos))
|
|
for _, shardInfo := range coll.ShardInfos {
|
|
require.Greater(t, shardInfo.LastTruncateTimeTick, uint64(0))
|
|
}
|
|
|
|
// Test DropCollection
|
|
// drop the collection should be ok.
|
|
status, err = core.DropCollection(ctx, &milvuspb.DropCollectionRequest{
|
|
DbName: dbName,
|
|
CollectionName: collectionName,
|
|
})
|
|
require.NoError(t, merr.CheckRPCCall(status, err))
|
|
_, err = core.meta.GetCollectionByName(ctx, dbName, collectionName, typeutil.MaxTimestamp)
|
|
require.Error(t, err)
|
|
// drop a dropped collection should be idempotent.
|
|
status, err = core.DropCollection(ctx, &milvuspb.DropCollectionRequest{
|
|
DbName: dbName,
|
|
CollectionName: collectionName,
|
|
})
|
|
require.NoError(t, merr.CheckRPCCall(status, err))
|
|
}
|