mirror of
https://gitee.com/milvus-io/milvus.git
synced 2026-01-07 19:31:51 +08:00
issue: #46635 ## Summary - Fix spelling error in constant name: `CredentialSeperator` -> `CredentialSeparator` - Updated all usages across the codebase to use the correct spelling ## Changes - `pkg/util/constant.go`: Renamed the constant - `pkg/util/contextutil/context_util.go`: Updated usage - `pkg/util/contextutil/context_util_test.go`: Updated usage - `internal/proxy/authentication_interceptor.go`: Updated usage - `internal/proxy/util.go`: Updated usage - `internal/proxy/util_test.go`: Updated usage - `internal/proxy/trace_log_interceptor_test.go`: Updated usage - `internal/proxy/accesslog/info/util.go`: Updated usage - `internal/distributed/proxy/service.go`: Updated usage - `internal/distributed/proxy/httpserver/utils.go`: Updated usage ## Test Plan - [x] All references updated consistently - [x] No functional changes - only constant name spelling correction <!-- This is an auto-generated comment: release notes by coderabbit.ai --> - Core invariant: the separator character for credentials remains ":" everywhere — only the exported identifier was renamed from CredentialSeperator → CredentialSeparator; the constant value and split/join semantics are unchanged. - Change (bug fix): corrected the misspelled exported constant in pkg/util/constant.go and updated all references across the codebase (parsing, token construction, header handling and tests) to use the new identifier; this is an identifier rename that removes an inconsistent symbol and prevents compile-time/reference errors. - Logic simplified/redundant work removed: no runtime logic was removed; the simplification is purely maintenance-focused — eliminating a misspelled exported name that could cause developers to introduce duplicate or incorrect constants. - No data loss or behavior regression: runtime code paths are unchanged — e.g., GetAuthInfoFromContext, ParseUsernamePassword, AuthenticationInterceptor, proxy service token construction and access-log extraction still use ":" to split/join credentials; updated and added unit tests (parsing and metadata extraction) exercise these paths and validate identical semantics. <!-- end of auto-generated comment: release notes by coderabbit.ai --> --------- Signed-off-by: majiayu000 <1835304752@qq.com> Signed-off-by: lif <1835304752@qq.com> Co-authored-by: Claude Opus 4.5 <noreply@anthropic.com>
153 lines
4.1 KiB
Go
153 lines
4.1 KiB
Go
// Licensed to the LF AI & Data foundation under one
|
|
// or more contributor license agreements. See the NOTICE file
|
|
// distributed with this work for additional information
|
|
// regarding copyright ownership. The ASF licenses this file
|
|
// to you under the Apache License, Version 2.0 (the
|
|
// "License"); you may not use this file except in compliance
|
|
// with the License. You may obtain a copy of the License at
|
|
//
|
|
// http://www.apache.org/licenses/LICENSE-2.0
|
|
//
|
|
// Unless required by applicable law or agreed to in writing, software
|
|
// distributed under the License is distributed on an "AS IS" BASIS,
|
|
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
// See the License for the specific language governing permissions and
|
|
// limitations under the License.
|
|
|
|
package info
|
|
|
|
import (
|
|
"context"
|
|
"encoding/json"
|
|
"fmt"
|
|
"strings"
|
|
|
|
"github.com/cockroachdb/errors"
|
|
"go.uber.org/atomic"
|
|
"google.golang.org/grpc/metadata"
|
|
|
|
"github.com/milvus-io/milvus-proto/go-api/v2/commonpb"
|
|
"github.com/milvus-io/milvus-proto/go-api/v2/schemapb"
|
|
"github.com/milvus-io/milvus/pkg/v2/util"
|
|
"github.com/milvus-io/milvus/pkg/v2/util/crypto"
|
|
"github.com/milvus-io/milvus/pkg/v2/util/funcutil"
|
|
)
|
|
|
|
var ClusterPrefix atomic.String
|
|
|
|
func getCurUserFromContext(ctx context.Context) (string, error) {
|
|
md, ok := metadata.FromIncomingContext(ctx)
|
|
if !ok {
|
|
return "", errors.New("fail to get md from the context")
|
|
}
|
|
authorization, ok := md[strings.ToLower(util.HeaderAuthorize)]
|
|
if !ok || len(authorization) < 1 {
|
|
return "", fmt.Errorf("fail to get authorization from the md, authorize:[%s]", util.HeaderAuthorize)
|
|
}
|
|
token := authorization[0]
|
|
rawToken, err := crypto.Base64Decode(token)
|
|
if err != nil {
|
|
return "", fmt.Errorf("fail to decode the token, token: %s", token)
|
|
}
|
|
secrets := strings.SplitN(rawToken, util.CredentialSeparator, 2)
|
|
if len(secrets) < 2 {
|
|
return "", fmt.Errorf("fail to get user info from the raw token, raw token: %s", rawToken)
|
|
}
|
|
username := secrets[0]
|
|
return username, nil
|
|
}
|
|
|
|
func getSdkVersionByUserAgent(ctx context.Context) string {
|
|
md, ok := metadata.FromIncomingContext(ctx)
|
|
if !ok {
|
|
return Unknown
|
|
}
|
|
UserAgent, ok := md[util.HeaderUserAgent]
|
|
if !ok {
|
|
return Unknown
|
|
}
|
|
|
|
SdkType, ok := getSdkTypeByUserAgent(UserAgent)
|
|
if !ok {
|
|
return Unknown
|
|
}
|
|
|
|
return SdkType + "-" + Unknown
|
|
}
|
|
|
|
func getSdkTypeByUserAgent(userAgents []string) (string, bool) {
|
|
if len(userAgents) == 0 {
|
|
return "", false
|
|
}
|
|
|
|
userAgent := userAgents[0]
|
|
switch {
|
|
case strings.HasPrefix(userAgent, "grpc-node-js"):
|
|
return "nodejs", true
|
|
case strings.HasPrefix(userAgent, "grpc-python"):
|
|
return "Python", true
|
|
case strings.HasPrefix(userAgent, "grpc-go"):
|
|
return "Golang", true
|
|
case strings.HasPrefix(userAgent, "grpc-java"):
|
|
return "Java", true
|
|
default:
|
|
return "", false
|
|
}
|
|
}
|
|
|
|
func getAnnsFieldFromKvs(kvs []*commonpb.KeyValuePair) string {
|
|
field, err := funcutil.GetAttrByKeyFromRepeatedKV("anns_field", kvs)
|
|
if err != nil {
|
|
return "default"
|
|
}
|
|
return field
|
|
}
|
|
|
|
func getLengthFromTemplateValue(tv *schemapb.TemplateValue) int {
|
|
arrayValues := tv.GetArrayVal()
|
|
// other single value data type
|
|
if arrayValues == nil {
|
|
return 1
|
|
}
|
|
switch arrayValues.GetData().(type) {
|
|
case *schemapb.TemplateArrayValue_BoolData:
|
|
return len(arrayValues.GetBoolData().GetData())
|
|
case *schemapb.TemplateArrayValue_LongData:
|
|
return len(arrayValues.GetLongData().GetData())
|
|
case *schemapb.TemplateArrayValue_DoubleData:
|
|
return len(arrayValues.GetDoubleData().GetData())
|
|
case *schemapb.TemplateArrayValue_StringData:
|
|
return len(arrayValues.GetStringData().GetData())
|
|
case *schemapb.TemplateArrayValue_JsonData:
|
|
return len(arrayValues.GetJsonData().GetData())
|
|
default:
|
|
// undefined
|
|
return -1
|
|
}
|
|
}
|
|
|
|
func listToString(strs []string) string {
|
|
result := "["
|
|
for i, str := range strs {
|
|
if i != 0 {
|
|
result += ", "
|
|
}
|
|
result += "\"" + str + "\""
|
|
}
|
|
return result + "]"
|
|
}
|
|
|
|
func kvsToString(kvs []*commonpb.KeyValuePair) string {
|
|
m := make(map[string]string)
|
|
for _, kv := range kvs {
|
|
m[kv.GetKey()] = kv.GetValue()
|
|
}
|
|
|
|
v, err := json.Marshal(m)
|
|
if err != nil {
|
|
return Unknown
|
|
}
|
|
|
|
return string(v)
|
|
}
|