milvus/internal/proxy/msg_pack_test.go
congqixia 6c34386ff2
enhance: extract shard client logic into dedicated package (#45018)
Related to #44761

Refactor proxy shard client management by creating a new
internal/proxy/shardclient package. This improves code organization and
modularity by:

- Moving load balancing logic (LookAsideBalancer, RoundRobinBalancer) to
shardclient package
- Extracting shard client manager and related interfaces into separate
package
- Relocating shard leader management and client lifecycle code
- Adding package documentation (README.md, OWNERS)
- Updating proxy code to use the new shardclient package interfaces

This change makes the shard client functionality more maintainable and
better encapsulated, reducing coupling in the proxy layer.

Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
2025-10-22 10:22:04 +08:00

186 lines
5.7 KiB
Go

// Licensed to the LF AI & Data foundation under one
// or more contributor license agreements. See the NOTICE file
// distributed with this work for additional information
// regarding copyright ownership. The ASF licenses this file
// to you under the Apache License, Version 2.0 (the
// "License"); you may not use this file except in compliance
// with the License. You may obtain a copy of the License at
//
// http://www.apache.org/licenses/LICENSE-2.0
//
// Unless required by applicable law or agreed to in writing, software
// distributed under the License is distributed on an "AS IS" BASIS,
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
// See the License for the specific language governing permissions and
// limitations under the License.
package proxy
import (
"context"
"testing"
"github.com/stretchr/testify/assert"
"google.golang.org/protobuf/proto"
"github.com/milvus-io/milvus-proto/go-api/v2/commonpb"
"github.com/milvus-io/milvus-proto/go-api/v2/milvuspb"
"github.com/milvus-io/milvus-proto/go-api/v2/msgpb"
"github.com/milvus-io/milvus-proto/go-api/v2/schemapb"
"github.com/milvus-io/milvus/internal/allocator"
"github.com/milvus-io/milvus/pkg/v2/mq/msgstream"
"github.com/milvus-io/milvus/pkg/v2/util/funcutil"
"github.com/milvus-io/milvus/pkg/v2/util/paramtable"
"github.com/milvus-io/milvus/pkg/v2/util/testutils"
)
func TestRepackInsertData(t *testing.T) {
nb := 10
hash := testutils.GenerateHashKeys(nb)
prefix := "TestRepackInsertData"
dbName := ""
collectionName := prefix + funcutil.GenRandomStr()
partitionName := prefix + funcutil.GenRandomStr()
ctx := context.Background()
mix := NewMixCoordMock()
defer mix.Close()
cache := NewMockCache(t)
globalMetaCache = cache
idAllocator, err := allocator.NewIDAllocator(ctx, mix, paramtable.GetNodeID())
assert.NoError(t, err)
_ = idAllocator.Start()
defer idAllocator.Close()
t.Run("create collection", func(t *testing.T) {
resp, err := mix.CreateCollection(ctx, &milvuspb.CreateCollectionRequest{
Base: nil,
DbName: dbName,
CollectionName: collectionName,
})
assert.Equal(t, commonpb.ErrorCode_Success, resp.GetErrorCode())
assert.NoError(t, err)
resp, err = mix.CreatePartition(ctx, &milvuspb.CreatePartitionRequest{
Base: &commonpb.MsgBase{
MsgType: commonpb.MsgType_CreatePartition,
MsgID: 0,
Timestamp: 0,
SourceID: paramtable.GetNodeID(),
},
DbName: dbName,
CollectionName: collectionName,
PartitionName: partitionName,
})
assert.Equal(t, commonpb.ErrorCode_Success, resp.GetErrorCode())
assert.NoError(t, err)
})
fieldData := generateFieldData(schemapb.DataType_Int64, testInt64Field, nb)
insertMsg := &BaseInsertTask{
BaseMsg: msgstream.BaseMsg{
HashValues: hash,
},
InsertRequest: &msgpb.InsertRequest{
Base: &commonpb.MsgBase{
MsgType: commonpb.MsgType_Insert,
MsgID: 0,
SourceID: paramtable.GetNodeID(),
},
DbName: dbName,
CollectionName: collectionName,
PartitionName: partitionName,
NumRows: uint64(nb),
FieldsData: []*schemapb.FieldData{fieldData},
Version: msgpb.InsertDataVersion_ColumnBased,
},
}
insertMsg.Timestamps = make([]uint64, nb)
for index := range insertMsg.Timestamps {
insertMsg.Timestamps[index] = insertMsg.BeginTimestamp
}
insertMsg.RowIDs = make([]UniqueID, nb)
for index := range insertMsg.RowIDs {
insertMsg.RowIDs[index] = int64(index)
}
}
func TestRepackInsertDataWithPartitionKey(t *testing.T) {
nb := 10
hash := testutils.GenerateHashKeys(nb)
prefix := "TestRepackInsertData"
collectionName := prefix + funcutil.GenRandomStr()
ctx := context.Background()
dbName := GetCurDBNameFromContextOrDefault(ctx)
mix := NewMixCoordMock()
err := InitMetaCache(ctx, mix)
assert.NoError(t, err)
idAllocator, err := allocator.NewIDAllocator(ctx, mix, paramtable.GetNodeID())
assert.NoError(t, err)
_ = idAllocator.Start()
defer idAllocator.Close()
fieldName2Types := map[string]schemapb.DataType{
testInt64Field: schemapb.DataType_Int64,
testVarCharField: schemapb.DataType_VarChar,
testFloatVecField: schemapb.DataType_FloatVector,
}
t.Run("create collection with partition key", func(t *testing.T) {
schema := ConstructCollectionSchemaWithPartitionKey(collectionName, fieldName2Types, testInt64Field, testVarCharField, false)
marshaledSchema, err := proto.Marshal(schema)
assert.NoError(t, err)
resp, err := mix.CreateCollection(ctx, &milvuspb.CreateCollectionRequest{
Base: nil,
DbName: dbName,
CollectionName: collectionName,
Schema: marshaledSchema,
NumPartitions: 100,
})
assert.Equal(t, commonpb.ErrorCode_Success, resp.GetErrorCode())
assert.NoError(t, err)
})
fieldNameToDatas := make(map[string]*schemapb.FieldData)
fieldDatas := make([]*schemapb.FieldData, 0)
for name, dataType := range fieldName2Types {
data := generateFieldData(dataType, name, nb)
fieldNameToDatas[name] = data
fieldDatas = append(fieldDatas, data)
}
insertMsg := &BaseInsertTask{
BaseMsg: msgstream.BaseMsg{
HashValues: hash,
},
InsertRequest: &msgpb.InsertRequest{
Base: &commonpb.MsgBase{
MsgType: commonpb.MsgType_Insert,
MsgID: 0,
SourceID: paramtable.GetNodeID(),
},
DbName: dbName,
CollectionName: collectionName,
NumRows: uint64(nb),
FieldsData: fieldDatas,
Version: msgpb.InsertDataVersion_ColumnBased,
},
}
insertMsg.Timestamps = make([]uint64, nb)
for index := range insertMsg.Timestamps {
insertMsg.Timestamps[index] = insertMsg.BeginTimestamp
}
insertMsg.RowIDs = make([]UniqueID, nb)
for index := range insertMsg.RowIDs {
insertMsg.RowIDs[index] = int64(index)
}
}