mirror of
https://gitee.com/milvus-io/milvus.git
synced 2025-12-28 14:35:27 +08:00
21ed1fabfd
issue: #46358 This PR implements segment reopening functionality on query nodes, enabling the application of data or schema changes to already-loaded segments without requiring a full reload. ### Core (C++) **New SegmentLoadInfo class** (`internal/core/src/segcore/SegmentLoadInfo.h/cpp`): - Encapsulates segment load configuration with structured access - Implements `ComputeDiff()` to calculate differences between old and new load states - Tracks indexes, binlogs, and column groups that need to be loaded or dropped - Provides `ConvertFieldIndexInfoToLoadIndexInfo()` for index loading **ChunkedSegmentSealedImpl modifications**: - Added `Reopen(const SegmentLoadInfo&)` method to apply incremental changes based on computed diff - Refactored `LoadColumnGroups()` and `LoadColumnGroup()` to support selective loading via field ID map - Extracted `LoadBatchIndexes()` and `LoadBatchFieldData()` for reusable batch loading logic - Added `LoadManifest()` for manifest-based loading path - Updated all methods to use `SegmentLoadInfo` wrapper instead of direct proto access **SegmentGrowingImpl modifications**: - Added `Reopen()` stub method for interface compliance **C API additions** (`segment_c.h/cpp`): - Added `ReopenSegment()` function exposing reopen to Go layer ### Go Side **QueryNode handlers** (`internal/querynodev2/`): - Added `HandleReopen()` in handlers.go - Added `ReopenSegments()` RPC in services.go **Segment interface** (`internal/querynodev2/segments/`): - Extended `Segment` interface with `Reopen()` method - Implemented `Reopen()` in LocalSegment - Added `Reopen()` to segment loader **Segcore wrapper** (`internal/util/segcore/`): - Added `Reopen()` method in segment.go - Added `ReopenSegmentRequest` in requests.go ### Proto - Added new fields to support reopen in `query_coord.proto` --------- Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
91 lines
2.8 KiB
Go
91 lines
2.8 KiB
Go
package segcore
|
|
|
|
/*
|
|
#cgo pkg-config: milvus_core
|
|
|
|
#include "common/type_c.h"
|
|
|
|
*/
|
|
import "C"
|
|
|
|
import "context"
|
|
|
|
// CSegment is the interface of a segcore segment.
|
|
// TODO: We should separate the interface of CGrowingSegment and CSealedSegment,
|
|
// Because they have different implementations, GrowingSegment will only be used at streamingnode, SealedSegment will only be used at querynode.
|
|
// But currently, we just use the same interface to represent them to keep compatible with querynode LocalSegment.
|
|
type CSegment interface {
|
|
GrowingSegment
|
|
|
|
SealedSegment
|
|
}
|
|
|
|
// GrowingSegment is the interface of a growing segment.
|
|
type GrowingSegment interface {
|
|
basicSegmentMethodSet
|
|
|
|
// Insert inserts data into the segment.
|
|
Insert(ctx context.Context, request *InsertRequest) (*InsertResult, error)
|
|
}
|
|
|
|
// SealedSegment is the interface of a sealed segment.
|
|
type SealedSegment interface {
|
|
basicSegmentMethodSet
|
|
|
|
// LoadFieldData loads field data into the segment.
|
|
LoadFieldData(ctx context.Context, request *LoadFieldDataRequest) (*LoadFieldDataResult, error)
|
|
|
|
// AddFieldDataInfo adds field data info into the segment.
|
|
AddFieldDataInfo(ctx context.Context, request *AddFieldDataInfoRequest) (*AddFieldDataInfoResult, error)
|
|
|
|
// DropIndex drops the index of the segment.
|
|
DropIndex(ctx context.Context, fieldID int64) error
|
|
|
|
DropJSONIndex(ctx context.Context, fieldID int64, nestedPath string) error
|
|
|
|
Reopen(ctx context.Context, request *ReopenRequest) error
|
|
}
|
|
|
|
// basicSegmentMethodSet is the basic method set of a segment.
|
|
type basicSegmentMethodSet interface {
|
|
// ID returns the ID of the segment.
|
|
ID() int64
|
|
|
|
// RawPointer returns the raw pointer of the segment.
|
|
// TODO: should be removed in future.
|
|
RawPointer() CSegmentInterface
|
|
|
|
// RawPointer returns the raw pointer of the segment.
|
|
RowNum() int64
|
|
|
|
// MemSize returns the memory size of the segment.
|
|
MemSize() int64
|
|
|
|
// HasRawData checks if the segment has raw data.
|
|
HasRawData(fieldID int64) bool
|
|
|
|
// HasFieldData checks if the segment has field data.
|
|
HasFieldData(fieldID int64) bool
|
|
|
|
// Search requests a search on the segment.
|
|
Search(ctx context.Context, searchReq *SearchRequest) (*SearchResult, error)
|
|
|
|
// Retrieve retrieves entities from the segment.
|
|
Retrieve(ctx context.Context, plan *RetrievePlan) (*RetrieveResult, error)
|
|
|
|
// RetrieveByOffsets retrieves entities from the segment by offsets.
|
|
RetrieveByOffsets(ctx context.Context, plan *RetrievePlanWithOffsets) (*RetrieveResult, error)
|
|
|
|
// Delete deletes data from the segment.
|
|
Delete(ctx context.Context, request *DeleteRequest) (*DeleteResult, error)
|
|
|
|
// FinishLoad wraps up the load process and let segcore do the leftover jobs.
|
|
FinishLoad() error
|
|
|
|
// Load invokes segment managed loading.
|
|
Load(ctx context.Context) error
|
|
|
|
// Release releases the segment.
|
|
Release()
|
|
}
|