mirror of
https://gitee.com/milvus-io/milvus.git
synced 2025-12-07 01:28:27 +08:00
issue: https://github.com/milvus-io/milvus/issues/41690 This commit implements partial search result functionality when query nodes go down, improving system availability during node failures. The changes include: - Enhanced load balancing in proxy (lb_policy.go) to handle node failures with retry support - Added partial search result capability in querynode delegator and distribution logic - Implemented tests for various partial result scenarios when nodes go down - Added metrics to track partial search results in querynode_metrics.go - Updated parameter configuration to support partial result required data ratio - Replaced old partial_search_test.go with more comprehensive partial_result_on_node_down_test.go - Updated proto definitions and improved retry logic These changes improve query resilience by returning partial results to users when some query nodes are unavailable, ensuring that queries don't completely fail when a portion of data remains accessible. --------- Signed-off-by: Wei Liu <wei.liu@zilliz.com>
273 lines
8.0 KiB
Go
273 lines
8.0 KiB
Go
// Licensed to the LF AI & Data foundation under one
|
|
// or more contributor license agreements. See the NOTICE file
|
|
// distributed with this work for additional information
|
|
// regarding copyright ownership. The ASF licenses this file
|
|
// to you under the Apache License, Version 2.0 (the
|
|
// "License"); you may not use this file except in compliance
|
|
// with the License. You may obtain a copy of the License at
|
|
//
|
|
// http://www.apache.org/licenses/LICENSE-2.0
|
|
//
|
|
// Unless required by applicable law or agreed to in writing, software
|
|
// distributed under the License is distributed on an "AS IS" BASIS,
|
|
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
// See the License for the specific language governing permissions and
|
|
// limitations under the License.
|
|
|
|
package task
|
|
|
|
import (
|
|
"context"
|
|
"fmt"
|
|
"strconv"
|
|
"time"
|
|
|
|
"github.com/samber/lo"
|
|
|
|
"github.com/milvus-io/milvus-proto/go-api/v2/commonpb"
|
|
"github.com/milvus-io/milvus-proto/go-api/v2/msgpb"
|
|
"github.com/milvus-io/milvus-proto/go-api/v2/schemapb"
|
|
"github.com/milvus-io/milvus/internal/querycoordv2/meta"
|
|
"github.com/milvus-io/milvus/internal/querycoordv2/utils"
|
|
"github.com/milvus-io/milvus/pkg/v2/common"
|
|
"github.com/milvus-io/milvus/pkg/v2/proto/datapb"
|
|
"github.com/milvus-io/milvus/pkg/v2/proto/indexpb"
|
|
"github.com/milvus-io/milvus/pkg/v2/proto/querypb"
|
|
"github.com/milvus-io/milvus/pkg/v2/util/commonpbutil"
|
|
"github.com/milvus-io/milvus/pkg/v2/util/typeutil"
|
|
)
|
|
|
|
// idSource helper type for using id as task source
|
|
type idSource int64
|
|
|
|
func (s idSource) String() string {
|
|
return fmt.Sprintf("ID-%d", s)
|
|
}
|
|
|
|
func WrapIDSource(id int64) Source {
|
|
return idSource(id)
|
|
}
|
|
|
|
func Wait(ctx context.Context, timeout time.Duration, tasks ...Task) error {
|
|
ctx, cancel := context.WithTimeout(ctx, timeout)
|
|
defer cancel()
|
|
|
|
var err error
|
|
go func() {
|
|
for _, task := range tasks {
|
|
err = task.Wait()
|
|
if err != nil {
|
|
cancel()
|
|
break
|
|
}
|
|
}
|
|
cancel()
|
|
}()
|
|
<-ctx.Done()
|
|
|
|
return err
|
|
}
|
|
|
|
func SetPriority(priority Priority, tasks ...Task) {
|
|
for i := range tasks {
|
|
tasks[i].SetPriority(priority)
|
|
}
|
|
}
|
|
|
|
func SetReason(reason string, tasks ...Task) {
|
|
for i := range tasks {
|
|
tasks[i].SetReason(reason)
|
|
}
|
|
}
|
|
|
|
// GetTaskType returns the task's type,
|
|
// for now, only 3 types;
|
|
// - only 1 grow action -> Grow
|
|
// - only 1 reduce action -> Reduce
|
|
// - 1 grow action, and ends with 1 reduce action -> Move
|
|
func GetTaskType(task Task) Type {
|
|
switch {
|
|
case len(task.Actions()) > 1:
|
|
return TaskTypeMove
|
|
case task.Actions()[0].Type() == ActionTypeGrow:
|
|
return TaskTypeGrow
|
|
case task.Actions()[0].Type() == ActionTypeReduce:
|
|
return TaskTypeReduce
|
|
case task.Actions()[0].Type() == ActionTypeUpdate:
|
|
return TaskTypeUpdate
|
|
case task.Actions()[0].Type() == ActionTypeStatsUpdate:
|
|
return TaskTypeStatsUpdate
|
|
}
|
|
return 0
|
|
}
|
|
|
|
func mergeCollectonProps(schemaProps []*commonpb.KeyValuePair, collectionProps []*commonpb.KeyValuePair) []*commonpb.KeyValuePair {
|
|
// Merge the collectionProps and schemaProps maps, giving priority to the values in schemaProps if there are duplicate keys.
|
|
props := make(map[string]string)
|
|
for _, p := range collectionProps {
|
|
props[p.GetKey()] = p.GetValue()
|
|
}
|
|
for _, p := range schemaProps {
|
|
props[p.GetKey()] = p.GetValue()
|
|
}
|
|
var ret []*commonpb.KeyValuePair
|
|
for k, v := range props {
|
|
ret = append(ret, &commonpb.KeyValuePair{
|
|
Key: k,
|
|
Value: v,
|
|
})
|
|
}
|
|
return ret
|
|
}
|
|
|
|
func packLoadSegmentRequest(
|
|
task *SegmentTask,
|
|
action Action,
|
|
schema *schemapb.CollectionSchema,
|
|
collectionProperties []*commonpb.KeyValuePair,
|
|
loadMeta *querypb.LoadMetaInfo,
|
|
loadInfo *querypb.SegmentLoadInfo,
|
|
indexInfo []*indexpb.IndexInfo,
|
|
) *querypb.LoadSegmentsRequest {
|
|
loadScope := querypb.LoadScope_Full
|
|
if action.Type() == ActionTypeUpdate {
|
|
loadScope = querypb.LoadScope_Index
|
|
}
|
|
|
|
if action.Type() == ActionTypeStatsUpdate {
|
|
loadScope = querypb.LoadScope_Stats
|
|
}
|
|
|
|
if task.Source() == utils.LeaderChecker {
|
|
loadScope = querypb.LoadScope_Delta
|
|
}
|
|
// field mmap enabled if collection-level mmap enabled or the field mmap enabled
|
|
collectionMmapEnabled, exist := common.IsMmapDataEnabled(collectionProperties...)
|
|
for _, field := range schema.GetFields() {
|
|
if exist {
|
|
field.TypeParams = append(field.TypeParams, &commonpb.KeyValuePair{
|
|
Key: common.MmapEnabledKey,
|
|
Value: strconv.FormatBool(collectionMmapEnabled),
|
|
})
|
|
}
|
|
}
|
|
|
|
schema.Properties = mergeCollectonProps(schema.Properties, collectionProperties)
|
|
|
|
return &querypb.LoadSegmentsRequest{
|
|
Base: commonpbutil.NewMsgBase(
|
|
commonpbutil.WithMsgType(commonpb.MsgType_LoadSegments),
|
|
commonpbutil.WithMsgID(task.ID()),
|
|
),
|
|
Infos: []*querypb.SegmentLoadInfo{loadInfo},
|
|
Schema: schema, // assign it for compatibility of rolling upgrade from 2.2.x to 2.3
|
|
LoadMeta: loadMeta, // assign it for compatibility of rolling upgrade from 2.2.x to 2.3
|
|
CollectionID: task.CollectionID(),
|
|
ReplicaID: task.ReplicaID(),
|
|
DeltaPositions: []*msgpb.MsgPosition{loadInfo.GetDeltaPosition()}, // assign it for compatibility of rolling upgrade from 2.2.x to 2.3
|
|
DstNodeID: action.Node(),
|
|
Version: time.Now().UnixNano(),
|
|
NeedTransfer: true,
|
|
IndexInfoList: indexInfo,
|
|
LoadScope: loadScope,
|
|
}
|
|
}
|
|
|
|
func packReleaseSegmentRequest(task *SegmentTask, action *SegmentAction) *querypb.ReleaseSegmentsRequest {
|
|
return &querypb.ReleaseSegmentsRequest{
|
|
Base: commonpbutil.NewMsgBase(
|
|
commonpbutil.WithMsgType(commonpb.MsgType_ReleaseSegments),
|
|
commonpbutil.WithMsgID(task.ID()),
|
|
),
|
|
|
|
NodeID: action.Node(),
|
|
CollectionID: task.CollectionID(),
|
|
SegmentIDs: []int64{task.SegmentID()},
|
|
Scope: action.GetScope(),
|
|
Shard: action.GetShard(),
|
|
NeedTransfer: false,
|
|
}
|
|
}
|
|
|
|
func packLoadMeta(loadType querypb.LoadType, collectionID int64, databaseName string, resourceGroup string, loadFields []int64, partitions ...int64) *querypb.LoadMetaInfo {
|
|
return &querypb.LoadMetaInfo{
|
|
LoadType: loadType,
|
|
CollectionID: collectionID,
|
|
PartitionIDs: partitions,
|
|
DbName: databaseName,
|
|
ResourceGroup: resourceGroup,
|
|
LoadFields: loadFields,
|
|
}
|
|
}
|
|
|
|
func packSubChannelRequest(
|
|
task *ChannelTask,
|
|
action Action,
|
|
schema *schemapb.CollectionSchema,
|
|
loadMeta *querypb.LoadMetaInfo,
|
|
channel *meta.DmChannel,
|
|
indexInfo []*indexpb.IndexInfo,
|
|
partitions []int64,
|
|
targetVersion int64,
|
|
) *querypb.WatchDmChannelsRequest {
|
|
return &querypb.WatchDmChannelsRequest{
|
|
Base: commonpbutil.NewMsgBase(
|
|
commonpbutil.WithMsgType(commonpb.MsgType_WatchDmChannels),
|
|
commonpbutil.WithMsgID(task.ID()),
|
|
),
|
|
NodeID: action.Node(),
|
|
CollectionID: task.CollectionID(),
|
|
PartitionIDs: partitions,
|
|
Infos: []*datapb.VchannelInfo{channel.VchannelInfo},
|
|
Schema: schema, // assign it for compatibility of rolling upgrade from 2.2.x to 2.3
|
|
LoadMeta: loadMeta, // assign it for compatibility of rolling upgrade from 2.2.x to 2.3
|
|
ReplicaID: task.ReplicaID(),
|
|
Version: time.Now().UnixNano(),
|
|
IndexInfoList: indexInfo,
|
|
TargetVersion: targetVersion,
|
|
}
|
|
}
|
|
|
|
func fillSubChannelRequest(
|
|
ctx context.Context,
|
|
req *querypb.WatchDmChannelsRequest,
|
|
broker meta.Broker,
|
|
includeFlushed bool,
|
|
) error {
|
|
segmentIDs := typeutil.NewUniqueSet()
|
|
for _, vchannel := range req.GetInfos() {
|
|
if includeFlushed {
|
|
segmentIDs.Insert(vchannel.GetFlushedSegmentIds()...)
|
|
}
|
|
segmentIDs.Insert(vchannel.GetUnflushedSegmentIds()...)
|
|
segmentIDs.Insert(vchannel.GetLevelZeroSegmentIds()...)
|
|
}
|
|
|
|
if segmentIDs.Len() == 0 {
|
|
return nil
|
|
}
|
|
|
|
segmentInfos, err := broker.GetSegmentInfo(ctx, segmentIDs.Collect()...)
|
|
if err != nil {
|
|
return err
|
|
}
|
|
|
|
req.SegmentInfos = lo.SliceToMap(segmentInfos, func(info *datapb.SegmentInfo) (int64, *datapb.SegmentInfo) {
|
|
return info.GetID(), info
|
|
})
|
|
|
|
return nil
|
|
}
|
|
|
|
func packUnsubDmChannelRequest(task *ChannelTask, action Action) *querypb.UnsubDmChannelRequest {
|
|
return &querypb.UnsubDmChannelRequest{
|
|
Base: commonpbutil.NewMsgBase(
|
|
commonpbutil.WithMsgType(commonpb.MsgType_UnsubDmChannel),
|
|
commonpbutil.WithMsgID(task.ID()),
|
|
),
|
|
NodeID: action.Node(),
|
|
CollectionID: task.CollectionID(),
|
|
ChannelName: task.Channel(),
|
|
}
|
|
}
|