mirror of
https://gitee.com/milvus-io/milvus.git
synced 2026-01-07 19:31:51 +08:00
b18ebd9468
issue: https://github.com/milvus-io/milvus/issues/44123 <!-- This is an auto-generated comment: release notes by coderabbit.ai --> - Core invariant: legacy in-cluster CDC/replication plumbing (ReplicateMsg types, ReplicateID-based guards and flags) is obsolete — the system relies on standard msgstream positions, subPos/end-ts semantics and timetick ordering as the single source of truth for message ordering and skipping, so replication-specific channels/types/guards can be removed safely. - Removed/simplified logic (what and why): removed replication feature flags and params (ReplicateMsgChannel, TTMsgEnabled, CollectionReplicateEnable), ReplicateMsg type and its tests, ReplicateID constants/helpers and MergeProperties hooks, ReplicateConfig and its propagation (streamPipeline, StreamConfig, dispatcher, target), replicate-aware dispatcher/pipeline branches, and replicate-mode pre-checks/timestamp-allocation in proxy tasks — these implemented a redundant alternate “replicate-mode” pathway that duplicated position/end-ts and timetick logic. - Why this does NOT cause data loss or regression (concrete code paths): no persistence or core write paths were removed — proxy PreExecute flows (internal/proxy/task_*.go) still perform the same schema/ID/size validations and then follow the normal non-replicate execution path; dispatcher and pipeline continue to use position/subPos and pullback/end-ts in Seek/grouping (pkg/mq/msgdispatcher/dispatcher.go, internal/util/pipeline/stream_pipeline.go), so skipping and ordering behavior remains unchanged; timetick emission in rootcoord (sendMinDdlTsAsTt) is now ungated (no silent suppression), preserving or increasing timetick delivery rather than removing it. - PR type and net effect: Enhancement/Refactor — removes deprecated replication API surface (types, helpers, config, tests) and replication branches, simplifies public APIs and constructor signatures, and reduces surface area for future maintenance while keeping DML/DDL persistence, ordering, and seek semantics intact. <!-- end of auto-generated comment: release notes by coderabbit.ai --> --------- Signed-off-by: bigsheeper <yihao.dai@zilliz.com>
84 lines
2.3 KiB
Go
84 lines
2.3 KiB
Go
// Licensed to the LF AI & Data foundation under one
|
|
// or more contributor license agreements. See the NOTICE file
|
|
// distributed with this work for additional information
|
|
// regarding copyright ownership. The ASF licenses this file
|
|
// to you under the Apache License, Version 2.0 (the
|
|
// "License"); you may not use this file except in compliance
|
|
// with the License. You may obtain a copy of the License at
|
|
//
|
|
// http://www.apache.org/licenses/LICENSE-2.0
|
|
//
|
|
// Unless required by applicable law or agreed to in writing, software
|
|
// distributed under the License is distributed on an "AS IS" BASIS,
|
|
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
// See the License for the specific language governing permissions and
|
|
// limitations under the License.
|
|
|
|
package proxy
|
|
|
|
import (
|
|
"fmt"
|
|
|
|
"github.com/milvus-io/milvus/pkg/v2/mq/msgstream"
|
|
)
|
|
|
|
// insertRepackFunc deprecated, use defaultInsertRepackFunc instead.
|
|
func insertRepackFunc(
|
|
tsMsgs []msgstream.TsMsg,
|
|
hashKeys [][]int32,
|
|
) (map[int32]*msgstream.MsgPack, error) {
|
|
if len(hashKeys) < len(tsMsgs) {
|
|
return nil, fmt.Errorf(
|
|
"the length of hash keys (%d) is less than the length of messages (%d)",
|
|
len(hashKeys),
|
|
len(tsMsgs),
|
|
)
|
|
}
|
|
|
|
result := make(map[int32]*msgstream.MsgPack)
|
|
for i, request := range tsMsgs {
|
|
keys := hashKeys[i]
|
|
if len(keys) > 0 {
|
|
key := keys[0]
|
|
_, ok := result[key]
|
|
if !ok {
|
|
result[key] = &msgstream.MsgPack{}
|
|
}
|
|
result[key].Msgs = append(result[key].Msgs, request)
|
|
} else {
|
|
return nil, fmt.Errorf("no hash key for %dth message", i)
|
|
}
|
|
}
|
|
|
|
return result, nil
|
|
}
|
|
|
|
// defaultInsertRepackFunc repacks the dml messages.
|
|
func defaultInsertRepackFunc(
|
|
tsMsgs []msgstream.TsMsg,
|
|
hashKeys [][]int32,
|
|
) (map[int32]*msgstream.MsgPack, error) {
|
|
if len(hashKeys) < len(tsMsgs) {
|
|
return nil, fmt.Errorf(
|
|
"the length of hash keys (%d) is less than the length of messages (%d)",
|
|
len(hashKeys),
|
|
len(tsMsgs),
|
|
)
|
|
}
|
|
|
|
// after assigning segment id to msg, tsMsgs was already re-bucketed
|
|
pack := make(map[int32]*msgstream.MsgPack)
|
|
for idx, msg := range tsMsgs {
|
|
if len(hashKeys[idx]) <= 0 {
|
|
return nil, fmt.Errorf("no hash key for %dth message", idx)
|
|
}
|
|
key := hashKeys[idx][0]
|
|
_, ok := pack[key]
|
|
if !ok {
|
|
pack[key] = &msgstream.MsgPack{}
|
|
}
|
|
pack[key].Msgs = append(pack[key].Msgs, msg)
|
|
}
|
|
return pack, nil
|
|
}
|