milvus/internal/storage/stats_collector.go
congqixia f94b04e642
feat: [2.6] integrate Loon FFI for manifest-based segment loading and index building (#46076)
Cherry-pick from master
pr: #45061 #45488 #45803 #46017 #44991 #45132 #45723 #45726 #45798
#45897 #45918 #44998

This feature integrates the Storage V2 (Loon) FFI interface as a unified
storage layer for segment loading and index building in Milvus. It
enables
manifest-based data access, replacing the traditional binlog-based
approach
with a more efficient columnar storage format.

Key changes:

### Segment Self-Managed Loading Architecture
- Move segment loading orchestration from Go layer to C++ segcore
- Add NewSegmentWithLoadInfo() API for passing load info during segment
creation
- Implement SetLoadInfo() and Load() methods in SegmentInterface
- Support parallel loading of indexed and non-indexed fields
- Enable both sealed and growing segments to self-manage loading

### Storage V2 FFI Integration
- Integrate milvus-storage library's FFI interface for packed columnar
data
- Add manifest path support throughout the data path (SegmentInfo,
LoadInfo)
- Implement ManifestReader for generating manifests from binlogs
- Support zero-copy data exchange using Arrow C Data Interface
- Add ToCStorageConfig() for Go-to-C storage config conversion

### Manifest-Based Index Building
- Extend FileManagerContext to carry loon_ffi_properties
- Implement GetFieldDatasFromManifest() using Arrow C Stream interface
- Support manifest-based reading in DiskFileManagerImpl and
MemFileManagerImpl
- Add fallback to traditional segment insert files when manifest
unavailable

### Compaction Pipeline Updates
- Include manifest path in all compaction task builders (clustering, L0,
mix)
- Update BulkPackWriterV2 to return manifest path
- Propagate manifest metadata through compaction pipeline

### Configuration & Protocol
- Add common.storageV2.useLoonFFI config option (default: false)
- Add manifest_path field to SegmentLoadInfo and related proto messages
- Add manifest field to compaction segment messages

### Bug Fixes
- Fix mmap settings not applied during segment load (key typo fix)
- Populate index info after segment loading to prevent redundant load
tasks
- Fix memory corruption by removing premature transaction handle
destruction

Related issues: #44956, #45060, #39173

## Individual Cherry-Picked Commits

1. **e1c923b5cc** - fix: apply mmap settings correctly during segment
load (#46017)
2. **63b912370b** - enhance: use milvus-storage internal C++ Reader API
for Loon FFI (#45897)
3. **bfc192faa5** - enhance: Resolve issues integrating loon FFI
(#45918)
4. **fb18564631** - enhance: support manifest-based index building with
Loon FFI reader (#45726)
5. **b9ec2392b9** - enhance: integrate StorageV2 FFI interface for
manifest-based segment loading (#45798)
6. **66db3c32e6** - enhance: integrate Storage V2 FFI interface for
unified storage access (#45723)
7. **ae789273ac** - fix: populate index info after segment loading to
prevent redundant load tasks (#45803)
8. **49688b0be2** - enhance: Move segment loading logic from Go layer to
segcore for self-managed loading (#45488)
9. **5b2df88bac** - enhance: [StorageV2] Integrate FFI interface for
packed reader (#45132)
10. **91ff5706ac** - enhance: [StorageV2] add manifest path support for
FFI integration (#44991)
11. **2192bb4a85** - enhance: add NewSegmentWithLoadInfo API to support
segment self-managed loading (#45061)
12. **4296b01da0** - enhance: update delta log serialization APIs to
integrate storage V2 (#44998)

## Technical Details

### Architecture Changes
- **Before**: Go layer orchestrated segment loading, making multiple CGO
calls
- **After**: Segments autonomously manage loading in C++ layer with
single entry point

### Storage Access Pattern
- **Before**: Read individual binlog files through Go storage layer
- **After**: Read manifest file that references packed columnar data via
FFI

### Benefits
- Reduced cross-language call overhead
- Better resource management at C++ level
- Improved I/O performance through batched streaming reads
- Cleaner separation of concerns between Go and C++ layers
- Foundation for proactive schema evolution handling

---------

Signed-off-by: Ted Xu <ted.xu@zilliz.com>
Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
Co-authored-by: Ted Xu <ted.xu@zilliz.com>
2025-12-04 17:09:12 +08:00

279 lines
7.3 KiB
Go

// Licensed to the LF AI & Data foundation under one
// or more contributor license agreements. See the NOTICE file
// distributed with this work for additional information
// regarding copyright ownership. The ASF licenses this file
// to you under the Apache License, Version 2.0 (the
// "License"); you may not use this file except in compliance
// with the License. You may obtain a copy of the License at
//
// http://www.apache.org/licenses/LICENSE-2.0
//
// Unless required by applicable law or agreed to in writing, software
// distributed under the License is distributed on an "AS IS" BASIS,
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
// See the License for the specific language governing permissions and
// limitations under the License.
package storage
import (
"strconv"
"github.com/apache/arrow/go/v17/arrow/array"
"github.com/cockroachdb/errors"
"github.com/samber/lo"
"github.com/milvus-io/milvus-proto/go-api/v2/schemapb"
"github.com/milvus-io/milvus/internal/allocator"
"github.com/milvus-io/milvus/pkg/v2/proto/datapb"
"github.com/milvus-io/milvus/pkg/v2/proto/etcdpb"
"github.com/milvus-io/milvus/pkg/v2/util/metautil"
"github.com/milvus-io/milvus/pkg/v2/util/typeutil"
)
// StatsCollector collects statistics from records
type StatsCollector interface {
// Collect collects statistics from a record
Collect(r Record) error
// Digest serializes the collected statistics, writes them to storage,
// and returns the field binlog metadata
Digest(
collectionID, partitionID, segmentID UniqueID,
rootPath string,
rowNum int64,
allocator allocator.Interface,
blobsWriter ChunkedBlobsWriter,
) (map[FieldID]*datapb.FieldBinlog, error)
}
// PkStatsCollector collects primary key statistics
type PkStatsCollector struct {
pkstats *PrimaryKeyStats
collectionID UniqueID // needed for initializing codecs, TODO: remove this
schema *schemapb.CollectionSchema
}
// Collect collects primary key stats from the record
func (c *PkStatsCollector) Collect(r Record) error {
if c.pkstats == nil {
return nil
}
rows := r.Len()
for i := 0; i < rows; i++ {
switch schemapb.DataType(c.pkstats.PkType) {
case schemapb.DataType_Int64:
pkArray := r.Column(c.pkstats.FieldID).(*array.Int64)
pk := &Int64PrimaryKey{
Value: pkArray.Value(i),
}
c.pkstats.Update(pk)
case schemapb.DataType_VarChar:
pkArray := r.Column(c.pkstats.FieldID).(*array.String)
pk := &VarCharPrimaryKey{
Value: pkArray.Value(i),
}
c.pkstats.Update(pk)
default:
panic("invalid data type")
}
}
return nil
}
// Digest serializes the collected primary key statistics, writes them to storage,
// and returns the field binlog metadata
func (c *PkStatsCollector) Digest(
collectionID, partitionID, segmentID UniqueID,
rootPath string,
rowNum int64,
allocator allocator.Interface,
blobsWriter ChunkedBlobsWriter,
) (map[FieldID]*datapb.FieldBinlog, error) {
if c.pkstats == nil {
return nil, nil
}
// Serialize PK stats
codec := NewInsertCodecWithSchema(&etcdpb.CollectionMeta{
ID: c.collectionID,
Schema: c.schema,
})
sblob, err := codec.SerializePkStats(c.pkstats, rowNum)
if err != nil {
return nil, err
}
// Get pk field ID
pkField, err := typeutil.GetPrimaryFieldSchema(c.schema)
if err != nil {
return nil, err
}
// Allocate ID for stats blob
id, err := allocator.AllocOne()
if err != nil {
return nil, err
}
// Assign proper path to the blob
fieldID := pkField.GetFieldID()
sblob.Key = metautil.BuildStatsLogPath(rootPath,
c.collectionID, partitionID, segmentID, fieldID, id)
// Write the blob
if err := blobsWriter([]*Blob{sblob}); err != nil {
return nil, err
}
// Return as map for interface consistency
return map[FieldID]*datapb.FieldBinlog{
fieldID: {
FieldID: fieldID,
Binlogs: []*datapb.Binlog{
{
LogSize: int64(len(sblob.GetValue())),
MemorySize: int64(len(sblob.GetValue())),
LogPath: sblob.Key,
EntriesNum: rowNum,
},
},
},
}, nil
}
// NewPkStatsCollector creates a new primary key stats collector
func NewPkStatsCollector(
collectionID UniqueID,
schema *schemapb.CollectionSchema,
maxRowNum int64,
) (*PkStatsCollector, error) {
pkField, err := typeutil.GetPrimaryFieldSchema(schema)
if err != nil {
return nil, err
}
stats, err := NewPrimaryKeyStats(pkField.GetFieldID(), int64(pkField.GetDataType()), maxRowNum)
if err != nil {
return nil, err
}
return &PkStatsCollector{
pkstats: stats,
collectionID: collectionID,
schema: schema,
}, nil
}
// Bm25StatsCollector collects BM25 statistics
type Bm25StatsCollector struct {
bm25Stats map[int64]*BM25Stats
}
// Collect collects BM25 statistics from the record
func (c *Bm25StatsCollector) Collect(r Record) error {
if len(c.bm25Stats) == 0 {
return nil
}
rows := r.Len()
for fieldID, stats := range c.bm25Stats {
field, ok := r.Column(fieldID).(*array.Binary)
if !ok {
return errors.New("bm25 field value not found")
}
for i := 0; i < rows; i++ {
stats.AppendBytes(field.Value(i))
}
}
return nil
}
// Digest serializes the collected BM25 statistics, writes them to storage,
// and returns the field binlog metadata
func (c *Bm25StatsCollector) Digest(
collectionID, partitionID, segmentID UniqueID,
rootPath string,
rowNum int64,
allocator allocator.Interface,
blobsWriter ChunkedBlobsWriter,
) (map[FieldID]*datapb.FieldBinlog, error) {
if len(c.bm25Stats) == 0 {
return nil, nil
}
// Serialize BM25 stats into blobs
blobs := make([]*Blob, 0, len(c.bm25Stats))
for fid, stats := range c.bm25Stats {
bytes, err := stats.Serialize()
if err != nil {
return nil, err
}
blob := &Blob{
Key: strconv.FormatInt(fid, 10), // temporary key, will be replaced below
Value: bytes,
RowNum: stats.NumRow(),
MemorySize: int64(len(bytes)),
}
blobs = append(blobs, blob)
}
// Allocate IDs for stats blobs
id, _, err := allocator.Alloc(uint32(len(blobs)))
if err != nil {
return nil, err
}
result := make(map[FieldID]*datapb.FieldBinlog)
// Process each blob and assign proper paths
for _, blob := range blobs {
// Parse the field ID from the temporary key
fieldID, parseErr := strconv.ParseInt(blob.Key, 10, 64)
if parseErr != nil {
// This should not happen for BM25 blobs
continue
}
blob.Key = metautil.BuildBm25LogPath(rootPath,
collectionID, partitionID, segmentID, fieldID, id)
result[fieldID] = &datapb.FieldBinlog{
FieldID: fieldID,
Binlogs: []*datapb.Binlog{
{
LogSize: int64(len(blob.GetValue())),
MemorySize: int64(len(blob.GetValue())),
LogPath: blob.Key,
EntriesNum: rowNum,
},
},
}
id++
}
// Write all blobs
if err := blobsWriter(blobs); err != nil {
return nil, err
}
return result, nil
}
// NewBm25StatsCollector creates a new BM25 stats collector
func NewBm25StatsCollector(schema *schemapb.CollectionSchema) *Bm25StatsCollector {
bm25FieldIDs := lo.FilterMap(schema.GetFunctions(), func(function *schemapb.FunctionSchema, _ int) (int64, bool) {
if function.GetType() == schemapb.FunctionType_BM25 {
return function.GetOutputFieldIds()[0], true
}
return 0, false
})
bm25Stats := make(map[int64]*BM25Stats, len(bm25FieldIDs))
for _, fid := range bm25FieldIDs {
bm25Stats[fid] = NewBM25Stats()
}
return &Bm25StatsCollector{
bm25Stats: bm25Stats,
}
}