mirror of
https://gitee.com/milvus-io/milvus.git
synced 2025-12-06 17:18:35 +08:00
f3e5a53fc5
When there're no growing segments in the collection, L0 Compaction will try to choose all L0 segments that hits all L1/L2 segments. However, if there's Sealed Segment still under flushing in DataNode at the same time L0 Compaction selects satisfied L1/L2 segments, L0 Compaction will ignore this Segment because it's not in "FlushState", which is wrong, causing missing deletes on the Sealed Segment. This quick solution here is to fail this L0 compaction task once selected a Sealed segment. See also: #45339 pr: #45340 --------- Signed-off-by: yangxuan <xuan.yang@zilliz.com>
111 lines
3.0 KiB
Go
111 lines
3.0 KiB
Go
// Licensed to the LF AI & Data foundation under one
|
|
// or more contributor license agreements. See the NOTICE file
|
|
// distributed with this work for additional information
|
|
// regarding copyright ownership. The ASF licenses this file
|
|
// to you under the Apache License, Version 2.0 (the
|
|
// "License"); you may not use this file except in compliance
|
|
// with the License. You may obtain a copy of the License at
|
|
//
|
|
// http://www.apache.org/licenses/LICENSE-2.0
|
|
//
|
|
// Unless required by applicable law or agreed to in writing, software
|
|
// distributed under the License is distributed on an "AS IS" BASIS,
|
|
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
// See the License for the specific language governing permissions and
|
|
// limitations under the License.
|
|
|
|
package datacoord
|
|
|
|
import (
|
|
"github.com/milvus-io/milvus/internal/datacoord/task"
|
|
"github.com/milvus-io/milvus/pkg/v2/proto/datapb"
|
|
)
|
|
|
|
type CompactionTask interface {
|
|
task.Task
|
|
// Process performs the task's state machine
|
|
//
|
|
// Returns:
|
|
// - <bool>: whether the task state machine ends.
|
|
//
|
|
// Notes:
|
|
//
|
|
// `end` doesn't mean the task completed, its state may be completed or failed or timeout.
|
|
Process() bool
|
|
// Clean performs clean logic for a fail/timeout task
|
|
Clean() bool
|
|
BuildCompactionRequest() (*datapb.CompactionPlan, error)
|
|
GetSlotUsage() int64
|
|
GetLabel() string
|
|
|
|
SetTask(*datapb.CompactionTask)
|
|
GetTaskProto() *datapb.CompactionTask
|
|
ShadowClone(opts ...compactionTaskOpt) *datapb.CompactionTask
|
|
|
|
SetNodeID(UniqueID) error
|
|
NeedReAssignNodeID() bool
|
|
SaveTaskMeta() error
|
|
}
|
|
|
|
type compactionTaskOpt func(task *datapb.CompactionTask)
|
|
|
|
func setNodeID(nodeID int64) compactionTaskOpt {
|
|
return func(task *datapb.CompactionTask) {
|
|
task.NodeID = nodeID
|
|
}
|
|
}
|
|
|
|
func setFailReason(reason string) compactionTaskOpt {
|
|
return func(task *datapb.CompactionTask) {
|
|
task.FailReason = reason
|
|
}
|
|
}
|
|
|
|
func setEndTime(endTime int64) compactionTaskOpt {
|
|
return func(task *datapb.CompactionTask) {
|
|
task.EndTime = endTime
|
|
}
|
|
}
|
|
|
|
func setResultSegments(segments []int64) compactionTaskOpt {
|
|
return func(task *datapb.CompactionTask) {
|
|
task.ResultSegments = segments
|
|
}
|
|
}
|
|
|
|
func setTmpSegments(segments []int64) compactionTaskOpt {
|
|
return func(task *datapb.CompactionTask) {
|
|
task.TmpSegments = segments
|
|
}
|
|
}
|
|
|
|
func setState(state datapb.CompactionTaskState) compactionTaskOpt {
|
|
return func(task *datapb.CompactionTask) {
|
|
task.State = state
|
|
}
|
|
}
|
|
|
|
func setStartTime(startTime int64) compactionTaskOpt {
|
|
return func(task *datapb.CompactionTask) {
|
|
task.StartTime = startTime
|
|
}
|
|
}
|
|
|
|
func setRetryTimes(retryTimes int32) compactionTaskOpt {
|
|
return func(task *datapb.CompactionTask) {
|
|
task.RetryTimes = retryTimes
|
|
}
|
|
}
|
|
|
|
func setLastStateStartTime(lastStateStartTime int64) compactionTaskOpt {
|
|
return func(task *datapb.CompactionTask) {
|
|
task.LastStateStartTime = lastStateStartTime
|
|
}
|
|
}
|
|
|
|
func setAnalyzeTaskID(id int64) compactionTaskOpt {
|
|
return func(task *datapb.CompactionTask) {
|
|
task.AnalyzeTaskID = id
|
|
}
|
|
}
|