mirror of
https://gitee.com/milvus-io/milvus.git
synced 2025-12-08 01:58:34 +08:00
f61952adfc
1. Use goroutine pool instead of sem. 2. Remove compaction executor from pipeline, since in streaming mode pipeline should be decoupled from compaction. issue: https://github.com/milvus-io/milvus/issues/44541 Signed-off-by: bigsheeper <yihao.dai@zilliz.com>
66 lines
1.9 KiB
Go
66 lines
1.9 KiB
Go
// Licensed to the LF AI & Data foundation under one
|
|
// or more contributor license agreements. See the NOTICE file
|
|
// distributed with this work for additional information
|
|
// regarding copyright ownership. The ASF licenses this file
|
|
// to you under the Apache License, Version 2.0 (the
|
|
// "License"); you may not use this file except in compliance
|
|
// with the License. You may obtain a copy of the License at
|
|
//
|
|
// http://www.apache.org/licenses/LICENSE-2.0
|
|
//
|
|
// Unless required by applicable law or agreed to in writing, software
|
|
// distributed under the License is distributed on an "AS IS" BASIS,
|
|
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
// See the License for the specific language governing permissions and
|
|
// limitations under the License.
|
|
|
|
package compactor
|
|
|
|
import (
|
|
"context"
|
|
"sync"
|
|
|
|
"go.uber.org/zap"
|
|
|
|
"github.com/milvus-io/milvus/pkg/v2/config"
|
|
"github.com/milvus-io/milvus/pkg/v2/log"
|
|
"github.com/milvus-io/milvus/pkg/v2/util/conc"
|
|
"github.com/milvus-io/milvus/pkg/v2/util/paramtable"
|
|
)
|
|
|
|
var (
|
|
execPool *conc.Pool[any]
|
|
execPoolInitOnce sync.Once
|
|
)
|
|
|
|
func initExecPool() {
|
|
pt := paramtable.Get()
|
|
initPoolSize := pt.DataNodeCfg.MaxCompactionConcurrency.GetAsInt()
|
|
execPool = conc.NewPool[any](
|
|
initPoolSize,
|
|
)
|
|
|
|
watchKey := pt.DataNodeCfg.MaxCompactionConcurrency.Key
|
|
pt.Watch(watchKey, config.NewHandler(watchKey, resizeExecPool))
|
|
log.Info("init compaction execution pool done", zap.Int("size", initPoolSize))
|
|
}
|
|
|
|
func resizeExecPool(evt *config.Event) {
|
|
if evt.HasUpdated {
|
|
newSize := paramtable.Get().DataNodeCfg.MaxCompactionConcurrency.GetAsInt()
|
|
log := log.Ctx(context.Background()).With(zap.Int("newSize", newSize))
|
|
|
|
err := GetExecPool().Resize(newSize)
|
|
if err != nil {
|
|
log.Warn("failed to resize pool", zap.Error(err))
|
|
return
|
|
}
|
|
log.Info("pool resize successfully")
|
|
}
|
|
}
|
|
|
|
func GetExecPool() *conc.Pool[any] {
|
|
execPoolInitOnce.Do(initExecPool)
|
|
return execPool
|
|
}
|