mirror of
https://gitee.com/milvus-io/milvus.git
synced 2025-12-06 17:18:35 +08:00
3cd0b26285
issue: #35821 After collection loaded, if we need to increase/decrease collection's replica, we need to release and load it again. milvus offers 4 solution to update loaded collection's replica, this PR aims to dynamic change the replica number without release, and after replica number changed, milvus will execute load replica or release replica in async, and the replica loaded status can be checked by getReplicas API. Notice that if set too much replicas than querynode can afford，the new replica won't be loaded successfully until enough querynode joins. --------- Signed-off-by: Wei Liu <wei.liu@zilliz.com>
455 lines
16 KiB
Go
455 lines
16 KiB
Go
// Licensed to the LF AI & Data foundation under one
|
|
// or more contributor license agreements. See the NOTICE file
|
|
// distributed with this work for additional information
|
|
// regarding copyright ownership. The ASF licenses this file
|
|
// to you under the Apache License, Version 2.0 (the
|
|
// "License"); you may not use this file except in compliance
|
|
// with the License. You may obtain a copy of the License at
|
|
//
|
|
// http://www.apache.org/licenses/LICENSE-2.0
|
|
//
|
|
// Unless required by applicable law or agreed to in writing, software
|
|
// distributed under the License is distributed on an "AS IS" BASIS,
|
|
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
// See the License for the specific language governing permissions and
|
|
// limitations under the License.
|
|
|
|
package job
|
|
|
|
import (
|
|
"context"
|
|
"fmt"
|
|
"time"
|
|
|
|
"github.com/cockroachdb/errors"
|
|
"github.com/samber/lo"
|
|
"go.opentelemetry.io/otel"
|
|
"go.opentelemetry.io/otel/trace"
|
|
"go.uber.org/zap"
|
|
|
|
"github.com/milvus-io/milvus/internal/proto/querypb"
|
|
"github.com/milvus-io/milvus/internal/querycoordv2/meta"
|
|
"github.com/milvus-io/milvus/internal/querycoordv2/observers"
|
|
"github.com/milvus-io/milvus/internal/querycoordv2/session"
|
|
"github.com/milvus-io/milvus/internal/querycoordv2/utils"
|
|
"github.com/milvus-io/milvus/pkg/eventlog"
|
|
"github.com/milvus-io/milvus/pkg/log"
|
|
"github.com/milvus-io/milvus/pkg/metrics"
|
|
"github.com/milvus-io/milvus/pkg/util/funcutil"
|
|
"github.com/milvus-io/milvus/pkg/util/merr"
|
|
"github.com/milvus-io/milvus/pkg/util/typeutil"
|
|
)
|
|
|
|
type LoadCollectionJob struct {
|
|
*BaseJob
|
|
req *querypb.LoadCollectionRequest
|
|
undo *UndoList
|
|
|
|
dist *meta.DistributionManager
|
|
meta *meta.Meta
|
|
broker meta.Broker
|
|
cluster session.Cluster
|
|
targetMgr meta.TargetManagerInterface
|
|
targetObserver *observers.TargetObserver
|
|
collectionObserver *observers.CollectionObserver
|
|
nodeMgr *session.NodeManager
|
|
}
|
|
|
|
func NewLoadCollectionJob(
|
|
ctx context.Context,
|
|
req *querypb.LoadCollectionRequest,
|
|
dist *meta.DistributionManager,
|
|
meta *meta.Meta,
|
|
broker meta.Broker,
|
|
cluster session.Cluster,
|
|
targetMgr meta.TargetManagerInterface,
|
|
targetObserver *observers.TargetObserver,
|
|
collectionObserver *observers.CollectionObserver,
|
|
nodeMgr *session.NodeManager,
|
|
) *LoadCollectionJob {
|
|
return &LoadCollectionJob{
|
|
BaseJob: NewBaseJob(ctx, req.Base.GetMsgID(), req.GetCollectionID()),
|
|
req: req,
|
|
undo: NewUndoList(ctx, meta, cluster, targetMgr, targetObserver),
|
|
dist: dist,
|
|
meta: meta,
|
|
broker: broker,
|
|
cluster: cluster,
|
|
targetMgr: targetMgr,
|
|
targetObserver: targetObserver,
|
|
collectionObserver: collectionObserver,
|
|
nodeMgr: nodeMgr,
|
|
}
|
|
}
|
|
|
|
func (job *LoadCollectionJob) PreExecute() error {
|
|
req := job.req
|
|
log := log.Ctx(job.ctx).With(zap.Int64("collectionID", req.GetCollectionID()))
|
|
|
|
if req.GetReplicaNumber() <= 0 {
|
|
log.Info("request doesn't indicate the number of replicas, set it to 1",
|
|
zap.Int32("replicaNumber", req.GetReplicaNumber()))
|
|
req.ReplicaNumber = 1
|
|
}
|
|
|
|
if len(req.GetResourceGroups()) == 0 {
|
|
req.ResourceGroups = []string{meta.DefaultResourceGroupName}
|
|
}
|
|
|
|
collection := job.meta.GetCollection(req.GetCollectionID())
|
|
if collection == nil {
|
|
return nil
|
|
}
|
|
|
|
if collection.GetReplicaNumber() != req.GetReplicaNumber() {
|
|
msg := fmt.Sprintf("collection with different replica number %d existed, release this collection first before changing its replica number",
|
|
job.meta.GetReplicaNumber(req.GetCollectionID()),
|
|
)
|
|
log.Warn(msg)
|
|
return merr.WrapErrParameterInvalid(collection.GetReplicaNumber(), req.GetReplicaNumber(), "can't change the replica number for loaded collection")
|
|
}
|
|
|
|
if !funcutil.SliceSetEqual(collection.GetLoadFields(), req.GetLoadFields()) {
|
|
log.Warn("collection with different load field list exists, release this collection first before chaning its replica number",
|
|
zap.Int64s("loadedFieldIDs", collection.GetLoadFields()),
|
|
zap.Int64s("reqFieldIDs", req.GetLoadFields()),
|
|
)
|
|
return merr.WrapErrParameterInvalid(collection.GetLoadFields(), req.GetLoadFields(), "can't change the load field list for loaded collection")
|
|
}
|
|
collectionUsedRG := job.meta.ReplicaManager.GetResourceGroupByCollection(collection.GetCollectionID()).Collect()
|
|
left, right := lo.Difference(collectionUsedRG, req.GetResourceGroups())
|
|
if len(left) > 0 || len(right) > 0 {
|
|
msg := fmt.Sprintf("collection with different resource groups %v existed, release this collection first before changing its resource groups",
|
|
collectionUsedRG)
|
|
log.Warn(msg)
|
|
return merr.WrapErrParameterInvalid(collectionUsedRG, req.GetResourceGroups(), "can't change the resource groups for loaded partitions")
|
|
}
|
|
|
|
return nil
|
|
}
|
|
|
|
func (job *LoadCollectionJob) Execute() error {
|
|
req := job.req
|
|
log := log.Ctx(job.ctx).With(zap.Int64("collectionID", req.GetCollectionID()))
|
|
meta.GlobalFailedLoadCache.Remove(req.GetCollectionID())
|
|
|
|
// 1. Fetch target partitions
|
|
partitionIDs, err := job.broker.GetPartitions(job.ctx, req.GetCollectionID())
|
|
if err != nil {
|
|
msg := "failed to get partitions from RootCoord"
|
|
log.Warn(msg, zap.Error(err))
|
|
return errors.Wrap(err, msg)
|
|
}
|
|
loadedPartitionIDs := lo.Map(job.meta.CollectionManager.GetPartitionsByCollection(req.GetCollectionID()),
|
|
func(partition *meta.Partition, _ int) int64 {
|
|
return partition.GetPartitionID()
|
|
})
|
|
lackPartitionIDs := lo.FilterMap(partitionIDs, func(partID int64, _ int) (int64, bool) {
|
|
return partID, !lo.Contains(loadedPartitionIDs, partID)
|
|
})
|
|
if len(lackPartitionIDs) == 0 {
|
|
return nil
|
|
}
|
|
job.undo.CollectionID = req.GetCollectionID()
|
|
job.undo.LackPartitions = lackPartitionIDs
|
|
log.Info("find partitions to load", zap.Int64s("partitions", lackPartitionIDs))
|
|
|
|
colExisted := job.meta.CollectionManager.Exist(req.GetCollectionID())
|
|
if !colExisted {
|
|
// Clear stale replicas, https://github.com/milvus-io/milvus/issues/20444
|
|
err = job.meta.ReplicaManager.RemoveCollection(req.GetCollectionID())
|
|
if err != nil {
|
|
msg := "failed to clear stale replicas"
|
|
log.Warn(msg, zap.Error(err))
|
|
return errors.Wrap(err, msg)
|
|
}
|
|
}
|
|
|
|
// 2. create replica if not exist
|
|
replicas := job.meta.ReplicaManager.GetByCollection(req.GetCollectionID())
|
|
if len(replicas) == 0 {
|
|
collectionInfo, err := job.broker.DescribeCollection(job.ctx, req.GetCollectionID())
|
|
if err != nil {
|
|
return err
|
|
}
|
|
|
|
// API of LoadCollection is wired, we should use map[resourceGroupNames]replicaNumber as input, to keep consistency with `TransferReplica` API.
|
|
// Then we can implement dynamic replica changed in different resource group independently.
|
|
_, err = utils.SpawnReplicasWithRG(job.meta, req.GetCollectionID(), req.GetResourceGroups(), req.GetReplicaNumber(), collectionInfo.GetVirtualChannelNames())
|
|
if err != nil {
|
|
msg := "failed to spawn replica for collection"
|
|
log.Warn(msg, zap.Error(err))
|
|
return errors.Wrap(err, msg)
|
|
}
|
|
job.undo.IsReplicaCreated = true
|
|
}
|
|
|
|
// 3. loadPartitions on QueryNodes
|
|
err = loadPartitions(job.ctx, job.meta, job.cluster, job.broker, true, req.GetCollectionID(), lackPartitionIDs...)
|
|
if err != nil {
|
|
return err
|
|
}
|
|
|
|
// 4. put collection/partitions meta
|
|
partitions := lo.Map(lackPartitionIDs, func(partID int64, _ int) *meta.Partition {
|
|
return &meta.Partition{
|
|
PartitionLoadInfo: &querypb.PartitionLoadInfo{
|
|
CollectionID: req.GetCollectionID(),
|
|
PartitionID: partID,
|
|
ReplicaNumber: req.GetReplicaNumber(),
|
|
Status: querypb.LoadStatus_Loading,
|
|
FieldIndexID: req.GetFieldIndexID(),
|
|
},
|
|
CreatedAt: time.Now(),
|
|
}
|
|
})
|
|
|
|
ctx, sp := otel.Tracer(typeutil.QueryCoordRole).Start(job.ctx, "LoadCollection", trace.WithNewRoot())
|
|
collection := &meta.Collection{
|
|
CollectionLoadInfo: &querypb.CollectionLoadInfo{
|
|
CollectionID: req.GetCollectionID(),
|
|
ReplicaNumber: req.GetReplicaNumber(),
|
|
Status: querypb.LoadStatus_Loading,
|
|
FieldIndexID: req.GetFieldIndexID(),
|
|
LoadType: querypb.LoadType_LoadCollection,
|
|
LoadFields: req.GetLoadFields(),
|
|
},
|
|
CreatedAt: time.Now(),
|
|
LoadSpan: sp,
|
|
}
|
|
job.undo.IsNewCollection = true
|
|
err = job.meta.CollectionManager.PutCollection(collection, partitions...)
|
|
if err != nil {
|
|
msg := "failed to store collection and partitions"
|
|
log.Warn(msg, zap.Error(err))
|
|
return errors.Wrap(err, msg)
|
|
}
|
|
eventlog.Record(eventlog.NewRawEvt(eventlog.Level_Info, fmt.Sprintf("Start load collection %d", collection.CollectionID)))
|
|
metrics.QueryCoordNumPartitions.WithLabelValues().Add(float64(len(partitions)))
|
|
|
|
// 5. update next target, no need to rollback if pull target failed, target observer will pull target in periodically
|
|
_, err = job.targetObserver.UpdateNextTarget(req.GetCollectionID())
|
|
if err != nil {
|
|
msg := "failed to update next target"
|
|
log.Warn(msg, zap.Error(err))
|
|
}
|
|
job.undo.IsTargetUpdated = true
|
|
|
|
// 6. register load task into collection observer
|
|
job.collectionObserver.LoadCollection(ctx, req.GetCollectionID())
|
|
|
|
return nil
|
|
}
|
|
|
|
func (job *LoadCollectionJob) PostExecute() {
|
|
if job.Error() != nil {
|
|
job.undo.RollBack()
|
|
}
|
|
}
|
|
|
|
type LoadPartitionJob struct {
|
|
*BaseJob
|
|
req *querypb.LoadPartitionsRequest
|
|
undo *UndoList
|
|
|
|
dist *meta.DistributionManager
|
|
meta *meta.Meta
|
|
broker meta.Broker
|
|
cluster session.Cluster
|
|
targetMgr meta.TargetManagerInterface
|
|
targetObserver *observers.TargetObserver
|
|
collectionObserver *observers.CollectionObserver
|
|
nodeMgr *session.NodeManager
|
|
}
|
|
|
|
func NewLoadPartitionJob(
|
|
ctx context.Context,
|
|
req *querypb.LoadPartitionsRequest,
|
|
dist *meta.DistributionManager,
|
|
meta *meta.Meta,
|
|
broker meta.Broker,
|
|
cluster session.Cluster,
|
|
targetMgr meta.TargetManagerInterface,
|
|
targetObserver *observers.TargetObserver,
|
|
collectionObserver *observers.CollectionObserver,
|
|
nodeMgr *session.NodeManager,
|
|
) *LoadPartitionJob {
|
|
return &LoadPartitionJob{
|
|
BaseJob: NewBaseJob(ctx, req.Base.GetMsgID(), req.GetCollectionID()),
|
|
req: req,
|
|
undo: NewUndoList(ctx, meta, cluster, targetMgr, targetObserver),
|
|
dist: dist,
|
|
meta: meta,
|
|
broker: broker,
|
|
cluster: cluster,
|
|
targetMgr: targetMgr,
|
|
targetObserver: targetObserver,
|
|
collectionObserver: collectionObserver,
|
|
nodeMgr: nodeMgr,
|
|
}
|
|
}
|
|
|
|
func (job *LoadPartitionJob) PreExecute() error {
|
|
req := job.req
|
|
log := log.Ctx(job.ctx).With(zap.Int64("collectionID", req.GetCollectionID()))
|
|
|
|
if req.GetReplicaNumber() <= 0 {
|
|
log.Info("request doesn't indicate the number of replicas, set it to 1",
|
|
zap.Int32("replicaNumber", req.GetReplicaNumber()))
|
|
req.ReplicaNumber = 1
|
|
}
|
|
|
|
if len(req.GetResourceGroups()) == 0 {
|
|
req.ResourceGroups = []string{meta.DefaultResourceGroupName}
|
|
}
|
|
|
|
collection := job.meta.GetCollection(req.GetCollectionID())
|
|
if collection == nil {
|
|
return nil
|
|
}
|
|
|
|
if collection.GetReplicaNumber() != req.GetReplicaNumber() {
|
|
msg := "collection with different replica number existed, release this collection first before changing its replica number"
|
|
log.Warn(msg)
|
|
return merr.WrapErrParameterInvalid(collection.GetReplicaNumber(), req.GetReplicaNumber(), "can't change the replica number for loaded partitions")
|
|
}
|
|
|
|
if !funcutil.SliceSetEqual(collection.GetLoadFields(), req.GetLoadFields()) {
|
|
log.Warn("collection with different load field list exists, release this collection first before chaning its replica number",
|
|
zap.Int64s("loadedFieldIDs", collection.GetLoadFields()),
|
|
zap.Int64s("reqFieldIDs", req.GetLoadFields()),
|
|
)
|
|
return merr.WrapErrParameterInvalid(collection.GetLoadFields(), req.GetLoadFields(), "can't change the load field list for loaded collection")
|
|
}
|
|
collectionUsedRG := job.meta.ReplicaManager.GetResourceGroupByCollection(collection.GetCollectionID()).Collect()
|
|
left, right := lo.Difference(collectionUsedRG, req.GetResourceGroups())
|
|
if len(left) > 0 || len(right) > 0 {
|
|
msg := fmt.Sprintf("collection with different resource groups %v existed, release this collection first before changing its resource groups",
|
|
collectionUsedRG)
|
|
log.Warn(msg)
|
|
return merr.WrapErrParameterInvalid(collectionUsedRG, req.GetResourceGroups(), "can't change the resource groups for loaded partitions")
|
|
}
|
|
|
|
return nil
|
|
}
|
|
|
|
func (job *LoadPartitionJob) Execute() error {
|
|
req := job.req
|
|
log := log.Ctx(job.ctx).With(
|
|
zap.Int64("collectionID", req.GetCollectionID()),
|
|
zap.Int64s("partitionIDs", req.GetPartitionIDs()),
|
|
)
|
|
meta.GlobalFailedLoadCache.Remove(req.GetCollectionID())
|
|
|
|
// 1. Fetch target partitions
|
|
loadedPartitionIDs := lo.Map(job.meta.CollectionManager.GetPartitionsByCollection(req.GetCollectionID()),
|
|
func(partition *meta.Partition, _ int) int64 {
|
|
return partition.GetPartitionID()
|
|
})
|
|
lackPartitionIDs := lo.FilterMap(req.GetPartitionIDs(), func(partID int64, _ int) (int64, bool) {
|
|
return partID, !lo.Contains(loadedPartitionIDs, partID)
|
|
})
|
|
if len(lackPartitionIDs) == 0 {
|
|
return nil
|
|
}
|
|
job.undo.CollectionID = req.GetCollectionID()
|
|
job.undo.LackPartitions = lackPartitionIDs
|
|
log.Info("find partitions to load", zap.Int64s("partitions", lackPartitionIDs))
|
|
|
|
var err error
|
|
if !job.meta.CollectionManager.Exist(req.GetCollectionID()) {
|
|
// Clear stale replicas, https://github.com/milvus-io/milvus/issues/20444
|
|
err = job.meta.ReplicaManager.RemoveCollection(req.GetCollectionID())
|
|
if err != nil {
|
|
msg := "failed to clear stale replicas"
|
|
log.Warn(msg, zap.Error(err))
|
|
return errors.Wrap(err, msg)
|
|
}
|
|
}
|
|
|
|
// 2. create replica if not exist
|
|
replicas := job.meta.ReplicaManager.GetByCollection(req.GetCollectionID())
|
|
if len(replicas) == 0 {
|
|
collectionInfo, err := job.broker.DescribeCollection(job.ctx, req.GetCollectionID())
|
|
if err != nil {
|
|
return err
|
|
}
|
|
_, err = utils.SpawnReplicasWithRG(job.meta, req.GetCollectionID(), req.GetResourceGroups(), req.GetReplicaNumber(), collectionInfo.GetVirtualChannelNames())
|
|
if err != nil {
|
|
msg := "failed to spawn replica for collection"
|
|
log.Warn(msg, zap.Error(err))
|
|
return errors.Wrap(err, msg)
|
|
}
|
|
job.undo.IsReplicaCreated = true
|
|
}
|
|
|
|
// 3. loadPartitions on QueryNodes
|
|
err = loadPartitions(job.ctx, job.meta, job.cluster, job.broker, true, req.GetCollectionID(), lackPartitionIDs...)
|
|
if err != nil {
|
|
return err
|
|
}
|
|
|
|
// 4. put collection/partitions meta
|
|
partitions := lo.Map(lackPartitionIDs, func(partID int64, _ int) *meta.Partition {
|
|
return &meta.Partition{
|
|
PartitionLoadInfo: &querypb.PartitionLoadInfo{
|
|
CollectionID: req.GetCollectionID(),
|
|
PartitionID: partID,
|
|
ReplicaNumber: req.GetReplicaNumber(),
|
|
Status: querypb.LoadStatus_Loading,
|
|
FieldIndexID: req.GetFieldIndexID(),
|
|
},
|
|
CreatedAt: time.Now(),
|
|
}
|
|
})
|
|
ctx, sp := otel.Tracer(typeutil.QueryCoordRole).Start(job.ctx, "LoadPartition", trace.WithNewRoot())
|
|
if !job.meta.CollectionManager.Exist(req.GetCollectionID()) {
|
|
job.undo.IsNewCollection = true
|
|
|
|
collection := &meta.Collection{
|
|
CollectionLoadInfo: &querypb.CollectionLoadInfo{
|
|
CollectionID: req.GetCollectionID(),
|
|
ReplicaNumber: req.GetReplicaNumber(),
|
|
Status: querypb.LoadStatus_Loading,
|
|
FieldIndexID: req.GetFieldIndexID(),
|
|
LoadType: querypb.LoadType_LoadPartition,
|
|
LoadFields: req.GetLoadFields(),
|
|
},
|
|
CreatedAt: time.Now(),
|
|
LoadSpan: sp,
|
|
}
|
|
err = job.meta.CollectionManager.PutCollection(collection, partitions...)
|
|
if err != nil {
|
|
msg := "failed to store collection and partitions"
|
|
log.Warn(msg, zap.Error(err))
|
|
return errors.Wrap(err, msg)
|
|
}
|
|
} else { // collection exists, put partitions only
|
|
err = job.meta.CollectionManager.PutPartition(partitions...)
|
|
if err != nil {
|
|
msg := "failed to store partitions"
|
|
log.Warn(msg, zap.Error(err))
|
|
return errors.Wrap(err, msg)
|
|
}
|
|
}
|
|
metrics.QueryCoordNumPartitions.WithLabelValues().Add(float64(len(partitions)))
|
|
|
|
// 5. update next target, no need to rollback if pull target failed, target observer will pull target in periodically
|
|
_, err = job.targetObserver.UpdateNextTarget(req.GetCollectionID())
|
|
if err != nil {
|
|
msg := "failed to update next target"
|
|
log.Warn(msg, zap.Error(err))
|
|
}
|
|
job.undo.IsTargetUpdated = true
|
|
|
|
job.collectionObserver.LoadPartitions(ctx, req.GetCollectionID(), lackPartitionIDs)
|
|
|
|
return nil
|
|
}
|
|
|
|
func (job *LoadPartitionJob) PostExecute() {
|
|
if job.Error() != nil {
|
|
job.undo.RollBack()
|
|
}
|
|
}
|