mirror of
https://gitee.com/milvus-io/milvus.git
synced 2026-01-07 19:31:51 +08:00
ca8740c7c0
issue: #45841 - CPP log make the multi log line in one debug, remove the "\n\t". - remove some log that make no sense. - slow down some log like ChannelDistManager. <!-- This is an auto-generated comment: release notes by coderabbit.ai --> - Core invariant: logging is purely observational — this PR only reduces, consolidates, or reformats diagnostic output (removing per-item/noise logs, consolidating batched logs, and converting multi-line log strings) while preserving all control flow, return values, and state mutations across affected code paths. - Removed / simplified logic: deleted low-value per-operation debug/info logs (e.g., ListIndexes, GetRecoveryInfo, GcConfirm, push-to-reorder-buffer, several streaming/wal/debug traces), replaced per-item inline logs with single batched deferred logs in querynodev2/delegator (logExcludeInfo) and CleanInvalid, changed C++ PlanNode ToString() multi-line output to compact single-line bracketed format (removed "\n\t"), and added thresholded interceptor logging (InterceptorMetrics.ShouldBeLogged) and message-type-driven log levels to avoid verbose entries. - Why this does NOT cause data loss or behavioral regression: no function signatures, branching, state updates, persistence calls, or return values were changed — examples: ListIndexes still returns the same Status/IndexInfos; GcConfirm still constructs and returns resp.GetGcFinished(); Insert and CleanInvalid still perform the same insert/removal operations (only their per-item logging was aggregated); PlanNode ToString changes only affect emitted debug strings. All error handling and control flow paths remain intact. - Enhancement intent: reduce log volume and improve signal-to-noise for debugging by removing redundant, noisy logs and emitting concise, rate-/threshold-limited summaries while preserving necessary diagnostics and original program behavior. <!-- end of auto-generated comment: release notes by coderabbit.ai --> --------- Signed-off-by: chyezh <chyezh@outlook.com>
114 lines
3.0 KiB
Go
114 lines
3.0 KiB
Go
// Licensed to the LF AI & Data foundation under one
|
|
// or more contributor license agreements. See the NOTICE file
|
|
// distributed with this work for additional information
|
|
// regarding copyright ownership. The ASF licenses this file
|
|
// to you under the Apache License, Version 2.0 (the
|
|
// "License"); you may not use this file except in compliance
|
|
// with the License. You may obtain a copy of the License at
|
|
//
|
|
// http://www.apache.org/licenses/LICENSE-2.0
|
|
//
|
|
// Unless required by applicable law or agreed to in writing, software
|
|
// distributed under the License is distributed on an "AS IS" BASIS,
|
|
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
// See the License for the specific language governing permissions and
|
|
// limitations under the License.
|
|
|
|
package delegator
|
|
|
|
import (
|
|
"sync"
|
|
"time"
|
|
|
|
"go.uber.org/atomic"
|
|
"go.uber.org/zap"
|
|
|
|
"github.com/milvus-io/milvus/pkg/v2/log"
|
|
)
|
|
|
|
type ExcludedSegments struct {
|
|
mu sync.RWMutex
|
|
segments map[int64]uint64 // segmentID -> Excluded TS
|
|
lastClean atomic.Time
|
|
cleanInterval time.Duration
|
|
}
|
|
|
|
func NewExcludedSegments(cleanInterval time.Duration) *ExcludedSegments {
|
|
return &ExcludedSegments{
|
|
segments: make(map[int64]uint64),
|
|
cleanInterval: cleanInterval,
|
|
}
|
|
}
|
|
|
|
func (s *ExcludedSegments) Insert(excludeInfo map[int64]uint64) {
|
|
if log.Level().Enabled(zap.DebugLevel) {
|
|
defer func() {
|
|
s.logExcludeInfo(excludeInfo)
|
|
}()
|
|
}
|
|
|
|
s.mu.Lock()
|
|
defer s.mu.Unlock()
|
|
|
|
for segmentID, ts := range excludeInfo {
|
|
s.segments[segmentID] = ts
|
|
}
|
|
}
|
|
|
|
func (s *ExcludedSegments) logExcludeInfo(excludeInfo map[int64]uint64) {
|
|
segmentIDs := make([]int64, 0, len(excludeInfo))
|
|
timeTicks := make([]uint64, 0, len(excludeInfo))
|
|
for segmentID, ts := range excludeInfo {
|
|
segmentIDs = append(segmentIDs, segmentID)
|
|
timeTicks = append(timeTicks, ts)
|
|
}
|
|
log.Debug("add exclude info",
|
|
zap.Int("count", len(excludeInfo)),
|
|
zap.Int64s("segmentIDs", segmentIDs),
|
|
zap.Uint64s("timeTicks", timeTicks),
|
|
)
|
|
}
|
|
|
|
// return false if segment has been excluded
|
|
func (s *ExcludedSegments) Verify(segmentID int64, ts uint64) bool {
|
|
s.mu.RLock()
|
|
defer s.mu.RUnlock()
|
|
if excludeTs, ok := s.segments[segmentID]; ok && ts <= excludeTs {
|
|
return false
|
|
}
|
|
return true
|
|
}
|
|
|
|
func (s *ExcludedSegments) CleanInvalid(ts uint64) {
|
|
removedSegmentIDs := make([]int64, 0, 32)
|
|
if log.Level().Enabled(zap.DebugLevel) {
|
|
defer func() {
|
|
log.Debug("remove segment from exclude info",
|
|
zap.Int("count", len(removedSegmentIDs)),
|
|
zap.Uint64("ts", ts),
|
|
zap.Int64s("segmentIDs", removedSegmentIDs),
|
|
)
|
|
}()
|
|
}
|
|
|
|
s.mu.Lock()
|
|
defer s.mu.Unlock()
|
|
|
|
invalidExcludedInfos := []int64{}
|
|
for segmentsID, excludeTs := range s.segments {
|
|
if excludeTs < ts {
|
|
invalidExcludedInfos = append(invalidExcludedInfos, segmentsID)
|
|
}
|
|
}
|
|
|
|
for _, segmentID := range invalidExcludedInfos {
|
|
delete(s.segments, segmentID)
|
|
removedSegmentIDs = append(removedSegmentIDs, segmentID)
|
|
}
|
|
s.lastClean.Store(time.Now())
|
|
}
|
|
|
|
func (s *ExcludedSegments) ShouldClean() bool {
|
|
return time.Since(s.lastClean.Load()) > s.cleanInterval
|
|
}
|